Image Magick support for versions 4 and 5 was dropped. The setting
to differentiate combine from composite is obsolete now and composite
is used always.

Change-Id: I0fbc847167d340fd83315285745c63d53225891a
Resolves: #52011
Releases: 6.2
Reviewed-on: https://review.typo3.org/23836
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Did you know there is an option to disable condition parsing in
TS config? It is removed with the patch.

Change-Id: If6ce720a4416af80b7deb293160e8b712c04ff0d
Resolves: #52013
Releases: 6.2
Reviewed-on: https://review.typo3.org/23838
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Support for Image Magick version 4 and 5 was dropped, allowed
settings for im_version_5 are "im6" and "gm". As soon as one
of this is set for im_version_5, bootstrap automatically sets
"im_no_effects" to 1. In effect, this value is *always* one, so
it is obsolete and can be removed from the system.

Change-Id: Ieb798352aebaae4943018a225518591a952a8bcb
Resolves: #52010
Releases: 6.2
Reviewed-on: https://review.typo3.org/23835
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Image Magick versions 6.7 and above need sRGB as colorspace,
otherwise images are too dark. This also works for older versions
like 6.6. Use sRGB as default is image configuration presets.

Change-Id: I7c50ee932b1335892eb228b10fc00136cfc54527
Resolves: #52017
Releases: 6.2
Reviewed-on: https://review.typo3.org/23840
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #52008
Releases: 6.2
Change-Id: I8fd7546ca6a293c6e9d11dd46d37a8cc89cf9620
Reviewed-on: https://review.typo3.org/23833
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

If execute path to ImageMagick or GraphicsMagick is not configured
correctly, the "Test setup" image tests in the install tool may show
false positives and do not render an error message that the image
generation faild.
The patch adds checks and displays an error message if for example
['GFX']['im_path'] is set to an invalid path.
There are other issues in this area, for example existing test
image files may be re-used with a broken configuration. These
are also fixed with this patch.

Change-Id: Id3cf116b80371379eae9c9dc348d9daee9d5b074
Resolves: #35070
Releases: 6.2
Reviewed-on: https://review.typo3.org/23797
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

In the InstallSysExtsUpdate update wizard the extensions are checked
by default. This gives the indication that the extensions need
to be installed. In fact they are optional and therefore should
not be checked by default.

Change-Id: Ic61ad081b08d1906d224a29c79702db3fe1597e1
Resolves: #47733
Releas: 6.2
Reviewed-on: https://review.typo3.org/23827
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

"All configuration" in install tool shows the integer representation
of the bit mask of the PHP error codes in settings like
['SYS']['errorHandlerErrors']. This change adds a view helper to
show the current setting in an E_* constants representation.

Resolves: #51376
Releases: 6.2
Change-Id: Ia69251d97c07b1180f8e7ad99b687b5639396892
Reviewed-on: https://review.typo3.org/23794
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Resolves: #52007
Releases: 6.2
Change-Id: I4c8bb6930040a9f3a5c5bc92c9638a98a2668daf
Reviewed-on: https://review.typo3.org/23832
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Resolves: #47588
Releases: 6.2
Change-Id: I266f28472ffd78443b107d7ad6577603aecbc584
Reviewed-on: https://review.typo3.org/23697
Reviewed-by: Jo Hasenau
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

If the settings of a local-only extension get saved the configuration
controller fatals. This is because the result of the extension model
repository does not get checked, if it really is a model.

With this fix the instance is first checked and afterwards the category
is read from the model.

Resolves: #51902
Releases: 6.2
Change-Id: I543aa0960f3c2ba1877189b44e47aa7f86c81928
Reviewed-on: https://review.typo3.org/23738
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #51995
Releases: 6.2
Change-Id: Ic1f2459b58f5376a306a6e8c910398ce6e4a9efe
Reviewed-on: https://review.typo3.org/23822
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The badges are now aligned and don't jump around when
the menu entry is selected. The left menu gets more room.

Releases: 6.2
Resolves: #51997
Change-Id: Ia9eb44467243781677df6a8046d6c2c864e70ad8
Reviewed-on: https://review.typo3.org/23824
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #51996
Releases: 6.2
Change-Id: I5afca17c80931f3f9946fa5f33dc29fd1f572644
Reviewed-on: https://review.typo3.org/23823
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

* Streamlines install tool main template.
* Adds a ContextService and use that in the templates.
  No more huge if/then/else constructs to differentiate
  standalone and backend modes.
* Fixes the left menu (and TYPO3 logo), letting the
  rest scroll up and down.
* In backend mode the menu and content starts right on top
  (no further headers to make scrolling look good)

Releases: 6.2
Resolves: #50910
Change-Id: Ie2ec277026a82332b533af51a37e7f308dd24e8c
Reviewed-on: https://review.typo3.org/23798
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Add a new icon for ext:reports-module and adjust the
IconViewHelper. Removes 2 old icons.

Change-Id: Iff731cc27ad8e6323aea8c6c01c036f3a776b3e2
Related: #41631
Resolves: #51993
Releases: 6.2
Reviewed-on: https://review.typo3.org/23818
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The document header is not at a fixed position but "scrolls away".
Fix this by adding a missing t3skin structure .css that defines this.

Change-Id: Ia1b3209db1b5fa08157002bca950110830e2403e
Resolves: #51989
Related: #50910
Releases: 6.2
Reviewed-on: https://review.typo3.org/23812
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The Core does not check for the JPEG file extension
when converting images with IM/GM.

Resolves: #51981
Releases: 6.2, 6.1, 6.0
Change-Id: I148ecb0d3c71fdee563476c33865cd18420b2384
Reviewed-on: https://review.typo3.org/23810
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

If login is not correct, a 401 should be used instead of a 200.

Change-Id: Ia2fa139e89fe19df77bb0530b4fbce502506f524
Resolves: #51803
Releases: 6.2,6.1,6.0,4.5
Reviewed-on: https://review.typo3.org/23649
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The SQL query "SHOW DATABASE" may be restricted on the SQL Server.
Since MySQL 5.0 (which is minimum since TYPO3 CMS 4.7) we can also query
the information_schema table to gather the information to which table
we have access.

Resolves: #47744
Releases: 6.2, 6.1
Change-Id: Ie65abadeed54cbc54bee401bdc1aab18ffc8eea6
Reviewed-on: https://review.typo3.org/23637
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Call to undefined method when setting
'pageHeaderFooterTemplateFile' in TypoScriptFrontendController.
This needs to be called on the page renderer object.

Change-Id: Ic4407addb5d22f09fc4cd6482cc79ad5af724582
Resolves: #51891
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23734
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Make use of the possibilities of PHP 5.3+ and replace all
instances of create_function with an inlined function call.

Change-Id: I3ebabd56efe5d7e3ee07cffbf1f3bb6b5c85e7ff
Resolves: #51937
Releases: 6.2
Reviewed-on: https://review.typo3.org/23782
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Christoph Dörfel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Order the sections in all configuration alphabetically.

Change-Id: I2096d2b0d8892e93a5740d0ad2b7dee1ddceb93e
Resolves: #47740
Releases: 6.2
Reviewed-on: https://review.typo3.org/23791
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Make the following adaption:
 * Change the order of the two options.
 * Preselect the first, empty, existing database.
 * Add a hint, that the user must have sufficient privileges
   to create a new database.

Resolves: #51931
Releases: 6.2
Change-Id: I823a194ddd1dc3aad2d560354bce20855c5c372c
Reviewed-on: https://review.typo3.org/23770
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Install tool should show a document header if called in backend.
It includes some .css files from t3skin to do that. Those files
were moved around in issue #51134, not adapted in install tool,
resulting in 404 and missing document header. The patch adapts
templates to include files at new locations.

Change-Id: I9df6950ec3e218c175b012d9ef4233c5b5f6c925
Resolves: #51952
Related: #51134
Releases: 6.2
Reviewed-on: https://review.typo3.org/23789
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Use correct product name in title tag and box during installation.

Change-Id: I21141aa06c12c1abf7fff83e1e33148be6c6373f
Resolves: #51946
Releases: 6.2
Reviewed-on: https://review.typo3.org/23784
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Refactor needsExecution() logic to make sure the mandatory settings
(username, password, host, port) are present in LocalConfiguration.php
before trying to establish a database connection using these settings.

This fixes a possible redirect loop if some of the mandatory settings
were not present, but the database connection check still succeeded.

Change-Id: Ifbf98a4bdcb62d9d29b7fbc1f3a03d3a7d621492
Resolves: #51433
Releases: 6.2
Reviewed-on: https://review.typo3.org/23394
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The method
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addStaticFile()
should be called in ext_tables.php files since it manipulates the
TCA.

Resolves: #51939
Releases: 6.2
Change-Id: I75f099fb5d64ee1e11867c41728b2747a666ebfd
Reviewed-on: https://review.typo3.org/23781
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Regression for SQL error introduced with #51562.

Resolves: #51929
Releases: 6.2, 6.1
Change-Id: Ib9756234fed6284c5c7547284dff9f3308360c35
Reviewed-on: https://review.typo3.org/23767
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Change the cursor and add an arrow for foldout sections
in the Install Tool.

Resolves: #49188
Releases: 6.2
Change-Id: Iaf8f17b420f0716a23b5a6d8d4ebbbaa815a9143
Reviewed-on: https://review.typo3.org/23755
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

All tests in the class belong to AbstractRepository, so the tests move.

Change-Id: I5e78e0d61a2d8f8bcfd06d871a909b749417e616
Resolves: #51923
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23762
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Throw an Exception if this method hits.

Change-Id: Ide94043bb008e1dfaf19b452570ce70d5f2aa432
Resolves: #51924
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/23763
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

getWhereClauseForEnabledFields() moved from StorageRepository
to AbstractRepository, but getEnvironmentMode() stayed
in StorageRepository although getWhereClauseForEnabledFields()
relies on it. Move getEnvironmentMode() as well.

Change-Id: Id252c8bd3b9e09a2c38d5ea1ebe6497dd76c12ae
Resolves: #51562
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23759
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The ResourceStorage accesses the index table sys_file directly via
a call to the $GLOBALS[TYPO3_DB]. The interaction with the sys_file
index table should be managed only by an according repository to
allow changes within that mechanism.

This patch rearranges the factory method to use the according
call within the FileRepository and adapts it, as the FileRepository
will return a file Object instead of an array.

This serves as a preparation for further indexing optimisations,
which need IndexRecords to be handled centrally.

Releases: 6.2, 6.1, 6.0
Resolves: #51519
Change-Id: I5aa2d212b936b218db1808ea3d0384b8292287a9
Reviewed-on: https://review.typo3.org/23470
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Mocked driver needs to return a proper "file" on calls to addFile().

Change-Id: Iddfc2f9b7e71101ad229a513727f65f64d654d45
Releases: 6.2, 6.1, 6.0
Resolves: #50795
Reviewed-on: https://review.typo3.org/23752
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The includeJS/includeCSS properties of the PAGE object feature an
allWrap property which replaces all pipe symbols with the generated
tag. This behaviour differs from how wraps are handled in TYPO3.
A splitChar can now be defined for the allWrap property and the wrap
works like the standard wrap method from the ContentObject class.

Resolves: #51782
Releases: 6.2
Change-Id: Ic2687394c209b0f58185f37a64b14dff30efd2a1
Reviewed-on: https://review.typo3.org/23669
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein

There are signals for most operations performed in the file storage, but
not for adding a file. Especially this operation is interesting for
things like file indexing, automatic generation of variants (renditions)
etc., therefore this patch adds the two missing signals.

Change-Id: I0def7b44ff8977a42916e01388604fcbf2d6d299
Resolves: #50795
Release: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22823
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This also fixes the 'Uncaught TYPO3 Exception #1317178604
No file found for given UID.' that appears when some sys_file
entries have a deleted flag set by mistake.

Resolves: #51562
Releases: 6.2, 6.1, 6.0
Change-Id: Id23636d2732f3562b8a155025656b26041c9a4e2
Reviewed-on: https://review.typo3.org/23567
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The patch implements a "configuration system" to the install tool
that bundles several settings to enable them on click
depending on system capabilities.

A "feature" is represented by a set of configuration options that
are filled by different presets. Presets have a priority, the
best preset is the first one. Presets can be available or
not available and active or not. For example the "image handling"
feature has the presets "GraphicsMagick" and "ImageMagick 6" and
a "Custom" preset if the others do not fit.

This first patch implements "Charset conversion", "Image handling",
"Development / Production" and "Extbase object cache" settings.

During installation the available preset with highest priority
are configured.

Change-Id: I7304ef001717989720924e7ae03951eb3874adfd
Resolves: #51454
Releases: 6.2
Reviewed-on: https://review.typo3.org/23321
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adjust unittest to changed conditions.

Change-Id: Ia885ba544a159cb1666464cece30c3e6ea3558b6
Fixes: #49386
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23716
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny