- May 12, 2014
-
-
Christian Kuhn authored
Do not forget to "composer update" test instances! Updating from phpunit 3.7 to 4.1 is smooth, except two details: * The mock framework dropped staticExpects, two test cases must be refactored to circumvent this. * The mocker now tries to resolve method argument type hints, so those classes must exist and autoloaded, some FLOW dependencies are affected here. Change-Id: Ie74bdad000182dde808d3771fa6eec4764a133da Resolves: #58676 Releases: 6.2 Reviewed-on: https://review.typo3.org/29584 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Markus Klein authored
Do not cache the enable fields part of queries. This part needs to be added on each query dynamically to reflect the current context. (Time restrictions, User restrictions) Resolves: #58369 Releases: 6.2 Change-Id: I492d5983ff6a06d72cd18cf9a08a0d62d304ac2b Reviewed-on: https://review.typo3.org/29932 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Marcin Sągol Reviewed-by: Jan Kiesewetter Tested-by: Jan Kiesewetter Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Christian Weiske authored
When editing a file mount in the backend, we need to check if the storage backend actually exists. Change-Id: I76e677f9b44eea7694005a4939eb9489dc4f71de Fixes: #57986 Releases: 6.2 Reviewed-on: https://review.typo3.org/29634 Reviewed-by: Wouter Wolters Reviewed-by: Frans Saris Reviewed-by: Sebastian Fischer Tested-by: Sebastian Fischer Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Christian Weiske authored
Instead of using the file identifier, the actual file name is used when asking if a file should be deleted. This is important for non-local FAL storage drivers that do not use paths as identifiers. Change-Id: I34e42ed1716f08a4133e02bbc36ee805c6a108c7 Fixes: #58150 Releases: 6.2 Reviewed-on: https://review.typo3.org/29635 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Sebastian Fischer Reviewed-by: Marcin Sągol Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- May 07, 2014
-
-
Christian Kuhn authored
All public methods of LocalizationUtility are static, but two protected methods are not. Make those static, too. Change-Id: I267805cad3f008f24e053f69670fac0f805f7ad2 Resolves: #58600 Releases: 6.2 Reviewed-on: https://review.typo3.org/29921 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Christian Kuhn authored
travis-ci already provides a PHP 5.6 beta build. It currently executes unit, functional and linting successfully and is added to the list of standard environments for now. Change-Id: Ibde2364564afe18f602f75174b779527b55c25bc Reviewed-on: https://review.typo3.org/29913 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- May 06, 2014
-
-
TYPO3 Release Team authored
Change-Id: I14eab875e340e6d779b4f224de9cc801d84559d1 Reviewed-on: https://review.typo3.org/29911 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
TYPO3 Release Team authored
Change-Id: Id59a7279b29d882221d8afa1f582c5c1ff791d33 Reviewed-on: https://review.typo3.org/29910 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
Markus Klein authored
Remove the old magic as classes are loaded properly already. Resolves: #58567 Related: #47852 Releases: 6.2 Change-Id: Iec20bf0dbd6955950225936911eba604faf720d6 Reviewed-on: https://review.typo3.org/29898 Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
Exporting a content element leads to a fatal error. A wrong url encoding is the cause of the problem. Resolves: #58576 Releases: 6.2 Change-Id: Ib2105aa9dc95e35eba9515cfc3d62b174919870a Reviewed-on: https://review.typo3.org/29903 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Wouter Wolters authored
Resolves: #58451 Releases: 6.2 Change-Id: I296720fd83343ea0d82b4461aaae46c4c9a14932 Reviewed-on: https://review.typo3.org/29904 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
Resolves: #58582 Related: #58010 Related: #57294 Releases: 6.2 Change-Id: I89e9bea10c24944ad2efb1fb9029ec75dc2f78db Reviewed-on: https://review.typo3.org/29579 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Helmut Hummel authored
Also add tests to enforce this behavior. Resolves: #58581 Releases: 6.2 Change-Id: Ife3894fe6dd5fc476bba9c9c74ae26bf310b9245 Reviewed-on: https://review.typo3.org/29582 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Kuhn authored
Simalar to UnitTests.xml, FunctionalTests.xml no longer register single test suites but find all functional tests cases using a wildcard. For travis-ci, single tests cases are now given to parallel using gnu find. This leads to a nice performance improvement on travis since more but shorter processes are executed, sharing the available hardware more effectively. Change-Id: I8dc34ed2fcc1ae8390bc05dbe6f5e7009af17a36 Resolves: #58578 Related: #58533 Releases: 6.2 Reviewed-on: https://review.typo3.org/29901 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Felix Oertel authored
To allow running of all functional tests, instead of relying on travis.yml, we want to clean up broken and abandoned tests. So we remove the tests that fatal because they are not meant to be used in the functional testing framework. Resolves: #58445 Releases: 6.2 Change-Id: I8fd021a9814dec43f71200641c9ba1ebbc0e32d0 Reviewed-on: https://review.typo3.org/29848 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Jan Helke Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
The CommandLineBackend using exec "openssl genrsa" outputs its key generation to standard error. If SAPI is cli (eg. in unit tests), this is is shown to the user. The patch silences openssl by redirecting stderr to /dev/null (NUL on Windows systems). Resolves: #58530 Related: #51436 Releases: 6.2 Change-Id: I702d2d3180bc2e32e5548a4402d4eefb02dd2523 Reviewed-on: https://review.typo3.org/29877 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes
-
Alexander Opitz authored
The var pageNotFound is set, if the called page has access restrictions. Afterwards starts a searching for an accessible page in the rootline upwards. If that page is a short link which also isn't accessible we stop instead of searching again in this new rootline. Limiting this to a maximum of 20 iterations to prevent endless loops. If an accessible page is found we do not reset the pageNotFound var. The PageNotFound handler reacts on this var and redirects to the 404 page instead of presenting the accessible page we found later on. You can reproduce this with the introduction package, for example change the access to the Example/Tables page to "Customer". Afterwards go to http://yourdomain/?id=38 and you will see the 404 page. If you disable the pageNotFound_handling you will see the content of the Example page. Resolves: #16472 Releases: 6.2, 6.1 Change-Id: I1e58ec1f96422c6bf3e5c9c74f1b1c1666b68762 Reviewed-on: https://review.typo3.org/21390 Reviewed-by: Sascha Wilking Tested-by: Sascha Wilking Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
As saltedpasswords is required for backend and can't be uninstalled, we can remove the implicit dependency on extension "setup" by adjusting the default settings there. Resolves: #58192 Releases: 6.2 Change-Id: I6490b9962924c0e384243f663f3e5057c947749e Reviewed-on: https://review.typo3.org/29656 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Nicole Cordes authored
This patch adds the conversion from Windows styled to unix styled path. Resolves: #58559 Releases: 6.2 Change-Id: I2b5b431fe60531ab1ad1c75bf9fd7749414c4df2 Reviewed-on: https://review.typo3.org/29893 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Markus Klein authored
The flexform converter in ContentObjectRenderer tries to access an array element on a non-array. Check existence with isset() first. Resolves: #57809 Releases: 6.2, 6.1 Change-Id: I8e6111afee3a639b3077dc59bc2e32b72fa12f5c Reviewed-on: https://review.typo3.org/29343 Reviewed-by: Oliver Klee Tested-by: Jost Baron Reviewed-by: Wouter Wolters Reviewed-by: Julian Wundrak Tested-by: Julian Wundrak Reviewed-by: Stefan Neufeind Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- May 05, 2014
-
-
Markus Klein authored
Remove the superfluous count() call. Resolves: #58529 Releases: 6.2, 6.1, 6.0 Change-Id: I0933650b52063009de52268034480f6e06af56ac Reviewed-on: https://review.typo3.org/29876 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Gabe Blair authored
Resolves: #58029 Releases: 6.2 Change-Id: If2a5f41e8524c457a20dec810f711f546d4fbb8c Reviewed-on: https://review.typo3.org/29554 Reviewed-by: Stefan Neufeind Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
Since introducing FAL the internalUploadMap array in ExtendedFileUtility was not set on uploading files. Resolves: #58463 Releases: 6.2, 6.1, 6.0 Change-Id: I4a537a57f1b688c26c20b9f68356a4be67bc5851 Reviewed-on: https://review.typo3.org/29820 Reviewed-by: Sascha Wilking Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
This is a regression to #54085 which accidentally converted a !strcmp() to !==. Resolves: #56393 Releases: 6.2 Change-Id: Ie0b2e169916e6b0ea848510e615b05d68be02199 Reviewed-on: https://review.typo3.org/29875 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Loek Hilgersom Tested-by: Loek Hilgersom Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Kuhn authored
All regular unit tests are located at typo3/sysext/"extension"/Tests/Unit. The patch substitutes the single suite registration in UnitTests.xml with a wildcard, only "Legacy" and "Integration" tests are still registered as special locations. Following this schema, tests located at default locations within extensions will be found automatically without explicit registration. Resolves: #58533 Related: #51436 Releases: 6.2 Change-Id: Ic822a68f60060437d2e3aabea7754f5b1e72af50 Reviewed-on: https://review.typo3.org/29879 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
The test suite of ext:rsaauth is missing in UnitTests.xml, add it. Resolves: #58531 Related: #58530 Related: #51436 Releases: 6.2 Change-Id: I5c1c8bbf415ed53270a09bdf68df300e28eb5f09 Reviewed-on: https://review.typo3.org/29878 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Frans Saris authored
The search box at the bottom of the BE List module disappears when you search for something and there are no records found. This patch makes sure the search box is also shown when a search was done. Resolves: #58526 Releases: 6.2 Change-Id: I95385bbdd988c4fb036d8bdc0c6b30638020a1cc Reviewed-on: https://review.typo3.org/29873 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Christian Kuhn authored
Our unit test environment is finally ready to execute existing dbal unit tests, even if no database connection exists. The patch refactors unit tests of ext:dbal, modernizes their codebase and adds them to the build. Resolves: #52527 Related: #51436 Releases: 6.2 Change-Id: I70507591dc89331d658d50196dfcaea002caa7d5 Reviewed-on: https://review.typo3.org/29874 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- May 04, 2014
-
-
Nicole Cordes authored
This patch adds the loading check of rsaauth before trying to access the BackendFactory of rsaauth. Otherwise the extension manager gets broken on entering extension configuration. Resolves: #58504 Releases: 6.2, 6.1 Change-Id: I197fb5e032b31e6add388269f77e6fc834e45b54 Reviewed-on: https://review.typo3.org/29859 Reviewed-by: Markus Klein Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Markus Klein authored
Issue #58484 fixed the inclusion of CSS class attributes in typolinks, but did not adjust the impexp tests. Update the affected fixture data. Resolves: #58503 Releases: 6.2 Change-Id: Ib71d50d03d045db37cd411523b54f8c6a1837833 Reviewed-on: https://review.typo3.org/29857 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Marc Bastian Heinrichs authored
Doesn't fix the tests completely. This reverts commit 8ae7a4b9 Change-Id: Ifadcc61d2bf159c5d70f4f1b5b8d436471a79f76 Reviewed-on: https://review.typo3.org/29856 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Markus Klein authored
Issue #58484 fixed the inclusion of CSS classes in typolinks, but did not adjust the tests. Update the affected fixture data. Resolves: #58503 Releases: 6.2 Change-Id: I511847bda3e393f104f1f141fb3a0bed4a97c1b1 Reviewed-on: https://review.typo3.org/29854 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Marc Bastian Heinrichs authored
The SoftReferenceIndex parses and rebuilds typolink tags, but the support for more than one value in class attribute is missing, because the values don't get enclosed with quotes on rebuilding. This leads to lost classes in typolinks in exports from impexp. Resolves: #58484 Releases: 6.2, 6.1, 4.5 Change-Id: I12ed3be7f5be36254bcee57fcb24bf2a10f92f46 Reviewed-on: https://review.typo3.org/29846 Reviewed-by: Wouter Wolters Reviewed-by: Sascha Wilking Tested-by: Sascha Wilking Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Oliver Hader authored
The file handling (downloading/storing or uploading/fetching existing T3D/XML files) is currently not full FAL compatible in the import/export module of the TYPO3 CMS backend. Also saving export file to folder on server shows an error, but the file is saved. In further TYPO3 version the .htaccess protected folder fileadmin/_temp_/ was used to store the export files. This was lately changed to the public accessible users default upload folder, normally fileadmin/user_upload/. This patch changes this back to a .htaccess protected folder, namely _temp_/importexport/ below users default upload folder. Resolves: #53552 Releases: 6.2 Change-Id: I250e08188d9e9aac011c759fccf7e831fea037fb Reviewed-on: https://review.typo3.org/25294 Reviewed-by: Sascha Wilking Tested-by: Sascha Wilking Reviewed-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Oliver Hader authored
With issue #57488 the pages.media field became localizable again, however the selective approach turns out to be problematic in terms of overlaying data in the frontend (the "mergeIfNotBlank" settings and the like). Thus, instead of letting the editor localize the references after persisting the parent and having to overlay/fallback in the frontend, now the references are already shown in the edit view during the localization (still before being persisted). Resolves: #58476 Releases: 6.2 Change-Id: Id6980f2a5cfea109375afce27f62cad8c101c58e Reviewed-on: https://review.typo3.org/29839 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Nicole Cordes authored
This patch removes the deletion possibility for installed extension in the list view of the extension manager. Furthermore the javascript can be adopted as the check for installed extensions can be removed as well. Resolves: #58493 Related: #53459 Releases: 6.2 Change-Id: I713bbb93230108db144044be9184e77f484931c9 Reviewed-on: https://review.typo3.org/29849 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Sascha Wilking Tested-by: Sascha Wilking Reviewed-by: Nadir S. Tested-by: Nadir S. Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Alexander Opitz authored
If the database field does not exist it may be that we have an installation before 6.0 or after 6.1 so we do not need to migrate the data to sys_file_metadata. This prevents empty metadata information which may lead to other issues. (width/height=0 for images) Resolves: #57492 Related: #46020 Releases: 6.2 Change-Id: Id5826ea480d4139f2e232587fc2b119928b28bc8 Reviewed-on: https://review.typo3.org/29024 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Nicole Cordes Reviewed-by: Anja Leichsenring Reviewed-by: Jan Runte Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Jan Runte authored
When dragging content elements in the page module, the element gets overlayed by TCEform elements. It loses its hover state, when dragged outside the viewport or very rapidly. * Set z-index higher than 4000 * Add a css class to stabilize active drag state * Remove duplicated javascript code in page module Resolves: #58473 Releases: 6.2, 6.1 Change-Id: I87577d30e5d6bb16f6999d466bef92da95b2add3 Reviewed-on: https://review.typo3.org/29837 Reviewed-by: Felix Oertel Tested-by: Felix Oertel Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Wouter Wolters
-
Helmut Hummel authored
If a not existent cache group is specified to the flushCachesInGroup methods, there is no indication that actually nothing happened. Throw an exception instead, so that calling code can easily be fixed. Resolves: #58465 Releases: 6.2 Change-Id: I9617fcee9abfa27a9cb76a3fd12543c62420e719 Reviewed-on: https://review.typo3.org/26981 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Felix Oertel Tested-by: Felix Oertel
-
Marc Bastian Heinrichs authored
Since making userHomePath and groupHomePath FAL compatible the descriptions in DefaultConfiguration don't fit anymore. Resolves: #56986 Releases: 6.2, 6.1 Change-Id: Ia27193b967137dd3744c2fdcf5b5b0d3366c0080 Reviewed-on: https://review.typo3.org/29838 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-