- Jul 26, 2014
-
-
Stefan Neufeind authored
With Change-Id: I57a2a2a06a97fc1eda6e0438bfdc6e210437e5bb a line was packported which relied on a use-statement for GeneralUtility. Since GeneralUtility is often used in this class, simply add a use-statement. Change-Id: Ifc8efbf97427a84e160c3e406b6a3e1dc1b7df1d Resolves: #60595 Releases: 6.1 Reviewed-on: http://review.typo3.org/31843 Reviewed-by: Markus Klein <klein.t3@reelworx.at> Tested-by: Markus Klein <klein.t3@reelworx.at>
-
- Jul 25, 2014
-
-
Stefan Neufeind authored
Checks for ATagParams & access key code before adding empty spaces between anchor parameters. Resolves: #50566 Releases: 6.3, 6.2, 6.1 Change-Id: I57a2a2a06a97fc1eda6e0438bfdc6e210437e5bb Reviewed-on: http://review.typo3.org/31683 Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl> Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
-
- Jul 08, 2014
-
-
Markus Klein authored
Re-add a missing use statement that vanished during rebase. Resolves: #59587 Releases: 6.3, 6.2, 6.1 Change-Id: I16ac1b9d5a00c4300202eaef493de43fc988a81d Reviewed-on: https://review.typo3.org/31522 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Alexander Opitz authored
This applies to Apc/Memcached/Wincache/Xcache backends. After an array_merge the values aren't unique. This leads to duplicate tags per identifier. This patch changes that and also moves the findTagsByIdentifier call out of the foreach loop. Resolves: #59587 Releases: 6.3, 6.2, 6.1 Change-Id: Id31e16fa4bba11038ba692a483fb9a33808d95fa Reviewed-on: https://review.typo3.org/31519 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
TYPO3 Release Team authored
Change-Id: Ie4ae5a728eecb0522e2937b685ed8704b3dd7cff Reviewed-on: https://review.typo3.org/31511 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
TYPO3 Release Team authored
Change-Id: I73a5e72ee9cad630ea2d2ee50d115d4a8d7310f0 Reviewed-on: https://review.typo3.org/31510 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
Nicole Cordes authored
Due to commit I148ca1b023226f2f99417b3baf238b72346e721f the information concerning previous and next content elements in one row is messed up. This patch helps to build information which depends on colPos again and prevents records being moved to another column. Resolves: #48939 Resolves: #49055 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I3a15321ee11a1f7d96b58b8b7a5ab14098664b22 Reviewed-on: https://review.typo3.org/31493 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
- Jul 07, 2014
-
-
Alexander Bigga authored
Using the TCA select renderMode=tree with the option minitems=1 AND maxitems=1 leads to two bugs since TYPO3 4.5: First #48943 * A new table entry won't mark the field selection as required. The yellow question mark is missing and you can save the entry. * Once you select a checkbox in the tree and unselect it again, the required-check is working. Second: #31637 * You load an existing table entry with a selection of e.g. a category which has been hidden or deleted. The selected checkbox won't be shown, but the required-check fails. * Even worse: You can't select another category as the form thinks you have already selected one item (maxitem=1). You can fix this only by manipulating the database directly. The reason for these bugs can be found in DataPreprocessor::renderRecord_selectProc(). For maxitems = 1 the foreign_table element ids for the tree will be fetched by getDataIdList(). These elements won't be checked whether they are valid (hidden/deleted). This check is done in selectAddForeign() which is used for maxitems > 1. The patch uses the same procedure as for maxitems > 1 in case of renderMode = tree. Resolves: #48943 Resolves: #31637 Releases: 6.3, 6.2, 6.1 Change-Id: I078ff524ea73951f2121d2c233a46bc2ae562952 Reviewed-on: https://review.typo3.org/31481 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
Since introducing FAL the internalUploadMap array in ExtendedFileUtility was not set on uploading files. Resolves: #58463 Releases: 6.2, 6.1, 6.0 Change-Id: I4a537a57f1b688c26c20b9f68356a4be67bc5851 Reviewed-on: https://review.typo3.org/29885 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes
-
Alexey Gafiulov authored
References in flexforms having type=inline are not processed correctly during copy. Fix this by properly applying the reference field check. Resolves: #59664 Releases: 6.3, 6.2, 6.1 Change-Id: I1abfa001ba420531ca0c59903e82b1509e0819e0 Reviewed-on: https://review.typo3.org/31426 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jul 06, 2014
-
-
Bernhard Kraft authored
When using the suggest wizard from within a flexform in a page it doesn't work properly. The $row variable was only set when processing tables other than pages but is required for proper flexform handling. Change-Id: I0eec29b3c7266bae809e2753cdee726a4c50b1ab Resolves: #59642 Releases: 6.3, 6.2, 6.1 Reviewed-on: https://review.typo3.org/31422 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Tomita Militaru authored
Removes parameter to prevent duplicate content, speaking url problems and overloaded urls. Resolves: #51189 Releases: 6.3, 6.2, 6.1 Change-Id: I076d2f87ac7a1d0d9d831cf3293d060318750c7d Reviewed-on: https://review.typo3.org/31420 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jul 02, 2014
-
-
Markus Klein authored
usergroup conditions in user TSconfig are currently failing as the list of groups the user is part of, is not yet compiled when the TSconfig is evaluated. This can be fixed by moving the group evaluation some lines upwards, as this does not influence the remaining code. Resolves: #59813 Releases: 6.3, 6.2, 6.1 Change-Id: Id3189ea5cd31936bdf538e2bb163ecc2d46ed6a0 Reviewed-on: https://review.typo3.org/31152 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Sascha Egerer authored
If a workspace placeholder record is generated the field, that is configured as label for a table, is filled with a placeholder. This is a hardcoded string. If database field does not allow strings (integer, double...) a TYPO3 warning is displayed. "... Propably value mismatch ...". This message is very confusing because the user does not know where it comes from. The label should be evaluated against the TCA eval configuration before it is written to the database. Resolves: #31757 Releases: 6.3, 6.2, 6.1 Change-Id: I18261359550dcaddaa9bd9ca0dd77f8300e81da9 Reviewed-on: https://review.typo3.org/31284 Reviewed-by: Sascha Egerer Tested-by: Sascha Egerer Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
- Jun 29, 2014
-
-
Helmut Hummel authored
Latest changes in PHP disallow unserialize on certain internal classes. Since phpunit uses unserialize to create objects of such classes when requesting a mock without calling the constructor these tests failed with a PHP fatal error. Instead of skipping the tests, we can simply provide mocked constructor arguments (if required) so that phpunit can create a mock object by using the new operator and passing these mocked constructor arguments. Change-Id: I26aa06125581b4ca93abcbad2ebb98003509e81a Resolves: #59979 Related: #59685 Releases: 6.1 Reviewed-on: https://review.typo3.org/31221 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
By default travis notifies on each build when posting to channels (irc, slack) We can reduce the number of notifications by only posting successful builds when it previously failed. Additionally encrypt the API token for posting to slack. Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I882d34903c972201454e6cc5b9041393e3bd3661 Reviewed-on: https://review.typo3.org/31222 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Anja Leichsenring authored
Some 6.1 tests do not work with phpunit 4.0 and above. Instead of fixing them in 6.1 branch, we use a ext:phpunit version that bundles phpunit 3.7. Releases: 6.1 Resolves: #59978 Change-Id: If2d9173ef964a2f71428c495c2ac5c5171025f9c Reviewed-on: https://review.typo3.org/31215 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Jun 28, 2014
-
-
Stefan Neufeind authored
Mask-functionality is broken since the introduction of FAL. Change-Id: Iff28d9561e10f7581041bcc35bd56dfc972954b3 Resolves: #59392 Releases: 6.3, 6.2, 6.1 Reviewed-on: https://review.typo3.org/31202 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Oliver Klee authored
The RootlineUtility uses two local caches and one additional cache from the caching framework. If a unit test uses the RootlineUtility, it needs a way of purging these caches so it does not change the environment. Resolves: #58763 Releases: 6.3, 6.2, 6.1 Change-Id: Ia9878b808acfa03f018086829f90b84d4c5e8512 Reviewed-on: https://review.typo3.org/31200 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 22, 2014
-
-
Helmut Hummel authored
This introduced a regression. It turns out that it needs more work to get all cases covered correctly. Resolves: #58728 Reverts: #16472 Releases: 6.1, 6.2, 6.3 This reverts commit 203c1eb9 Change-Id: I469461a042f37757daafbf23d27a73ad236fcb50 Reviewed-on: https://review.typo3.org/31041 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Jun 21, 2014
-
-
Marc Bastian Heinrichs authored
The correct setting would have been rootLevel. So it was never evaluated, remove it. Resolves: #59773 Releases: 6.3, 6.2, 6.1 Change-Id: I594924caed47c5c911def94524148354790b77b4 Reviewed-on: https://review.typo3.org/31012 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
Marc Bastian Heinrichs authored
An empty "LIT:" condition results in NULL, so the strict compare doesn't match with the empty string. Solution is to cast the haystack to string before, like it was done anyway later in the preg_match. Releases: 6.3, 6.2, 6.1 Resolves: #59344 Change-Id: I1e4b00e454d921eedd0c03a1767d4ec57c321bd7 Reviewed-on: https://review.typo3.org/30992 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 20, 2014
-
-
Alexander Stehlik authored
The RteHtmlParser will now check if a scheme found by parse_url() matches a configured typolinkLinkHandler. If this is the case the link will be treated as internal. Resolves: #49036 Releases: 6.3, 6.2, 6.1 Change-Id: Ie4e6bded7a1c4d0c61e4f1a20bc23115612c1519 Reviewed-on: https://review.typo3.org/30976 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
A backport mistake happened letting the jpeg file extension vanish. Undo that mistake. Resolves: #30244 Releases: 6.1 Change-Id: I9e12485f03b5f4f468920e47b81308de2e0c6a4a Reviewed-on: https://review.typo3.org/30897 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Jigal van Hemert authored
If paths or filenames of external documents contain utf-8 characters the system locale must be used. Functions like escapeshellarg and basename are locale aware. Change-Id: I50a73a42d60de569c63e5ba27ad6a6a3a66fd6c8 Fixes: #30244 Releases: 4.5, 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/26918 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 19, 2014
-
-
Claus Due authored
A field name parameter is not being passed from within DataHandler when copying a record which has a FlexForm DF associated with it. This causes dynamic FlexForm DS definitions to not be able to depend on the field name, in turn causing the problem that an incorrect DS may be returned from the DS utility which makes TYPO3 process the data value incorrectly (for example, not detecting file fields and processing the values accordingly). To solve this the $field parameter is passed. Resolves: #59423 Releases: 6.3, 6.2, 6.1 Change-Id: Icfafd553f76e17ad5db651bb3f5dea52b140dcf7 Reviewed-on: https://review.typo3.org/30891 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 13, 2014
-
-
Philipp Gampe authored
The extension manager fails to show any error message if an extension update fails. Convert exceptions (e.g. dependency fails, TER download fails) into a nice flashmessage. Convert any server errors (uncatchable PHP errors) into a flashmessage. Resolves: #56823 Releases: 6.2, 6.1 Change-Id: Ife3c6d3dcd23177ba22192dd6ae720352931b538 Reviewed-on: https://review.typo3.org/29735 Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Francois Suter authored
The sorting by date fails in the Filelist module when more than 9 files with the same date are found since the numerical suffix used to avoid overwriting existing entries in the sorting array is not properly padded. Fixes: #59458 Releases: 6.2, 6.1 Change-Id: I2c80a00dd1692b0987da3d461cc5a21fcea4c97d Reviewed-on: https://review.typo3.org/30711 Reviewed-by: Francois Suter Tested-by: Francois Suter
-
- Jun 12, 2014
-
-
Alexander Opitz authored
Set RteHtmlParser in dontHSC_rte modus to fix garbled output. Resolves: #25188 Releases: 6.2, 6.1 Change-Id: Ib01c3f6dcf1729b1979003c207aa622cc5c9b5c3 Reviewed-on: https://review.typo3.org/30690 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Jun 06, 2014
-
-
Mathias Brodala authored
Due to using array_pop instead of array_shift the last line of the command description is dropped instead of the first. Use array_shift instead to get the full description annotated for the command method. Resolves: #59324 Releases: 6.2, 6.1, 4.7 Change-Id: I4d7c320b0ef334adbd15997d15d8e7a56d5739c1 Reviewed-on: https://review.typo3.org/30613 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Jan-Erik Revsbech authored
When running TYPO3 behind a reverse proxy, which also handles SSL, the setting reverseProxySSL should check if the site is requested from one of the reverse proxies in order to determine whether the site is using SSL. It incorrectly does this check via getIndpEnv('REMOTE_ADDR') which has already translated the proxy IP to the end-users IP, thus always returning FALSE. Resolves: #37467 Releases: 6.2, 6.1 Change-Id: I95615b0fea94e0ef0222e958e4e0bba5e6e9f60a Reviewed-on: https://review.typo3.org/30604 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 05, 2014
-
-
Robert Vock authored
Logoff sets user property to an empty string instead of NULL. This leads to a PHP Warning in PHP 5.4 Change-Id: Ib0e1a31dbf2fd3fcbcf1e7afd972b53d60c3ab5d Resolves: #59364 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/30595 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Zenker authored
$this->sWArr is not defined SearchController. Fix this to use the correct $this->searchWords variable. Change-Id: Iba888f1a47dcc0952ffbbb1e3bb4413435c2a95e Resolves: #59277 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/30587 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 04, 2014
-
-
Helmut Hummel authored
* Unit tests are allowed for CLI anyway * Remove allow all in data provider The latter implicitly caused a global allow, as PHPUint parses all data providers before any test is run, thus setting globals there will cause them to be preserved (and restored when backup globals is true). Releases: 6.2, 6.1, 6.0 Resolves: #59343 Change-Id: I646294bb472027e22d6edc0622068698fe9a88fc Reviewed-on: https://review.typo3.org/30563 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Jun 03, 2014
-
-
Markus Klein authored
Ensure the DataHandler::log() function does return integers in all cases as denoted in the doc header. Resolves: #59185 Releases: 6.2, 6.1, 6.0 Change-Id: I2a6aa0415b7cc19f10b4a290e43bd20065e6c9e1 Reviewed-on: https://review.typo3.org/30549 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
RTE feature "userlinks" generates a wrong JS function name due to the automatic replacement during the namespace conversion. Revert this line to use the correct JS function name. Resolves: #59302 Releases: 6.2, 6.1, 6.0 Change-Id: Ia6b51e7e1b1dfa0e618106f4f039bd0774464a97 Reviewed-on: https://review.typo3.org/30540 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
The AJAX url for retrieving a new encryption key contains two question marks. This causes the request to fail. Fix this by removing the superflous ? from the parameters. Resolves: #59034 Releases: 6.1, 4.7, 4.5 Change-Id: Iab3833f50a48b71b25cf0205f7eb8d6b57dd859a Reviewed-on: https://review.typo3.org/30385 Reviewed-by: Alexander Opitz Reviewed-by: Michael Schams Tested-by: Michael Schams Reviewed-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- May 29, 2014
-
-
Sebastian Michaelsen authored
The title of a flexform element is cropped to maximum length of 30 characters. Instead it should obey the maximum title length in the user settings. Resolves: #58910 Releases: 6.2, 6.1 Change-Id: I28c6fc94b2d492217479bf014ff8f67463b4e98f Reviewed-on: https://review.typo3.org/30488 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
When setting up a new TYPO3 installation, TYPO3 should redirect to the install tool, when accessing the frontend or backend. This redirect fails since introduction of the trustedHostsPattern since no configuration is available at this point, while the request itself is a BE or FE request, which will be denied in this case. Solution is to set the REQUEST_TYPE to INSTALL before doing the redirect to install tool so that creating the redirect is allowed. Resolves: #59087 Releases: 6.2, 6.1 Change-Id: I31bcbc20fa1c9bca0d6bf2b940bf26b9affe893b Reviewed-on: https://review.typo3.org/30487 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- May 28, 2014
-
-
David Greiner authored
If localizing a parent-child structure, usually the language of the parent element shall be applied to related child records as well as new child records. Due to a missing array segment, the accordant section in the the InlineElement source code never was processed. Resolves: #57063 Releases: 6.2, 6.1 Change-Id: I7e563044f9889538f9b8171f71f7685722db8266 Reviewed-on: https://review.typo3.org/30472 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-