- Nov 02, 2014
-
-
Wouter Wolters authored
Use "int" or "bool" in @var notation instead of "interger" or "boolean". Resolves: #62571 Releases: master Change-Id: Icc17d2a7806a4632da2c4684c57f1f6d619878a3 Reviewed-on: http://review.typo3.org/33632 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
- Nov 01, 2014
-
-
Markus Klein authored
This patch removes all upgrade wizard updates before version 7. The old [wizardDone] LocalConfiguration entries are removed with the SilentConfigurationUpgradeService. Resolves: #62402 Releases: master Change-Id: If5aff37a8caf8e74eebac8ff857bcf9be8cd0092 Reviewed-on: http://review.typo3.org/33476 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Stanislas Rolland authored
Avoid useless overhead. Releases: master Resolves:#62617 Change-Id: Ibb722b405d8c95335f655c78faa05fe3be8a4ea6 Reviewed-on: http://review.typo3.org/33706 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
-
Helmut Hummel authored
The introduction of CSRF protection for backend modules introduced a regression for traditional modules. Previously the script was calculated correctly if not provided. Now API calls without providing the script are assumed to be mod.php dispatched. Fix that by checking if the M GET argument was sent and fall back to traditional URL calculation. Resolves: #62569 Releases: 6.2, master Change-Id: I26d16acb513d678f117e0b645fe3eefebf909e3d Reviewed-on: http://review.typo3.org/33626 Reviewed-by:
-
Helmut Hummel authored
Fix the missing CSS classes for the up/down/remove buttons of select fields in FormEngine. Resolves: #62591 Releases: master Change-Id: I5ab3bda5a1170451a75e0c992cf2c6579bfb8c5d Reviewed-on: http://review.typo3.org/33676 Reviewed-by:
-
Helmut Hummel authored
Currently registering the exception handler is done after extensions are loaded to allow extensions to modify configuration to override the exception handler defined in LocalConfiguration or DefaultConfiguration. Registering the exception handler so late has however the drawback that exceptions throw before, lack proper handling (and maybe in production even disclose more information than needed). Change that and register error handling much earlier in the bootstrap so that exceptions thrown e.g. while loading ext_localconf.php can show a proper stack trace to give developers more useful information why the exception occurred. To still allow extensions to override configuration, we now remember the early exception and error handler classes and potentially register a new exception handler after extensions have been loaded. Resolves: #60235 Releases: 6.2, master Change-Id: I087173073ba75a54be14ca4f40f90c0e5304892d Reviewed-on: http://review.typo3.org/31555 Reviewed-by:
-
Stanislas Rolland authored
Avoid useless overhead. Releases: master Resolves: #62609 Change-Id: I6b2f2805945d0e6a04b3617807f952cd30d8ede8 Reviewed-on: http://review.typo3.org/33700 Reviewed-by:
-
Stanislas Rolland authored
Remove the span tags inserted by Chrome or Opera on execution of native execCommand. The attributes of these span tags have evolved... This is a follow-up change to http://review.typo3.org/33392. Releases: master, 6.2 Resolves: #52470 Change-Id: Ib3c2fa3a1a8f0e378bfa2ca4a5f6e78d1fdf3da7 Reviewed-on: http://review.typo3.org/33657 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Stanislas Rolland authored
Releases: master, 6.2 Resolves: #62559 Change-Id: Ib9c0576e82424065e875a73edfa91795c71e841e Reviewed-on: http://review.typo3.org/33655 Reviewed-by:
-
Stanislas Rolland authored
Fix wrong absolute path calculation. Releases: master, 6.2 Resolves: #56408 Change-Id: Ia96197f0dcf81bb8b52b511c75ae303a85ec9b97 Reviewed-on: http://review.typo3.org/33568 Reviewed-by:
-
Frank Nägler authored
Change the docComment of FlashMessageViewHelper to match the new output Resolves: #62603 Releases: master Change-Id: Ie32a8e2f4eac3d18bccc059c85370d063eaa65c2 Reviewed-on: http://review.typo3.org/33693 Reviewed-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Tested-by:
-
Wouter Wolters authored
Resolves: #62600 Releases: master Change-Id: I494232aa223de15df076699af8af6dfcfe66f5a8 Reviewed-on: http://review.typo3.org/33691 Reviewed-by:
-
Wouter Wolters authored
The message when there are unresolved dependencies uses the old flashmessage styling classes. Use the new classes. Resolves: #62599 Releases: master Change-Id: I3b48c6ae6ba19f771e81ce3de4bddefb2d509900 Reviewed-on: http://review.typo3.org/33690 Reviewed-by:
-
Wouter Wolters authored
Due to the new flashmessage styling the checks done for saltedpasswords don't work anymore. Change the checks to the new class names. Resolves: #62598 Releases: master Change-Id: Iea269f1d138e58cd551fa5575f3b03455a48d930 Reviewed-on: http://review.typo3.org/33689 Reviewed-by:
-
Helmut Hummel authored
The content exception handler change introduced PHP 5.5 only code parts. Revert these parts until we have a final decision when to introduce PHP 5.5 only code in master Releases: master Change-Id: I16c818a686e1a99a5084ce8f8dcddef0cc930929 Reviewed-on: http://review.typo3.org/33682 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
Felix Kopp authored
Rebrushes the FlashMessage layout and output. Better contrast of box and text. Prominent links. Lighter boxes. Resolves: #62580 Releases: master Change-Id: I7db1dbf8aa8ce8d626757c001c1f1a1621d1a303 Reviewed-on: http://review.typo3.org/33666 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Felix Kopp authored
<table class="t3-table"> is the TYPO3 standard class. Allows success / danger / warning / info and active on table rows and table cells. Also makes use of new table row markup in Report>Services. This preceedes #62580 since FlashMessages can't be changed. Test run this patch with EXT: styleguide Table demo markup. Resolves: #62592 Releases: master Change-Id: I36b4977ab1c412b4f29e4c6a1b958f498304048f Reviewed-on: http://review.typo3.org/33677 Reviewed-by:
-
- Oct 31, 2014
-
-
Wouter Wolters authored
The timestamp handed to the date function must be of type int otherwise a warning is issued. Cast the value to int before passing it to the date function. The important scenarios are when the timestamp is "0" or "" (blank string). Add unit test for formatValue function and the possible format configurations. Resolves: #62032 Releases: master, 6.2, 6.1, 4.5 Change-Id: I5207ef5b562dd70b9b5e574eef1b9ee59fa836f0 Reviewed-on: http://review.typo3.org/33129 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Oct 30, 2014
-
-
Martin Kästner authored
If adding new content elements in Web>List with the CE wizard, you get the old column layout & titles even if you have a complete backend_layout working. But for Moving Elements the Backend Layout is already correct. Column titles are already in $tcaItems a few lines before the lines in the patch for File PagePositionMap.php. Using this values the backend_layout is correct in Web>List CE Wizard. Resolves: #42457 Releases: master, 6.2 Change-Id: I5f57aeac493ec5db02aaa92bd9eab97390cdb967 Reviewed-on: http://review.typo3.org/16837 Tested-by:
-
Markus Klein authored
Resolves: #62547 Releases: master Change-Id: Idada794755d8e40f702d0d9ada5a8b8b5719bf4c Reviewed-on: http://review.typo3.org/33616 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Felix Kopp authored
Use twbs Bootstrap 3.3 release for t3skin. Notes: https://github.com/twbs/bootstrap/releases/tag/v3.3.0 Resolves: #62573 Releases: master Change-Id: I4138bbf154d091e30155998c4e52c79c41967dc1 Reviewed-on: http://review.typo3.org/33640 Reviewed-by:
-
Tomita Militaru authored
Adds checks for file existence to avoid returning directory paths instead of path to file. Resolves: #51781 Releases: master, 6.2 Change-Id: I8f879f38b95e6d9562a8883d35664550d8fa8774 Reviewed-on: http://review.typo3.org/25286 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
Frank Nägler authored
In some cases the $fileObject is null and getName() is called on a null object which results in a fatal error. This patch add a check if $fileObject is an instance of FileInterface before call getName(). Also correct the wrong doc comment. Resolves: #60773 Releases: 6.2, master Change-Id: I6f3f817a089c665d8cc9e0b3369d6d690ffaf620 Reviewed-on: http://review.typo3.org/32713 Reviewed-by:
-
Markus Klein authored
Since the Core uses and embraces the usage of short data type names like "bool" or "int", internal type checks must ensure these are recognized as well. This patch takes the load off the checks and implements type conversion for these short names right into the ReflectionService, so the checks are still done against the full names like "boolean" or "integer". Resolves: #62547 Releases: master Change-Id: I0d391f04f91c40035d0ff9ae314f8f5bc4d0454c Reviewed-on: http://review.typo3.org/33611 Reviewed-by:
-
- Oct 29, 2014
-
-
Helmut Hummel authored
Currently exceptions throw when rendering single content objects bubble up to the default exception handler and break the complete frontend. This change adds the possibility to register an exception handler for a content object which can render an appropriate message instead if wanted (e.g. in production context). Releases: master Resolves: #47919 Change-Id: I9e3697401432b043e164fa84340739a525f80264 Reviewed-on: http://review.typo3.org/31123 Reviewed-by:
-
Georg Ringer authored
Because of introducing a strict comparion in #60346, the active page is not highlighted anymore as a float and an int value are compared. Change-Id: Id66c77e64fb4824f5b254240b1774f77adfa6ab9 Resolves: #62532 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/33605 Reviewed-by:
-
Markus Klein authored
Remove a wrong escaping method from sysext form which causes email problems. Resolves: #60437 Releases: master, 6.2 Change-Id: I3a5447b55f4f0723637c04929de0412a4a3b67a7 Reviewed-on: http://review.typo3.org/33499 Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
Markus Klein authored
Fix various code issues like missing return values, wrong phpdoc, unused variables, etc. Resolves: #62414 Releases: master Change-Id: I1769e9c365b96d70cde426a3d079acf8abbfc724 Reviewed-on: http://review.typo3.org/33480 Reviewed-by:
-
- Oct 28, 2014
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
-
Frank Nägler authored
Remove unnecessary fully qualified names from Utility classes. Resolves: #62505 Releases: master Change-Id: I3d4af98670911b3b49bd8043136c92422925cd2a Reviewed-on: http://review.typo3.org/33588 Reviewed-by:
-
Felix Kopp authored
Resolves: #61443 Releases: master Change-Id: I2a524b3b066712a614534acb14eaef28c4fce86e Reviewed-on: http://review.typo3.org/33589 Reviewed-by:
-
Helmut Hummel authored
Browsers started to distinguish how opening a new window from JavaScript happens. They track "user initiated" opening and not user initiated opening and behave differently. A request to open a window by JavaScript which is not user initiated is caught by a pop up blocker most of the time nowadays. This means a user must explicitly allow the current page to open new windows by JavaScript. Additionally some browsers (e.g. Chrome) always open a new window instead of a new tab if the request is not user initiated, regardless of browser settings, which nowadays default to open a new tab. The "save and preview" button currently initiates a page reload which saves the document and add some JavaScript to to open a preview window in the HTML response of this action. This JavaScript action is then not considered to be user initiated any more as opening the new window does not follow a direct user click action. The result is, that if a preview window/tab was opened previously, then the preview/window tab is just reloaded with the new preview URL. If it is the first time the window/tab should be opened this request is caught by the popup blocker. Other preview buttons in the backend (from Click Menu or action toolbar) behave differently (correctly) as they are always identified as user initiated. For that reasons, change the "save and preview" button to directly open a new window on click (without URL) and let the HTML/ JavaScript response set the correct preview URL after that. By doing so we gain a consistent behavior no matter what preview button a user clicks first. The only downside is, that in case the preview window is opened the first time, it remains empty until the page is saved and then reloaded through the JavaScript code that is already present. Resolves: #62503 Releases: 6.2, master Change-Id: I7a96c347453b1ccdeaf0d8d1bd5b080f905563ca Reviewed-on: http://review.typo3.org/33576 Reviewed-by:
-
- Oct 27, 2014
-
-
Georg Ringer authored
The field "email" should use the input type "email". Resolves: #62504 Releases: master Change-Id: I1f443eac86508dd914a75c4a1ab7d0454c043f66 Reviewed-on: http://review.typo3.org/33587 Reviewed-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
-
Georg Ringer authored
The icon for collapsed table must be also styled with a font awesome icon as the expand icon. Resolves: #62439 Releases: master Change-Id: I908bffadcfa05def7633002bfccdce5afe5ed4ae Reviewed-on: http://review.typo3.org/33585 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Helmut Hummel authored
InlineElement::updateInlineView() is only used once throughout the core and called statically, although the method is not declared to be static. Fix this by declaring it static. Resolves: #62501 Releases: 6.2, master Change-Id: Ifeb8551899ccf285d87a66767bf7de4e8e98b32f Reviewed-on: http://review.typo3.org/33582 Reviewed-by:
Cedric Ziel <cedric@cedric-ziel.com> Tested-by:
-
Helmut Hummel authored
When using the click menu to hide, unhide or delete a record, previously the page tree was refreshed, although those changes are only reflected in the pagetree if page properties are changed. Adapt the click menu to only refresh the tree if a page record is changed or deleted. Resolves: #40687 Releases: 6.2, master Change-Id: I32844b359abd790f1dbd6839eec6feeb6e62bd02 Reviewed-on: http://review.typo3.org/33573 Reviewed-by:
-
Stanislas Rolland authored
The HTMLparser properties must be defined under subproperty HTMLparser of enableWordClean and not directly under property enableWordClean. Releases: master, 6.2 Resolves: #58105 Change-Id: I0b21e5789aa4db867e0057e484d17f40a26b5c56 Reviewed-on: http://review.typo3.org/33565 Reviewed-by:
-
Felix Kopp authored
Fixes several layout issues with the FormEngine form: Adds space between checkbox+label. Forms element browser link as default button. Form field header will be a headline h4. Repairs outer padding and inner padding and borders. Resolves: #62466 Releases: master Change-Id: I0dcf1cd2206c0cee63a8353516a3b41b94fd670b Reviewed-on: http://review.typo3.org/33520 Reviewed-by:
-
Felix Kopp authored
Allow video and audio playback in the backend (i) element information window. Uses the new introduced RenderingRegistry to find a matching rendering class (#61800). Brings default letter box background color for <Video> tags. Resolves: #61668 Releases: master Change-Id: I7c01fbaf2258b4e7c6f10da0e6438bdc55d12197 Reviewed-on: http://review.typo3.org/32816 Reviewed-by:
-
Felix Kopp authored
First step for Toolbar/Topbar refactoring. This is a first step to refactor HTML5 output - the path to gain HTML5 viewport without ExtJS and based on jQuery and Bootstrap. Migrates HTML from topbar to .navbar - keeps ids. Makes use of .dropdown and .dropdown-menu. Therefore removes duplicated CSS. Also increase size to fit our fingers & touch. This issue is not breaking since common css classes and interfaces are kept. Next step #62166: introduce "ToolbarItemInterface" and remove toolbar-item css and layouts. Resolves: #62481 Related: #62166 Releases: master Change-Id: I8c215b19da4a99ad81e53b000b281849991d8deb Reviewed-on: http://review.typo3.org/33564 Reviewed-by:
-
