Skip to content
Snippets Groups Projects
  1. Mar 19, 2013
    • Wouter Wolters's avatar
      [TASK] Update copyright year to 2013 · 4d463976
      Wouter Wolters authored
      In this patch are also some fixes for files containing
      a interface. Due the namespace change all interfaces
      have the curly bracket not on the same line as the
      interface name.
      
      Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
      Resolves: #46370
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18984
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      4d463976
  2. Mar 18, 2013
    • Stefan Neufeind's avatar
      [TASK] Use minimised version of jquery.dataTables-1.9.4 · a8cbf426
      Stefan Neufeind authored
      Change-Id: Ic8f2f046b6df70c885158f4c1f08cbad1c943cf1
      Resolves: #43186
      Releases: 6.1, 6.0
      Reviewed-on: https://review.typo3.org/16652
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      a8cbf426
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · 1fbd023d
      Christian Kuhn authored
      Change-Id: I8b49be31e8f22a661dbb9c38f2e6a11d370541d3
      Reviewed-on: https://review.typo3.org/19018
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      1fbd023d
    • Georg Ringer's avatar
      [TASK] Declare non static methods as static · a612a841
      Georg Ringer authored
      Change-Id: Ifa199fd6b500f4f161b49a406aa2678abdaa785b
      Resolves: #45509
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18301
      Reviewed-by: Dmitry Dulepov
      Reviewed-by: Oliver Klee
      Reviewed-by: Simon Schaufelberger
      Tested-by: Simon Schaufelberger
      Reviewed-by: Soren Malling
      Tested-by: Soren Malling
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      a612a841
    • Andreas Schütte's avatar
      [BUGFIX] Media element not working with FAL · c07cd400
      Andreas Schütte authored
      With FAL the path to a file is no longer used,
      instead the UID to the specific file is used,
      prefixed with "file:"
      
      This patch just adds a check if the filename
      starts with "file:" and if so load the specific FileObject
      to retrive the url. This check is done before all others,
      because FAL should be the default file handler.
      Additionally use explode() first to get the filename
      if an editor adds (non used)
      link parameters: file:740 _blank media-title
      
      This fixes also the problem with audio files mentioned in #39416,
      using the same patch.
      
      Resolves: #41280
      Related: #39416
      Releases: 6.0, 6.1
      Change-Id: Ibec6cefda54b6e136c0d5ae43c67ef2eea3b1bb8
      Reviewed-on: https://review.typo3.org/18228
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Marco Huber
      Tested-by: Marco Huber
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Mattias Nilsson
      Tested-by: Mattias Nilsson
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      c07cd400
  3. Mar 17, 2013
    • Helmut Hummel's avatar
      [BUGFIX] Fix PHP warning in BackendUtility::lockRecords · c6eb4502
      Helmut Hummel authored
      This methods triggers a warning "Illegal String offset"
      with PHP 5.4, because $GLOBALS['BE_USER']->user['uid'] is accessed
      even if a user is not logged in.
      
      Additionally a delete query is executed in this case which
      does not make sense at all.
      
      Properly check if a user is logged in before executing any
      functionality in this method.
      
      Fixes: #46361
      Releases: 4.5, 4.7, 6.0, 6.1
      Change-Id: I370e0a8610a55b3d684bef95d7c6905eaaaacbab
      Reviewed-on: https://review.typo3.org/18978
      Reviewed-by: Markus Klein
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      c6eb4502
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · ae53e44c
      Christian Kuhn authored
      Change-Id: Ib66dcd1ca3ea25d55e9ff8a8dee281aa99687489
      Reviewed-on: https://review.typo3.org/18991
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      ae53e44c
  4. Mar 16, 2013
    • Georg Ringer's avatar
      [TASK] Remove old JS in page header · 2fd2f062
      Georg Ringer authored
      Change-Id: I509ffe2cc3dc37cc08de3633c79127c1f50145a7
      Resolves: #45528
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18313
      Reviewed-by: Oliver Klee
      Reviewed-by: Dmitry Dulepov
      Tested-by: Dmitry Dulepov
      Reviewed-by: Markus Klein
      Reviewed-by: Henrik Ziegenhain
      Reviewed-by: Thomas Loeffler
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Wouter Wolters
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      2fd2f062
    • Georg Ringer's avatar
      [FEATURE] Add stdWrap to config.pageTitleSeperator · 3bd2b3c4
      Georg Ringer authored
      Add stdWrap to config.pageTitleSeperator
      
      Change-Id: I88c2141167414b184f158d09f40df3aa36390b4a
      Resolves: #35223
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18123
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      3bd2b3c4
    • Stefan Neufeind's avatar
      [TASK] Use central jQuery · 2336e9cd
      Stefan Neufeind authored
      Change-Id: I80ebeaff81fbcb8d4d479d977f7aa23390692d28
      Resolves: #43184
      Releases: 6.0
      Reviewed-on: https://review.typo3.org/16650
      Reviewed-by: Oliver Klee
      Reviewed-by: Mattias Nilsson
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Sebastian Michaelsen
      Reviewed-by: Felix Kopp
      Tested-by: Felix Kopp
      Reviewed-by: Marcus Schwemer
      Tested-by: Marcus Schwemer
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      2336e9cd
    • Stefan Froemken's avatar
      [BUGFIX] respect rootLevel=-1 in exec_foreign_table_where_query · 49b6aef3
      Stefan Froemken authored
      exec_foreign_table_where_query does not interpret the
      rootLevel directive correctly.
      
      Resolves: #45703
      Releases: 6.1, 6.0, 4.7, 4.6, 4.5
      Change-Id: I2a4dd0335ac5373562f287427d5592cfd406e2f9
      Reviewed-on: https://review.typo3.org/18417
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      49b6aef3
    • Christian Kuhn's avatar
      [BUGFIX] HMENU rendering uses old tslib_ class names · e304a7de
      Christian Kuhn authored
      The menu rendering in frontend still instantiates menu classes with
      its old tslib_ prefixed names. This is unflexible and a potential
      performance issue.
      
      The patch introduces a simple factory instead with a mapping for
      existing TypoScript menu types to the implementing classes.
      The current variable $menuclasses is obsolete.
      Additionally, the naming of three existing classes is adapted to
      the correct class names to be in sync with the others.
      
      A method in the factory to register additional menu types will
      be added with a second patch.
      
      Change-Id: I3d65258ffe4d30a918705b23349d3facb563c80e
      Resolves: #46292
      Releases: 6.1, 6.0
      Reviewed-on: https://review.typo3.org/18913
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      e304a7de
    • Christian Kuhn's avatar
      [BUGFIX] Make sure XML parser is created everytime when needed · bd86bd1d
      Christian Kuhn authored
      Currently, EM's MirrorXmlPushParser, which is based on ext/xml,
      is not properly working. The constructor creates the parser and
      within parseXML() method the parser resource is freed.
      However, when clicking on retrieve/update button method
      parseXML() is invoked multiple times which makes subsequent calls
      fail.
      
      Creating the parser is now done within parseXML() method.
      
      Change-Id: I7c6c15f65d08fb0264d7d66cc584cbe7ff423b45
      Resolves: #25292
      Releases: 6.1, 6.0, 4.7, 4.5
      Reviewed-on: https://review.typo3.org/18966
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      bd86bd1d
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · 5c3c09b0
      Christian Kuhn authored
      Change-Id: Ifc59f15abf43026007737c1051bb0f79bfacc55d
      Reviewed-on: https://review.typo3.org/18963
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      5c3c09b0
  5. Mar 15, 2013
    • Christian Kuhn's avatar
      [BUGFIX] Importing extensions from repository fails · 48ad6728
      Christian Kuhn authored
      If importing the extension list from TER, an incoming XML extension
      row has a field 'category' that contains either a string like
      'plugin' or a category number.
      The list is persisted to the 'extension' repository. In the
      database, the category is stored as integer. There is a mapping
      function in the extension model to get the integer category
      index from given XML input. The method is faulty and returns
      strings instead of an index if the given category is a string
      itself. This results in database errors during insert.
      
      The patch fixes the method, renames it along the way and adds
      unit tests to document desired behavior.
      
      Change-Id: I601b84d0829f3d20a4cdd25a3f7f37e8128dbce1
      Fixes: #46115
      Releases: 6.1, 6.0
      Reviewed-on: https://review.typo3.org/18805
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      48ad6728
    • Christian Kuhn's avatar
      Revert "[BUGFIX] Fix wrong column title in web>list for field colpos" · d5e711a2
      Christian Kuhn authored
      This reverts commit 50eba0a8
      
      The patch triggers warnings and errors in multiple extensions. Digging
      into the details shows the implementation is neither finished nor
      stable. See issue #25113 for a detailed analysis.
      
      Change-Id: I739c72887617b026d80063fe1fab57f95124d508
      Related: #25113
      Fixes: #45833
      Releases: 6.1, 6.0, 4.7, 4.6, 4.5
      Reviewed-on: https://review.typo3.org/18941
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      d5e711a2
    • Francois Suter's avatar
      [BUGIFX] Extra output block backend thumbnails · 51774f94
      Francois Suter authored
      If some inclusion causes output when viewing image thumbnails
      in the backend, the output will be broken. Adding a call to
      ob_clean() ensures that this does not happen.
      
      Resolves: #31953
      Releases: 6.1, 6.0
      Change-Id: I1d33bc3c5e8bbd1851f087c76564f8924f8dfe26
      Reviewed-on: https://review.typo3.org/18220
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Wouter Wolters
      Reviewed-by: Mattias Nilsson
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      51774f94
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · 78debdd8
      Christian Kuhn authored
      Change-Id: I5eff310e62fc43d9d2f9b52631da8ce3b085d474
      Reviewed-on: https://review.typo3.org/18931
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      78debdd8
  6. Mar 14, 2013
  7. Mar 13, 2013
    • Christian Kuhn's avatar
      [TASK] Raise submodule pointer · ad0a8b0e
      Christian Kuhn authored
      Change-Id: I04d40a3796937182603c7b85e16227f18f51c002
      Reviewed-on: https://review.typo3.org/18889
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      ad0a8b0e
    • Christian Kuhn's avatar
      [FEATURE] Central system environment check · 009f307b
      Christian Kuhn authored
      This patch adds a new structure to the install tool to centralize
      all system and especially PHP related system checks cluttered in
      various modules and parts of the core at the moment.
      
      The idea is to have a basic, standalone script to test for all
      requirements TYPO3 CMS has in order to run smoothly. The script does
      not use any TYPO3 core code and has no further dependencies. With
      a later patch, the check will be integrated as the very first
      step during install, to give a good indicator if the final
      installed system will work well or if any system constraints are
      not met.
      
      Currently, the script is included as a new section in the install
      tool, called "System environment", where all checks are performed
      and each gives a status back. This will already help to support
      questions on mailing lists and should be the first step every user
      is guided to: "Do you have warnings or errors in the system
      environment?". The install tool implementation should also help
      already if moving an instance to a different server.
      
      Furthermore, there is a simple integration in the reports module
      that points to the install tool if issues are found.
      
      The class structure is as simple as possible, it is very easy to
      adapt single checks later on, the API is a single getStatus() method
      that returns all check object of the specific tests. Due to the
      nature of the script and the later usage in the installation
      process, things like localization and so on are not done and
      should also not be implemented later on.
      
      Most current check code is fetched from existing install tool,
      reports module and bootstrap code. This also make the main
      Installer.php class of the install tool already a bit better
      maintainable since 600 lines of code are removed from it.
      
      Change-Id: I64387ca9aaa4b429ee4a909cdab4386180af0d45
      Resolves: #46219
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18870
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      009f307b
    • Mario Rimann's avatar
      [BUGFIX] Translation of a form makes the form wizard unusable · 338cf5b6
      Mario Rimann authored
      As soon as the form-configuration for the form wizard gets
      loaded, the leading "[Translate to XYZ:] " is stripped off to get the
      wizard working (with the leading text, the form config could not
      be serialized as needed and the wizard didn't show a single field).
      
      The stripping is only done on localized records.
      
      Change-Id: I0cab1d371abf5ae01b524c39acedcd1a3a5db9c4
      Fixes: #39127
      Releases: 4.7, 6.0, 6.1
      Reviewed-on: https://review.typo3.org/12996
      Tested-by: Mario Rimann
      Reviewed-by: Stefan Galinski
      Tested-by: Stefan Galinski
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      338cf5b6
    • Dmitry Dulepov's avatar
      [TASK] Improve FAL performance · 76ec3573
      Dmitry Dulepov authored
      FAL performance in BE and FE can be improved by using certain database
      indexes. One set of indexes improves performance in BE by adding a
      "deleted" column, which is used by List module. Without this column
      in the 'pid' index, List module will do a full scan, which is much
      slower. Another set of indexes improves performance when getting files
      from storage.
      
      Change-Id: I1f8577453ed917db95d680ca74fefc4691ba53b0
      Resolves: #45532
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18316
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      76ec3573
    • Georg Ringer's avatar
      [TASK] Improve rootline cache handling · 688d341c
      Georg Ringer authored
      The method get() checks if there is an entry by using
      has() and does then an additional get(). This can
      be simplified which saves a query for every hit
      
      Change-Id: I0ebfd8c7622a5e673d3f34aa685f18a9878116ef
      Resolves: #45530
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/18314
      Reviewed-by: Oliver Hader
      Reviewed-by: Philipp Gampe
      Reviewed-by: Steffen Ritter
      Reviewed-by: Oliver Klee
      Reviewed-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      688d341c