- Mar 19, 2013
-
-
Wouter Wolters authored
In this patch are also some fixes for files containing a interface. Due the namespace change all interfaces have the curly bracket not on the same line as the interface name. Change-Id: I64ba45de73693452d681ce7f018965968b11d2af Resolves: #46370 Releases: 6.1 Reviewed-on: https://review.typo3.org/18984 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 18, 2013
-
-
Stefan Neufeind authored
Change-Id: Ic8f2f046b6df70c885158f4c1f08cbad1c943cf1 Resolves: #43186 Releases: 6.1, 6.0 Reviewed-on: https://review.typo3.org/16652 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: I8b49be31e8f22a661dbb9c38f2e6a11d370541d3 Reviewed-on: https://review.typo3.org/19018 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Georg Ringer authored
Change-Id: Ifa199fd6b500f4f161b49a406aa2678abdaa785b Resolves: #45509 Releases: 6.1 Reviewed-on: https://review.typo3.org/18301 Reviewed-by: Dmitry Dulepov Reviewed-by: Oliver Klee Reviewed-by: Simon Schaufelberger Tested-by: Simon Schaufelberger Reviewed-by: Soren Malling Tested-by: Soren Malling Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Andreas Schütte authored
With FAL the path to a file is no longer used, instead the UID to the specific file is used, prefixed with "file:" This patch just adds a check if the filename starts with "file:" and if so load the specific FileObject to retrive the url. This check is done before all others, because FAL should be the default file handler. Additionally use explode() first to get the filename if an editor adds (non used) link parameters: file:740 _blank media-title This fixes also the problem with audio files mentioned in #39416, using the same patch. Resolves: #41280 Related: #39416 Releases: 6.0, 6.1 Change-Id: Ibec6cefda54b6e136c0d5ae43c67ef2eea3b1bb8 Reviewed-on: https://review.typo3.org/18228 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Marco Huber Tested-by: Marco Huber Reviewed-by: Stefan Neufeind Reviewed-by: Mattias Nilsson Tested-by: Mattias Nilsson Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 17, 2013
-
-
Helmut Hummel authored
This methods triggers a warning "Illegal String offset" with PHP 5.4, because $GLOBALS['BE_USER']->user['uid'] is accessed even if a user is not logged in. Additionally a delete query is executed in this case which does not make sense at all. Properly check if a user is logged in before executing any functionality in this method. Fixes: #46361 Releases: 4.5, 4.7, 6.0, 6.1 Change-Id: I370e0a8610a55b3d684bef95d7c6905eaaaacbab Reviewed-on: https://review.typo3.org/18978 Reviewed-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: Ib66dcd1ca3ea25d55e9ff8a8dee281aa99687489 Reviewed-on: https://review.typo3.org/18991 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 16, 2013
-
-
Georg Ringer authored
Change-Id: I509ffe2cc3dc37cc08de3633c79127c1f50145a7 Resolves: #45528 Releases: 6.1 Reviewed-on: https://review.typo3.org/18313 Reviewed-by: Oliver Klee Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Reviewed-by: Markus Klein Reviewed-by: Henrik Ziegenhain Reviewed-by: Thomas Loeffler Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Georg Ringer authored
Add stdWrap to config.pageTitleSeperator Change-Id: I88c2141167414b184f158d09f40df3aa36390b4a Resolves: #35223 Releases: 6.1 Reviewed-on: https://review.typo3.org/18123 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Stefan Neufeind authored
Change-Id: I80ebeaff81fbcb8d4d479d977f7aa23390692d28 Resolves: #43184 Releases: 6.0 Reviewed-on: https://review.typo3.org/16650 Reviewed-by: Oliver Klee Reviewed-by: Mattias Nilsson Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Sebastian Michaelsen Reviewed-by: Felix Kopp Tested-by: Felix Kopp Reviewed-by: Marcus Schwemer Tested-by: Marcus Schwemer Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Stefan Froemken authored
exec_foreign_table_where_query does not interpret the rootLevel directive correctly. Resolves: #45703 Releases: 6.1, 6.0, 4.7, 4.6, 4.5 Change-Id: I2a4dd0335ac5373562f287427d5592cfd406e2f9 Reviewed-on: https://review.typo3.org/18417 Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Christian Kuhn authored
The menu rendering in frontend still instantiates menu classes with its old tslib_ prefixed names. This is unflexible and a potential performance issue. The patch introduces a simple factory instead with a mapping for existing TypoScript menu types to the implementing classes. The current variable $menuclasses is obsolete. Additionally, the naming of three existing classes is adapted to the correct class names to be in sync with the others. A method in the factory to register additional menu types will be added with a second patch. Change-Id: I3d65258ffe4d30a918705b23349d3facb563c80e Resolves: #46292 Releases: 6.1, 6.0 Reviewed-on: https://review.typo3.org/18913 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Currently, EM's MirrorXmlPushParser, which is based on ext/xml, is not properly working. The constructor creates the parser and within parseXML() method the parser resource is freed. However, when clicking on retrieve/update button method parseXML() is invoked multiple times which makes subsequent calls fail. Creating the parser is now done within parseXML() method. Change-Id: I7c6c15f65d08fb0264d7d66cc584cbe7ff423b45 Resolves: #25292 Releases: 6.1, 6.0, 4.7, 4.5 Reviewed-on: https://review.typo3.org/18966 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: Ifc59f15abf43026007737c1051bb0f79bfacc55d Reviewed-on: https://review.typo3.org/18963 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 15, 2013
-
-
Christian Kuhn authored
If importing the extension list from TER, an incoming XML extension row has a field 'category' that contains either a string like 'plugin' or a category number. The list is persisted to the 'extension' repository. In the database, the category is stored as integer. There is a mapping function in the extension model to get the integer category index from given XML input. The method is faulty and returns strings instead of an index if the given category is a string itself. This results in database errors during insert. The patch fixes the method, renames it along the way and adds unit tests to document desired behavior. Change-Id: I601b84d0829f3d20a4cdd25a3f7f37e8128dbce1 Fixes: #46115 Releases: 6.1, 6.0 Reviewed-on: https://review.typo3.org/18805 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
This reverts commit 50eba0a8 The patch triggers warnings and errors in multiple extensions. Digging into the details shows the implementation is neither finished nor stable. See issue #25113 for a detailed analysis. Change-Id: I739c72887617b026d80063fe1fab57f95124d508 Related: #25113 Fixes: #45833 Releases: 6.1, 6.0, 4.7, 4.6, 4.5 Reviewed-on: https://review.typo3.org/18941 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Francois Suter authored
If some inclusion causes output when viewing image thumbnails in the backend, the output will be broken. Adding a call to ob_clean() ensures that this does not happen. Resolves: #31953 Releases: 6.1, 6.0 Change-Id: I1d33bc3c5e8bbd1851f087c76564f8924f8dfe26 Reviewed-on: https://review.typo3.org/18220 Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Reviewed-by: Mattias Nilsson Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Christian Kuhn authored
Change-Id: I5eff310e62fc43d9d2f9b52631da8ce3b085d474 Reviewed-on: https://review.typo3.org/18931 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 14, 2013
-
-
Wouter Wolters authored
* Fix old classnames in comments * Add missing function documentation * Add \ to DOM* classes Change-Id: Iec474715af103e0d158e5539b46a31c81ba678ac Resolves: #45149 Releases: 6.1 Reviewed-on: https://review.typo3.org/18009 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: I1c7c78225043cd5b0edd5a1ee0ce3ea236ed5c0f Reviewed-on: https://review.typo3.org/18927 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
Change-Id: Ia23ed69335b6728c198b84b830104f11994e4663 Resolves: #45180 Releases: 6.1 Reviewed-on: https://review.typo3.org/18025 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
There seems to be some magic in SOBE that automatically includes language files if they are located parallel to the module that is loaded. The task from #46143 and #46144 registered new wizard classes at a different location, so the magic doesn't hit anymore. As a result, no labels are show in above extensions in the backend. Fix is to include the locallang file in main() of the modules. The direct access to $LANG is removed along the way by accessing $GLOBALS['LANG'] directly. Change-Id: Iecddb181141f5317b87e405ada925c61cfd9261c Fixes: #46296 Related: #46143 Related: #46144 Releases: 6.1 Reviewed-on: https://review.typo3.org/18925 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: I13442a04ae0e0dc2c4907b72b9b5381177870b4e Reviewed-on: https://review.typo3.org/18923 Reviewed-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
The LanguageController of the lang sysext throws exceptions if the rewritten property mapper is enabled. The type annotation 'mixed' is unknown. The patch fixed the annotation to the correct string value to make the property mapper happy. Change-Id: I57ebd268d2fe82c095ccf20b581e721703fb2868 Fixes: #44672 Releases: 6.1, 6.0 Reviewed-on: https://review.typo3.org/17975 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Anja Leichsenring authored
After enabling the rewrittenPropertyMapper per default, the explicit enabling in sysexts is no longer needed. Resolves: #46294 Releases: 6.1 Change-Id: I7f5760ae85999495606a3d56098cf7b38682b452 Reviewed-on: https://review.typo3.org/18919 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: Ie182842c25a5dcb49989cd8478497c63a1fe1938 Reviewed-on: https://review.typo3.org/18918 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Benjamin Mack authored
With the new jQuery API introduced in TYPO3 CMS 6.0, it is possible to ship and include multiple jQuery versions. For 6.1 the latest version of jQuery should be used, so the latest release is added to the local jQuery repository. Releases: 6.1 Resolves: #46286 Change-Id: I5745df65b463db4973df346afe963a35d68d5bab Reviewed-on: https://review.typo3.org/18909 Reviewed-by: Mattias Nilsson Tested-by: Mattias Nilsson Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
ajax.php entry script requires t3lib_div very early to use a single method from it. This is ugly, so the needed code is now implemented in ajax.php directly, removing the requirement to include t3lib_div so early. Change-Id: I974c39c185872ab68bdc7732434c4bc52d77f75f Resolves: #46269 Release: 6.1 Reviewed-on: https://review.typo3.org/18903 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
APC has some slam protection that tries to prevent hammering of cache entries. This can be disabled, but the option does not work at least in native PHP 5.3.3 on debian squeeze. While it is no problem with higher PHP version like the current one on travis-ci.org, some tests are now just skipped on PHP environments knows for issues. Change-Id: Ibbef201805b58041bb0b3e8aa16f0c1a2e366020 Resolves: #46267 Release: 6.1, 6.0 Reviewed-on: https://review.typo3.org/18901 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: I7ada1e5e40067cf1faed8b2b5d338a690e921cad Fixes: #46264 Releases: 6.1, 6.0 Reviewed-on: https://review.typo3.org/18897 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Some cache backends have specific sql resource files located at t3lib/cache/backend/resources. After namespace switch, the class files are located at ext:core. According to the extbase scheme, the resource files are now moved to ext:core/Resources/Private/Sql/Cache/Backend and renamed. Change-Id: Ib693e0dfed8636b9898ef9bbff73dab21df5c2b0 Resolves: #46263 Releases: 6.1 Reviewed-on: https://review.typo3.org/18895 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: I32887386c6a5b4162a12b419c5f34e1ddc061a35 Resolves: #46262 Releases: 6.1 Reviewed-on: https://review.typo3.org/18894 Reviewed-by: Georg Ringer Tested-by: Georg Ringer Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Felix Kopp authored
The toolbar function could output erroneous html is case additional toolbar items do not bring additionalAttributes. Additional attributes are defined based on ToolbarItemHookInterface. But additionalAttributes can be an empty string: Fix output <liclass="separator"> to <li class="separator"> by adding an extra white-space. Change-Id: I09338d17848c8fc74b25e7c532d6ee329956321b Fixes: #45795 Releases: 6.0, 6.1 Reviewed-on: https://review.typo3.org/18458 Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
This is a non-functional change that reformats the code, removes unnecessary empty lines and fixes reference to old classnames. Furthermore change "0" to FALSE where a boolean is needed. Change-Id: Ida0c80ce0c54c6054e248b29c716b740f5e65194 Resolves: #46143 Releases: 6.1 Reviewed-on: https://review.typo3.org/18820 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
Change-Id: Icd9ad7fadbd6910eba87a77908e15568be800dc2 Resolves: #46144 Releases: 6.1 Reviewed-on: https://review.typo3.org/18821 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 13, 2013
-
-
Christian Kuhn authored
Change-Id: I04d40a3796937182603c7b85e16227f18f51c002 Reviewed-on: https://review.typo3.org/18889 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
This patch adds a new structure to the install tool to centralize all system and especially PHP related system checks cluttered in various modules and parts of the core at the moment. The idea is to have a basic, standalone script to test for all requirements TYPO3 CMS has in order to run smoothly. The script does not use any TYPO3 core code and has no further dependencies. With a later patch, the check will be integrated as the very first step during install, to give a good indicator if the final installed system will work well or if any system constraints are not met. Currently, the script is included as a new section in the install tool, called "System environment", where all checks are performed and each gives a status back. This will already help to support questions on mailing lists and should be the first step every user is guided to: "Do you have warnings or errors in the system environment?". The install tool implementation should also help already if moving an instance to a different server. Furthermore, there is a simple integration in the reports module that points to the install tool if issues are found. The class structure is as simple as possible, it is very easy to adapt single checks later on, the API is a single getStatus() method that returns all check object of the specific tests. Due to the nature of the script and the later usage in the installation process, things like localization and so on are not done and should also not be implemented later on. Most current check code is fetched from existing install tool, reports module and bootstrap code. This also make the main Installer.php class of the install tool already a bit better maintainable since 600 lines of code are removed from it. Change-Id: I64387ca9aaa4b429ee4a909cdab4386180af0d45 Resolves: #46219 Releases: 6.1 Reviewed-on: https://review.typo3.org/18870 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Mario Rimann authored
As soon as the form-configuration for the form wizard gets loaded, the leading "[Translate to XYZ:] " is stripped off to get the wizard working (with the leading text, the form config could not be serialized as needed and the wizard didn't show a single field). The stripping is only done on localized records. Change-Id: I0cab1d371abf5ae01b524c39acedcd1a3a5db9c4 Fixes: #39127 Releases: 4.7, 6.0, 6.1 Reviewed-on: https://review.typo3.org/12996 Tested-by: Mario Rimann Reviewed-by: Stefan Galinski Tested-by: Stefan Galinski Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Dmitry Dulepov authored
FAL performance in BE and FE can be improved by using certain database indexes. One set of indexes improves performance in BE by adding a "deleted" column, which is used by List module. Without this column in the 'pid' index, List module will do a full scan, which is much slower. Another set of indexes improves performance when getting files from storage. Change-Id: I1f8577453ed917db95d680ca74fefc4691ba53b0 Resolves: #45532 Releases: 6.1 Reviewed-on: https://review.typo3.org/18316 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Georg Ringer authored
The method get() checks if there is an entry by using has() and does then an additional get(). This can be simplified which saves a query for every hit Change-Id: I0ebfd8c7622a5e673d3f34aa685f18a9878116ef Resolves: #45530 Releases: 6.1 Reviewed-on: https://review.typo3.org/18314 Reviewed-by: Oliver Hader Reviewed-by: Philipp Gampe Reviewed-by: Steffen Ritter Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-