- Jul 01, 2012
-
-
Helmut Hummel authored
In order to execute certain unit tests special requirements of the environment must be met. In particular several additional PHP modules need to be installed. Instead of hiding what is added to the environment, use a helper script to not clutter the travis configuration file, but at the same time make it transparent there which PHP modules are built. Change-Id: I7111cbd0f3d1d32d68df6eaf8c4b6176bfe82eff Resolves: #38507 Releases: 6.0 Reviewed-on: http://review.typo3.org/12498 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Christian Kuhn authored
If the autoload registry is read from cache, all class names are already lowercased. The patch calls the lowercase logic only if the registry files are not read from cache. The unit tests show that nothing breaks with this patch. Cachegrind shows ~22% of rendering time is spend in loadCoreAndExtensionRegistry() on a fully cached page, this is reduced to ~2% with the patch. Change-Id: I07dc95b29bf05970061b5fb2f9a5d8a5ba194960 Resolves: #38498 Releases: 6.0 Reviewed-on: http://review.typo3.org/12494 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Susanne Moog Tested-by: Susanne Moog
-
Franz Geiger authored
PostProcessors now need to implement the tx_form_System_Postprocessor_Interface. All classes implementing this interface can be loaded as a postProcessor by passing its class-name by typoscript. Before loading the class in the namespace 'tx_form_System_Postprocessor_' tx_form_System_Postprocessor first tries to load the class passed by typoscript directly. Change-Id: I3bea8ce8287a6713f483d7e019cb5f47cdc68cb8 Resolves: #32701 Releases: 6.0 Reviewed-on: http://review.typo3.org/9006 Reviewed-by: Susanne Moog Tested-by: Susanne Moog
-
Andy Grunwald authored
At the moment, the Travis-CI build file only supports PHP 5.3. I`ve tested to run the same UnitTests for PHP 5.4 and it works quite well: http://travis-ci.org/#!/andygrunwald/TYPO3v4-Core/builds/1746689 Change-Id: I47559493900f56d038243bf13ab116455b4f49bb Fixes: #38508 Releases: 6.0 Reviewed-on: http://review.typo3.org/12486 Reviewed-by: Philipp Gampe Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Felix Kopp authored
Extensions are sorted by categories. EXT: t3skin does not have a default category. Change-Id: I525c0d22a32441d63c5b8561a009ecf43bd58d56 Fixes: #38510 Releases: 6.0 Reviewed-on: http://review.typo3.org/12487 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
The password test is not very useful and fails with younger redis versions. It was already removed in TYPO3.FLOW3 with commit e06bd9bb0a3e602a6b067d91b94e88cd78d96135 Change-Id: Iae7372c54c3c8befd08cbdccfb578f6986e1d588 Resolves: #38511 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/12488 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Jun 30, 2012
-
-
Helmut Hummel authored
Many of the unit tests are skipped because dependencies to certain PHP modules are not matched. Add a script that sets up certain dependencies like igbinary or memcached to lower the number of skipped tests. Change-Id: I432809066f65ea5c1be33c478cecae49057b2a36 Releases: 6.0 Reviewed-on: http://review.typo3.org/12485 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
Because of the identifiers being changed in the last commit, the unit tests failed. Adjust the tests according to the change. Change-Id: I62a168ffc5fe63fffc205ff551a7f954c197bc5c Resolves: #38507 Releases: 6.0 Reviewed-on: http://review.typo3.org/12484 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Sebastian Michaelsen authored
In the comment describing $this->registerStack (of tslib_fe) there's a reference to CLEAR_REGISTER, which doesn't exist. Correct that to RESTORE_REGISTER. I searched the core and didn't find other occurrences of CLEAR_REGISTER. Change-Id: I26c429d9f9cb16e6957425bfd85cc17f3e75a9de Fixes: #34559 Releases: 6.0 Reviewed-on: http://review.typo3.org/9419 Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
Currently all identifier for php code caches are only a sha1 hash, so it is not possible to distinguish them in the filesystem. Add some speaking prefix to the identifier. Change-Id: I12971d524489b2d31b07440867d6afbaef42d62c Resolves: #38507 Releases: 6.0 Reviewed-on: http://review.typo3.org/12483 Reviewed-by: Christian Kuhn Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Susanne Moog authored
The unit test getNodesSetsIsMountPointField fails if the pages with uid 1, 2, 3 are not available. Instead of relying on user dependent data, we should mock it. The patch introduces a wrapper method for getRecordWSOL to be able to mock that method and changes the test to do that. Change-Id: I36ec23a47bd39821595e787fba1cb8b77e2c3b0c Fixes: #38503 Releases: 6.0, 4.7 Reviewed-on: http://review.typo3.org/12478 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Philipp Gampe authored
When creating or editing a task in scheduler, the icon for the save action must be save and close, because the task is closed after clicking the icon. Change-Id: Ic7abd84524c1a02417694707e2fb1fa12a4bec1d Fixes: #36344 Releases: 6.0, 4.7 Reviewed-on: http://review.typo3.org/12479 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Dimitri Koenig authored
In t3lib_tceforms::t3lib_TCEforms() you have a whitelist definition that allows tca field configuration to be overridden by TSconfig => allowOverrideMatrix To enable readOnly for certain fields this whitelist must be extended by this option. Change-Id: Ibda9cbb196961b9ef40d6016e6e66ceba495b5c9 Fixes: #36945 Releases: 6.0 Reviewed-on: http://review.typo3.org/11072 Reviewed-by: Philipp Gampe Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Steffen Ritter authored
While adding the new media stuff the flexform has been altered. Therefore a update wizard needs to be provided to not lose the old media elements. Change-Id: I60943b2f9eee84d768bce8b5a5f38b6f83c027f3 Resolves: #35879 Releases: 6.0, 4.7 Reviewed-on: http://review.typo3.org/10308 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Susanne Moog authored
If gif_compress is disabled in the install tool, the test gifCompressFixesPermissionOfConvertedFileIfUsingGd fails, as the method it tests only does things if gif_compress is enabled. Change-Id: I91603452e43188cd38afeb3ca8b38e2913848e66 Fixes: #38501 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/12473 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Arjen Hoekema authored
Raise the syslog severity for user authentication failures from 0 (info) to 2 (warning). Log scanners like 'fail2ban' can be used to detect login errors without setting the syslog severity level to 'info'. Change-Id: Id08f71ef281631326c4b4a75a62088876604c82d Resolves: #36979 Releases: 6.0 Reviewed-on: http://review.typo3.org/11517 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Daniel Pötzinger authored
The method is protected and is not called in the container then Change-Id: I03ab47aa1030e782d14304d9371fc62b9c5aed18 Fixes: #35915 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/10356 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Georg Ringer authored
If the popup window with the login information is rendered, an additional class can help to style the output a bit better Change-Id: I606760e46f2af457aae025014002030d16a12763 Resolves: #38471 Releases: 6.0 Reviewed-on: http://review.typo3.org/12433 Reviewed-by: Philipp Gampe Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Philipp Gampe authored
The saltedpassword password conversion task for the schedular features two configuration option: * canDeactivateSelf to disable the task after all records are processed * numberOfRecords to define how many records should be processed at once Make those two options configurable via the schedular task edit interface. Change-Id: I9b090fa534b14c0051cda51fa3faf4e610b3948d Resolves: #33703 Releases: 6.0 Reviewed-on: http://review.typo3.org/9139 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Juergen Furrer authored
Change-Id: I75f1a27b4ef1a94831d6d80f8d0d8d649fc8d1ca Fixes: #37618 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/11840 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Georg Ringer authored
Complete redesign of the sys_notes Resolves: #26796 Releases: 6.0 Change-Id: I7b8748c7142a1ab6615edb4567aa748d21c54a84 Reviewed-on: http://review.typo3.org/11789 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Bart Dubelaar authored
Change-Id: I33d8840390deba3e8a2ac5a188fd6fb089b91b5f Fixes: #36290 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/10660 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Susanne Moog authored
This happens because an object is handed over as $arr[$key]. In this case convert $arr[$key] to a real array. Change-Id: I128de2da656a3d4782bcb9b8b2a9519aade6ce9f Fixes: #33444 Releases: 4.6, 4.7, 6.0 Reviewed-on: http://review.typo3.org/8693 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
Fix CGL violations against InlineControlStructure Change-Id: I2935a11c27c22070e9a3f08306c2cf69e3c83dd5 Resolves: #38494 Releases: 6.0 Reviewed-on: http://review.typo3.org/12456 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Jun 29, 2012
-
-
Wouter Wolters authored
Fix CGL violations against InlineControlStructure Change-Id: I296c5f8cc847c4d7d80ab64703834902d65aa8e2 Resolves: #38492 Releases: 6.0 Reviewed-on: http://review.typo3.org/12454 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
Fix CGL violations against InlineControlStructure Change-Id: I4fcde4f6d0b5d0252154f254799b9cef8fedc775 Resolves: #38493 Releases: 6.0 Reviewed-on: http://review.typo3.org/12455 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Oliver Hader authored
TSFE->additionalFooterData was introduced with TYPO3 4.3, but only for the purpose of t3lib_PageRenderer. The definition of this property is e.g. missing at all in tslib_fe and besides that, the handling for USER_INT/COA_INT objects is not there at all. Change-Id: I86372e332503d6907e5ff2d28c893bfd127bdcdc Fixes: #29254 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/11859 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Jun 28, 2012
-
-
Wouter Wolters authored
Add missing calls to sql_free_result in t3lib classes. Change-Id: Iac695e8e9644b068771947e03deef1062e0dd822 Resolves: #36762 Releases: 6.0 Reviewed-on: http://review.typo3.org/10920 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Bart Dubelaar authored
The flag showHiddenPage is set if the requested uid is a hidden page. The original code always looked at the original uid and not to version in the active workspace. This is fixed. Change-Id: I6b1be8e459d499578ca30e13d1cc50e9b2ace415 Fixes: #33392 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/8720 Reviewed-by: Stefan Neufeind Reviewed-by: Bart Dubelaar Tested-by: Bart Dubelaar Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Steffen Ritter authored
Adding multiple images using the "import elements" link within the record picker fails, since it calls a request to collapse all already existing images of the element, without handing the needed parameters. As the needed parameters are not available at this point, just ommit the request to close collapse the IRRE entries. Change-Id: Ibc870cdcac32b4f5867ae12ca1020a20a5905310 Releases: 6.0 Resolves: #38383 Reviewed-on: http://review.typo3.org/12367 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
After the basic bootstrap refactoring that moved the loading of ext_tables.php and ext_localconf.php to class context, it is now easily possible to put the former temp_CACHED_* files to the caching framework as cached PHP code, next to the autoloader registry cache entry. This patch introduces a new API to t3lib_extMgm to handle the loading of ext_localconf, ext_tables and the global TYPO3_LOADED_EXT array and removes the current handling that was cluttered throughout the core. The setting of TYPO3_CONF_VARS['SYS']['extCache'] is now deprecated and unused. The bootstrap now decides based on its context, whether caching of those files is used. This way we can for example run the install tool in a fully uncached environment and can get rid of the nasty side effects we had in this area in the past. With a simple call to t3lib_extMgm::removeCacheFiles() all cache entries in PHP code cache that are tagged with 'core' can be removed at once. This currently affects the autoloader registry, the TYPO3_LOADED_EXT entry, and the concatenated ext_localconf and ext_tables files. The patch furthermore gets rid of the _CACHEFILE array key in $GLOBALS['TYPO3_LOADED_EXT'] that worked as a kind of API to the calling method to indicate if a concatenated ext_tables and ext_localconf file is available. Change-Id: Id00be5f24ec1698ed9126e61b229a718d6ca6741 Resolves: #38414 Releases: 6.0 Reviewed-on: http://review.typo3.org/12383 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Susanne Moog Tested-by: Susanne Moog Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Stefan Galinski authored
In case there is no page (except the root page) within TYPO3, you can't use the drag and drop functionality in the page tree to create the first page. Change-Id: I4f4aed78916f1ab0ebf9bbc1baad2b2743e9d1b2 Fixes: #24626 Releases: 6.0, 4.7, 4.6, 4.5 Reviewed-on: http://review.typo3.org/10428 Reviewed-by: Susanne Moog Tested-by: Susanne Moog Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Susanne Moog authored
The media folder in the TYPO3 core is duplicated: It resides once in tslib/media and once in statictemplates/media. It is only used in statictemplates. This patch moves the already "cglfixed" files from tslib/media to statictemplates and removes the superfluous media folder. Change-Id: I4c740849fd0d147590cf28efd6ae0680fc66b779 Resolves: #28024 Releases: 6.0 Reviewed-on: http://review.typo3.org/12334 Reviewed-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Markus Klein Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Stanislas Rolland authored
Solution: First parameter should be defined as reference so as to be compatible with the definition of t3lib_rteapi::drawRTE(). Change-Id: I11a24893f9fb1020fb194c7d2cff2731f7ce52f0 Releases: 4.5, 4.6, 4.7, 6.0 Resolves: #37541 Reviewed-on: http://review.typo3.org/12426 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
Wouter Wolters authored
Fix CGL violations against DoubleQuoteUsage Change-Id: I6e97a8f02130b246c4eeaa9493722a53974c0a21 Resolves: #38358 Releases: 6.0 Reviewed-on: http://review.typo3.org/12338 Reviewed-by: Oliver Klee Reviewed-by: Andy Grunwald Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Stefan Galinski authored
The internal cleanup feature for the table sys_history kept the entries only for 30 days by default. This behaviour can lead to lost information if the history is needed and the feature wasn't known and changed. As a replacement, the users can use the table garbage collection scheduler task that exists for some time now. Change-Id: Iede559e0ece282c16a54e6659c26737c8bf86d90 Resolves: #38436 Releases: 6.0 Reviewed-on: http://review.typo3.org/12404 Reviewed-by: Markus Klein Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Stanislas Rolland authored
Problem: inRange method not supported by standard range object used with IE9. Solution: Use standards-based method with IE9 Note: Thanks to Johannes Pfeiffer Change-Id: Iccf230e6103e72953e49eb1a4dde967f3e65a5b7 Releases: 4.7, 6.0 Resolve: #38300 Reviewed-on: http://review.typo3.org/12422 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
Stefan Galinski authored
The change improves the general spacing and CGL of the code, removes some unused variables, tailores some very long lines for better readability, adds the creation date, creation user and last modified timestamp of the record and adds some general actions to the references which improve the usability of the feature a lot. Change-Id: Iad2ec3ca01707a1486e2785115e3c5c25f6e1c57 Resolves: #38469 Releases: 6.0 Reviewed-on: http://review.typo3.org/12420 Reviewed-by: Susanne Moog Tested-by: Susanne Moog Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Stefan Galinski authored
Change-Id: I8474d3400245e47c817ca1a2c63116a410d03747 Resolves: #38453 Releases: 6.0 Reviewed-on: http://review.typo3.org/12419 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Susanne Moog Tested-by: Susanne Moog
-
- Jun 27, 2012
-
-
Mario Rimann authored
Changes the labels to be a bit more general since this CType can be used for more than just sitemaps. Also changes the default menu type. Change-Id: Ibed4a9aa6d67059c9f8d6a517248ae33ed2a301b Resolves: #17969 Release: 6.0 Reviewed-on: http://review.typo3.org/6743 Reviewed-by: Georg Ringer Tested-by: Georg Ringer Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-