- Oct 21, 2021
-
-
Simon Schaufelberger authored
In CLI context the full path to the temporary generated file by the GIFBUILDER can't be resolved. Because of this inconsistency, absolute file paths are used from now on. Resolves: #95379 Releases: master, 10.4 Change-Id: I6d2a489eee84843fc001ac405f69a15403598388 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71335 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Helmut Hummel authored
Instead of reading the composer.json / ext_emconf.php of extensions at runtime just to retrieve the extension title, use the existing package meta data API to store and retrieve this information. With these changes in place, the workaround for title handling can be removed and CLI extension list can also use the new API and show the (shorter) title instead of the description. In the long run, it should be evaluated, whether the UI can be changed to be able to show longer descriptions, or whether a short description (aka title) is important enough to introduce a public configuration for it. Releases: master Resolves: #95701 Change-Id: Iee51f200bb5017f3a6516ebf9e55b2c6eb125949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71888 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Oliver Hader authored
Reports generated by custom data providers might contain specific HTML markup (including JavaScript, SVG and styles). The changes of issue #95179 introduced XSS-safe HTML sanitization, which however breaks existing functionality for mentioned markups. Thus, HTML sanitization is dropped again in this particular scenario. Resolves: #95713 Related: #95179 Releases: master Change-Id: I7d79fa3077f221b170cbc23baa500fb7c845b26d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71903 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Sybille Peters authored
The ext:redirects integrity check was implemented without considering site language host and prefix for the integrity check, thus reporting false positive redirect conflicts. This patch collects page uris, respecting the site language configuration for the page language. This way, the same slugs for multiple languages are not detected as conflicting anymore. Furthermore tests are extended to verify that the same slugs within several language variants of one page are covered correctly. Example for false positive redirect conflict: - pages.slug=/test - pages.sys_language_uid=1 - url: https://example.com/de/test Now, assuming no other page of the same language has the slug /test and a redirect has a source_path=/test, there should be no match. Several @todo were added which need deeper research and are out of the scope of this patch. Resolves: #95650 Releases: master, 10.4 Change-Id: I8a3d0f8a4cc077e04010e7980eebe51455a4afba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71775 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Christoph Lehmann authored
$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies'] keeps a list of language fallbacks for labels which are now considered in stdwrap.lang. Resolves: #91721 Releases: master, 10.4 Change-Id: I56c63a3a2f51553ff8d93511e2e10d5ab88095ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64945 Tested-by:
Christoph Lehmann <christoph.lehmann@networkteam.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Helmut Hummel authored
To avoid confusion for inexperienced TYPO3 Composer users and for the time being, Composer packages that are not of type "typo3-cms-*" will be hidden from TYPO3 extension lists, although the PackageManager can still interact with them. Releases: master Resolves: #95703 Change-Id: I6f9622d59f89b316af89f2adeddc16da3aa75ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71897 Tested-by:
-
- Oct 20, 2021
-
-
Stefan Bürk authored
Recently adding quote syntax to typoscript definitions has been added through #94715, which fails in nightly on mssql. Quotes has been removed from the join part of a query build in TypoScript content objects, to let dbal handle the dbms quoting. QueryHelper::parseJoin() has done this only for '"' and '`', leaving out the quoting for mssql, which uses brackets, thus not removing them. This patch removes mssql quoting style characters from the join part to mitigate this issue, which also make nightly green. Further there are tests added to cover these cases. Resolves: #95715 Related: #94715 Releases: master Change-Id: I8eb8e071725af1d262dbaa432da3b07786b140c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71902 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
This reverts commit c7c47956. The patch did not make sense: A class that has methods serialize() and unserialize() and NOT implements \Serializable interface, will never get these methods invoked when php function serialize() or unserialize() is called. So, the two methods have been bogus ever since. By renaming serialize() to __serialize() and unserialize() to __unserialize(), we actively activated the exception. This is reverted now. And both method now have a @todo to drop them in v12. Reverts: #95712 Releases: master Change-Id: I948d4b057a00ac9d53b30de55792295c1e7ae02a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71904 Tested-by:
-
Helmut Hummel authored
Instead of reading the composer.json of packages on runtime, use the existing meta data API to store and retrieve this information. Releases: master Resolves: #95699 Change-Id: I41d97c1c87e5f45a20b00e04d819ccf5dea4ad5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71887 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Christian Kuhn authored
extbase ObjectStorage always had a serialize() and unserialize(), even though they always just threw exceptions. This is probably for historical reasons where ObjectStorage implemented further SPL classes and had to satisfy interfaces. To still prevent instances of ObjectStorage can be serialized or unserialized, we rename the two methods to the magic method names and still throw the exceptions. This avoids shenanigans in classes that extend ObjectStorage. Resolves: #95712 Releases: master Change-Id: I139337ff49b062ce34620d9ac5b180bd866dd2ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71900 Tested-by:
-
- Oct 19, 2021
-
-
Stefan Bürk authored
Extbase DebuggerUtility uses reflection to determine information that should be rendered as debug output in 'renderContent()'. PHP 8.0 deprecated some methods of ReflectionParameter which will be removed in PHP 9.0. This patch avoids the deprecation message using the alternative way to get these informations. Additionally tests are added to cover the behaviour. Resolves: #95704 Releases: master Change-Id: I808f88b912d41b50ad551bb3411818f797badbbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71892 Tested-by:
-
Christian Kuhn authored
\Serializable interface has been deprecated with PHP 7.4 and the introduction of __serialize() and __unserialize(). There are two strategies to avoid deprecations: Either skip implementation of \Serializable and only implement the magics, or implement both to suppress a E_DEPRECATED and fully stay b/w compatible. Since this part of ContainerTest is about Serializable interface directly, this patch picks the b/w compat way and just additionally implements the two magic methods in fixture class t3lib_object_tests_serializable. Test subject class extbase container will vanish in v12. Resolves: #95709 Releases: master Change-Id: I71f8fbf23904ce379482b8b1bde64127f5143120 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71896 Tested-by:
-
Georg Ringer authored
Changing the exception message can help developers to find the issue faster. The previous message "The page 123 had no proper connection to a site, no link could be built." is not always correct because there might be exceptions raised when the slug field is empty. Resolves: #95115 Releases: master Change-Id: Ic915c69775112dc96ed9eabcdf560f51838f5edd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70898 Tested-by:
-
Christian Kuhn authored
Having more than one class per file is discouraged and leads to issues with class-alias-loader if non-namespaced classes are handled. The test classes are target of test subject extbase Container, which is deprecated. We don't care that too much and simply split file Testclasses.php into single files to get rid of the issue. Resolves: #95707 Releases: master Change-Id: I61edf5abf934d3d0a92e62bd97cc3a16415d5590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71895 Tested-by:
-
Oliver Hader authored
Disables the possibility to export extension sources as archive via extension manager when using Composer-based setup. Resolves: #95705 Releases: master Change-Id: I60cc02696a72b3be1c0528c0adaad54903e30d1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71893 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Kuhn authored
phpunit has a default-enabled feature to write test result to a cache file. phpunit however has no option to only run failed tests since those tests may have an @depends annatation and its hard for phpunit to sort this out. The cache file is of rather little use and mostly only pollutes the filesystem in real life. When developing core tests, developer typically use a filter or a path constraint to execute a sub set of tests only. Additionally, with multiple phpunit .xml files in one directory, the cache file overrides itself when different suites are executed. The patch disables that cache file by default in phpunit xml files. If anyone still wants to run the test suite and have tests that failed executed first, the option can be enabled on a per-use basis, example using runTests.sh: # Run suite and create cache file Build/Scripts/runTests.sh -e '--cache-result' # Run tests that failed first and update cache file Build/Scripts/runTests.sh -e '--cache-result --order-by=depends,defect' Change-Id: Ia385b604eec2b49224f729cc335261ac3f042958 Resolves: #95702 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71890 Tested-by:
-
Oliver Bartsch authored
The NewRecordController previously relied on a record title being a locallang reference. This was used to determine the extension key, to further fetch the corresponding extension title and the icon. This then lead to various misbehaviour for records, not using a locallang reference as title. For example, the last record title might end up being used as the group title, and similar. To prevent such scenarios an additional check is added, which tries to fetch the extension key from the table name, which might most probably work since by convention a table name starting with tx_ or tt_ is followed by the extension name. Another topic, not part of this patch is the fact that the extension title is fetched from the ext_emconf.php file. This file however might no longer exist in the future. Therefore, the corresponding part needs to be refactored to also take the composer.json into account. Resolves: #94049 Resolves: #95641 Releases: master Change-Id: Ic5e27c68571fc2a1a6fe19c0017b26795dbebec0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71640 Tested-by:
-
Helmut Hummel authored
The current implementation makes it possible to have different wizard identifiers defined in the class and in the configuration. Until this is cleaned up, all core wizards should always use the same. Releases: master Resolves: #95660 Change-Id: Ie0637b5040fd374d389b5a0e25d625ddb1557068 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71802 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Markus Klein authored
Pieces assembled into slugs must be strings. The pieces may stem from any database field. Depending on the database driver the data type may vary, so always cast them to string. Releases: master, 10.4 Resolves: #95692 Change-Id: If9e12a02d5d396ab12714069073d5f80202ac8b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71878 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Georg Ringer authored
'Accept-Language' may not be sent by clients, the patch sanitizes access to $request HTTP_ACCEPT_LANGUAGE using null coalescing operator. Resolves: #95683 Related: #95625 Releases: master Change-Id: I039e10add84d53984f16a5efa3658426867a3ed7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71879 Tested-by:
-
Nikita Hovratov authored
Resolves: #95687 Releases: master Change-Id: If4fde4dcac49e043b60686141a5b412c88fc9ade Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71874 Tested-by:
-
neusta infomantis authored
Requests with special characters like for ex. cyrilic characters in it would be rawurlencoded by the used Uri() components. Webservers like Apache normally decodeds them for the php process. 'RedirectService::matchRedirect()' has been using rawurldecode() to decode the path to work properly to resolve path with such characters. RegExp redirects may have capture groups which should be replaced in the target url for the redirect. The corresponding replace method has not been working with urldecoded variant and as such the encoded value was used. Furthermore if for ex. cyrilic characters where in the path, and not only part of the capture group the seconady preg_match in that replace method did not matched the regexp which has matched as redirect. Additional it could be that cyrilic characters would be used for the regexp in the query part, if respect query parameters options is enabled for the redirect. This patch adds a rawurldecode() call to decode the path and query, if needed, to the method `RedirectService::replaceRegExpCaptureGroup()` and covers these cases with unit tests. Releases: master, 10.4 Resolves: #94934 Change-Id: I464896d7efe2af20f5d2b725195b231f428760a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71610 Tested-by:
-
Lina Wolf authored
"LinkValidator" as a proper noun is always spelled in CamelCase with these exceptions: The namespace is spelled "Linkvalidator" for historic reasons. The extension name is "linkvalidator" for historic reasons. Updated the documentation, screenshots therein, the language files and the strings used within the extension. Resolves: #95423 Releases: master Change-Id: Ib905d977ee60f1c50678e531a083d59883b939bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71880 Tested-by:
-
Jochen Roth authored
The clipboard component features helper methods, which generate a URL to update the clipboard state with new elements. Those are used in recordlist and filelist. Previously the "setCopyMode" parameter was only set in case the element should be "copied". This then might lead to no "mode" set in the clipboardData at all. Like other modules already do, the helper methods do now always set the "setCopyMode" parameter to enforce the generation of the "mode" key in the clipboardData. Anyways, an access of the "mode" in the page module is secured by a null collapse operator. Resolves: #95536 Releases: master Change-Id: I0799f711cd3ab8b6be702b62ba26d974d46da2d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71504 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Jochen Roth authored
To make sure the sitemap works as expected a acceptance test has been added for the sitemap overview and detail view. Resolves: #94903 Releases: master Change-Id: Ia747e4103aec5678300c0f91721bbef14e27e1d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70639 Tested-by:
-
Jochen Roth authored
Add quoting for 'foreign_table_where' in TCA. Resolves: #94717 Related: #94697 Releases: master Change-Id: I9abcf5f6c6c37887c45c9d66fefdc1aac4348ace Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70208 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Jochen Roth authored
Currently the expanded tree does not reflect the state (collapsed/expanded). This has been fixed by using the correct css selector. Also removed some obsolete styles. Resolves: #95582 Releases: master, 10.4 Change-Id: I3b44bedc2cb46c260384c9ea559831e580ba82c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71564 Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
-
Jochen Roth authored
Some TS snippets miss proper DB field name quoting. This is important to get right to be as DBMS compatible as possible. * Make additionalWhere in xmlSitemap dataProviders quotable for the quote filename syntax. * Change syntax for DatabaseQueryProcessor usages in TypoScript Resolves: #94715 Related: #80506 Related: #94697 Releases: master Change-Id: I3453bd9703bdfe44e71abe5080ff3cd2505136cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70205 Tested-by:
-
Helmut Hummel authored
The CLI command extension:list already uses package information for listing extensions, whereas Extension Manager still scans for and prefers information from ext_emconf.php and install path. Adapt EM to also prefer package manager information. Releases: master Resolves: #95693 Change-Id: Ia98304b65de1d693c8f89f8bba96a52fd507305c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71877 Reviewed-by:
-
Christian Kuhn authored
Build/Scripts/splitFunctionalTests.php is used in gitlab-ci via runTests.sh to split functional tests into smaller and better digestible chunks, so we can run multiple jobs instead of one. The script writes one xml file per job, which is then picked up by phpunit runner. It currently duplicates the basic xml setup from Build/phpunit/FunctionalTests.xml. The patch changes this to read existing .xml file adds the files to be tested using an xml parser and writes new xml files per job. This avoids the xml setup duplication and is easier to maintain. Resolves: #95696 Releases: master Change-Id: I4fd3e2b1284ef078e27e435216e3f7753bb29a5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71882 Tested-by:
-
Christian Kuhn authored
Since PHP 8.1, most internal classes are updated with tentative return types. This will be enforced with 9.0. It means incompatible or missing return types in extending user land classes emit E_DEPRECATED since 8.1. We can not add the return type in many cases since that would be breaking in v11, solution is the #[\ReturnTypeWillChange] attribute. This patch adds according attributes to FlashMessageQueue, which extends \SplQueue. No longer returning $this in enqueue() can be done in v12 as breaking patch and mixed return type will be usable when core requires at least PHP 8.0. Change-Id: Iee7e4b79662b9c390e032d344164e4f1c0591688 Resolves: #95697 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71883 Reviewed-by:
-
- Oct 18, 2021
-
-
Christian Kuhn authored
Property $expectedErrorLogEntries can be set to an integer when tests expect that DataHandler operations log errors of type USER_ERROR or SYSTEM_ERROR to table sys_log. The two tests don't do that, the property can be dropped. Change-Id: Ife9a104e70af5eaf12e01d1e659599c597259e7e Resolves: #95684 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71872 Tested-by:
-
Stefan Bürk authored
This patch adds correct return types where possible, otherwise add the #[\ReturnTypeWillChange] attribute to temporarly silence the message for php8.1, but keep 7.4 compatibility. Added parentheses in `ObjectStorage::offsetSet()` to ensure operation order for the future. Resolves: #95680 Releases: master Change-Id: I10b4caa6b6ff117379b24e2b36d336834f5a4585 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71848 Tested-by:
-
Christian Kuhn authored
Constant TYPO3_MODE has been deprecated in v11. It should not be defined for tests anymore. Resolves: #95685 Related: #92947 Releases: master Change-Id: I41216a99c3b6888e97b64ed3693eaba07b495555 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71873 Tested-by:
-
- Oct 17, 2021
-
-
Benni Mack authored
This change reduces the amount of invalid PHP code for PHP 8.0 and removes some unused functionality, also uses proper casting where necessary. Resolves: #95648 Releases: master Change-Id: Ief021f2677ed129496293e828ef55ee332e2fea4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71800 Tested-by:
-
Daniel Dorndorf authored
This prevents an exception for missing array keys when using an extbase repository in the "render-preProcess" hook. Resolves: #95674 Releases: master Change-Id: Ia3ba1232097ec308acadaae4cdd137a39130d4b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71843 Reviewed-by:
-
Stefan Bürk authored
PHP SPL class ArrayAccess requires return values in PHP 8.1. We can not change those since that would be breaking in core v11. Add #[\ReturnTypeWillChange] instead to silence PHP deprecation handler until we raise PHP minimum version to 8.1. Resolves: #95679 Releases: master Change-Id: I9106a400466d01040c27e52845e04d539439c474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71846 Tested-by:
-
Tim Schreiner authored
When checking if an identifier is within the processing folder, the processing folders driver is used instead of current driver. Resolves: #94645 Releases: master, 10.4 Change-Id: I47e63e2fcdc05ed28a3cf091f2384191cb5dde9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70116 Tested-by:
-
Christian Kuhn authored
Brings a series of core v11 alignments and PHP 8.1 preparation. Resolves: #95682 Releases: master Change-Id: Ib291cc81add92ee2b712b4127652b62d2458dfb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71851 Tested-by:
-
Stefan Bürk authored
Redis backend tests has been using native Redis to verify test results. 'Redis::getKeys()' method has been deprecated and throws deprecation notices if errorlevel is set to E_ALL. This patch uses 'Redis::keys()' to avoid depcrecation messages. Resolves: #95681 Releases: master Change-Id: Ic92b76d8c74673f7a2e8128918b3f69d91998b6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71850 Tested-by:
-
