Change-Id: I42a88d82c1f1e252946f15d0ae53e037fe3ddfb1
Reviewed-on: http://review.typo3.org/2061
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

This reverts commit be13ba38.

Change-Id: I1f16e8bd6d5853fd0153cea8f8d128dff4e289e2
Reviewed-on: http://review.typo3.org/2059
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: I56b4964444f4320fd76be3473e97a9e076b1fc41
Reviewed-on: http://review.typo3.org/2057
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

This reverts commit 2512e832.

Change-Id: Ie706762dcd844984c0031f01813f2c71f98da20d
Reviewed-on: http://review.typo3.org/2056
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: I952e21e466288b77fba172e0561004b4bec26f39
Reviewed-on: http://review.typo3.org/2055
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

This reverts commit fab9e662.

Change-Id: I7fd68d23f6b259171b7af337281f76b8a187e2f3
Reviewed-on: http://review.typo3.org/2054
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: I8a466e03172f2bbd2fd1fe6c79f4d40efa3da028
Reviewed-on: http://review.typo3.org/2053
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

IM4 and IM5 support has been deprecated and is scheduled for
removal in TYPO3 4.6. Default empty setting for im_version_5
meant IM4. It should now reflect v6 instead.

Change-Id: Idcebd41d9cf6059ea61363a8965fef9d526e9d00
Resolves: #24146
Reviewed-on: http://review.typo3.org/2049
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

IM4 and IM5 support has been deprecated and is scheduled for
removal in TYPO3 4.6.

Change-Id: Ib7610a3666e764e32c854fb04b5d80ef3030dad3
Resolves: #24146
Reviewed-on: http://review.typo3.org/1989
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Using the new PHP5 constructors (__construct) instead of PHP4 variants.

Change-Id: Iab19b1be570cde143dacbbe244aedaf2dd8ce1a6
Resolves: #26505
Releases: 4.6
Reviewed-on: http://review.typo3.org/1797
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: Iaae5e6978096de060a1253f14de01b763048645c
Resolves: #26738
Releases: 4.2, 4.3, 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/2016
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

These parts are not working with IRRE in workspaces:
Removing children in TCEforms
Removing children in the list view
Reverting changes in the workspace module

Change-Id: I91313235e57c193e7103d065c02d2005ef74ab86
Resolves: #25352
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1195
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Variable $codeLines should be initialized prior to being used
in a concatenation within the loop.

Change-Id: Ife0b44b937a33040f46402492a5ede6e99d39668
Resolves: #26622
Releases: 4.6
Reviewed-on: http://review.typo3.org/1927
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Affected projects: version, workspaces

Change-Id: Ic0229c0a25e450d4aae96843965bd7629780cce8
Reviewed-on: http://review.typo3.org/1981
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Part 2/2

Change-Id: If78cf29e57c7ab560082826cbc395ad35fad0097
Resolves: #26581
Reviewed-on: http://review.typo3.org/1948
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Part 1/2

Change-Id: I13ba0ff933510e5ee83fc719fb87933555ac3e70
Resolves: #26581
Reviewed-on: http://review.typo3.org/1947
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Stefan Neufeind

Because of a PHP bug on some systems, login to TYPO3 backend
fails because the interface backend_toolbaritem is included
twice, once with a relative path and the other one with an
absolute one.

Change-Id: I91f993935155af6d50dd99498c9d19b684f99b69
Resolves: #26535
Reviewed-on: http://review.typo3.org/1820
Tested-by: Steffen Gebert
Reviewed-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

There are several places where two or more statements are in one line
like "if (condition) do something;" or just to semicolons at the end of
a line "$foo = 42;;"

Change-Id: I9e587751676fee8db27226c751483c1070de935d
Resolves: #26626
Release: 4.6
Reviewed-on: http://review.typo3.org/1932
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

When maxCharacters is equal or less then the length of the first word,
the whole string was returned when 'crop to word' is enabled instead of
the only the cropped part.

Change-Id: I0a7ec720b12a7999245b183f36daff5cdd7a8ace
Resolves: #25368
Reviewed-on: http://review.typo3.org/1274
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The module DB Check > Record statistics counts the deleted pages
instead of the lost pages and displays that number. As the links
for adopting orphaned records should correlate to the count of
lost records, we should display the correct number.

Change-Id: Ie793aa337b56503f6f37ffd9cc6fbb8d052c1540
Resolves: #25863
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1531
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Icons status overlays are defined in t3lib_iconWorks::
mapRecordOverlayToSpriteIconName(). However it is necessary
for "external" process (e.g. versioning) to override the
icon status. Currently a deleted record in a workspace will
not appear properly overlaid because only deleted = 1 is
checked and not also t3ver_state = 2. This hook makes it
possible for the version sysext to hook into the process and
set the right status.

Change-Id: I349012e402ab349ad810c57e46b0a7d5f8a46b03
Resolves: #25765
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1459
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Hader

Booleans should be written in uppercase.

Change-Id: I5c6e07ceb53deb128f82dc67948925f5cb99dd91
Resolves: #26347
Releases: 4.6
Reviewed-on: http://review.typo3.org/1792
Reviewed-by: Peter Beernink
Tested-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Abandon the extra security feature of having one time tokens and create tokens
which are valid during a whole login session. Additionally create only one random token,
store it in the session and create the real URL and form tokens by hashing the scope strings
with the secret session token.

To enable re-login, store the session token in the registry and retrieve it in case a
re-login happens.

Thanks to Marion Eher (Bluechip.at) for sponsoring
this fix with 75 beers during the bug auction at T3BOARD11.

Resolves: #25359
Change-Id: If37990fbc1ae3701777e8218cc1bc8760a4d6a55
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1364
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The TCA tree feature did not work when setting maxitems=1 in the TCA.

This bug has been fixed in master in 290529a7 and in
TYPO3_4-5 branch 3019ca92 but the solution is different.

Use the same solution as is TYPO3_4-5 because it is cleaner:

* Check for empty() value instead of comparing with 0 in 
  t3lib/tceforms/class.t3lib_tceforms_tree.php
* Do not recalculate the number of checked items only if a new
  item is checked and the maximum item count is reached instead of always
  recalculating the item count in 
  t3lib/js/extjs/tree/tree.js

Resolves: #25347
Releases: 4.6

Change-Id: I1b55960f9c26f57aa05d6a95a9980798c06e8316
Reviewed-on: http://review.typo3.org/1804
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Remove the last occurrences of IE6 specific code.
Resolves: #26274

Change-Id: I82e86c5b8ecc14d6592871a2f86d6c50d69eed48
Reviewed-on: http://review.typo3.org/1723
Reviewed-by: Peter Beernink
Tested-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The logging functions in saltedpasswords are not able to log failed
backend userlogins to TYPO3s syslog, because the inherited
writelog-function gets overridden by a local function. As a result, no
notification e-mail is sent to [warning_email_addr] when a backend user
has multiple failed login attempts. A remote 'attacker' could try to
login to a TYPO3 installations backend numerous of times without being
noticed (no log entry and no warning-email if configured).

Rename the local writelog-function to writeLogMessage and add the
original writelog-functionality, so that failed backend logins are
written to TYPO3s syslog again and all logging/notifications work as
expected.

Change-Id: Ic05b05873e3fd20df675db908ba76b7dd0e5548f
Resolves: #23917
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1795
Reviewed-by: Torben Hansen
Tested-by: Torben Hansen
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The special value "null" should written in uppercase "NULL".

Change-Id: I84deb049c823ee6b51792df7afd08b18bbff5cac
Resolves: #26345
Releases: 4.6
Reviewed-on: http://review.typo3.org/1791
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In class tslib_content_offsettable there is one occurence of "tsdWrap",
which should read "stdWrap".

Change-Id: Ia658149602d5bbf1e3453ad8ed9eacbec247c1c5
Resolves: #26500
Reviewed-on: http://review.typo3.org/1800
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Booleans should be written in uppercase.

Change-Id: Ib29abc6e1e658e3a1b65cd1873a3a3edac7dba57
Resolves: #26346
Releases: 4.6
Reviewed-on: http://review.typo3.org/1790
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The test fixPermissionsSetsPermissionsWithRelativeFileReference
(t3lib_divTest) used a (wrong) relative path to a test file in the chmod
call. Thus the test failed.

Prepend PATH_site have the correct absolute path.

Change-Id: Ifab5649272952a626381e8562ca018d087efc789
Resolves: #26423
Reviewed-on: http://review.typo3.org/1780
Reviewed-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The unit test cropIsMultibyteSafe (class tslib_contentTest) fails, if
error reporting includes E_WARNING. In this case mb_strlen() throws an
error, as it is called with an empty string as second parameter
$charset. Initializing $GLOBALS['TSFE']->renderCharset in the setUp
method solves this.

Change-Id: If04278e3cbd01ad2f4b6b02c1b3df7cf89b251f0
Resolves: #26491
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1785
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

When EXT:felogin is not installed, a FE login content element is available, that is
out of date and should not be used anymore.
As we ship felogin since 4.2 and install it by default, the default login form is
useless and confusing.

Thanks to naw.info for sponsoring 135 beers at the bug auction for this fix.

Change-Id: I765b3d391b06dac34550f46f19992c9cf9d1c5c7
Resolves: #22408
Reviewed-on: http://review.typo3.org/1369
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Additionally throw exceptions instead of a return string if directory could
not be created.

Change-Id: I90da96e1b62d28997573d821c62b7b24b3ef2ba3
Resolves: #26240
Depends: #26230
Releases: 4.6
Reviewed-on: http://review.typo3.org/1716
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The message has TYPO3_CONF_VARS['SYS']['requiredExt'] instead of
TYPO3_CONF_VARS['EXT']['requiredExt'] as in config_default.php.

Change-Id: I46a3559b4b4da028b55b8cc8cda63aaa81fb91ea
Resolves: #26354
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1765
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "$includeEmtpyValues" into "$includeEmptyValues"

Change-Id: I8527373b7b5934025f8ef44bde8ef76ee9036a07
Resolves: #26351
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/1763
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "else if" into "elseif"
This is a follow-up because I forgot one "else if".

Change-Id: I51eeab3ced57a7f9ffc84ad05ee952e529ed533b
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1731
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "else if" into "elseif"

Change-Id: I7db545131851b2bb99dfe25c80fef6b26f5504dd
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1725
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The methods addReplyTo and addCc accept strings as parameters, but we
need the setReplyTo and setCc which accept arrays. This will make the
reply-to and recipient-copy options work in formMail.

Change-Id: Ia3826d51f53ffe497f4c3b25957f0332fb89e81e
Resolves: #25301
Releases: 4.6
Reviewed-on: http://review.typo3.org/1442
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adds a helper functions for easier handling of arrays.
New class t3lib_utility_Array adds a method to reduce an
array by a search value.
New method in t3lib_extMgm adds a method to add new items
to a TCA select list at a spcified position.

Change-Id: I589294525a7eacc7af6e54c5b78f5ee411574f12
Resolves: #26069
Relates: #22408
Reviewed-on: http://review.typo3.org/1647
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

A few files are containing inconsistent linebreaks.
Since all of these files are taken from external projects,
someone needs to make sure that they get fixed during future
imports.

Change-Id: I49e482add2f991356a4ad335f13c9c60719e9e44
Resolves: #26126
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1661
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn