- Jul 27, 2018
-
-
Benni Mack authored
The method only does one line of code, and is now instantiated if needed. Resolves: #85666 Releases: master Change-Id: Id5df0ecb3f887743ea1167829c9cca69aef501e4 Reviewed-on: https://review.typo3.org/57693 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Fernandez authored
Resolves: #85638 Releases: master, 8.7 Change-Id: I98ecaef360d5a27e965cbb67c5719729054b9c37 Reviewed-on: https://review.typo3.org/57676 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Jul 26, 2018
-
-
Benni Mack authored
The backend request with the cli check is dead code since a different application is used for cli. Resolves: #85662 Releases: master Change-Id: Icea2667e9369c4041094eaa53283c6c59b3e9dd7 Reviewed-on: https://review.typo3.org/57695 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Georg Ringer authored
Use same ordering for content elements in the page module for the default language and translations. Resolves: #85631 Releases: master Change-Id: Ibbbb0dd813a5ad9211737bbc07ca84b766a2abfa Reviewed-on: https://review.typo3.org/57673 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Benni Mack authored
Due to the introduction of Context's, the FrontendRestrictionContainer does not have a dependency on TSFE->sys_page anymore. Resolves: #85661 Releases: master Change-Id: Iea969090da31c81ccd419c87f3b9970b2634cf11 Reviewed-on: https://review.typo3.org/57694 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Nicole Cordes authored
As the PackageManager is a singleton class, you should call GeneralUtility::makeInstance to retrieve the instance. The bootstrap correctly initializes the first instance and registers it as singleton already. Resolves: #85659 Releases: master Change-Id: I414a3fe4004044b0cdf6d2d8978f7e3463886018 Reviewed-on: https://review.typo3.org/57692 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #85639 Releases: master, 8.7 Change-Id: Ie7bd2b7e446ea0b11386bd77acb38d94320a6d1e Reviewed-on: https://review.typo3.org/57677 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Georg Ringer authored
Even if a root page is flagged as hidden it must be shown in the site module. Resolves: #85660 Releases: master Change-Id: I22a0b1888511940e23cb073ef0477b1f0774b3d6 Reviewed-on: https://review.typo3.org/57696 Tested-by:
-
Xavier Perseguers authored
In addition to the query string, having the uid of the record allows more flexibility when implementing a custom suggest receiver. Releases: master, 8.7 Resolves: #85655 Change-Id: I8dea34a26b845b0a49b5406880790b55e445d780 Reviewed-on: https://review.typo3.org/57689 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Christian Kuhn authored
v8 has a fallback if PackageStates.php vanished on a running instance and the install tool is called, a default PackageStates file is generated that comes with a minimal set of active packages that allow login to the backend and activating further packages again. This broke in v9 with the install tool refactoring and is fixed with the patch: The install tool detects after successful login if PackageStates.php misses and creates a new one. Note this operation is not yet messaged to the user. This could be added later if a true recovery procedure is added to the install tool. For now, the sole purpose of the patch is to resurrect an instance. Resolves: #85634 Releases: master Change-Id: I0e72a9e8b4f828892838921d722c61520179af1d Reviewed-on: https://review.typo3.org/57690 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Oliver Hader authored
After fixing the issue of TYPO3-CORE-SA-2018-003 file commands for form definitions (those ending with new ".form.yaml" extension) has been limited. Since the "move" command theoretically would allow to move and rename a file, it has been denied as well. However, it is okay to move those files around in case the file extension has not been changed or when being moved to a recycle folder. Resolves: #85570 Releases: master, 8.7 Change-Id: Ic1f40d061b330d62138a42be9e868fca77b17187 Reviewed-on: https://review.typo3.org/57653 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Nicole Cordes authored
The database handling and comparison was streamlined with patch https://review.typo3.org/57429/. The extension manager uses the global database compare action after an extension was activated. For that reason we do not have to maintain a couple of duplicated signals anymore and can mark them as deprecated. Resolves: #85462 Releases: master Change-Id: I7f6d814c43b530bb51737b3457b89c8075c364e7 Reviewed-on: https://review.typo3.org/57671 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Wouter Wolters authored
Resolves: #85646 Releases: master Change-Id: Ib8d550acb922c02c240f09898e4a354708a729b7 Reviewed-on: https://review.typo3.org/57683 Reviewed-by:
-
- Jul 25, 2018
-
-
Christian Kuhn authored
We're finally able to manage our core internal framework state, at least in the backend. This is a huge step. To proof this, functional tests now execute without process isolation. We need a couple of additional reset state methods. Those are for now marked @internal to allow us changing this stuff if needed later. The SystemEnvironmentBuilder also needs a change to not directly rely on PATH_thisScript anymore. composer require --dev typo3/testing-framework ~4.1.0 Change-Id: I37fbee7e4cf6ccb2eec18d057b6b9671d6a85167 Resolves: #85649 Releases: master Reviewed-on: https://review.typo3.org/57129 Tested-by:
-
Christian Kuhn authored
To allow loading php cache files more than once it is necessary to add a require() method next to requireOnce() to cache backends. This can be used if cache entries do not execute one-time-per-process-only code, if they for instance do not declare classes. This is needed to execute for instance the functional test suite multiple times in one process and to still make use of caching. The cache_core php cache is affected by this: Those calls are changed to require() instead of requireOnce() to make them multi-loadable per request. Note require() is not yet added to the PhpCapableBackendInterface since that would be breaking, but marked as todo for v10.0 Resolves: #85648 Releases: master Change-Id: Id711044e9554587dba38f976bd1c5bab23826de2 Reviewed-on: https://review.typo3.org/57686 Tested-by:
-
Christian Kuhn authored
Class StorageRepository parks static state in property $storageRowCache. This is ugly and needs proper reset functionality. However, the class is also a singleton through AbstractRepository, so there is no need to make $storageRowCache static in the first place. Just making the property non-static keeps all the functionality, and removes the hard to evict static state at the same time. Resolves: #85647 Releases: master Change-Id: I6c8dd489b05f80f2450e1d39051da5b8e53c55a0 Reviewed-on: https://review.typo3.org/57684 Reviewed-by:
-
Benni Mack authored
TSFE->fe_user is set to '' by default, but UserAspect expects "null". Extensions like solr set up their own TSFE object which is fine, however they still access gr_list which is OK, because it is deprecated. However, a deprecation message must be thrown, and NOT a strict typing warning. UserAspect expects either "null" or object of type AbstractUserAuthentication, but TSFE delivers '' by default. Modifying '' would not be an option as this would be (slightly but still) breaking. Resolves: #85632 Releases: master Change-Id: I2dbd46bee1c497f413ede8a1e55334ef954cf723 Reviewed-on: https://review.typo3.org/57674 Tested-by:
-
Christian Kuhn authored
Similar to recent 'composer update everything' to see if youngest dependencies allowed by our composer.json survive the test suite, a 'composer update --prefer-lowest' now does the opposite: An additional nightly test stage checks if our lower bounds survive testing. We need younger minimum fluid to run through all tests: composer require typo3fluid/fluid ^2.5.2 We need to restrict doctrine/dbal to a higher patch level: composer require doctrine/dbal ~2.7.1 And a series of require-dev dependencies: composer require --dev typo3/testing-framework ^4.0.2 composer require --dev codeception/codeception ^2.4.4 composer require --dev friendsofphp/php-cs-fixer ^2.12.2 Change-Id: I5c3fa8478acc9537acc2205711081dc51b1c417a Resolves: #85626 Related: #85624 Releases: master Reviewed-on: https://review.typo3.org/57666 Tested-by:
-
Mathias Schreiber authored
Deferred rendering of thumbnails via an external request speed up the backend performance. This currently works in all places that use BackendUtility::thumbsCode. Resolves: #85605 Releases: master, 8.7 Change-Id: Id5635fc9cd340b8bcf21995cd457415aaa1a8926 Reviewed-on: https://review.typo3.org/56765 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Andreas Fernandez authored
Resolves: #85641 Related: #60019 Releases: master, 8.7, 7.6 Change-Id: If9c94c020da6991dc070fa6aa8395042686b2752 Reviewed-on: https://review.typo3.org/57679 Reviewed-by:
-
- Jul 24, 2018
-
-
Benni Mack authored
Instead of calling PageRepository to fetch the rootline, RootlineUtility can do that now directly. However, all exceptions are more specific and caught specifically, for each use-case. Additionally, PageRepository->getRootline() is deprecated now. For this reason, the deprecation for the argument $ignoreMPerrors is removed again, as it does not make sense anymore. Resolves: #85557 Releases: master Change-Id: I5a9192311c5616f5a58e89a39c3869b593e97968 Reviewed-on: https://review.typo3.org/57590 Tested-by:
-
- Jul 23, 2018
-
-
Anja Leichsenring authored
The functionality guarded by the test does not apply anymore. After the test has been skipped since a long time already, it is safe to just remove it. Change-Id: I7757b57e7f7424d2631f67b736d927f525e01f0b Resolves: #85625 Releases: master Reviewed-on: https://review.typo3.org/57664 Reviewed-by:
-
Benni Mack authored
The property does not need to be accessed from the outside anymore, and can be marked as protected/deprecated, as this information is all stored within the given context of the page repository. Resolves: #85556 Releases: master Change-Id: I36072c06b6ac5c5faa5ebce5b373e76530af7509 Reviewed-on: https://review.typo3.org/57592 Reviewed-by:
-
Christian Kuhn authored
We recently had an issue where a dependency released new versions that break our build. Our composer.json definitions were not strict enough and we did not find this issue before release. The patch extends the bamboo nightly plan with a new stage that does a full 'composer update --with-dependencies' before running tests, additionally to the usual 'composer install' that loads dependencies according to our composer.lock definitions. This way, we should find depency releases that break our system much quicker next time. Resolves: #85624 Related: #85552 Releases: master Change-Id: I1d10260cdfea4d10f54e6d77de3a837bc52632b7 Reviewed-on: https://review.typo3.org/57663 Tested-by:
-
Christian Kuhn authored
composer update codeception/codeception --with-dependencies Updates codeception from 2.4.1 to 2.4.4 and brings phpunit 7.1.4 to 7.1.5 along with some deeper dependencies. The younger phpunit bundle seems to be a bit more picky on string assertions, so we need to fix two unit tests that silently used the bug before. Resolves: #85623 Releases: master Change-Id: Iceae98384b4e2e45a8b8958835b42faca9ee704a Reviewed-on: https://review.typo3.org/57662 Tested-by:
-
Christian Kuhn authored
Updates friendsofphp/php-cs-fixer from 2.11.1 to 2.12.2 The 'no_unused_imports' scanner is a bit more picky and finds another unused import fixed along with the update. composer update friendsofphp/php-cs-fixer Change-Id: I40a724371c35ae4202fd8e90f43eafcb1a70c0a9 Resolves: #85621 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/57660 Tested-by:
-
Christian Kuhn authored
The script to split acceptance tests into chunks has been rewritten in typo3/testing-framework and is used in pre-merge and nightly plan. It should lead to a more fair split into single jobs so they end up with similar runtimes again. One test file is additionally split into three to allow better distribution. composer update typo3/testing-framework Resolves: #85618 Releases: master Change-Id: Ic65c29c5d0e4813d3953d1e70bd0c746df2b8ff4 Reviewed-on: https://review.typo3.org/57658 Tested-by:
-
Anja Leichsenring authored
The removed test was skipped for a long time, and its intended guarding against the usage of objects in extbase requests does not apply. Resolves: #85610 Releases: master Change-Id: Icf401ff50badba4d8d33405d86708ec7af157516 Reviewed-on: https://review.typo3.org/57649 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Jul 22, 2018
-
-
Christian Kuhn authored
Executing functional tests on mssql has been disabled a while ago since the daemon crashed frequently: The server can not run on tmpfs volumes that we usually use to speed up database operations. sql server uses O_DIRECT i/o system calls which tmpfs does not support. Find details at https://github.com/Microsoft/mssql-docker/issues/12 We now run mssql tests on hard disks again, but enable them only as nightly since they are too slow as pre-merge tests. Change-Id: Iefc61670dcf74012fcdaada8e5b771538e7cf8c3 Resolves: #85614 Releases: master Reviewed-on: https://review.typo3.org/57641 Tested-by:
-
Ioulia Kondratovitch authored
In content elements of form_formframework, the order of finisher options offered for overriding will be in accordance with the order defined in FormEditorSetup.yaml. Resolves: #85435 Releases: master, 8.7 Change-Id: Ie506858bc363c62af02a123b27c84cb9754dbda3 Reviewed-on: https://review.typo3.org/57420 Reviewed-by:
-
Tymoteusz Motylewski authored
Update comments in the code not to mention tce_db.php. The tce_db.php entry point is gone since v8. The SimpleDataHandlerController is responsible for pushing data from request to DataHandler. Resolves: #85600 Releases: master, 8.7 Change-Id: I6d323a9aab77ab67ff811970ff3c0f47dbf84340 Reviewed-on: https://review.typo3.org/57636 Tested-by:
-
Anja Leichsenring authored
The test was skipped, its guarded functionality does not exist. Change-Id: I683a3be8ace5556052e948ca9d35eedcadd79c29 Resolves: #85612 Releases: master Reviewed-on: https://review.typo3.org/57652 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
- Jul 21, 2018
-
-
Benni Mack authored
An unused if() statement removes the last occurrence of this method, so it can be deprecated. Resolves: #85554 Releases: master Change-Id: Ica80f66f7fdce4d72c8d97d0405360c307ca14dd Reviewed-on: https://review.typo3.org/57593 Tested-by:
-
- Jul 20, 2018
-
-
Christian Kuhn authored
typo3.org git/gerrit show flakiness lately. To not torture the poor servers with our pesky testing so much we switch the git clones to github/TYPO3/TYPO3.CMS and hope merges are mirrored over there more quickly and they sustain our testing load easily. Resolves: #85606 Releases: master, 8.7, 7.6 Change-Id: I772d945a3bf697172cb26edb761f01e6cb8da4bf Reviewed-on: https://review.typo3.org/57643 Tested-by:
-
Ralf Zimmermann authored
Define the "label" property for tt_content form elements within the form setup to allow saving tt_content form elements. Resolves: #85578 Releases: master, 8.7 Change-Id: I490a43692a9f54ef843e9362d0f700a9e5552106 Reviewed-on: https://review.typo3.org/57616 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Benni Mack authored
Also config.concatenateJsAndCss TypoScript is replaced with concatenateCss and concatenateJs since TYPO3 v6.0, and can now be deprecated. Resolves: #65578 Releases: master Change-Id: I23ee9637a3c880c67a93a6f9771a9bfab5ed6ac3 Reviewed-on: https://review.typo3.org/57629 Tested-by:
-
Wouter Wolters authored
Resolves: #85479 Releases: master Change-Id: I576ab5fb6a7937016497a93d3b4dd025478e81bd Reviewed-on: https://review.typo3.org/57468 Tested-by:
-
Benni Mack authored
The field "uid" is never fetched, so no count() is possible in the DB count query. Resolves: #85252 Releases: master, 9.3 Change-Id: I9a3f1cb13bf20dcbe4bfb5451afd465e5981ecb4 Reviewed-on: https://review.typo3.org/57634 Reviewed-by:
-
Benni Mack authored
The method is just a wrapper for PageRepository->enableFields() which should be used instead. Resolves: #85558 Releases: master Change-Id: I5fd18ef3e101325bc95f4d0147899d961f5898f6 Reviewed-on: https://review.typo3.org/57598 Tested-by:
-
- Jul 19, 2018
-
-
Christian Kuhn authored
Bring back backend acceptance test execution as pre-merge and nightly tests. They are hopefully more stable now and we'll test if they survive the hard pre-merge load without being too flaky.. The patch changes the bamboo plan specs accordingly but disables a couple for FormEngine related detail tests that need further investigation. The patch also fetches a new patch level of testing-framework to have proper ac path definition of the ac splitter script: composer update typo3/testing-framework Change-Id: Iffcfd60391ba60d5ab2196a00a5bd0a4a93fff7f Resolves: #85599 Releases: master Reviewed-on: https://review.typo3.org/57635 Tested-by:
-
