- Sep 27, 2018
-
-
Benni Mack authored
The functionality of _GETset() is really broken by design when thinking about having a non-global state. On top $TSFE->mergingWithGetVars(), which was mainly used in RealURL, is deprecated, as this needs to go within a PSR-15 middlware (I actually did that in a fork already for realurl v1). Resolves: #86389 Releases: master Change-Id: I7081ed48131237f9d1b0da6a4ddf252a34a02072 Reviewed-on: https://review.typo3.org/58344 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Daniel Siepmann authored
Use yaml as default highlighting. Add markup for code blocks. Also add highlighting for file names. Resolves: #86214 Releases: master Change-Id: I716c9bf80f86e3188409d173d767469a84a28e82 Reviewed-on: https://review.typo3.org/58409 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Josef Glatz authored
This patch prevents closing a form without showing the modal to inform the backend user about unsaved changes if values of an element with renderType `selectCheckBox` were changed through a „toggle all“ checkbox. Resolves: #86377 Releases: master, 8.7 Change-Id: I8a0ffd7ae0104739fdb66a1863e7012c0d30c84e Reviewed-on: https://review.typo3.org/58392 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Sep 26, 2018
-
-
Benni Mack authored
We heavily rely on Symfony Routing for TYPO3 routing, however we want to encapsulate this as much as possible to allow us to use a different routing system if a better one comes up. In order to proceed with Route Enhancers we introduce our own objects to extend them, and to typehint against these objects in the next patches. Some minor code preparations have been made as well. Resolves: #86393 Releases: master Change-Id: Id50186aa1a5ad57e097e6ff85e15d0f925bd63ef Reviewed-on: https://review.typo3.org/58401 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Susanne Moog authored
During upgrading missing information in some rst files has been added to ease upgrading for others. Resolves: #86376 Releases: master Change-Id: I4027e9b6e7da9ca663549fbe6489d1eea5671152 Reviewed-on: https://review.typo3.org/58391 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Oliver Hader authored
The PageUriBuilder is gone, as all is centralized in the PageRouter now, which acts as the centralized place to resolve Requests ("matchRequest") and to create URLs ("generateUri") for pages that have a site configuration. RouterInterface is the abstract interface which is intended to be used within Backend as well in the future, and provides a good basis for both cases (that's why page ID and SiteInterface is not hardcoded in the API). RouteResultInterface is introduced to allow further Result objects like page-specific results, useful for future routing improvements. Since PageUriBuilder was only used in cases where there was a site, the Router is now bound to a site (see constructor). When generating a URL, the PageRouter can receive a special argument called "_language" to hand over a SiteLanguage object. Resolves: #86388 Releases: master Change-Id: Ib090d3373a88cb7c534557ef21b46dce646078b5 Reviewed-on: https://review.typo3.org/58149 Tested-by: -
Frank Naegler authored
This patch put more information into IRRE titles of site configuration. Resolves: #85887 Releases: master Change-Id: I7d3df7b9513eb9cd591605eb450c4ae451b1fd75 Reviewed-on: https://review.typo3.org/58385 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benjamin Franzke authored
Since https://review.typo3.org/56968 handing over arguments to getTSConfig() is deprecated. As a drive-by we also fix some related wrong getTSConfig() mocks in Unit/Middleware/AdminPanelInitiatorTest.php – they do not produce errors, but these mocks are too unspecific, as they still allow an argument to be passed. Releases: master Resolves: #86383 Related: #85016 Change-Id: I7254b5d0b87bc66da319728f7fe82aaa614b6a43 Reviewed-on: https://review.typo3.org/58396 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Josef Glatz authored
This patch prevents closing a form without showing the modal to inform the backend user about unsaved changes if values of an element with renderType `t3editor` were changed within the CodeMirror editor. In addition to the fix, a CSS border is added if the code editor content was changed to improve the user experience. Releases: master Resolves: #86380 Change-Id: I641180a531b879ece70e30d0a22c9e5878d02953 Reviewed-on: https://review.typo3.org/58394 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- Sep 25, 2018
-
-
Josef Glatz authored
Resolves: #86379 Releases: master Change-Id: I8eadc7d6cf242581601065ef780229e577149204 Reviewed-on: https://review.typo3.org/58395 Reviewed-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
Susanne Moog authored
To ease the update pain a compatibility layer for AbstractUpdate based upgrade wizards has been implemented, that allows running "old" wizards on CLI (enabling extension authors to support both v8 and v9 with one wizard). To get people to migrate to the new structure the methods in Abstract Update have all been deprecated. As it is an abstract class this has been done in all methods and the constructor as we cannot reliably know which methods are overwritten. Resolves: #86366 Relates: #86076 Releases: master Change-Id: I3d4ba756ca37d82a918c1021c48b2f331e64f696 Reviewed-on: https://review.typo3.org/58370 Reviewed-by:
-
Guido Schmechel authored
Use either field mount_pid or display a note Releases: master Resolves: #86349 Change-Id: Iaed4f7ab527f02644670d980dc6f6feaef010537 Reviewed-on: https://review.typo3.org/58372 Tested-by:
-
Frank Naegler authored
This patch prevents saving an invalid record by click „close“ and „save“ in the modal. Resolves: #86357 Releases: master Change-Id: If7f581e9eaaf55dea463528563b7e679a6e65201 Reviewed-on: https://review.typo3.org/58386 Reviewed-by:
-
David Bruchmann authored
Add missing blank line before each list to have proper rendering. Releases: master Resolves: #86364 Change-Id: I4f8ee96e7996cfb925abad23ad950da7153c25cc Reviewed-on: https://review.typo3.org/58383 Reviewed-by:
-
- Sep 24, 2018
-
-
Guido Schmechel authored
Now the editlock information of the page is retreived and used as condition for the rollback command icon. Releases: master Resolves: #69114 Change-Id: Ie3122a511c96ca6d6d7913e3e1efcfe3d4d84cd6 Reviewed-on: https://review.typo3.org/57804 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Jigal van Hemert authored
Resolves: #86355 Releases: master Change-Id: I348a52aaccc481bc928e096d54818c5d572e7e5f Reviewed-on: https://review.typo3.org/58374 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Josef Glatz authored
This patch activates the autolink functionality while pasting an URL or an email address from the clipboard to the CKEditor in WYSIWYG-mode. Resolves: #83789 Releases: master Change-Id: I0c23dc57406207614aca0d865b99ade3917ef15a Reviewed-on: https://review.typo3.org/58377 Tested-by:
-
Josef Glatz authored
A translate VH was converted incorrectly in one of the patchsets of #86291 before it was just merged into the core. Resolves: #86358 Related: #86291 Releases: master Change-Id: Idead223d0a5ba988cb4d20e58d686c4e265b7eb1 Reviewed-on: https://review.typo3.org/58378 Tested-by:
-
Frank Naegler authored
Resolves: #86352 Releases: master Change-Id: I30ed9f8f2b14819654fc496991b860b0bdf97d9c Reviewed-on: https://review.typo3.org/58367 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #86360 Releases: master, 8.7 Change-Id: I34e6b720a93bd86f863fbf4ae0b5efb6cccdc76d Reviewed-on: https://review.typo3.org/58381 Tested-by:
-
Jigal van Hemert authored
The IRRE records show an icon depending on the type of error handler that is configured. Because the wrong keys were used only the default "not found" icon was displayed. Resolves: #86359 Releases: master Change-Id: I424fc17daa3d24dd8763b08d1b00994f49da5d91 Reviewed-on: https://review.typo3.org/58379 Tested-by:
-
Markus Klein authored
Re-establish the functionality to set language labels in TypoScript even though no locallang.xlf file is present for the given extension. Resolves: #86194 Releases: master Change-Id: Ifcd31909fa594be892f93c1037941313011b74cf Reviewed-on: https://review.typo3.org/58373 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Tested-by:
-
- Sep 23, 2018
-
-
Georg Ringer authored
Use the dark icons, just as in the list module. Resolves: #86345 Releases: master Change-Id: Ife258d11a1384076f1333e2c97a1c0a41599202f Reviewed-on: https://review.typo3.org/58363 Tested-by:
Gianluigi Martino <gmartino27@gmail.com> Tested-by:
-
- Sep 22, 2018
-
-
Tymoteusz Motylewski authored
Introduction of the LanguageAspect changed the Extbase behavior, now it's reintroduced. When reviewing this patch please compare new code of Typo3QuerySettings.php from this patch with state before patch https://review.typo3.org/57424/ and compare QueryLocalizedDataTest.php with one from v8 to see that result is the same. Resolves: #86332 Related: #85543 Releases: master Change-Id: Ide9f5e1fe1875b942aac8d1187dc897cc1b20181 Reviewed-on: https://review.typo3.org/58351 Reviewed-by:
-
Christian Kuhn authored
The patch removes a set of common methods and properties from the extension scanner to show less weak matches: * method init() * class properties ->config, ->tmpl, ->id, ->returnUrl Remember this only kicks methods and properties that are so common that many extensions use them and there are more false positives than actual matches. Remember a green file does not mean nothing breaks and a red file does not mean nothing works. It is not goal of the extension scanner to find everything, and matches do not mean they are valid. The above matcher configurations have only been removed since they use a naming that is often also used in extension. The places where they are used in core are usually deep in the API and it is rather unlikely a match found by the scanner does really mean the deprecated / removed method or property rather than just a false positive due to the common naming. Other matchers should still be kept, even if they show false positives in specific cases. It should not be a goal of an extension developer to make the extension scanner green. Change-Id: Ifc27974fe9e854a93661cd1814f044f50a552119 Resolves: #86340 Releases: master Reviewed-on: https://review.typo3.org/58360 Reviewed-by:
-
- Sep 21, 2018
-
-
Andreas Fernandez authored
The actions "Create admin" and "Change install tool password" now listen to the `submit` event of their respective form to allow using the HTML5-based field validation. Resolves: #86344 Releases: master Change-Id: I4e913d71e356f41d04b6b0b653445c48a3a671e1 Reviewed-on: https://review.typo3.org/58369 Tested-by:
-
Ralf Zimmermann authored
Speeds up the form manager module and the form plugin especially if there are many forms within the TYPO3 instance. Resolves: #86000 Releases: master, 8.7 Change-Id: Ic483029e0d1b1955d58e04496f97862c00b6d6a4 Reviewed-on: https://review.typo3.org/58054 Reviewed-by:
-
Susanne Moog authored
Resolves: #86350 Releases: master Change-Id: Iae67211c8a3421a8cdd78a68c88d15da43f9e67e Reviewed-on: https://review.typo3.org/58366 Reviewed-by:
-
Sascha Egerer authored
Related: #86303 Releases: master Change-Id: I56e48fa481fc59dd7bda20a4cc76bf2d3b1826a4 Reviewed-on: https://review.typo3.org/58368 Reviewed-by:
-
Georg Ringer authored
Extend the site configuration by allowing multiple base domains which are checked by the ConditionMatcher. Resolves: #86303 Releases: master Change-Id: Ib80821c80e88d86656b03d29b746e526f300fd95 Reviewed-on: https://review.typo3.org/58206 Tested-by:
-
Christian Kuhn authored
The first 'silent configuration update' ajax call in the install tool does two things: As all others, it checks for a valid session, if valid, it executes the update. If session is not active, the 'enable install tool' file view is loaded next. Not having a dedicated 'check session' call as first step saves one ajax round trip. The patch improves the status message to avoid confusion why the silent configuration update is executed for login view. Resolves: #86347 Related: #86347 Releases: master Change-Id: Idfd1fbb449dca4acd641f86e42092d56246ee3a2 Reviewed-on: https://review.typo3.org/58365 Reviewed-by:
-
Benni Mack authored
The init() method is now called implicitly within the constructor, so the last part is to mark the method protected. Resolves: #86338 Related: #85450 Releases: master Change-Id: Ic4c49f1dfbc3d9cda2f9c2bfbbdf4de333d836c0 Reviewed-on: https://review.typo3.org/58343 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
Some `self` assignments were removed that shouldn’t have been removed. That was selfish, so they are added again. Resolves: #86339 Related: #86330 Releases: master Change-Id: I0ae875b60c9766b233d0a93a55d68bc7142a417d Reviewed-on: https://review.typo3.org/58359 Tested-by:
-
- Sep 20, 2018
-
-
Riny van Tiggelen authored
Wrong order of directory names Releases: master Resolves: #86342 Change-Id: I8aaf9ad050bac017b5b5f2bca6d98bea69a9487b Reviewed-on: https://review.typo3.org/58361 Reviewed-by:
-
Josef Glatz authored
Update CKEditor to the lastest version that fixes a lot of bugs. Release notes: https://ckeditor.com/cke4/release-notes https://ckeditor.com/cke4/release/CKEditor-4.9.2 https://ckeditor.com/cke4/release/CKEditor-4.10.0 https://ckeditor.com/cke4/release/CKEditor-4.10.1 @types/ckeditor has also been updated. Following commands were used to update dependencies: - yarn upgrade ckeditor@4.10.1 -E -D - yarn upgrade @types/ckeditor@4.9.1 -E -D (As there is no newer types definition, version 4.9.1 must be used) The following command was used to update the files in EXT:rte_ckeditor: - yarn build Releases: master Resolves: #86305 Change-Id: I8e5210316454854b93c979e0e7ac1eea3b54e7d4 Reviewed-on: https://review.typo3.org/58324 Tested-by:
-
Tymoteusz Motylewski authored
DataMapper is not a singleton any more. Thanks to that, a further refactoring can be done to pass aggregate root query configuration to the DataMapper, which will allow to fix inconsistencies in Extbase language handling. The runtime cache of data maps is moved to DataMapFactory. Resolves: #86268 Releases: master Change-Id: I003451c4d07855ff25d695578c9ec7b443f630bc Reviewed-on: https://review.typo3.org/58287 Tested-by:
-
Georg Ringer authored
Catch an exception which is thrown if a file of a sys_file_reference relation does not exist anymore. Resolves: #86267 Releases: master Change-Id: Ie50ae07845964346bcd8e042a6a3d62a1e8084d3 Reviewed-on: https://review.typo3.org/58286 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
The panels used in Settings > Configuration Presets do now have the same UI than the other panels in the Install Tool. Resolves: #86337 Releases: master Change-Id: Iada1994fa77ff2fe78d5a81720bff6c97f14bccd Reviewed-on: https://review.typo3.org/58356 Reviewed-by:
-
Christian Kuhn authored
Give earlier feedback when opening the database analyzer modal, block the buttons again if executing changes and update the progress bar with what is currently going on. Resolves: #86335 Releases: master Change-Id: Ib1e01427fc7bb364d9a030ca1978804a7c1a8b49 Reviewed-on: https://review.typo3.org/58355 Reviewed-by:
-
Christian Kuhn authored
* Direct action buttons (eg. clear cache) catch ajax errors and turn them into a notification, so the main frame of the install tool does not die. * Server side errors triggered by ajax calls from within modals no longer kill the main install tool frame, but render the error message into the modal. * Improved error display with more info on how to recover and a (collapsed) output of the generic server side error message or backtrace depending on error settings. Resolves: #86330 Releases: master Change-Id: I9fa7602d0ea26d979f832022e03b78975b9877af Reviewed-on: https://review.typo3.org/58350 Reviewed-by:
-
