- Jul 18, 2018
-
-
Benni Mack authored
The unused method TypoScriptFrontendController->getUniqueId() is marked as deprecated, as this method conceptually should go into a custom service with a singleton pattern or a runtime cache, but not within TypoScriptFrontendController. Resolves: #85555 Releases: master Change-Id: Ib3af4b32e3c03d90b832ee725dcf9846af92f9ba Reviewed-on: https://review.typo3.org/57597 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Mathias Brodala authored
Change-Id: I9f396da2084880b3dd813c8d7f0777c36ac989d9 Resolves: #84414 Releases: master Reviewed-on: https://review.typo3.org/56331 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Robert van Kammen <rvkammen@hotmail.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Jul 17, 2018
-
-
Christian Kuhn authored
bamboo php 7.2 has apc & apcu support again. Two unit tests fail. These two however don't make much sense in the first place since they md5(internal-knowledge). Remove them. Resolves: #85584 Releases: master Change-Id: I5f1e1589189866508e684a7ca1bb6cae87d22fad Reviewed-on: https://review.typo3.org/57621 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
The bamboo containers need a better passwd mapping per agent to set a proper home directory, otherwise ssh tasks may fail. Resolves: #85582 Releases: master, 8.7, 7.6 Change-Id: I42b59df7512dd5bd6e00c2c07eee9441cf1aa28c Reviewed-on: https://review.typo3.org/57618 Tested-by:
-
- Jul 16, 2018
-
-
Tymoteusz Motylewski authored
It's based on tt_content and categories. Releases: master, 8.7 Resolves: #85493 Change-Id: Ie7222f38ea89536ab463ff46aabb94b8f834d599 Reviewed-on: https://review.typo3.org/57474 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klein authored
Resolves: #85552 Releases: master, 8.7 Change-Id: I1056a5825fd79df4c495894970721713b10728cd Reviewed-on: https://review.typo3.org/57603 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
Our unit tests should not rely on running daemons, there is a functional test environment to take care of this. The patch turns redis cache backend unit tests into funcitional tests and adapts the unit test setup to no longer start dependencies. Resolves: #85565 Releases: master Change-Id: I8d81209ed339d35af11bb06fb7cb191845b6b587 Reviewed-on: https://review.typo3.org/57607 Tested-by:
-
- Jul 15, 2018
-
-
Christian Kuhn authored
A new bamboo agent infrastructure has been deployed that significantly changes how tests are executed: The agent docker containers are now "stupid" and no longer bundle specific php versions or daemons. Instead, they can run own containers to start needed daemons for specific jobs and execute needed php commands in ad-hoc containers that provide the required php version. Daemons needed for single jobs are defined in a docker-compose.yml file provided by core itself. This docker-compose.yml file can not be used directly for local test execution since it has to fiddle quite a bit with docker volume mounts, networks and executing users that is specific to the bamboo environment. However, another yml file can be added later to ease local test execution in a similar way. The patch rewrites the bamboo plan pre-merge and nightly specs of core master to use the new infrastructure and brings a couple of minor changes to tests that rely on a running memcached or redis to retrieve the daemon host from an environment variable. There will be separated patche for older core versions. Change-Id: I65777eeee6e28fca5b3d3d979498293cc91a77af Resolves: #85563 Resolves: #36934 Releases: master Reviewed-on: https://review.typo3.org/57522 Tested-by:
-
Jigal van Hemert authored
In CommandTest::testGetDescription() now also LF is used as line ending, just as in the tested function. Resolves: #85509 Releases: master, 8.7 Change-Id: I907e24b19d87d94a3fb1b3cbee9947d68358e5cc Reviewed-on: https://review.typo3.org/57501 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
Minor fix to use the static constant directly, like in all other usages. Resolves: #85559 Releases: master Change-Id: I163bea97ddd78b6f37945daaf7aecaab6c47bdff Reviewed-on: https://review.typo3.org/57599 Tested-by:
-
- Jul 14, 2018
-
-
Andreas Fernandez authored
With the release of doctrine/dbal in version 2.8, the class `Doctrine\Common\Lexer` got removed. To circumvent this issue, the package `doctrine/lexer` will be used. Used composer command: composer require doctrine/lexer:^1.0 Resolves: #85552 Releases: master, 8.7 Change-Id: I5dd007c3b95be42dfd3305f750606ae4fcabedf2 Reviewed-on: https://review.typo3.org/57589 Reviewed-by:Benni Mack <benni@typo3.org> Tested-by:
-
- Jul 13, 2018
-
-
Oliver Hader authored
Including files from Phar archives (e.g. "phar://file.phar/autoload.php") does not work properly with having PHP setting open_basedir defined. The reason for that is, that TYPO3's custom PharStreamWrapper tries to find the appropriate base Phar file using file_exists() calls internally. In case those files are not part of the open_basedir restriction - which is the case for everything prefixed with the "phar://" scheme - a PHP warning is shown. Resolves: #85547 Releases: master, 8.7, 7.6 Change-Id: I72fdd7f0c016c0a8b1ed56a82b6b4042cac4d930 Reviewed-on: https://review.typo3.org/57587 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benni Mack authored
This change adds a new Aspect called "Language" which bundles most existing TypoScript options on frontend language fetching. A factory allows to migrate the logic from TSFE. Major / Important Changes: - RootlineUtility is decoupled from PageRepository - TSFE->sys_language_mode is not necessary anymore - TSFE->sys_language_contentOL can be substituted by "overlayType" of Aspect - A new PageRepository->getLanguageOverlay() bundles all other methods - A lot of common public properties in TSFE are now deprecated Next steps: - Isolate calls from RootlineUtility/PageRepository more from each other and from TSFE - Migrate PageRepository "-1" parameters to "null" - Migrate usages PageRepository->getRootline() to RootlineUtility::__construct() - Then deprecate PageRepository->getRootLine() - Migrate Extbase QuerySettings to Contexts Resolves: #85543 Releases: master Change-Id: I8d177222a244a8d1fd66a884e9fc50b107f27e20 Reviewed-on: https://review.typo3.org/57424 Tested-by:
-
Benni Mack authored
The constructor of TemplateService now has a context, which knows everything to define public settings to define if tt_track and verbose should be set. Resolves: #85542 Releases: master Change-Id: I11306a57c64e8c5cb0d0a069b73e06f066b72d8e Reviewed-on: https://review.typo3.org/57581 Tested-by:
-
Benni Mack authored
The new Context API is added so TypoScript can check this in cObject like this: 10 = TEXT 10.data = context:workspace:id where as the key is context:[aspectName]:[propertyName] Arrays are automatically converted to comma-separated lists, which is useful for reading info on user groups. Resolves: #85550 Releases: master Change-Id: I86673055e088ec4e65288df6145399f8e45055c8 Reviewed-on: https://review.typo3.org/57588 Tested-by:
-
Mathias Brodala authored
Resolves: #85536 Releases: master, 8.7 Change-Id: Ie1f5c97af1a315eb5b8d7bf4bc7a31872362750d Reviewed-on: https://review.typo3.org/57536 Tested-by:
-
Josef Glatz authored
Show progress bar only if verbosity level is set. The default output of this command is disabled by default to limit the amount of e-mails sent by the TYPO3 scheduler (which normally makes only sense, if any error occurs). You can activate the output if you set the verbosity while calling the command ("-v" option). Resolves: #85533 Releases: master Change-Id: I6f95559cc1228afd66192f7382e81f9ae91c0ed8 Reviewed-on: https://review.typo3.org/57530 Tested-by:Alexander Grein <alexander.grein@gmail.com> Reviewed-by:
-
- Jul 12, 2018
-
-
Anja authored
The included task in not subject to be executed upon each `composer install`. Resolves: #85537 Related: #83249 Releases: master, 8.7 Change-Id: I12240cbd7ea571b1872effd6942a3bd65bf37a89 Reviewed-on: https://review.typo3.org/57537 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Susanne Moog authored
FormDefinitionValidationServiceTest modified the encryption key in test data-provider functions. Those functions are executed prior to actually executing the tests and causes side-effects during running the test suite. Resolves: #85539 Releases: master, 9.3, 8.7 Change-Id: I9fbd60905eb37470fa3661225b681476ff9df3c3 Reviewed-on: https://review.typo3.org/57570 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
Resolves: #..... Releases: master, 8.7 Change-Id: Iace5c4d064182c628e9d3b03876c73e19dd725cd Reviewed-on: https://review.typo3.org/57565 Reviewed-by:
-
Oliver Hader authored
Resolves: #85424 Releases: master, 8.7 Security-Commit: 82619eb231e725d77fb8196f0b6bfca9f722bc4f Security-Bulletin: TYPO3-CORE-SA-2018-004 Change-Id: Ic104c79ebfc1daff0b05b0f5531345b5bf7ce74b Reviewed-on: https://review.typo3.org/57563 Reviewed-by:
-
Ralf Zimmermann authored
The form editor save and preview actions now check the submitted form definition against configured possibilities within the form editor setup. Releases: master, 8.7 Resolves: #85044 Security-Commit: f4a1a09378ed286f3744d6a72f09bfa11a6ba87e Security-Bulletin: TYPO3-CORE-SA-2018-003 Change-Id: Ibf6083ab98b9fe73effe217380f555892c9c6bb0 Reviewed-on: https://review.typo3.org/57562 Reviewed-by:
-
Susanne Moog authored
Before this change, form definitions have been persisted in regular `.yaml` files. In order to make the meaning and purpose of those files more explicit, the new file ending `.form.yaml` is introduced. Invocations of the file abstraction layer API for those form files have to be allowed explicitly by granting commands individually using `FilePersistenceSlot::allowInvocation`. New form definitions are created with the new file ending per default. An upgrade wizard renames existing form definitions that are stored in according storage folders (`allowedFileMounts`). In addition references in FlexForm of content elements are adjusted to the new file names as well - in case a form definition has been referenced before. The file list user interface disabled according direct actions for `.form.yaml` files or redirects those to the according form module. Using just `.yaml` instead of `.form.yaml` from site packages is deprecated. Using just `.yaml` instead of `.form.yaml` from file storages is not allowed anymore. Resolves: #84910 Releases: master, 8.7 Security-Commit: 444f9dc4f1902871391bd1f139d19b46a63a162f Security-Bulletin: TYPO3-CORE-SA-2018-003 Change-Id: I456c03f745e614729cdbf2915efc6b5e6d11fc0f Reviewed-on: https://review.typo3.org/57561 Reviewed-by:
-
Oliver Hader authored
Resolves: #85385 Releases: master, 8.7, 7.6 Security-Commit: f4d645d131fabc98cbbdcefcffb951040d2dd246 Security-Bulletin: TYPO3-CORE-SA-2018-002 Change-Id: Ia138f22856c7dd754e373803af799273868c622b Reviewed-on: https://review.typo3.org/57560 Reviewed-by:
-
Christian Kuhn authored
SoftReferenceIndex throws exceptions on phar streams LegacyLinkNotationConverter throws exceptions on phar streams Resolves: #85385 Releases: master, 8.7, 7.6 Security-Commit: 4fde9d6a2333435af9033f55e9a5e2d428f6ea0d Security-Bulletin: TYPO3-CORE-SA-2018-002 Change-Id: I69333fff4d94dc7369ba729333a39e8be5dda7a3 Reviewed-on: https://review.typo3.org/57559 Reviewed-by:
-
Oliver Hader authored
This custom stream wrapper for the phar:// protocol overrides PHP's native handling. In case Phar bundles shall be loaded from a valid directory, the custom wrapper falls back to the native PHP wrapper in order to invoke Phar-related actions. In case the location is not trustworthy, an according exception is thrown. The custom stream wrapper is registered in the beginning of TYPO3's bootstrap class. Truested locations are those in typo3conf/ext/* - anything else is denied and not considered as trustworthy. Releases: master, 8.7, 7.6 Resolves: #85385 Security-Commit: efa085d9a5aebfac6b92309ea53c455b95a81fcc Security-Bulletin: TYPO3-CORE-SA-2018-002 Change-Id: Ifd38eab7a5757e6cfbd6f773a3fed8f3d742e09d Reviewed-on: https://review.typo3.org/57558 Reviewed-by:
-
Oliver Hader authored
Using password hashing methods that are related by class inheritance can lead to authentication bypass by just knowing a valid username. Resolves: #84703 Releases: master, 8.7, 7.6 Security-Commit: 2951c4fc0529ec0fd6047786edd3b7189428e574 Security-Bulletin: TYPO3-CORE-SA-2018-001 Change-Id: I859a20c85305291e1cd79b61e630bbbfc4e0568a Reviewed-on: https://review.typo3.org/57557 Reviewed-by:
-
- Jul 11, 2018
-
-
Benni Mack authored
The Logger can be used with the LoggerAwareInterface+Trait combination and was fogot for FAL related areas. The LocalImageProcessor and FileProcessingService did not have any usage of the logger, thus, they were removed. Additionally, one should reference against the interfaces, not the implementation classes directly. Resolves: #85519 Releases: master Change-Id: Ie381b1fc9a7007e76ea1c487fa9b1bda4a793bc0 Reviewed-on: https://review.typo3.org/57515 Tested-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Tested-by:
-
- Jul 10, 2018
-
-
Stefan Neufeind authored
The setting used bits 1 and 2. But useful values were only 0/1/2. So this setting can be simplified. Resolves: #85508 Releases: master Change-Id: Ib78174035bcefdec7658f37dae9071062dcb52c1 Reviewed-on: https://review.typo3.org/57500 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Jul 09, 2018
-
-
Ralf Zimmermann authored
Variants allow you to change properties of a form element. Variants can contain conditions. If a concrete condition is TRUE the variant is applied. If no condition exists the variant will be ignored. Variants make it possible to manipulate form element values, validator options, and finisher options based on conditions. This allows you among other things: * translation of form element values depending on the frontend language * set and remove validators of one form element depending on the value of another form element * hide entire pages depending on the value of a form element * set finisher values depending on the value of a form element * hiding a form element in certain finishers and on the summary page This feature implements variants for the frontend rendering and the ability to define variants in the formDefinition. The implementation to define variants in the form editor is out of scope of this patchset. Releases: master Resolves: #84133 Change-Id: I9efeeea5af67df2d2f9252339c26baf8a03cf9c8 Reviewed-on: https://review.typo3.org/54982 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Helmut Hummel authored
Remove inheritance from abstract log module Inheritance was used only to be able to get the time from which to start to look for errors. This however never really worked, because the constraint only had a startTimestamp value set, if the user selected a custom time frame when viewing the log. Therefore we can just assume errors have not been seen, unless they are confirmed through the system information toolbar. Resolves: #85517 Releases: master Change-Id: Id6aa21fbbe0c56baeb19633aba0f9f7ff6215c0e Reviewed-on: https://review.typo3.org/57513 Tested-by:
-
Michael Giek authored
TCA defines default status code as 307, which seems like a good default. However the SQL definition should match this definition to avoid any invalid redirect status codes. Releases: master Resolves: #85513 Related: #85488 Change-Id: I972d83bd782592c77b6606cd6f7d6a1fc82d2414 Reviewed-on: https://review.typo3.org/57510 Reviewed-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
Benni Mack authored
Similar to https://review.typo3.org/#/c/57434/ the check for TSFE->showHiddenRecords is unneeded as the RestrictionContainer evaluates this information (now done via aspects) directly anyway. Resolves: #85516 Releases: master Change-Id: Icc88b1995fe603f3707c9a83e83bf03ff549422e Reviewed-on: https://review.typo3.org/57512 Tested-by:
-
Frank Naegler authored
In case the adminOnly flag is set, an information window is shown. The middleware now creates a valid JSON response to show the information window again. Resolves: #84765 Releases: master Change-Id: Ibe36b9d2c06b730bb2687d528d011268af4da660 Reviewed-on: https://review.typo3.org/56706 Tested-by:
-
Stefan Neufeind authored
Resolves: #85512 Releases: master, 8.7, 7.6 Change-Id: I4077fe7481063feb97014048580c3fb1b1ca5e2a Reviewed-on: https://review.typo3.org/57507 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Łukasz Uznański authored
* replace usages of _GP, getIndpEnv * add return hints Resolves: #84387 Releases: master Change-Id: I156f9005c132ab91abfbd72b97084ede6708d0dc Reviewed-on: https://review.typo3.org/56264 Tested-by:
-
- Jul 07, 2018
-
-
Davert authored
typo3/testing-framework got a major release: composer update typo3/testing-framework ^4.0 * codeception acceptance tests now live in a proper php namespace * merged installation suites yml files into one * installer tests are now one suite with different environment settings * aligned with changes in typo3/testing-framework * renamed Acceptance test suite to Backend test suite * removed Admin/Editor steps, replaced with useExistingLogin('role') Resolves: #85472 Releases: master Change-Id: Ia049b43f5f9f645dddb509bde557ad83a7ac9023 Reviewed-on: https://review.typo3.org/57461 Tested-by:
-
- Jul 06, 2018
-
-
moger-xx authored
Releases: master Resolves: #85500 Change-Id: I060e27a52a2a840dca2fd65db0e206f73dc5c8f9 Reviewed-on: https://review.typo3.org/57482 Tested-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Andreas Fernandez authored
Resolves: #85505 Releases: master Change-Id: I73315ce0c958cccbce401875b13514b7dae58f27 Reviewed-on: https://review.typo3.org/57495 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #85504 Releases: master Change-Id: I75580fb05c0217b1c28a2109b7f6bc2147d458d8 Reviewed-on: https://review.typo3.org/57494 Reviewed-by:
-
