- Mar 01, 2015
-
-
Andreas Allacher authored
Due to missing check of the last char being a new line, it is possible that a closing bracket character is removed by using INCLUDE_TYPOSCRIPT. This leads to broken typoscript. By introducing the missing check this kind of error is prevented. Change-Id: I92ef213d31c4d62ba797e2741d5a0beaa042c6b3 Resolves: #62280 Releases: master Reviewed-on: http://review.typo3.org/37038 Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Helmut Hummel authored
Previously the URI to a module which was dispatched through mod.php was stored in a global variable $GLOBALS['MCONF']['_'] In terms of cleanup of global variable usage and module configuration cleanup, this functionality is removed without substitution. Instead BackendUtility::getModuleUrl() API must be used now. Releases: master Resolves: #65432 Change-Id: Iad436056e96d2334357320278cd8243f0f975538 Reviewed-on: http://review.typo3.org/37406 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
Michael Oehlhof authored
backend/classes/Controller/Wizard/ColorpickerController.php To get it "green" in PhpStorm several changes were made: - set correct return type in PhpDoc comment - makeInstance of GraphicalFunctions to call non-static function imageCreateFromFile - change local variable names to lowerCamelCase Resolves: #65431 Releases: master Change-Id: I54182c8ed17423e1cbc1c97e424d92a58dd5e3a9 Reviewed-on: http://review.typo3.org/37404 Reviewed-by:
-
Frederic Gaus authored
Fix code completion in t3editor when substituing a value with completed code behind a typoscript operator. Change-Id: Id1fbb99aba850ee0787dba4b8562d0a22c119979 Resolves: #25594 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/36804 Reviewed-by:
-
Frans Saris authored
Resolves: #65040 Releases: master, 6.2 Change-Id: I14d6d362db1796c90b03254f6339cb131f152a45 Reviewed-on: http://review.typo3.org/37159 Reviewed-by:
Viktor Livakivskyi <invisible.kinder@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Jigal van Hemert authored
The functionality is unnecessary and it's confusing when using DataHandler that it must be explicitly set to FALSE to handle properly prepared data. The only place in the core where it was set to TRUE only handles integer values. Releases: master Resolves: #65381 Change-Id: I968fccc9311bb9ad5f9153217ecf84ff4777df4a Reviewed-on: http://review.typo3.org/37316 Reviewed-by:
-
Michael Oehlhof authored
backend/Classes/Controller/File/RenameFileController.php To get it "green" in PhpStorm several changes are made: - set correct parameter type in PhpDoc comment - set correct return type in PhpDoc comment - add getter for LanguageService - add getter for DocumentTemplate Resolves: #65426 Releases: master Change-Id: I1794d12fed33ab06d460c043632139bc30682a76 Reviewed-on: http://review.typo3.org/37398 Reviewed-by:
-
Wouter Wolters authored
Use dispatching for show_item.php Resolves: #65283 Releases: master Change-Id: If70f513ecc50445ea67b7e68bf7cd1df44cbf013 Reviewed-on: http://review.typo3.org/37186 Reviewed-by:
-
Frederic Gaus authored
Add code autocompletion for property listNum and property preIfEmptyListNum in t3editor. Resolves: #25732 Releases: master, 6.2 Change-Id: I13c15e2e262a926e8444d7f50933823b27cdcd9d Reviewed-on: http://review.typo3.org/36793 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #65376 Releases: master Change-Id: If06b63748fba645f7bdd4dce3938d313e598a1ae Reviewed-on: http://review.typo3.org/37307 Reviewed-by:
-
- Feb 28, 2015
-
-
Wouter Wolters authored
Resolves: #65296 Releases: master Change-Id: I08a3c8b6f89c029efacad06e13ea137560370e43 Reviewed-on: http://review.typo3.org/37293 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #65375 Releases: master Change-Id: I880f4f467e3a634cbabd375d13cb0e9f0029107c Reviewed-on: http://review.typo3.org/37306 Reviewed-by:
-
Benjamin Mack authored
The alias cObjects COBJ_ARRAY for COA and CASEFUNC for CASE are moved to compatibility6. Resolves: #65422 Change-Id: I419997c3b70d0dfd9e23d9bc67bf909295e4faff Reviewed-on: http://review.typo3.org/37379 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
Helmut Hummel authored
Doing a composer install directly in typo3 source has been a requirement for core development for a while and a convenient shortcut to quickly set up a TYPO3 installation for executing tests for extensions. Respecting the class loading information generated in that location is unfortunate however as it would require editing of the core composer.json if additional classes from the core should respected. Instead of respecting this as valid composer autoload file location, we always fall back to the hard coded and committed class loading info if no autoload file of a composer distribution call is found. Releases: master, 6.2 Resolves: #65420 Change-Id: I1953303c6d2b5b221017deb7d2d7a0b43e4d08bf Reviewed-on: http://review.typo3.org/37373 Reviewed-by:
-
Nicole Cordes authored
This patch allows the use of links with file scheme in typolink(). Releases: master, 6.2 Resolves: #65358 Change-Id: I25a8ca88637d1ecab4881127cf2228214b6c954a Reviewed-on: http://review.typo3.org/37370 Reviewed-by:
Göran Bodenschatz <coding@46halbe.de> Reviewed-by:
-
Benjamin Mack authored
Missed some removal of old classes, also make sure that they are registered for FE and BE. Resolves: #64719 Releases: master Change-Id: I416d1a9fa19aacb5950e8f33e0e085b020f4d242 Reviewed-on: http://review.typo3.org/37377 Reviewed-by:
-
Alexander Schnitzler authored
The SelectViewHelper tries to resolve the value and label field as long as options are of type object, i.e. domain objects but that functionality must also exist for arrays because their structure is similar to objects. Example: <f:form.select options="{items}" optionValueField="uid" optionLabelField="title" /> $items = array( 0 => array( 'uid' => 1, 'title' => 'Foo' ), ); Currently the view helper tries to use the array key as value field (i.e. 0) and the array value (i.e. array) as label and fails calling htmlspecialchars on the array. This patch allows values to be arrays themselves and to be treated like domain objects. Resolves: #65073 Releases: master, 6.2 Change-Id: Ia803ceb38c1f7488d48863f5a6781b229def50c4 Reviewed-on: http://review.typo3.org/36909 Reviewed-by:Stefan Froemken <froemken@gmail.com> Tested-by:
Andy Grunwald <andygrunwald@gmail.com> Reviewed-by:
-
Benjamin Mack authored
EXT:cms still registers logic that is completely placed inside EXT:frontend (classes, content element wizards, tables, CTypes). These leftovers are moved to EXT:frontend. Resolves: #65418 Releases: master Change-Id: I3919340de863a7b1c07149161d2ce758e42de4db Reviewed-on: http://review.typo3.org/37368 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65374 Releases: master Change-Id: I64d942327a49d6e5cb6d292ee260b4c37b459374 Reviewed-on: http://review.typo3.org/37303 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
Nicole Cordes authored
If you add a page link to a field which is defined as softrefs, the ReferenceIndex creates an index to a FAL record if there exists a file record with the page id. As file links are always prefixed with 'file:' this patch adds a proper check before generating a file ref_index. Because the functional tests of impexp extension still use a hardcoded file path for the header_link field the patch corrects the value to refer to a file. Furthermore if you add a file or folder link, the field is referenced twice for the FAL record. So we have to suppress the softreference for those records. Releases: master, 6.2 Resolves: #60226 Change-Id: I969224e2a291491cb7ece1f61b375071bf0eaebc Reviewed-on: http://review.typo3.org/37086 Reviewed-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Reviewed-by:
-
Benjamin Mack authored
Files related solely to the media Content Element are moved from typo3/contrib/ to the extension itself. Resolves: #65417 Releases: master Change-Id: I8223f204ccf35c4f4399760da90a90d6a7d1e46d Reviewed-on: http://review.typo3.org/37367 Reviewed-by:
-
Stanislas Rolland authored
When using the element browser for image insertion in backend form or in RTE, there should be some Back button on the Info page to go back to the wizard form. Currently, one has to close the window and start over. Releases: master Resolves: #55787 Change-Id: I909767feaacf260736707b3b28cb34efe2bf82e6 Reviewed-on: http://review.typo3.org/36848 Reviewed-by:
-
Alexander Stehlik authored
The submitted sword_list GET parameters are parsed through preg_quote() when loaded into TSFE->sWordRegEx to prevent invalid regular expressions. The initialization is moved to a seperate method PageGenerator::initializeSearchWordDataInTsfe() and unit tests are added. Releases: master, 6.2 Resolves: #41728 Change-Id: Id96fd5e201c25b06001f7e1c7811d6c38239aafa Reviewed-on: http://review.typo3.org/37328 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Nicole Cordes authored
Due to FAL checks it's not possible to link to a file:// resource as external link. This patch checks for correct "file:" prefix for FAL relations and allows the use of file:// as external link scheme. Furthermore a Javascript error is resolved which prevents the closing of the Element Browser in Chrome. Releases: master, 6.2 Resolves: #65358 Change-Id: I706fd975654bf82a0830d9901f08ae9de7cc49bf Reviewed-on: http://review.typo3.org/37329 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
-
Michael Oehlhof authored
When editing a group in the edit document popup the browse for records button was without function, this is now fixed. Resolves: #65215 Releases: master Change-Id: I1bed83669d8a62f193f6b92d3fd3a39f5250707f Reviewed-on: http://review.typo3.org/37089 Reviewed-by:
-
Benjamin Mack authored
When clicking on the edit button wizard in FormEngine (e.g. when editing a be_group inside the be_user record) then there is a JS error preventing from opening a popup. Resolves: #65415 Relates: #63846 Releases: master Change-Id: Iafac6759054d0e2ce229b34b17b6a5312e1408df Reviewed-on: http://review.typo3.org/37359 Reviewed-by:
Frank Nägler <typo3@naegler.net> Reviewed-by:
-
Benjamin Mack authored
As the refactoring of FormEngine now always includes the suggest JS code, scriptaculous needs to be loaded all the time as well for the time being (as long as scriptaculous is still needed). Resolves: #65416 Relates: #55575 Releases: master Change-Id: I276448c7c0dc6745926eb18a0ffae49836c718f2 Reviewed-on: http://review.typo3.org/37360 Reviewed-by:
-
Benjamin Mack authored
For historical reasons the "Static Template #43" was "content.default" and the possibility to add TypoScript after this default rendering was introduced in order to have CTypes and plugins register their TypoScript just after e.g. "content.default" or "css_styled_content". Since TYPO3 CMS 6.2 the preferred option is called "defaultContentRendering" instead of the magic number "43". Some leftover parts in sysexts are replaced with "defaultContentRendering", as well as some more descriptive information on how the legacy number exists. Releases: master Resolves: #65346 Change-Id: I7268ec9ee8454d1eb4b0fda9f12fdfb5cb191ba8 Reviewed-on: http://review.typo3.org/37239 Reviewed-by:
-
Andreas Wolf authored
The MIME type is stored in a field "mimetype" in the drivers, while the field is called "mime_type" in the database. As the file object deals with both when retrieving the type, it must respect this mismatch. Change-Id: I06882c4d77e38284a48f7f7d7527bfc1c535edf3 Resolves: #65335 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/37214 Reviewed-by:
-
Frederic Gaus authored
The usage of getBackendUser and getBackendUserAuthentication is mixed up in the core. But at least in inheritance this should be consistent. Rename ScheduleModuleController::getBackendUserAuthentication to ScheduleModuleController::getBackendUser Change-Id: Icf21b4565ed66d3dabaf1df2d62d6b022c07248c Resolves: #64982 Releases: master Reviewed-on: http://review.typo3.org/36823 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
Mathias Brodala authored
This makes sure exception details thrown in Extbase scheduler tasks can be shown by the Scheduler. Resolves: #49071 Releases: master, 6.2 Change-Id: Ic703568715bf92523a9cbd0dcab6c5606ea278bb Reviewed-on: http://review.typo3.org/36985 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Thomas Deuling authored
The method of GeneralUtility::mkdir_deep has two parameters, which are concatenated. This could end up in a double slashes. To prevent that, the parameters are modified to concat them with only one slash. Additionally fix a Bug with double slash in FileStreamWrapper. Resolves: #63920 Releases: master, 6.2 Change-Id: I2d15f6c33550f9045db9b7730f7b074ae54a18dc Reviewed-on: http://review.typo3.org/36399 Reviewed-by:
-
Benjamin Mack authored
In order to separate features and also consolidate code for specific features into one place, a new system extension is created. The extension "mediace" ships with the core (not installed by default) for now but could be moved to TER in future releases. Next steps are: - move third-party files from typo3/contrib/ to EXT:mediace - find a proper solution to move the MediaWizard provider - (optionally) create a Update Wizard that checks if the system uses media or multimedia elements or the "multimedia" and install the extension automatically. Change-Id: I312ba6c15fece3a1319de23c085790590a659755 Resolves: #64719 Releases: master Reviewed-on: http://review.typo3.org/36572 Reviewed-by:
-
Christian Kuhn authored
This patch improves the separation of FormEngine and its sub classes. Currently, all sub classes like single element and wizard classes get an instance of the parent object to call various methods and properties on them. This is very hard to refactor and the mesh of call trees must be simplified to ease further refactoring and improve maintainability of code. This patch follows a divide & conquer approach: * Methods only used by sub elements are moved to AbstractFormElement * Properties FormEngine "knows" that are needed by element classes are given down in a data array during element instatiation to have a clear definition of what element classes know. * Methods used by both FormEngine and sub classes that do not need an instance of FormEngine are moved to a static helper for now to reduce the amount of code in FormEngine and to mark certain areas as stateless. * Class instances are not created on a global level anymore but created only in the scope where they are used * Class instances injected by outer code are created internally for enabling the using code to be moved around. All in all, this patch is mostly a preparation of defining a fully separated structure with defined concerns for every sub class. Most methods are moved around "as is" without changing functionality. The only area that is refactored codewise is renderWizards(). There is still a nasty circular dependency between FormEngine, FlexFormElement and InlineElement. This is not resolved by the patch, but the surrounding code is now separated enough that this structure could be refactored to a tree. This may follow with other patches. This patch evolved on catharsis in branch formengine with 53 single patches. Details can be looked up there, all single patches are prefixed with [FormEngine]. https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f Releases: master Resolves: #65357 Resolves: #63848 Resolves: #63849 Resolves: #63851 Resolves: #63853 Resolves: #63855 Resolves: #63857 Resolves: #63867 Resolves: #63868 Resolves: #63869 Resolves: #63870 Resolves: #63871 Resolves: #63872 Resolves: #63873 Resolves: #63874 Resolves: #63875 Resolves: #63877 Resolves: #63879 Resolves: #63880 Resolves: #63884 Resolves: #63885 Resolves: #63886 Resolves: #63887 Resolves: #63888 Resolves: #63890 Resolves: #63892 Reviewed-on: http://review.typo3.org/37265 Reviewed-by:
-
- Feb 27, 2015
-
-
Wouter Wolters authored
Resolves: #65372 Releases: master Change-Id: I19d67cb8de220f25f74667bc39a5ca25c62c9500 Reviewed-on: http://review.typo3.org/37309 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Wouter Wolters authored
Resolves: #65302 Releases: master Change-Id: I215fc48ba7a1ac72e5be5c7357a2dd1557413d1f Reviewed-on: http://review.typo3.org/37305 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65297 Releases: master Change-Id: I7822f7aa48fc47940300467ea15422d5910767cb Reviewed-on: http://review.typo3.org/37237 Reviewed-by:
-
- Feb 26, 2015
-
-
Michael Oehlhof authored
The local property languageService was only used in the indexAction. In getModulesData and getSubModuleData there was still $GLOBALS[‘LANG’] used, which is now changed to the local property languageService. Resolves: #65368 Releases: master Change-Id: Ibae1f34b7baa37d5693bdb8220f59c23c5bbac0c Reviewed-on: http://review.typo3.org/37297 Reviewed-by:
-
Andreas Allacher authored
In the emitPostProcessTreeDataSignal of the DatabaseTreeDataProvider the namespace for the SlotDispatcher to get the class name is wrong. TableConfiguration is used twice here. This patch removes the doubled namespace. Releases: master Resolves: #65360 Change-Id: Iff4f02ad63cc0f7ed6f0176a624aa293c5b1f4cc Reviewed-on: http://review.typo3.org/37252 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #65369 Releases: master Change-Id: Id488fb523c3b3dcc255f9c5d36af537abec267d0 Reviewed-on: http://review.typo3.org/37298 Reviewed-by:
-
