- Mar 27, 2023
-
-
Nikita Hovratov authored
Due to a missing file suffix check, @import for tsconfig was included twice, while it was looping through the possible ".typoscript" an ".tsconfig" file suffixes. This is now fixed by making sure that the absolute file name ends with the current file suffix. Resolves: #100240 Related: #97816 Releases: main Change-Id: I1f8acdddd60b257b93ce0ca21aee3434947fa999 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78200 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Christian Kuhn authored
* Submodule drop-down is shown on page 0 as well since page TSconfig is typically available on page 0 as well * Rename route pagetsconfig_records to pagetsconfig_pages * Headline improvements for page 0 Change-Id: I01eb793124042c34ad4aa21b6dceb058d1f3d9d8 Resolves: #100310 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78265 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Max Frerichs authored
A user who's about to log in into the backend is now able to reveal the typed password. Once the password field is cleared, the visibility mode automatically switches back to its default to avoid revealing sensitive data by accident. Resolves: #86880 Releases: main Change-Id: I3c45730e2bed9a71371e472729edf12c29bf5860 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75380 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Alexander Schnitzler authored
This patch introduces ColumnMap\Relation enum as a replacement for the former ColumnMap::RELATION_* class constants. Releases: main Resolves: #100272 Change-Id: I517bd3ed30815e1bc51845ae2739121999ca5863 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78230 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Jochen Roth authored
The group of "Not assigned to any task group" can not be collapsed anymore. This has been fixed by adding the correct id, so the element to collapse is found and collapsed again. Resolves: #100308 Releases: main Change-Id: I08c705cea67d03c02667cc6753752b385339733f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78264 Tested-by:
-
Torben Hansen authored
The default value for a confirmation is currently not respected in the install tool on UI level and a confirmation dialog will always show the "deny" button as selected. On CLI level the default value is however taken into account. This change sets the default value of the confirm dialog buttons depending on the `defaultValue` property of the confirmation. If the `defaultValue` is `true`, the "confirm" button is selected, otherwise the "deny" button is selected. Resolves: #100291 Releases: main, 11.5 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Iee6e89c61cc5ad7117f7e565b42d39bd82ce26f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78246 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Klee authored
- use arrow functions - make anonymous functions static if possible - add type declarations - use first class callables see https://www.php.net/manual/en/functions.first_class_callable_syntax.php Resolves: #100146 Releases: main Change-Id: Ic4f3f93b7592dc9ce3fdb2a3bd8bf2fea491ebbe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78099 Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
An internal csp-violation reporting endpoint is integrated, which keeps track of potential violations in frontend and backend scope. Alternative remote endpoints of 3rd party services can be configured with in TYPO3_CONF_VARS setting `contentSecurityPolicyReportingUrl` for `BE` or `FE`. Violations ("reports") are visualized in the new Content-Security-Policy backend module, which allows to select from possible suggestions that would resolve a violation - however a user with system maintainer privileges has to make this decision. For the time being, the `GoogleMapsHandler` has been added, which can be used as an inspiration for additional custom CSP violation handlers. The following test extension triggers CSP violations: https://packagist.org/packages/oliver-hader/csp-test Resolves: #87423 Related: #99499 Releases: main Change-Id: I7476b954c896c4d367d4e41e3d0f6f663952e966 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77998 Tested-by:Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Georg Ringer authored
As there are no records regarding PageTsConfig, the wording should be adopted. Resolves: #100179 Releases: main Change-Id: I156d9a94aca69c774616633e04a2ac8345e1c868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78134 Tested-by:
-
Christoph Lehmann authored
Given a page has TSconfig and it is translated, then the translation is also listed which blow ups the overview unnecessarily and is somehow confusing too, because page translations don't show the field TSconfig in BE. Resolves: #100303 Releases: main Change-Id: If8ac2f01a0c4ba99983f8389909d854a911d0c76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78256 Reviewed-by:
-
Sybille Peters authored
This is a change to ease translation of the existing texts. The phrase "for your internal reference" adds little value to the description descripion and causes difficulties while translating: The phrase is ambiguous, it can mean "for your internal documentation" or something else and I am not sure what it means in this context. Resolves: #100299 Releases: main Change-Id: I9b6583c9a5315eab3e7c048eb61c4c06c0d236a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78255 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Thomas Hohn authored
In #97202 types for the class ArrayUtility were added. Unfortunately the second parameter ($path) for the method isValidPath was changed to string only. The method basically calls getValueByPath, which has $path defined as array|string and handles it properly. It makes no sense, not to be able to call isValidPath with the same types for the $path argument. Resolves: #100302 Releates: #97202 Releases: main Change-Id: I7b0235d3013c84a6580397162de8f65dea212cda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78258 Tested-by:
-
- Mar 26, 2023
-
-
Nikita Hovratov authored
Just like other ViewHelper tests, the AssetCollector ViewHelper tests now utilize the RenderingContext and TemplateView to render a real Fluid snippet. The AssetCollector Singleton can now also be retrieved from the DI container. Resolves: #100290 Releases: main Change-Id: I22841b46061d9f1510bc2967545fe8773b1b2ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78245 Tested-by:
-
Thomas Hohn authored
Added a null coalescing operator around the access $item['lastMod']. Resolves: #100280 Releases: main, 11.5 Change-Id: Idd4de6d647198e10d87ec01d64fa685535ab59aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78241 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Stefan Froemken authored
Add an index to TYPO3 table be_dashboard to prevent FTS. Resolves: #100298 Releases: main Change-Id: I7da4f23047c61053e646c445399edf3eb2bc2d64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78254 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Stefan Froemken authored
Counting by column name has to check against null before. To speed up performance a little bit we switch to COUNT(*). Resolves: #100297 Releases: main Change-Id: Ia19e34852bea634de6447c198865a00ed3cb81a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78253 Reviewed-by:
-
- Mar 24, 2023
-
-
Jochen Roth authored
Currently, it is not possible to get the uid of a given task via cli. For ease of use, the command 'scheduler:list' has been added to list all available tasks or only a given group. On top of that another command called 'scheduler:execute' was added which provides a multi-select list where the user can choose which tasks or grouped tasks to run. Resolves: #100143 Releases: main Change-Id: I3a153daf26c6bab358f6930999c74178f60ab12b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78095 Tested-by:
-
Frank Naegler authored
A webhook is an automated message sent from one application to another via HTTP. Most modern web applications have the ability to communicate either via outgoing or incoming webhooks. This way of communication allows application users to integrate multiple systems without writing code (so-called no-code/low-code integrations). TYPO3 provides the incoming webhooks part via the system extension "reactions". This feature now allows configuring outgoing webhooks in the TYPO3 backend - completing the round trip. A new backend module is added called "Webhooks" where any administrative user can create a webhook. At its' core a webhook consists of a trigger (when something should happen) and a target URL (what should happen). Every time the webhook is triggered, an HTTP request is sent to the target URL. With this feature, the request can be either a POST or a GET request. POST requests commonly contain data, and GET requests can trigger actions in third-party systems. The webhooks extension provides various triggers as examples - for example a trigger when a page is created or updated, or a file is added or removed - however, additional triggers can be provided in the future and custom triggers can be written by extension authors and project developers. The backend module also enforces the setting of a secret for each webhook which can be used to verify that the webhook request originated from the TYPO3 system and its' payload has not been modified in the meantime. Under the hood, the webhooks extension uses the TYPO3 queue and therefore the Symfony messenger component, which provides a flexible and extensible way for handling messages either synchronously or asynchronously. Co-authored-by:
Oliver Bartsch <bo@cedev.de> Co-authored-by:
Susanne Moog <look@susi.dev> Co-authored-by:
-
Muhammad Suleman authored
It is now possible to define additional fields (subject, cc, bcc, body) to links to emails by default. This means, that in the link picker of the TYPO3 Backend, emails can now be filled with additional fields, and the TYPO3 Frontend renders the mailto link properly encoded. The <f:link.email> Fluid ViewHelper now also accepts the new properties: * subject * cc * bcc * body This change also fixes some problems with existing links with percent-encoded parameters (RFC 3986) (see tests). Resolves: #70276 Resolves: #84594 Releases: main Change-Id: Iaf0366927feb79c9bfa0319556569236409858fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77514 Tested-by:
-
Andreas Fernandez authored
Resolves: #100292 Related: #83580 Releases: main Change-Id: Ie3cf10bcb17645445ecc695912322ee1c76f5fef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78247 Tested-by:
-
Thomas Hohn authored
Fix spelling error. Resolves: #100287 Relates: #95769 Releases: main Change-Id: I5dfa77780409208cce30db09b33d441a85f5b7d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78244 Reviewed-by:
-
Alexander Nitsche authored
EXT:impexp may run into memory limits when converting XML to PHP arrays, even before all PHP memory is used up, because libxml has a specific limit of 10 MB. This limit can be turned off by using the `XML_PARSE_HUGE` (libxml) or `LIBXML_PARSEHUGE` (PHP) option, but only for the DOMDocument implementation of libxml, and not for the current XmlParser implementation. By replacing the XmlParser implementation with a DOMDocument implementation, larger XML files can be parsed with lower peak memory consumption as a side effect. For example, parsing a 4 MB dummy XML file consumes 56.03 MB (memory) / 168.72 MB (memory peak) with the XmlParser, while using DOMDocument reduces the consumption to 56.15 MB (memory) / 60.08 MB (memory peak). Besides the replacing of the implementation, XML parsing has been moved to separate classes (Typo3XmlSerializer / Typo3XmlParser), fully covered by tests, and restructured to reduce the number of required parameters to a minimum. The functional scope was not reduced in any way. Resolves: #83580 Releases: main, 11.5 Change-Id: Ic3345d539f028d766b49d01096ec34a6190a6dfe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70814 Reviewed-by:
-
Oliver Hader authored
When using Content-Security-Policy for `style-src` with a `nonce-...` value, it requires that inline styles (those using a `<style>` element) have to be granted with a corresponding `nonce="..."` attribute. Note: 'unsafe-inline' is ignored when using a nonce or hashes. This behavior is decribed in CSP L3 in section 6.7.3.2.:2.1 (https://w3c.github.io/webappsec-csp/#allow-all-inline) > If expression matches the nonce-source or hash-source grammar, > return "Does Not Allow". Even if `<style>` usages in lit-element templates are static in most cases, it is considered a "inline style" in the scope of CSP. This change introduces a work-around, exposing `window.litNonce` in the global JavaScript context. In case a malicous script manages to retrieve this information, it does not really matter, since the malicious script was already executed with a valid nonce before... Resolves: #100140 Releases: main Change-Id: I53c2967f2c80c0f862145a4c94d75a5fc1349205 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78231 Tested-by:
-
Sybille Peters authored
The class name is removed since it is not customary for ViewHelpers and can easily be derived from the ViewHelper name. A description is added. In particular, the TYPO3 AssetCollector is mentioned. More details are added after the example (so the developer can still easily see the example in a preview of the IDE). Also, the specific attributes for this element are mentioned because the automatically generated ViewHelper reference lists all attributes in alphabetical order and quite a few make no sense for the asset ViewHelpers. Resolves: #100285 Releases: main Change-Id: I17d5f72ca4de4ad4ce4f244de29a54e97eecb7ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78242 Reviewed-by:
-
Torben Hansen authored
The password reset feature for TYPO3 frontend users does now consider the configurable password policy introduced in #97388, if the new feature toggle `security.usePasswordPolicyForFrontendUsers` is active. Password validation configured through `plugin.tx_felogin_login.settings.passwordValidators` has been marked as deprecated. Additionally, the `getLanguageService` function in `AbstractPasswordValidator` has been adopted to support both backend and frontend context. Resolves: #97390 Releases: main Change-Id: I3ab6f8a2fb7301ce2c8f70e7819d06a627366e6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76445 Tested-by:
-
Benni Mack authored
Due to the removal of ExtJS in TYPO3 v8, the "last changed" column in the workspaces administration module was removed. It is now added back to the view. Resolves: #95769 Releases: main Change-Id: Ie485afdd3399ded7afbf22cdc2e30366db33984d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78238 Reviewed-by:
-
Benni Mack authored
Historically, some backend modules have complex namings. Since TYPO3 v12, we can define aliases, and use the new names to make them more understandable: * "help_AboutAbout" => "about" * "system_BeuserTxBeuser" => "backend_user_management" * "system_BeuserTxPermission" => "permissions_pages" * "file_FilelistList" => "media_management" * "web_RecyclerRecycler" => "recycler" * "web_ViewpageView" => "page_preview" In addition, various third-level modules have dropped their "web_" prefix (only added during v12 development) Resolves: #100279 Releases: main Change-Id: Ib9637448679bcdf2d308e45c4f89db7cd2df9d72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78221 Tested-by:
-
Georg Ringer authored
The scheduler submodule "Available scheduler commands" lists all registered scheduler commands. This list is now grouped by the extension name to improve readability. Additionally, cli commands that can be executed as scheduler commands are now listed as well. Minor drive-by changes are applied along the way. Resolves: #99436 Releases: main Change-Id: I879a7fcc7b1593054958cbd4419c13ff1b4b7ff5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77239 Tested-by:
-
Mario Lubenka authored
Many users forget their login username and try to login with their email address. The username of the backend user is now displayed in the password recovery email alongside the reset link. Resolves: #98517 Releases: main Change-Id: I23c48295928c69367257461e77c93f7566e23f08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75975 Reviewed-by:
-
Benni Mack authored
This change adds a new PSR-14 Event "LoginAttemptFailedEvent" instead of the legacy hook "$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['postLoginFailureProcessing']" which has now been deprecated. Resolves: #100278 Releases: main Change-Id: If0146d585c6af6fc38e30801db5bc5092c8f6d36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78237 Reviewed-by:
-
Lukas Niestroj authored
This patch adds keyboard support for selecting and deselecting options in Multiselect. This should lead into a more accessible behaviour in forms with TCA configurations like: selectMultipleSideBySide, group or folder. Resolves: #97667 Releases: main Change-Id: I732a3a54a7b8b8e7fd004434d1d03fb3386ecd25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77780 Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Nikita Hovratov authored
Oftentimes bool values are provided as integer in TCA. Therefore, a cast to bool is needed for invertStateDisplay. Note: Error might happen in itemsProcFunc for checkbox fields. Resolves: #100275 Related: #99739 Releases: main Change-Id: I14c2e798385250b40a7d4e4a73cbc157618a7a0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78234 Tested-by:
-
- Mar 23, 2023
-
-
Alexander Schnitzler authored
The ColumnMap only carried the propertyName to be queried by the DataMap (of a class) to have a key for its internal stack of ColumnMaps. The overall goal is to separate core (TCA columns) logic from Extbase (entity properties) logic. A ColumnMap should only describe the actual state of the TCA, prepared for Extbase to read but without enriched data from entities. Releases: main Resolves: #100274 Change-Id: Ife29d8dc89bdca07cb334095bd4048aaf8d6af9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78233 Tested-by:
-
Torben Hansen authored
This change fixes a typo in `FeLoginModeExtractionUpdate` Resolves: #100276 Releases: main Signed-off-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Christian Kuhn authored
phpunit 10 removed ->setMethods() on mocks. This is especially problematic with typo3/testing-framework, which provides ->getAccessibleMock(). The scope of this API is to "open up" sub methods of a class, to check if they are called with this-or-that argument, and to return some value as mock, while keeping other parts of the mocked class as-is. TF ->getAccessibleMock() will have to change from using ->setMethods() for phpunit 10 support. It will switch to ->onlyMethods() instead. The difference between setMethods() and onlyMethods() is, that onlyMethods() throws an exception if a method to-be-mocked method does not exist, while setMethods() did not do that. We do *not* want to implement some API within TF ->getAccessibleMock() (and friends) to check if some method actually exists in a to-mock class, we'll switch to onlyMethods() and will avoid additional magic that would be potentially available using ->addMethods(). As such, we need to get rid of all calls within the TYPO3 core that try to create mocks of methods that don't exist. There are a couple of hard nuts. This patch solves the easy cases, more complicated use cases will be sorted out with dedicated patches. Strategy with this patch: * Use 'null' instead of ['dummy'] to mock no method and only have an accessible proxy. 'dummy' has been used a lot in the past, has been removed a lot already, but left overs need to be removed now. * Avoid mocking methods in tests that have been removed meanwhile. That part is the good thing of phpunit 10: It forces tests to keep up with the system under test in case it removed methods, so we don't end up with dead method mocks. Resolves: #100273 Related: #100249 Change-Id: If93ec4b87fdad15954ba0c17d868cd8f1165d372 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78223 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Benjamin Kott authored
Releases: main Resolves: #100269 Change-Id: I396c78d8ee699457c9b000da895eef7b4bbe3424 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78227 Tested-by:
-
Alexander Schnitzler authored
That property always held string "pid" if TCA for the defined foreign_table exists. This field is only evaluated at one place in the Backend class, when persisting new rows into foreign_table. Therefore, ColumnMap does not need to carry around said value. Releases: main Resolves: #100271 Change-Id: I263c1d4e5b6676ceeb46621fdaf2be37169c805c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78229 Tested-by:
-
Christian Kuhn authored
phpunit ^10 expects test data providers to be static. Using rector rule StaticDataProviderClassMethodRector, this bulk change adapts most of them in typo3/sysext/*/Tests/Unit. A couple of data providers use $this, those are left out for now and need to be adapted with dedicated patches since they need more refactoring. Resolves: #100264 Related: #100249 Releases: main Change-Id: I89243d5467cadfde04efe61f24e2ce568e828c6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78222 Reviewed-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #100261 Change-Id: I3d88b19b5965ef0ce6f9594d9d0c59a241eb0151 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78217 Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #100266 Releases: main Change-Id: I46ecde712133e57b79989a8a841f05039ddcc9ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78225 Reviewed-by:
-
