- Jul 05, 2023
-
-
Josef Glatz authored
Streamline total amount text for backend groups and backend user listing. Also correct wording is applied, depending on the number of records displayed. Resolves: #99966 Releases: main, 12.4 Change-Id: Ie96dfc1148d4eafcc4418b7187645bf4831262f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79736 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Oliver Bartsch authored
Resolves: #101238 Releases: main, 12.4 Change-Id: I3ff0ea07c5b4121d3b585215b13b4834de7838b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79735 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Stefan Bürk authored
`ext:redirects` allowed to redirect to absolute target path. With #97159 the target field TCA type has changed and did not allowed to enter a path identifier since then. This change lets the `LinkService` resolve a path identifier not matching a file or folder as type `URL` and restore the ability to create path based redirect target links. Additionally, it's now possible again to link directly `/` again in link fields or RTE fields (#97693). The underlying solution is that "old-school" links to files (before FAL) to e.g. "fileadmin/mydownload.exe" is now actually treated as an external URL, and not as a automatically detected file anymore. Resolves: #101083 Resolves: #97693 Related: #97159 Releases: main, 12.4 Change-Id: Ib6a1503137b1c424c55aa3785f6c5d260b5a3aad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79734 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Elias Häußler authored
The `PageErrorHandlerInterface` is often implemented in case a custom error handler is used in site configuration. Static code analysis may complain about missing iterable types in implementations. Thus, we now provide the iterable types to ease the implementation effort in TYPO3 projects. Resolves: #100004 Releases: main, 12.4 Change-Id: I9734ce09c091f6d0e6f68d19019e8d77d1ffc685 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79733 Tested-by:
-
Benni Mack authored
When a link href is empty or invalid, TYPO3 now does not crash anymore. Resolves: #100958 Releases: main, 12.4 Change-Id: I768d43b72a3abd55af06cd9750ac8a400bc41d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79732 Reviewed-by:
-
Florian Schöppe authored
Added tests for: - indexing contents and words - a basic search - metaphone search Resolves: #97732 Releases: main, 12.4 Change-Id: Id56e09f129de4bd13092f584e97eedc9fd326b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79691 Tested-by:
-
Susanne Moog authored
The cache identifier for file mounts only consisted of storage id and path. In rare cases (with same name file mounts with different read-only settings) this lead to rendering an arbitrary folder instead of the mount with the "higher" access rights. The read_only field is now taken into account when generating the runtime cache identifier. The file module already takes care of using the write file mount if both read-only and not read-only exist. Resolves: #99103 Releases: main, 12.4 Change-Id: If4c62b6e0dd8fd5a8e6e8581b072a4f22e27f075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79690 Tested-by:
-
Stefan Bürk authored
Creating redirects for `SysFolder`,`Spacer` and `Recycler` on slug changes does not make sense as they are not reachable in the frontend. Updating child pages if they start with the orignal slug however is a wanted behaviour following the normal page type behaviour. Resolves: #99624 Releases: main, 12.4 Change-Id: I8c93c9ceb858c0e0c0eda32ae8f6c58af652b7e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79695 Reviewed-by:
-
Thomas Hohn authored
The following classes were marked as @internal in TYPO3 11 since the feature was experimental. This should have been removed with TYPO3 12. The @internal has now been removed for: \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderInterface \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderPropertyManager \TYPO3\CMS\Core\Authentication\Mfa\MfaViewType Resolves: #101237 Related: #100224 Related: #93526 Releases: main, 12.4, 11.5 Change-Id: Iad9b3337a595c2ee1b9162f4cd1463d3c45881f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79715 Tested-by:
-
Stig Nørgaard Færch authored
This makes the groupHomePath and userHomePath features available again. Releases: main, 12.4 Resolves: #101188 Change-Id: I2d3ebc283b4ed72f0e2885c203c0ad2123c9a357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79687 Tested-by:
-
Andreas Nedbal authored
Prepared nodes were not properly handled in the category element, causing the indetermination state recalculation to never trigger properly. Using the nodes from the nodes-prepared event fixes this issue. Resolves: #98689 Releases: main, 12.4, 11.5 Change-Id: I63f9618c596cdad343d4af8393120eabae3fdbd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79688 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
- Jul 04, 2023
-
-
Oliver Hader authored
VariableProcessor::addHash() is called to convert URI path variables that don't comply with certain rules to a hash, which does. First of all, variables must not exceed a certain length of 32, second of all, variables must only contain word characters aka "\w" or "[A-Za-z0-9_]". So whenever a variable is too long or contains invalid characters, it is converted to an md5 hash which complies with both rules. It has been reported that the checks, whether to generate a hash and the hashing would have a very noticable performance impact. This change introduces as specific runtime cache for VariableProcessor that is shared with any other new instance. This way, the necessity whether a hash is required and the hash representation of a value can be resolved from this cache. For instance, this would speed up scenarios that are enerating large product lists and generate, when every invocation with a new UID would have triggered a new hash check and assignment. Resolves: #100974 Releases: main, 12.4 Change-Id: I19e1d138a79792cc05a6a908f1ee5f87236a65bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79710 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christian Eßl authored
The new save notification currently lists all changes separately, when editing records in EditDocumentController. This leads to a huge notification box, when saving many records at once. The behaviour is now changed so that if more than 10 records were edited, a more generic message is shown instead: "x records have been successfully saved." Resolves: #100223 Releases: main, 12.4 Change-Id: Ic3db6a1937de8eb288a7ded0bce3e1a88f10cb1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79686 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
Oliver Bartsch authored
Maintaining the "disallowed" list in TCA for type=file previously was only respected in the DataHandler but the restriction was not displayed neither in FormEngine nor in the FileBrowser. Additionally, the file extension filter did not restrict available files to select and the list was also not used by the DragUploader. All those places are now unified. Resolves: #101231 Releases: main, 12.4 Change-Id: Iab187e8d9787469016e2110306e35ae4192f6323 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79709 Reviewed-by:
-
Jochen Roth authored
This adds missing form engine inline language labels, used e.g. for the "unsaved changes" modal. Resolves: #98718 Releases: main, 12.4 Change-Id: Ifb8964bf40b8cc410cb46c36fc82c6d4572a05ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79685 Tested-by:
-
Krzysztof Gutkowski authored
Currently, when switching the 'Show fluid debug output' in AdminPanel, the relevant frontend caches weren't flushed, causing pages to be rendered using the old ViewHelper namespace configuration, so that the debug viewhelpers weren't added/removed, depending on the value. This commit makes the caches get flushed when the option is changed. Resolves: #99883 Releases: main, 12.4 Change-Id: I495d678bce2128f538b46f79485fdab67581a29f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79684 Reviewed-by:
-
Andreas Nedbal authored
The hint when changing a slug previously was a combination of utility classes and with color changes in a recent Bootstrap version, it became barely readable. Resolves: #101222 Releases: main, 12.4 Change-Id: I594c995f23c99d81b0d5e2d619e63f811c36576a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79683 Tested-by:
-
Manuel Glauser authored
Rendering image '<source>' elements using the IMAGE content object (layoutKey 'picture') no longer have the document root path prepended in the 'srcset' attribute. Resolves: #100867 Related: #95379 Releases: main, 12.4 Change-Id: Id49b0f9a41dd9760e25fc17386cae805f66083e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79682 Tested-by:
-
Tim Horstmann authored
Additionally switch $nextActive to boolean Resolves: #100995 Releases: main, 12.4 Change-Id: I0e41835f42753595480afb16182c446991157ec2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79681 Tested-by:
-
Stefan Bürk authored
With #89091 pages with slugs containing trailing slash have been enabled to be resolved when requested with trailing slash in the request uri and have been a logical follow-up of #86055. In between an issue with language fallback chain have been found, which allowed that a valid translated page could be resolved with the default language slug even and reported as #88715 and #96010. These issues have been solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75101 which partly broke the original implemented behaviour for pages with trailing slash slugs requested without a trailing slash. This change now ensures pages are resolved containing a trailing slash in their "slug" like "/my-page/subpage/" if requested without the trailing slash like "https://domain.tld/my-page/subpage". Additionally, tests are added to cover this case along with other possible cases. This should detect future regressions. The docblock return annotation for `PageRouter::matchRequest()` is changed to the correct returned value, removing ignore pattern for the phpstan baseline instead of increasing the counter. Note: This change ensures that a page can be resolved in any constellation with trailing slash in record slug/not in record slug and requested with trailing slash/not requested slug. In both cases, already working and the now fixed variant are serving both potential duplicate content - if no correct cannonical url is provided. Tackling the duplicate issue should be done in a dedicated change for both cases. Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100990 Related: #96010 Related: #88715 Related: #89091 Related: #86055 Releases: main, 12.4, 11.5 Change-Id: I9f26c4500e2f812e8727b4b565570fcc579bf3e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79679 Tested-by:
-
Torben Hansen authored
With #100255 it has been ensured, that the translate ViewHelper uses the site language locale. For backend context, the locale is resolved from `$GLOBALS['BE_USER']->user['lang']`. In case of the backend login or password reset form , the evaluated preferred browser language is however not set to the global `BE_USER` object, when no user is logged in. As a result, some labels in the fluid views are always rendered in the default language. This change sets the preferred browser language to the `BE_USER` object in the backend login controller and the reset password controller, when no backend user is logged in, so label translation is now consistent again. Resolves: #101166 Related: #100255 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: If3ba886c4e8be19990c45cc48c7001a128535f25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79678 Reviewed-by:
-
Daniel Siepmann authored
Some checks might return a message why images can't be generated. Those checks didn't return success which prevents processing by JavaScript, leading to endless "Loading" state within UI. All responses now properly return success = true in order to be processed by JavaScript. Resolves: #100893 Releases: main, 12.4 Change-Id: I720893a0b01a26a7b77bdcb16c02295eed3ae595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79680 Tested-by:
-
Alexander Schnitzler authored
ObjectAccess::getGettablePropertyNames() has quite the history by now. It used to be quite simple, an is_callable() check for getters/hassers and issers of objects. That didn't account for methods with mandatory method arguments which was fixed by using reflection. Because runtime reflection is slow, the usage of cached reflection (ClassSchema) had been introduced. But, during that change, symfony/property-access had also been introduces, which contradicts the idea of performance gain because: - symfony/property-access also uses uncached reflection - symfony/property-access actually calls the accessors under test As both is undesirable, the usage of symfony/property-access has been removed again. Releases: main, 12.4, 11.5 Resolves: #101176 Change-Id: I2bc796ebeaf2f1357fd3154b711910c6f553f4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79675 Tested-by:
-
Georg Ringer authored
The deleted records should be sorted by the timestamp descending instead of by the uid ascending because in most cases one of the recently deleted records should be restored. In addition, a comparison is fixed as a drive-by change to have compatible types. Resolves: #100252 Releases: main, 12.4 Change-Id: I67ce8134ea498782b476381716559e92f9867059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79677 Reviewed-by:
-
Oliver Bartsch authored
Since #97330, a form engine elements label might not be represented by a <label> tag, but by using a <legend> tag. This patch now ensures that those elements are also correctly considered within form engine validation. Resolves: #101221 Related: #97330 Releases: main, 12.4 Change-Id: Iac4ef9b198bd7a7b8c75e53b83e45117be348c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79636 Reviewed-by:
-
Oliver Bartsch authored
The markup is adjusted to make the "parallel execution" checkbox in the scheduler module edit view working again. Additionally, the checkbox is only displayed for recuring tasks, because it's always set to FALSE for tasks with single execution. Resolves: #101146 Releases: main, 12.4 Change-Id: I0bc595683565ab099ca2a78f7a0aaf1480255a8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79674 Tested-by:
-
Guillaume Germain authored
Use array chunked query combined with direct value list to retrieve full data set in `DataMapProcessor` methods `fetchTranslationValues` and `fetchDependentElements`. Resolves: #99326 Releases: main, 12.4, 11.5 Change-Id: Iaf220014cd991002450779197169c5c32a3c7dbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79673 Tested-by:
-
Benni Mack authored
This change also adds some basic tests for MediaViewHelper Resolves: #100929 Resolves: #99122 Releases: main, 12.4 Change-Id: Ie5d086efe605845f70f55e647c4edb87d03eba6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79638 Reviewed-by:
-
Nikita Hovratov authored
Since the swap to LinkResult, the ATagParams and some more attributes are cached independent of different configuration. This is now fixed by adding the following configuration options to the md5 hash: - TMENUITEM: ATagParams - TMENUITEM: additionalParams - TMENU: addParams - TMENU: target Note: Doing this weakens the usefulness of the runtime cache again (especially for old-school TypoScript based menus). Another option would be to add the attributes after the LinkResult generation (how it was done before), but this would bypass possible Event manipulation. Resolves: #100319 Related: #96486 Releases: main, 12.4 Change-Id: I8a0346b5b932f071f9498ddccd7ecceca39deed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79672 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Benni Mack authored
This way, it works in CLI mode as well. Resolves: #100745 Releases: main, 12.4 Change-Id: Idc00323c012bd3c7f6816b6431ed91c44da50605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79637 Reviewed-by:
-
- Jul 03, 2023
-
-
Oliver Bartsch authored
Resolves: #101194 Releases: main, 12.4, 11.5 Change-Id: I431e0af6b35d85aed0a3834c16b9f75c2923bfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79634 Tested-by:
-
Benni Mack authored
Resolves: #100538 Releases: main, 12.4, 11.5 Change-Id: Ia0e37a39ed566938a9b9f947ad21949a9ab3b0bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79550 Reviewed-by:
-
Andreas Fernandez authored
This change updates ckeditor5 to version 38.1. See [1] for detailed information. Executed commands: npm i --save \ @ckeditor/ckeditor5-alignment@^38.1.0 \ @ckeditor/ckeditor5-autoformat@^38.1.0 \ @ckeditor/ckeditor5-basic-styles@^38.1.0 \ @ckeditor/ckeditor5-block-quote@^38.1.0 \ @ckeditor/ckeditor5-clipboard@^38.1.0 \ @ckeditor/ckeditor5-code-block@^38.1.0 \ @ckeditor/ckeditor5-core@^38.1.0 \ @ckeditor/ckeditor5-dev-utils@^38.0.4 \ @ckeditor/ckeditor5-editor-classic@^38.1.0 \ @ckeditor/ckeditor5-engine@^38.1.0 \ @ckeditor/ckeditor5-essentials@^38.1.0 \ @ckeditor/ckeditor5-find-and-replace@^38.1.0 \ @ckeditor/ckeditor5-heading@^38.1.0 \ @ckeditor/ckeditor5-horizontal-line@^38.1.0 \ @ckeditor/ckeditor5-html-support@^38.1.0 \ @ckeditor/ckeditor5-indent@^38.1.0 \ @ckeditor/ckeditor5-link@^38.1.0 \ @ckeditor/ckeditor5-list@^38.1.0 \ @ckeditor/ckeditor5-paragraph@^38.1.0 \ @ckeditor/ckeditor5-paste-from-office@^38.1.0 \ @ckeditor/ckeditor5-remove-format@^38.1.0 \ @ckeditor/ckeditor5-source-editing@^38.1.0 \ @ckeditor/ckeditor5-special-characters@^38.1.0 \ @ckeditor/ckeditor5-style@^38.1.0 \ @ckeditor/ckeditor5-table@^38.1.0 \ @ckeditor/ckeditor5-theme-lark@^38.1.0 \ @ckeditor/ckeditor5-ui@^38.1.0 \ @ckeditor/ckeditor5-undo@^38.1.0 \ @ckeditor/ckeditor5-utils@^38.1.0 \ @ckeditor/ckeditor5-word-count@^38.1.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0 Resolves: #101223 Releases: main, 12.4 Change-Id: I5653cc0fb217dfa9bb2301c5a985aca953fc4d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79633 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Fernandez authored
With the dismissal of jQuery and jQuery UI from the image manipulation component, the event handling for the trigger button ("Open Editor") got borked as the event state toggling previously done via `.off(...).on(...)` was replaced with using a `signal` as documented at [1]. The `AbortController` instance is only built when the modal has been fully shown, way after the event handling took place, breaking the module's global state. To solve this issue we removed the `AbortController` and its usages again. Also, `initializeTrigger()` now uses event delegation to register the event handler on the trigger buttons. As a drive-by fixes, the `active` state of the ratio buttons is now properly toggled, and the ratio title field is correctly updated by comparing with the scoped `ratioTitleWindow.HTMLElement` prototype. [1] https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#add_an_abortable_listener Resolves: #101150 Resolves: #101199 Related: #100948 Releases: main, 12.4 Change-Id: I021c74bb67976468ebdc5226263c6441796bd65b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79632 Tested-by: -
Benni Mack authored
This change prevents a PHP warning in ContentObjectRenderer when working with "max" and "begin". Resolves: #100857 Releases: main, 12.4, 11.5 Change-Id: I1af115deecc537efdc41125daa119630d6449044 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79548 Tested-by:
-
Benni Mack authored
When editing in FormEngine the popup now has a larger size, corresponding to up-to-date displays and devices. Resolves: #99383 Releases: main, 12.4 Change-Id: I0638d42b0b4018aba1093cca5f816e91bf86e471 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79546 Tested-by:
-
Andreas Nedbal authored
This change in the Rollup configuration caused the window namespace to disappear, breaking the JS call in the process. Resolves: #101202 Releases: main, 12.4 Change-Id: Ie216d7d91502436b68c6404b0c81268ce0f5672e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79547 Tested-by:
-
Torben Hansen authored
This change moves the section about "Access restrictions on the felogin plugin" to the user manual, since the section is not an example, but an important notice for users of the plugin. The part about having two plugins on one page has been removed, since this will lead to other problems as noted in the "Known problems" chapter. Additionally, a short notice about the "Hide at login" problem has been added to the "Known problems" chapter. Resolves: #100632 Releases: main, 12.4, 11.5 Signed-off-by:
-
Benni Mack authored
The site language's configuration setting "hreflang" was deprecated with #99908, however, it still serves a valid purpose. If working with EXT:seo and the <link rel="alternate"> tags, it is still valid and possible to set a specific "hreflang" attribute. Example setups: * You have "German (Germany)" (which is using de-DE as locale) and "German (Austria)" (which is using de-AT as locale). here you want to set "de" as generic fallback in the "de-DE" locale when using hreflang attributes. * You want to explicitly set "x-default" for a specific language, which is clearly not a valid language key. This change does the following: * It re-adds the hreflang property to be managed by the UI, however it is empty by default and will fallback to the $locale->getName(). * It is not used within the <html lang="..."> attribute anymore as this was a mis-use in the first place (and now properly using just the language key, see https://www.w3.org/International/questions/qa-html-language-declarations.en.html#attributes * The method "SiteLanguage->getHrefLang()" is not deprecated anymore. * The RST is adapted accordingly Still, the relevant information is: The site language configuration option "hreflang" is not relevant anymore for regular websites without rendering hreflang tags, but is now customizable, and has a proper fallback. Resolves: #101160 Resolves: #95798 Related: #99908 Releases: main, 12.4 Change-Id: Ifc5b5b10ba46b4da4abd5c504d4d69f240f2fd02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79545 Reviewed-by:
-
Susanne Moog authored
As LC_NUMERIC is not set via Locales::setLocale because conflicts on float calculation may occur, we have to manually set LC_NUMERIC in places where we need the locale aware numeric functionality. In the core this is only formatSize - which missed the LC_NUMERIC handling since the switch to SiteConfiguration. With this patch, the handling is reintroduced by using the locale set by setLocale for LC_MONETARY to temporarily set LC_NUMERIC in formatSize. Resolves: #101211 Releases: main, 12.4 Change-Id: Id694f04fb07fb421644fa87c415d786ca11bcfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79542 Tested-by:
-
