- Sep 18, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92258 Change-Id: Ifb2a7a9879e4e6d826137567a5224adef33eadc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65678 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Daniel Windloff authored
Merge the methods `init()` and `main()` to the `mainAction()` method. Remove unnecessary properties, which were only used to transfer values between these methods. Initialize `siteLanguages` with the current page uid. Releases: master Resolves: #92308 Resolves: #90966 Change-Id: Iafd45ebeb06e8c61dac9e9ed865e40bc999ab54a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65739 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Daniel Windloff authored
Use `editContentPermissionIsGranted()` to calculate the permission to cut records (except pages). Releases: master Related: #89465 Resolves: #92307 Change-Id: I387c486c3814c3e5b6f4959d6c725ff59562c32e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65736 Tested-by:
-
Uwe Trotzek authored
When a users sends a draft version to another stage a modal opens to let the user decide which users should be notified about this. This patch ensures that only the selected persons will get an email. Prior to this only the last user of the list got an e-mail. Resolves: #92316 Change-Id: Ia4014878f6b30a3773b5d38e01d5379094394c32 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65746 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Bartsch authored
Add possibility to use language labels as value for the user TSconfig `options.bookmarkGroups` option. Resolves: #15760 Resolves: #92337 Releases: master Change-Id: I0e0e2467b8ab87b05ec432f09d65abc676081228 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65764 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Reviewed-by:
-
Benni Mack authored
In order to ensure PHP 8 compatibility, PHP methods should not have optional arguments BEFORE required arguments. Resolves: #92140 Releases: master Change-Id: Ia9ee2ba12af0301d7bf2a0defbe6ad64674c1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65742 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
The fluid based page module used a non existing variable to access the language id of a column. This lead to passing `NaN` as language id to the DataHandler when moving a content element in the corresponding column. Therefore the content element was actually moved to the default column because of the changed language. The template is now accessing the correct variable fetched from the SiteLanguage object which makes moving content on translated pages possible again. Resolves: #92086 Releases: master, 10.4 Change-Id: I6fb95338e47e9ad5b0a3f637f6b637174271ba35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65691 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Oliver Bartsch authored
To not falsely show content as "unused" if not translated yet, content fetcher must respect the language, selected for columns mode, in the fluid based page module. Resolves: #91350 Releases: master, 10.4 Change-Id: If0abbc4572706c54d9b8bdc18b4bc02d0ec3240b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64507 Tested-by:
-
Benni Mack authored
Since the removal of "pid=-1" in TYPO3 v10, it is not necessary to fix the versioning PID for all versioned records anymore. The checks in BackendUtility::fixVersioningPid() and PageRepository->fixVersioningPid() are cleaned up, because: * The only version type that has a DIFFERENT page ID than its online pendant is the MOVE_POINTER (t3ver_state=4) * The MOVE_PLACEHOLDER does not contain a t3ver_oid and is not evaluated ever in these methods * All other t3ver_state items have the same PID as the live version, and should not be evaluated. Resolves: #92314 Releases: master, 10.4 Change-Id: I0551547bd2bb9f469ed3a68396b74c0d4de1a18d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65705 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Christian Kuhn authored
There are 4 "drop record" scenarios in workspaces: * Delete a new or changed record in list/page module * Create a delete placeholder in list/page module to mark a live record as to-be-deleted on workspace publish * Discard (throw away) a change in workspace module * Flush all workspace changes by deleting a sys_workspace record. All these scenarios are handled with the same DataHandler code which leads to tons of bugs since especially "delete & create delete placeholder" compared to "discard & flush" are logically different things. The patch separates discard and flush to a new codebase. First patch sets started with a 1:1 copy of the delete code, then carefully refactored the code to its final state. The roughly 850 lines of delete code are streamlined to about 300 lines for discard and flush. The code is much easier to follow, recursions are simplified and access checks are in one place. Discard previously created a mixture of hard and soft deleted records in the database, leading to a huge mess. This changed: Discard now always means that records are dropped from database. The discard code now properly cascades down into relations, solving tons of bugs along the way. The functional DataHandler tests are refactored and heavily extended to cover discard. Two previously existing issues are not fixed yet: ManyToMany relations are not properly cleaned up on discard, and discarding does not fully follow localization overlays in 'connected' mode. Those scenarios are marked with @todo's in the .csv files and should be relatively easy to solve with dedicated single patches. Change-Id: Ie33dd2bdc333a4d8ed9314b7520212cc11942c89 Resolves: #85778 Resolves: #92336 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65638 Tested-by:
-
Oliver Bartsch authored
All FAL tags must be uppercase as otherwise they are suggested multiple times in the View Upgrade Documentation module. Resolves: #92342 Releases: master, 10.4 Change-Id: Ib86882151ccf19a40204e882eef3dca8c977244e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65765 Tested-by:
-
Frank Naegler authored
The existing console command can also be executed as a scheduler task, for this reason, we remove the scheduler task. Resolves: #92339 Releated: #91712 Releases: master Change-Id: Iab9d855360bf022a91e93b668ade912968844f62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65760 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92266 Change-Id: I3668e18896478da791e606f240ed321f65d50e7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65672 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Anja Leichsenring authored
used commands: composer remove rector/rector --no-update-with-dependencies The groundwork to use rector as a integrity check is not yet done. In order to remove a dependency from the set, the package is removed. Resolves: #92332 Related: #89785 Releases: master, 10.4 Change-Id: I7b965c9826dc45bb8409d4460e9dcb071aa83c68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65750 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
-
Nikita Hovratov authored
The toggleContainerControls method of InlineControlContainer.ts now only toggles its immediate controls. Furthermore, the new record link control for creating inline records has gotten the required class to toggle its visibility, when reaching maxitems limit. Resolves: #91808 Releases: master, 10.4 Change-Id: Ic8988943c349c874b6d9b7427a42c224dca1ded1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65058 Tested-by:
-
- Sep 17, 2020
-
-
Benni Mack authored
The database fields "be_users.options" ("Mount from groups") and "be_users.workspace_perms" (Allow editing on live workspace) use the Page Permission class for checks, which is semantically incorrect. The patch adapts the according changes in BackendUserAuthentication. Resolves: #92208 Releases: master Change-Id: Iec805fbc3ff3a72cfcdbdb67e6868c4389e8e688 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65586 Tested-by: -
Alexander Schnitzler authored
While introducing symfony/property-access, method isPropertyGettable of class ObjectAccess had been adjusted in a manner which made the mixed usage of array access and regular property access impossible. If an object implemented ArrayAccess and used regular properties, all of those properties were reported inacessible/non-gettable which is not true. With this patch, regular properties and those defined magically via ArrayAccess are detected correctly as gettable. Releases: master, 10.4 Resolves: #91784 Change-Id: If523943f679beabf40ad5d71c0e0d1d0fef8db4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65234 Tested-by:
-
Georg Ringer authored
Resolves: #92327 Releases: master, 10.4 Change-Id: I375f8002ef1a57a5653a17691bd258c2ea971ec7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65753 Tested-by:
-
Ingo Fabbri authored
A varchar length of 30 seems not enough for uncommon search words. This limit gets hit quite frequently - especially when the word contains one or multiple UTF-8 escape sequences. Increase it to allow up to 50 characters - keep safe with index length. Resolves: #92323 Releases: master, 10.4, 9.5 Change-Id: Ie2a27bedd1a45f21cbf92d244b3df395fb2b2423 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65747 Reviewed-by:
Bernhard Berger <bernhard.berger@gmail.com> Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Reviewed-by:
-
Daniel Windloff authored
The classes `firstcol` and `lastcol` for the first and last row of a table were not used anymore. Therefore, they have been removed. As the property `totalRowCount` was only used to set the class `lastcol`, it also has been removed. Releases: master Resolves: #92302 Change-Id: I12873b4604a165743a83019a123a72eb75b039a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65732 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Benni Mack authored
The methods * BackendUtility::versioningPlaceholderClause() * BackendUtility::getWorkspaceWhereClause() can be removed, as this is all done via Doctrine DBAL Restrictions. Resolves: #92315 Releases: master Change-Id: I5e90b63514b326900a472ab14260b7706c13b3fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65745 Tested-by:
-
- Sep 16, 2020
-
-
Benni Mack authored
This change introduces functional tests for the rootline utility. For now, this patch ensures the validity of Workspace Overlays when reading a given page tree / rootline. Covered tests: * Live workspace (no overlays) * New record in workspace * Modified record in workspace * Deleted record in workspace * Moved record in workspace Adding such a test class helps to extend coverage for language overlays and MountPoints in conjunction with workspaces in the future. Resolves: #92311 Releases: master, 10.4 Change-Id: Ie8a746253e4b10f98c05a448d736a5d00d59d3fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65741 Tested-by:
-
Georg Ringer authored
Since #83461 the name of the field is rendered next to the label for administrator users if debug mode is enabled. Now also the name of flexform fields is rendered. Resolves: #92283 Releases: master, 10.4 Change-Id: I90f7452808f08f5cbf77713f3416a4a1c02b1e6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65738 Tested-by:
-
- Sep 15, 2020
-
-
Simon Gilli authored
Since the change of platform.php in the composer.json to 7.2.5 according to Symfony 5.x composer does not install the lowest dependencies for sure. This patch enforces the change of the platform before running composer update --prefer-lowest Resolves: #92251 Releases: master, 10.4, 9.5 Change-Id: I6b0fce76a2995c39215caf04d355154c87cfe3fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65692 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Georg Ringer authored
The field ´filelink_sorting` of the DB table tt_content contains the sorting field. Its size should be set to 64 characters to be able to use any column name for sorting. Resolves: #92294 Releases: master, 10.4 Change-Id: Iea9f7fcc42902222f6ea2683483bb4bddf5d25e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65737 Tested-by:
-
Benni Mack authored
In contrast to the actual documentation in the code, when using RDBMS native DATE / TIME / DATETIME fields, the RDBMS does not adjust these field's values for time zone. Independent of the actual time zone the DMBS (or the current session) is using, the data is stored and retrieved "as is". The only thing that matters is the TZ of PHP, which must be identical for storing and retrieving the data, otherwise data is modified. TYPO3 works just fine like that in Backend, however Extbase' DataMapper considered the timezone of these fields as "UTC-stored", which is wrong. This patch corrects this behaviour to match the rest of the Core. Resolves: #91240 Releases: master Change-Id: Idb8e0a6f241aa0ed4e8d4a66129b58e34b9b3292 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64053 Tested-by:
Thorben Kapp <thorben@webcoast.dk> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Sep 14, 2020
-
-
Alexander Künzl authored
Extracts CSS path fixing functionality of ResourceCompressor to a separate class in order to be used in other contexts. PageRenderer uses the new object. Resolves: #91935 Releases: master, 10.4 Change-Id: Icba71dcd0ceb110fb2398b2839310fb1952d0601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65395 Tested-by:
-
- Sep 12, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92110 Change-Id: I41e6959173e28db5aaa2310c5956296fdd8e4525 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65685 Tested-by:
-
- Sep 11, 2020
-
-
Benni Mack authored
Due to the removal of branch-based versioning in TYPO3 v8, there are two methods that can be removed now (as they have been marked as internal in TYPO3 v10). * BackendUserAuthentication->workspaceAllowLiveRecordsInPID * BackendUserAuthentication->workspaceCreateNewRecord Resolves: #92290 Releases: master Change-Id: I634fd509847c29b17ad0c9f366557f34222bd5dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65702 Tested-by:
-
Benni Mack authored
Since "pid=-1" is gone in TYPO3 v10, the "_REAL_PID" value is not needed anymore and can be removed in Workspace-related code. Resolves: #92291 Releases: master Change-Id: Iad882f43f7a07015af65eecd516bc983ae98ce5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65703 Tested-by:
-
Benjamin Franzke authored
Resolves: #92250 Releases: master, 10.4 Change-Id: Ia9e0caefa6d5b4e198f4af80f97e96117a583dc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65689 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92260 Change-Id: I9d0a9e546f0de5d12cf5dfdc4fe4c64550407e4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65655 Tested-by:
-
Torben Hansen authored
The workaround in AbstractUserAuthentication targets versions of Internet Explorer 6, which are not supported by TYPO3 nor by Microsoft any more. Resolves: #91992 Releases: master Change-Id: I93007efbbaf044922e8d916a7552b9e1bea4ee96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65312 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Benni Mack authored
The option $TYPO3_CONF_VARS[SYS][cookieSecure] is removed in favor of always setting a secure cookie on HTTPS requests. This leads to errors when a page would be available in HTTP and HTTPS which is normally not the case when using a full site base in Site Handling anymore, and making TYPO3 more secure out-of-the-box. Resolves: #87301 Releases: master Change-Id: Iba90c19456af6a82feb9c53fea52228fbff516be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65695 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Resolves: #92267 Releases: master, 10.4 Change-Id: I2bc6a6ee2f97c880dd370cae08b2ac74a988ff1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65662 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92269 Change-Id: If10d8b49d817e23f5b35dc02d641a398983db78e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65659 Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92254 Change-Id: I3c5d0625a497acd10696b8ce6ea58a9fa891bc18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65671 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92255 Change-Id: Ib00584487fe1e963c3fd13e3284fd372bc0c4752 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65683 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92252 Change-Id: I2026aa5a66851f4734a15348cb0a14931773ed06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65677 Tested-by:
-
Frank Naegler authored
A new scheduler task and CLI command to clean up existing redirects periodically under given conditions are added with this patch. Resolves: #91712 Releases: master Change-Id: Ib07145eac700fb4af1ba59589a09987c55f221ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64939 Tested-by:
-
