- Jan 13, 2017
-
-
Ralf Zimmermann authored
https://review.typo3.org/#/c/50285/ breaks the ext:form backend modul. Remove "class" tag attributes from flashMessages viewHelper tags. Resolves: #79306 Releases: master Change-Id: I753cc5bf4deabfa824179c5e025044c65df4e069 Reviewed-on: https://review.typo3.org/51303 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
Adding SSL support on a per-page basis is something that does not happen very much in 2017 anymore, rather doing this on a per-domain basis, and based on server-redirects makes more sense these days. The field and the functionality for links is moved to EXT:compatibility7. Resolves: #79302 Releases: master Change-Id: I7ae1c59533bee1d015b39811f39d590e5488aabe Reviewed-on: https://review.typo3.org/51077 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jan 12, 2017
-
-
Benni Mack authored
The option transformBoldAndItalicTags is there to convert <i> and <b> tags from the DB to <strong> and <em> for the RTE. When saving, all tags are converted back to <i> and <b> before storing the content in the database again. This is actually a (weird) shortcut due to historical reasons, and can easily be set up by the HTMLparser directly using the tags.[tagname].remap = [newtagname]. This syntax can be used directly to enable this functionality again RTE.default.proc { # make <strong> and <em> tags when sending to the RTE HTMLparser_rte { tags { b.remap = strong i.remap = em } } # make <b> and <i> tags when sending to the DB HTMLparser_db { tags { strong.remap = B em.remap = I } } } The option is removed and the explicit (and IMHO more understandable) syntax is used in the RTE configuration of HTMLArea. If the InlineElements functionality of HTMLarea is enabled, then the remapping is not done, as any tag (b, i, strong, em) is kept as is, becoming more flexible. In any case, any "unification" if necessary, can also be done the same way via the HTMLparser for the frontend when outputting the content. Resolving: #79300 Releases: master Change-Id: I354b0ccd1948ea7d018c7135c4694e0c0f9b72b8 Reviewed-on: https://review.typo3.org/51289 Reviewed-by:Frans Saris <franssaris@gmail.com> Tested-by:
-
Christian Kuhn authored
The new DatabaseL10nModeUpdate install tool upgrade wizard that migrates row content for old "mergeIfNotBlank" fields is now implemented as the first consumer of the new row updater upgrade wizard. Change-Id: If7495ef09e06c5fd611fe95feff640c67d3a672b Resolves: #79281 Related: #79243 Related: #79279 Releases: master Reviewed-on: https://review.typo3.org/51277 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Tymoteusz Motylewski authored
A new field which is a ctrl-based field for any TCA table called "translationSource" set to a DB field name (used for the new field tt_content.l10n_source) is added and filled as it contains the uid of the record of where a translation record came from. This is different to "transOrigPointerField" as it contains not the record to a record in the default language or the one where a record was copied from, but rather the information what the translation source was made. Releases: master Resolves: #78169 Change-Id: I3ecfeedb656c64681e5e3021cad6b708482520dc Reviewed-on: https://review.typo3.org/51070 Tested-by:
-
Benni Mack authored
When moved to EXT:compatibility7 the pi-based Indexed Search plugin registration was moved to "Configuration/TCA" but should go into "Configuration/TCA/Overrides". Resolves: #79299 Releases: master Change-Id: Ic9abec2a967b08514a786bc2ee62ce65024a1e32 Reviewed-on: https://review.typo3.org/51288 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Benni Mack authored
The RTE uses <a> tags for handling links, a transformation that replaces <link> tags to <a> tags is updated to use the new t3:// linking syntax instead of hard-coding index.php?id=23 or trying to manually resolve the TypoLink functionality for doing links. This also means that the RTE now deals with t3:// links, and HtmlArea is adapted as well. When saving the links in the database again, the links are now not transformed into <link> tags again but kept as proper <a> tags. Resolves: #79291 Releases: master Change-Id: Idc002138e1283d6962666dcd44ba3039c464d6ca Reviewed-on: https://review.typo3.org/49441 Tested-by:
-
Nicole Cordes authored
This reverts commit e538ed3f. We do need the information about the main repository status as there is currently no other possibility to get information about the (security) status of extension besides the TER itself. Resolves: #79285 Related: #79277 Releases: master, 7.6 Change-Id: Ia769dc95eaeff405f291d5929b7790a50c332a83 Reviewed-on: https://review.typo3.org/51280 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Mathias Brodala authored
Extensions are not installed and updated from the main extension repository in Composer mode, thus skip this check completely. Resolves: #79277 Releases: master, 7.6 Change-Id: I6cb209b5ebae04b7e29b55a52ac61ce0f4b261c2 Reviewed-on: https://review.typo3.org/51267 Tested-by:
-
- Jan 11, 2017
-
-
Oliver Hader authored
The TCA setting "l10n_mode=mergeIfNotBlank" for a single column is removed from the list of values. The functionality was there to use the value of a field of the original record, if the value of the translated record is empty (or trim'ed empty), and is then overlaid. The new behaviour is to duplicate the behaviour during the localize process, and then completely separate. As a result the related TypoScript setting config.sys_language_softMergeIfNotBlank is not required anymore and is removed as well. Resolves: #79243 Releases: master Change-Id: I55f3ebd2fe2ddd8412101d5496a0da3c5ab64c68 Reviewed-on: https://review.typo3.org/51239 Tested-by:
-
Susanne Moog authored
This patch reverts some changes of #73698 and adds some new things: - Introduce context based FlashMessageRenderer - Add special FlashMessageViewHelper for the backend - Cleanup classes related to FlashMessages - Deprecate some methods from the FlashMessages::class Resolves: #78477 Related: #73698 Releases: master Change-Id: I937d5896b0a3d45e59c9174d233410f202add997 Reviewed-on: https://review.typo3.org/50285 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Josef Glatz authored
Just add another/meaningful message to the flash message queue if the file/folder was not really renamed. It just gives a better feedback to the backend user. Resolves: #79206 Releases: master Change-Id: Id2378fdd0f24a94c2260cff9fd7e2cb8feb40eaf Reviewed-on: https://review.typo3.org/51203 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Michael Oehlhof authored
The file info modal now contains the width and height of images Resolves: #65822 Releases: master, 7.6 Change-Id: Iadb64ae3db4558bf74f15aaeac1fe29848120563 Reviewed-on: https://review.typo3.org/51052 Reviewed-by:
-
Benni Mack authored
The new CLI functionality to use one dedicated CLI user called _cli_ makes all previous users prefixed with _cli_* obsolete, as they are not in use anymore. An update wizard in the install tool sets all _cli_* users to "deleted=1". Resolves: #79276 Releases: master Change-Id: Ie9c72595b5c42106f437e59383d2f1ebc9b7f3a0 Reviewed-on: https://review.typo3.org/51266 Tested-by:
-
Benni Mack authored
The condition in the ResourceCompressor for fetching external files never worked, as it was a simple typo to update an external resource. So the first time the local file did not exist (and thus, the md5 did not match) and the file was fetched but due to the wrong check, the file never got updated. Resolves: #79269 Releases: master, 7.6 Change-Id: If6942284ccd46f400e23d199e827d4e7a696961d Reviewed-on: https://review.typo3.org/51270 Tested-by:
David Greiner <hallo@davidgreiner.de> Tested-by:
-
Benni Mack authored
Several code parts have been cleaned up and sorted into separate methods to ensure readability. Certain options defined by procOptions are now initialized at the very beginning, before all transformations. Resolving modes are moved into a separate method, as well as configuring the entry- and exit-HTML parser, making the main method easier to read. Cleaning up content and adding <p> tags around "simple" content lines has been split up as well to avoid code duplication. Resolves: #79280 Releases: master Change-Id: Ib734a8cedebff3cc0b415155b6328bf3a77841e9 Reviewed-on: https://review.typo3.org/51268 Reviewed-by:
-
Christian Kuhn authored
Fix a left over hack and improve comment wording at a couple of places. Change-Id: Ida005a7d5889e8aa4afd1e39eb66862f85fd3fbc Resolves: #79279 Releases: master Reviewed-on: https://review.typo3.org/51273 Tested-by:
-
Oliver Hader authored
This adds the possibility to create TRIM expressions using the ExpressionBuilder like shown in the following example: $queryBuilder->expr()->comparison( $queryBuilder->expr()->trim($fieldName), ExpressionBuilder::EQ, $queryBuilder->createNamedParameter('', \PDO::PARAM_STR) ); Resolves: #79262 Releases: master Change-Id: I7813e8a1b0a38ec36797dfbb4fdb02ab78ebe8b2 Reviewed-on: https://review.typo3.org/51255 Tested-by:Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Christian Kuhn authored
Introduce an upgrade wizard in install tool that walks through all TCA table rows and calls registered row updaters to manipulate single row data. Change-Id: I25425e79d966d229da0fa6a181f0eabf97208a70 Resolves: #79279 Releases: master Reviewed-on: https://review.typo3.org/51253 Tested-by:
-
Benni Mack authored
This hook allows to extend the added TypoScript by adding custom TypoScript templates (e.g. not loaded from the database) Resolves: #79140 Releases: master Change-Id: Ie2350c809685fdc3886f5f77761bad5124baa2bb Reviewed-on: https://review.typo3.org/51106 Tested-by:
-
Oliver Hader authored
ADMCMD arguments are not filtered when calculating the cache-hash which results in a page not found error. The behavior can be triggered by creating and opening a preview link in the workspace module which implicitly sets ADMCMD_previewWS during runtime. Resolves: #79275 Releases: master, 7.6, 6.2 Change-Id: I339c2787e7de1adf47bb1322c91e0a78c476f790 Reviewed-on: https://review.typo3.org/51265 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benni Mack authored
The RTE processing options "dontProtectUnknownTags_rte" and "dontConvAmpInNBSP_rte" come from a legacy point of view when transforming from DB to the RTE and have never been set since TYPO3 4.x as a default for installations. Additionally the option "dontConvBRtoParagraph" which was used for setups without RTE where people just wrote plain HTML is removed, so BR tags are kept as they are (which is a regular use case in any RTE). This option was set with HtmlArea at all time (same with other RTEs). The options are very custom and when transferring data to the RTE the best practice is applied by default since a decade (original code was from CVS by Kasper - before the RTE was enabled by default). Resolves: #79273 Releases: master Change-Id: Ib05955b7294fc8f5600d91de443f519176b58634 Reviewed-on: https://review.typo3.org/51264 Tested-by:
-
Benni Mack authored
The RTE parser has the following functionality: - When transforming content from DB to RTE, and <link 13> tag references a page that does not exist anymore, it adds an attribute rteerror="Page 13 does not exist" and style="background-color: yellow; border:2px red solid; color: black;" to the then rendered <a> tag. - When coming back from the RTE to the DB, the <a> tags that do not contain a "rteerror" attribute but a style attribute are wrapped in a <span> tag before transforming back to a <link> tag, since the custom <link> tag cannot contain any other property than href, class, target and title. - If both "rteerror" and "style" attributes are still set, they get removed again. This approach has several downsides: - Due to the limitation of the <link> tag an additional <span> tag gets added to the database (!) which adds hard-coded styling. The only way to remove this is to disallow "style" attributes in "span" tags, or to manually remove the span tags from the database. - The transformation is not 1:1 the same / are not in sync. So, if the editor changes the page ID of the broken link from "13" to any other existing page, the span tag with the yellow background is still added and kept. - If the target page 13 gets added back via the recycler, the span tag needs to be removed from the RTE content again manually (in source code mode of the RTE) Instead, the functionality to display broken links is now handled differently: - A new transformation "detectbrokenlinks" is added to the RTE parser which checks all <a> tags with the new link service class (thus, checks for all ! links not just <link> tags) - The added attributes which are added to the <a> tag is removed again (regardless if the link was fixed or not) when saving the data again in the RTE thus leaving no ugly hard-coded tags when rendering the content in the frontend, making sure that content is clean in the database. - The frontend is now only throwing a TS log message for the admin panel (as before), and this should be the way to handle broken links in the future. Resolves: #79267 Releases: master Change-Id: I8d0979fe9694d278a3e642a33e66f5decfb46bd8 Reviewed-on: https://review.typo3.org/51258 Reviewed-by:
-
Benni Mack authored
The ExtDirect component for fetching the state (for the pagetree) can be simplified by simply using the Storage.Persistent logic which does the same. For this, a simple inline ExtJS onReady code block is added. All functionality related to ExtDirect State Provider is removed. Resolves: #79227 Releases: master Change-Id: I464ffd0608c1fd38cd81c8324f044da6f4140847 Reviewed-on: https://review.typo3.org/51224 Tested-by:
-
Morton Jonuschat authored
If an index is defined on a table that is stored on a MySQL database and uses the MySQL specific subpart length feature add the information to the schema diff so that the upgrade wizards don't show false positive changes. Change-Id: I49eb73c18f7b86aad70d11f3e222c44bd1bd827f Resolves: #78024 Resolves: #79065 Releases: master Reviewed-on: https://review.typo3.org/50081 Reviewed-by:
-
Mathias Schreiber authored
The log module of TYPO3 now shows a button to delete multiple errors at once based on the `details` field of the `sys_log` table. This comes in handy when you fixed an error that spammed the log before. Releases: master Resolves: #79235 Change-Id: I314abcae454e96b9809c6f4a2fb69b3b926f3118 Reviewed-on: https://review.typo3.org/51238 Reviewed-by:
-
Benni Mack authored
HTMLarea defines htmlSpecialChars=0 which is set by default. If it is overriden by an installation, this can still be done and does not break anything then. Resolves: #79268 Releases: master Change-Id: I39022320d3f4834ceea4a52e3a4e80cd34b90506 Reviewed-on: https://review.typo3.org/51260 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
The RTE option "proc.disableUnifyLineBreaks" was never set by default. If NOT set (= default), then all line breaks within the RteHtmlParser are converted as LF, and then migrated to CRLFs after all transformations are done. Activating the option did not do that, thus having problems when content was entered on different OSes (Windows / Unix) and leaving with mixed line break data in the database, the option was historically added to stay compatible with old versions where the unification was not available yet. Resolves: #79270 Releases: master Change-Id: If3b3f48ea7d9ba98882ee340d017296f7b650dda Reviewed-on: https://review.typo3.org/51261 Tested-by:
-
Benni Mack authored
The AJAX call to store uc settings should be handled as POST request, and not a GET request to ensure that even long data can be stored on the server and not run in Firewall/HTTP GET length restrictions. Additionally a really bad typo did not allow any POST requests in UserSettingsController as the key evaluation was wrong. Resolves: #79266 Releases: master, 7.6 Change-Id: I0fd10090416b1a16f6a9bdc6a07efceccf147336 Reviewed-on: https://review.typo3.org/51257 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Tymoteusz Motylewski authored
Fixes two issues: syntax error (missing semicolon), and "Uncaught TypeError: Cannot read property 'refresh' of undefined" when e.g. deleting a page or a file. In file module, refresh is not needed as all actions are refreshing the frames anyway. Releases: master, 7.6 Resolves: #79091 Change-Id: Icfc9f786c24099c55d8e60cf30f72f035ae28231 Reviewed-on: https://review.typo3.org/51251 Reviewed-by:
-
Ralf Zimmermann authored
With this patch is it possible to: * save existing forms within extension locations ("allowedExtensionPaths") if "allowSaveToExtensionPaths" is set to true (like before) * save new created forms within extension locations ("allowedExtensionPaths") if "allowSaveToExtensionPaths" is set to true * delete forms within extension locations ("allowedExtensionPaths") if "allowDeleteFromExtensionPaths" is set to true Resolves: #79250 Releases: master Change-Id: I2d06448f7ee9a0ab0a249ddfee750eda8aeee54e Reviewed-on: https://review.typo3.org/51254 Tested-by:Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Benni Mack authored
The base classes of the very very old CommandLineController and the Cleaner Command are deprecated. They are not in use anymore. Extbase Command Controllers or Symfony Commands should be used instead. Resolves: #79265 Releases: master Change-Id: I85a975038ce54b5a82069ec57679da9815e6e010 Reviewed-on: https://review.typo3.org/51249 Tested-by:
-
Benni Mack authored
The _cli_scheduler backend user was necessary before the introduction of the unified "_cli_" user for all CLI processes. The scheduler module had an info and functionality to create such a user which is not needed anymore and can safely be removed. Resolves: #79264 Releases: master Change-Id: Ie2472869b9db1fc9dcb4add9fae6be63722156c6 Reviewed-on: https://review.typo3.org/51256 Tested-by:
-
Benni Mack authored
The scheduler CLI controller that is triggered via "typo3/cli_dispatch.phpsh scheduler" is migrated to a Symfony Command, which also allows the scheduler to be called via "typo3/sysext/core/bin/typo3 scheduler:run" with the same arguments. The PHP class TYPO3\CMS\Scheduler\Controller\SchedulerCliController has been replaced by TYPO3\CMS\Scheduler\Command\SchedulerCommand. Resolves: #79263 Releases: master Change-Id: I3f117a5a4d46cffe303f0209ac256d0011afe979 Reviewed-on: https://review.typo3.org/51246 Tested-by:
-
Wouter Wolters authored
The system extension "t3skin" has been slowly trimmed down due to the native CSS/LESS building of the TYPO3 core into EXT:backend and EXT:core, and through the IconProvider / IconFactory concepts. The leftover files, which are mainly related to ExtJS (which will be removed soon anyway) have been moved to EXT:core for the time being. All other images are unused and deleted from the TYPO3 core. Resolves: #79259 Releases: master Change-Id: Ic0a0c47999ca57d4e6ea5d7499afc399b307b15f Reviewed-on: https://review.typo3.org/51252 Reviewed-by:
-
Tymoteusz Motylewski authored
After the change https://review.typo3.org/#/c/47645/ was merged methods getRecordLocalization and getPreviousLocalizedRecordUid are not needed. Releases: master Resolves: #79258 Change-Id: I08fe089ddcaed2a7d879630acd046c8b7c303a06 Reviewed-on: https://review.typo3.org/51245 Tested-by:
-
- Jan 10, 2017
-
-
Benni Mack authored
* Make backend:unlock and backend:lock a separate class. * Manually require the CLI user for ReferenceIndexUpdateCommand * Cleanup the commands.php (as the "user" property is not evaluated anymore) Resolves: #79261 Releases: master Change-Id: Id3c90780de0dc299c07c5bca14dd4247b634d53c Reviewed-on: https://review.typo3.org/51247 Reviewed-by:
-
Benni Mack authored
The new _CLI_ user authentication is now explictly set and required in each command (if a user is needed) during runtime, and not done by the bootstrap anymore, so this needs to be called separately. Additionally, some cleanups to the new CommandLineUserAuthentication is made. Resolves: #79260 Releases: master Change-Id: I6a882d083ec6fd878519c1472702f2a724bd7ed3 Reviewed-on: https://review.typo3.org/51248 Reviewed-by:
-
Oliver Hader authored
The setting noCopy is removed from the list of possible values of the TCA column property l10n_mode without any replacement. Resolves: #79242 Releases: master Change-Id: If6be272bd71f955a4f3a12c953ffedc55f7e07ac Reviewed-on: https://review.typo3.org/51235 Tested-by:
Christian Müllenhagen <christianmuellenhagen@yahoo.de> Tested-by:
-
Benni Mack authored
The command line users prefixing with _CLI_scheduler etc. is flawed, however a single user is needed for doing e.g. DataHandler calls. This patch adds a new CommandLineUserAuthentication class, which extends the regular $BE_USER object to only allow a user called "_cli_" and which is created automatically if it does not exist, so the _cli_ user always exists. Additionally, the _cli_ user is now an admin user so access settings on command line are obsolete and crucial stuff like the DataHandler can be used without restrictions. * Adapt Extbase Bootstrap * Make sure to have an API to "opt-in" for the need for a user * Adapt documentation (e.g. in scheduler) because a new user is not needed. Resolves: #79240 Releases: master Change-Id: I5a6277fa2252ce6c61f57bbfa26e8be9dc47bbab Reviewed-on: https://review.typo3.org/51089 Reviewed-by:
-
