Skip to content
Snippets Groups Projects
  1. Jul 08, 2014
  2. Jul 07, 2014
    • Alexander Bigga's avatar
      [BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1 · 10b853dc
      Alexander Bigga authored
      Using the TCA select renderMode=tree with the option
      minitems=1 AND maxitems=1
      leads to two bugs since TYPO3 4.5:
      
      First #48943
      * A new table entry won't mark the field selection as required. The yellow
        question mark is missing and you can save the entry.
      * Once you select a checkbox in the tree and unselect it again, the
        required-check is working.
      
      Second: #31637
      * You load an existing table entry with a selection of e.g. a category
        which has been hidden or deleted. The selected checkbox won't be shown,
        but the required-check fails.
      * Even worse: You can't select another category as the form thinks you
        have already selected one item (maxitem=1). You can fix this only by
        manipulating the database directly.
      
      The reason for these bugs can be found in
      DataPreprocessor::renderRecord_selectProc(). For maxitems = 1 the
      foreign_table element ids for the tree will be fetched by getDataIdList().
      These elements won't be checked whether they are valid (hidden/deleted).
      This check is done in selectAddForeign() which is used for maxitems > 1.
      
      The patch uses the same procedure as for maxitems > 1 in case
      of renderMode = tree.
      
      Resolves: #48943
      Resolves: #31637
      Releases: 6.3, 6.2, 6.1
      Change-Id: I078ff524ea73951f2121d2c233a46bc2ae562952
      Reviewed-on: https://review.typo3.org/31481
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      10b853dc
    • Marc Bastian Heinrichs's avatar
      [BUGFIX] Set internalUploadMap on upload in ExtendedFileUtility · a33b5373
      Marc Bastian Heinrichs authored
      Since introducing FAL the internalUploadMap array in
      ExtendedFileUtility was not set on uploading files.
      
      Resolves: #58463
      Releases: 6.2, 6.1, 6.0
      Change-Id: I4a537a57f1b688c26c20b9f68356a4be67bc5851
      Reviewed-on: https://review.typo3.org/29885
      Reviewed-by: Nicole Cordes
      Tested-by: Nicole Cordes
      a33b5373
    • Alexey Gafiulov's avatar
      [BUGFIX] Wrong image reference handling during flexform copying · 316ba859
      Alexey Gafiulov authored
      References in flexforms having type=inline are not processed correctly
      during copy.
      
      Fix this by properly applying the reference field check.
      
      Resolves: #59664
      Releases: 6.3, 6.2, 6.1
      Change-Id: I1abfa001ba420531ca0c59903e82b1509e0819e0
      Reviewed-on: https://review.typo3.org/31426
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      316ba859
  3. Jul 06, 2014
  4. Jul 02, 2014
    • Markus Klein's avatar
      [BUGFIX] Fix usergroup condition in user TSconfig · 5adc991b
      Markus Klein authored
      usergroup conditions in user TSconfig are currently failing as
      the list of groups the user is part of, is not yet compiled when
      the TSconfig is evaluated.
      
      This can be fixed by moving the group evaluation some lines upwards,
      as this does not influence the remaining code.
      
      Resolves: #59813
      Releases: 6.3, 6.2, 6.1
      Change-Id: Id3189ea5cd31936bdf538e2bb163ecc2d46ed6a0
      Reviewed-on: https://review.typo3.org/31152
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      5adc991b
    • Sascha Egerer's avatar
      [BUGFIX] Create workspace label placeholder that matches field conditions · d6ee5a65
      Sascha Egerer authored
      If a workspace placeholder record is generated the field, that
      is configured as label for a table, is filled with a placeholder.
      This is a hardcoded string.
      If database field does not allow strings (integer, double...)
      a TYPO3 warning is displayed. "... Propably value mismatch ...".
      This message is very confusing because the user does not know
      where it comes from.
      
      The label should be evaluated against the TCA eval configuration
      before it is written to the database.
      
      Resolves: #31757
      Releases: 6.3, 6.2, 6.1
      Change-Id: I18261359550dcaddaa9bd9ca0dd77f8300e81da9
      Reviewed-on: https://review.typo3.org/31284
      Reviewed-by: Sascha Egerer
      Tested-by: Sascha Egerer
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      d6ee5a65
  5. Jun 29, 2014
    • Helmut Hummel's avatar
      [BUGFIX] Fix unit tests after latest PHP changes · 656dd153
      Helmut Hummel authored
      Latest changes in PHP disallow unserialize on
      certain internal classes. Since phpunit uses
      unserialize to create objects of such classes
      when requesting a mock without calling the constructor
      these tests failed with a PHP fatal error.
      
      Instead of skipping the tests, we can simply provide
      mocked constructor arguments (if required) so that
      phpunit can create a mock object by using the new operator
      and passing these mocked constructor arguments.
      
      Change-Id: I26aa06125581b4ca93abcbad2ebb98003509e81a
      Resolves: #59979
      Related: #59685
      Releases: 6.1
      Reviewed-on: https://review.typo3.org/31221
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      656dd153
    • Helmut Hummel's avatar
      [TASK] Improve travis notifications to channels · 0a3ec65e
      Helmut Hummel authored
      By default travis notifies on each build when
      posting to channels (irc, slack)
      We can reduce the number of notifications by only
      posting successful builds when it previously failed.
      Additionally encrypt the API token for posting to slack.
      
      Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5
      Change-Id: I882d34903c972201454e6cc5b9041393e3bd3661
      Reviewed-on: https://review.typo3.org/31222
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      0a3ec65e
    • Anja Leichsenring's avatar
      [TASK] Reset phpunit to 3.7 version · 5e0c3def
      Anja Leichsenring authored
      Some 6.1 tests do not work with phpunit 4.0 and above.
      Instead of fixing them in 6.1 branch, we use a ext:phpunit
      version that bundles phpunit 3.7.
      
      Releases: 6.1
      Resolves: #59978
      Change-Id: If2d9173ef964a2f71428c495c2ac5c5171025f9c
      Reviewed-on: https://review.typo3.org/31215
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      5e0c3def
  6. Jun 28, 2014
  7. Jun 22, 2014
  8. Jun 21, 2014
  9. Jun 20, 2014
  10. Jun 19, 2014
    • Claus Due's avatar
      [BUGFIX] Pass field name variable to flexform DS utility · 7f4cc74e
      Claus Due authored
      A field name parameter is not being passed from within
      DataHandler when copying a record which has a FlexForm
      DF associated with it. This causes dynamic FlexForm DS
      definitions to not be able to depend on the field name,
      in turn causing the problem that an incorrect DS may be
      returned from the DS utility which makes TYPO3 process
      the data value incorrectly (for example, not detecting
      file fields and processing the values accordingly).
      
      To solve this the $field parameter is passed.
      
      Resolves: #59423
      Releases: 6.3, 6.2, 6.1
      Change-Id: Icfafd553f76e17ad5db651bb3f5dea52b140dcf7
      Reviewed-on: https://review.typo3.org/30891
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      7f4cc74e
  11. Jun 13, 2014
    • Philipp Gampe's avatar
      [BUGFIX] Extensionmanager does not show error messages on update failure · 5dba6de7
      Philipp Gampe authored
      The extension manager fails to show any error message if an extension
      update fails.
      
      Convert exceptions (e.g. dependency fails, TER download fails) into a
      nice flashmessage.
      Convert any server errors (uncatchable PHP errors) into a flashmessage.
      
      Resolves: #56823
      Releases: 6.2, 6.1
      Change-Id: Ife3c6d3dcd23177ba22192dd6ae720352931b538
      Reviewed-on: https://review.typo3.org/29735
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      5dba6de7
    • Francois Suter's avatar
      [BUGFIX] Erroneous date sorting in File List · 15ffdb20
      Francois Suter authored
      The sorting by date fails in the Filelist module when more
      than 9 files with the same date are found since the numerical
      suffix used to avoid overwriting existing entries in the
      sorting array is not properly padded.
      
      Fixes: #59458
      Releases: 6.2, 6.1
      Change-Id: I2c80a00dd1692b0987da3d461cc5a21fcea4c97d
      Reviewed-on: https://review.typo3.org/30711
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      15ffdb20
  12. Jun 12, 2014
  13. Jun 06, 2014
    • Mathias Brodala's avatar
      [BUGFIX] Fix command description · ce838380
      Mathias Brodala authored
      Due to using array_pop instead of array_shift the last line
      of the command description is dropped instead of the first.
      
      Use array_shift instead to get the full description
      annotated for the command method.
      
      Resolves: #59324
      Releases: 6.2, 6.1, 4.7
      Change-Id: I4d7c320b0ef334adbd15997d15d8e7a56d5739c1
      Reviewed-on: https://review.typo3.org/30613
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      ce838380
    • Jan-Erik Revsbech's avatar
      [BUGFIX] getIndpEnv('TYPO3_SSL') fails to detect reverseProxyIp · 0f9bd665
      Jan-Erik Revsbech authored
      When running TYPO3 behind a reverse proxy, which also handles SSL,
      the setting reverseProxySSL should check if the site is requested
      from one of the reverse proxies in order to determine whether
      the site is using SSL.
      
      It incorrectly does this check via getIndpEnv('REMOTE_ADDR') which has
      already translated the proxy IP to the end-users IP, thus always
      returning FALSE.
      
      Resolves: #37467
      Releases: 6.2, 6.1
      Change-Id: I95615b0fea94e0ef0222e958e4e0bba5e6e9f60a
      Reviewed-on: https://review.typo3.org/30604
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      0f9bd665
  14. Jun 05, 2014
  15. Jun 04, 2014
    • Helmut Hummel's avatar
      [BUGFIX] Fix frontend unit tests if executed standalone · 2c8a4285
      Helmut Hummel authored
      * Unit tests are allowed for CLI anyway
      * Remove allow all in data provider
      
      The latter implicitly caused a global allow, as PHPUint parses
      all data providers before any test is run, thus setting globals there
      will cause them to be preserved (and restored when backup globals is true).
      
      Releases: 6.2, 6.1, 6.0
      Resolves: #59343
      Change-Id: I646294bb472027e22d6edc0622068698fe9a88fc
      Reviewed-on: https://review.typo3.org/30563
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      2c8a4285
  16. Jun 03, 2014
    • Markus Klein's avatar
      [BUGFIX] DataHandler::log() must not return NULL · cd81ccb5
      Markus Klein authored
      Ensure the DataHandler::log() function does return integers
      in all cases as denoted in the doc header.
      
      Resolves: #59185
      Releases: 6.2, 6.1, 6.0
      Change-Id: I2a6aa0415b7cc19f10b4a290e43bd20065e6c9e1
      Reviewed-on: https://review.typo3.org/30549
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      cd81ccb5
    • Markus Klein's avatar
      [BUGFIX] Fix wrong JS function name in RTE · 9576c32c
      Markus Klein authored
      RTE feature "userlinks" generates a wrong JS function
      name due to the automatic replacement during the
      namespace conversion.
      
      Revert this line to use the correct JS function name.
      
      Resolves: #59302
      Releases: 6.2, 6.1, 6.0
      Change-Id: Ia6b51e7e1b1dfa0e618106f4f039bd0774464a97
      Reviewed-on: https://review.typo3.org/30540
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9576c32c
    • Markus Klein's avatar
      [BUGFIX] Fix double ? in eID url for encryption key · d7919b04
      Markus Klein authored
      The AJAX url for retrieving a new encryption key contains
      two question marks. This causes the request to fail.
      
      Fix this by removing the superflous ? from the parameters.
      
      Resolves: #59034
      Releases: 6.1, 4.7, 4.5
      Change-Id: Iab3833f50a48b71b25cf0205f7eb8d6b57dd859a
      Reviewed-on: https://review.typo3.org/30385
      Reviewed-by: Alexander Opitz
      Reviewed-by: Michael Schams
      Tested-by: Michael Schams
      Reviewed-by: Wouter Wolters
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      d7919b04
  17. May 29, 2014
    • Sebastian Michaelsen's avatar
      [BUGFIX] Flexform element title is cropped to hardcoded length · 34f254ba
      Sebastian Michaelsen authored
      The title of a flexform element is cropped to maximum length of 30
      characters. Instead it should obey the maximum title length in the user
      settings.
      
      Resolves: #58910
      Releases: 6.2, 6.1
      Change-Id: I28c6fc94b2d492217479bf014ff8f67463b4e98f
      Reviewed-on: https://review.typo3.org/30488
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      34f254ba
    • Markus Klein's avatar
      [BUGFIX] Fix redirect to install tool in new installations · 91640252
      Markus Klein authored
      When setting up a new TYPO3 installation, TYPO3 should redirect
      to the install tool, when accessing the frontend or backend.
      
      This redirect fails since introduction of the trustedHostsPattern
      since no configuration is available at this point, while the
      request itself is a BE or FE request, which will be denied in this
      case.
      Solution is to set the REQUEST_TYPE to INSTALL before doing the redirect
      to install tool so that creating the redirect is allowed.
      
      Resolves: #59087
      Releases: 6.2, 6.1
      Change-Id: I31bcbc20fa1c9bca0d6bf2b940bf26b9affe893b
      Reviewed-on: https://review.typo3.org/30487
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      91640252
  18. May 28, 2014
    • David Greiner's avatar
      [BUGFIX] Parent language is not applied to new child records · 3e6e8ec8
      David Greiner authored
      If localizing a parent-child structure, usually the language
      of the parent element shall be applied to related child records
      as well as new child records.
      
      Due to a missing array segment, the accordant section in the
      the InlineElement source code never was processed.
      
      Resolves: #57063
      Releases: 6.2, 6.1
      Change-Id: I7e563044f9889538f9b8171f71f7685722db8266
      Reviewed-on: https://review.typo3.org/30472
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      3e6e8ec8
  19. May 26, 2014
  20. May 23, 2014
    • Marc Bastian Heinrichs's avatar
      [BUGFIX] Alternative implementations for view helpers do not work · 003c6628
      Marc Bastian Heinrichs authored
      Extbase allows to register alternative implementations for
      objects. However that does not work for view helpers using
      a closing tag. The resolved (alternative) object is compared
      to the name of the original view helper and throws an
      exception like:
      
        #1224485398: Templating tags not properly nested. Expected:
        "AlternativeViewHelper"; Actual: "OriginalViewHelper"
      
      A simple solution is to save the class name of the object returned
      from the object manager in a runtime cache and check this when
      resolving a view helper name. A nice side effect is, that a same
      view helper name must not be calculated over and over again.
      
      Fixes: #52272
      Releases: 6.0, 6.1, 6.2
      Change-Id: Ie49e5e83c779b4748dc2059f8fbc85552ce4b406
      Reviewed-on: https://review.typo3.org/30349
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      003c6628
  21. May 22, 2014