- Nov 08, 2014
-
-
Christian Kuhn authored
Running the test suite with hhvm shows some code smells and actual issues the core with this interpreter. While unit tests are in a fairly good shape already, functionals are still totally broken. Having hhvm in our standard test suite in travis as "allowed failure" is a first step to raise awareness towards this topic. Change-Id: Ia684965af9e43ccbce791a10ba664fc49a86191a Resolves: #62783 Releases: master Reviewed-on: http://review.typo3.org/33902 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
- Nov 07, 2014
-
-
Stanislas Rolland authored
Releases: master Resolves: #62768 Change-Id: I6948bb97d156e47ab16f130a54785f55e7e6daac Reviewed-on: http://review.typo3.org/33888 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
- Nov 06, 2014
-
-
Stanislas Rolland authored
Releases: master Resolves: #62759 Change-Id: I198a7ad5a131dc96c0dc4d669125061097867f5d Reviewed-on: http://review.typo3.org/33865 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stanislas Rolland authored
Releases: master Resolves: #62753 Change-Id: Iaa9bfc48a571d0fc6a0974981703c75fc3976620 Reviewed-on: http://review.typo3.org/33860 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stanislas Rolland authored
Releases: master Resolves: #62751 Change-Id: Ic363948a411ba8a0bf4a63391b97909b237229e3 Reviewed-on: http://review.typo3.org/33859 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stanislas Rolland authored
Releases: master Resolves: #62748 Change-Id: I35cc1e76a92a7ae863e017e1d7877385be9ee7e6 Reviewed-on: http://review.typo3.org/33856 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stanislas Rolland authored
Releases: master Resolves: #62733 Change-Id: I2387e316f110312488c32045d0f3e92e0f9cb7a5 Reviewed-on: http://review.typo3.org/33851 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stefan Froemken authored
The parser of the ext_tables.sql file removes double blanks from the input line - but only once. So if there are multiple blanks at least double blanks remain and irritate the later comparison about whether the field definition is different. Resolves: #62245 Releases: master,6.2 Change-Id: I6ab4cb543f5373916388567d3d9969c6681fa8e8 Reviewed-on: http://review.typo3.org/33321 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Markus Klein authored
Does not touch extbase and fluid. Resolves: #62670 Releases: master Change-Id: I853fd1814b7ea5853cdf75abf16be238a27af9f5 Reviewed-on: http://review.typo3.org/33768 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benjamin Mack <benni@typo3.org>
-
Wouter Wolters authored
Resolves: #53658 Releases: master Change-Id: If36c17741d8f3a9a07f7cc8ad2f3289164b8b195 Reviewed-on: http://review.typo3.org/33831 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stanislas Rolland authored
Move the RTE wizards to Modules directory and cleanup configuration and class structure. Releases: master Resolves: #62731 Change-Id: Ib5eaa065435ea1d09e539059301f22538d4c4d63 Reviewed-on: http://review.typo3.org/33836 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
- Nov 05, 2014
-
-
Wouter Wolters authored
Resolves: #47207 Releases: master Change-Id: I953d05d478ae03626c235553ce8fe56ec13eb4f9 Reviewed-on: http://review.typo3.org/33650 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Wouter Wolters authored
* Correct phpDoc * Use strict comparison where possible Resolves: #62703 Releases: master Change-Id: Iea29cdb9593a17529dee72cecce67c51f03da367 Reviewed-on: http://review.typo3.org/33799 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Wouter Wolters authored
* Use short class name where possible * Correct curly bracket at end of defining the interface * Create getDatabaseConnection method Resolves: #62704 Releases: master Change-Id: I2f52a045a34aa188e79f9b729e3df34a27bf9220 Reviewed-on: http://review.typo3.org/33800 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Fabien Udriot authored
Images in RTE are now Processed Files. As a result it makes little sense to store the table name of a File since "sys_file" is the unique possible value. The change-set removes attribute "data-htmlarea-file-table" from the RTE, e.g.: data-htmlarea-file-table="sys_file" Change-Id: If8bde0822629cab2acb8b9dbdf9337f599da64b9 Releases: master Resolves: #56996 Reviewed-on: http://review.typo3.org/28470 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stanislas Rolland authored
To comply with complex CSS frameworks like Twitter Bootstrap, we need to add multiple classes on the same element. This adds complexity for authors. With this new dependency feature, users just have to select one style instead of many styles. The syntax of this new property is: RTE.classes.[ *classname* ] { .requires = list of class names; list of classes that are required by the class; if this property, in combination with others, produces a circular relationship, it is ignored; when a class is added on an element, the classes it requires are also added, possibly recursively; when a class is removed from an element, any non-selectable class that is not required by any of the classes remaining on the element is also removed. } Releases: master Resolves: #51905 Change-Id: I890e6786647a4b31e759e8a3086b3bd8c7e5dd4e Reviewed-on: http://review.typo3.org/29643 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stanislas Rolland authored
In Firefox, depending on how we delete something in RTE, we get different results. This change makes the results consistent and identical in all browsers. Releases: master, 6.2 Resolves: #61747 Change-Id: I7bc15992efb0703b96a59adf6d14484249d9f785 Reviewed-on: http://review.typo3.org/33497 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Stanislas Rolland authored
A similar issue arises with configured microdata schema. This is a follow-up to change https://review.typo3.org/#/c/33568/ Releases: master, 6.2 Resolves: #56408 Change-Id: Ic8122d7a40372f1da85b31d1bd3a7677f2c14a2b Reviewed-on: http://review.typo3.org/33821 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Andreas Fernandez authored
Currently, the spinning wheel displayed after clearing the cache is a graphic larger than the used font. This caused a "jumping" of the topbar. Additionally, adjust the text-align to avoid wobbling of fa-spinner. Resolves: #62702 Releases: master Change-Id: Ic17875bb75259aa7615bbe52b43bc912b2b7cf30 Reviewed-on: http://review.typo3.org/33798 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Stanislas Rolland authored
Toolbar elements do not wrap correctly. Releases: master Resolves: #62710 Change-Id: Iefba035219c46baf3b481547d990c80b04924430 Reviewed-on: http://review.typo3.org/33808 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Andreas Fernandez authored
Using ADOdb, the charset might not be set properly, since every database driver needs to define their own "SetCharSet" method. Every driver extends from ADOConnection. "SetCharSet" of this class just returns FALSE. Resolves: #61738 Releases: master, 6.2 Change-Id: Ia9cef4fa3da76523de883ed7faa5aaebde4b9e9b Reviewed-on: http://review.typo3.org/32883 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
- Nov 04, 2014
-
-
Georg Ringer authored
Adopt the order icon to fit the others. The changed icon can e.g. be found in content element type "media", section "HTML5 additions", field "video sources". Resolves: #62661 Releases: master Change-Id: I7e242a853ebed3632c6a496246ccdb90a6b1ef66 Reviewed-on: http://review.typo3.org/33787 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
Markus Klein authored
This patch does not touch the $include_once magic of BE modules. Resolves: #59659 Releases: master Change-Id: I8721b44d93f002d152c93b094df6a60c578d7bf4 Reviewed-on: http://review.typo3.org/33483 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
Mathias Schreiber authored
Refactor the code to go green in PHPStorm. Main tasks: * Initialize variables * Centralize objects in $GLOBALS Resolves: #62689 Releases: master Change-Id: Ia48365341da93d6f3bc86af53840a8bfeb45feb6 Reviewed-on: http://review.typo3.org/33782 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
Benjamin Mack authored
Remove hard-coded additional wrapper table around FormEngine elements. Styling will be handled differently in the future. Resolves: #62667 Releases: master Change-Id: I3f8eff09aa92da174f686c8d5267da87544ee4eb Reviewed-on: http://review.typo3.org/33766 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Stanislas Rolland authored
This mis a follow-up to change https://review.typo3.org/#/c/33655/ Resolves: #62559 Resolves: #59559 Resolves: #52470 Releases: master, 6.2 Change-Id: I66c1ed5cf288cd8aaaac66fc12655c655ac1964c Reviewed-on: http://review.typo3.org/33772 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Mathias Schreiber authored
AbstractPlugin serves as a base for non-extbase plugins. In order to allow for a notice free environment and no code warnings within TYPO3 CMS AbstractPlugin should: * provide a central property for Database access (DatabaseConnection) * provide a central property to access GLOBALS['TSFE'] These properties will then aid both us in the CMS core development as well as extension authors by supplying code completion in IDEs like PHPStorm or alike. Resolves: #62662 Releases: master Change-Id: I6a698b2481f33643ab800c7152f710f4ed6706a5 Reviewed-on: http://review.typo3.org/33762 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
- Nov 03, 2014
-
-
Frank Nägler authored
Refactoring the reports module a bit to no longer use status message HTML for rendering since this is a misuse. Similar change in extension manager configuration of salted passwords extension. Resolves: #62614 Releases: master Change-Id: I0b3e4e1dfed72441bb01abdb4ad35b7dc058a606 Reviewed-on: http://review.typo3.org/33703 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
Wouter Wolters authored
Fixes some minor things on the go. Resolves: #62669 Releases: master Change-Id: Ida96d56d5f81ac3f1050958aa8ed821613a87e67 Reviewed-on: http://review.typo3.org/33767 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
Frank Nägler <typo3@naegler.net> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Georg Ringer authored
Adopt the order icon to fit the others. Resolves: #62661 Releases: master Change-Id: I1f34fb7eb808e9da0d9c5ba8177da979814cdd1a Reviewed-on: http://review.typo3.org/33765 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Wouter Wolters authored
Resolves: #62664 Releases: master Change-Id: Ib8e0695fc234ab67a2f73a65737e07cf9a2d19c6 Reviewed-on: http://review.typo3.org/33757 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
Benjamin Mack authored
There is an always activated option to show a description for tasks on hover. This option is removed, the feature is always turned on. Releases: master Resolves: #62663 Change-Id: I6f3b656fb9f4721dcd23982eda31f63309bb35ed Reviewed-on: http://review.typo3.org/33761 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benjamin Mack authored
The clickmenu still used its own alt_clickmenu.php entry point until now which is not needed anymore with ajax.php. Further steps (out of scope for this patch) are: use JSON instead of proprietary XML and jQuery instead of prototype. Releases: master Resolves: #62666 Change-Id: Iae4a9623c59a8c985d15dbc9be0c0544ce6abf8e Reviewed-on: http://review.typo3.org/33763 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
Stanislas Rolland authored
In IE, the pasting pad for plain text pasting sometimes shows an error page. Apparently, a timing issue. Releases: master, 6.2 Resolves: #62658 Change-Id: Idb34ea6bc00d6020da637addee42cfd2db2d87f3 Reviewed-on: http://review.typo3.org/33758 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Anja Leichsenring authored
When binding Fluid forms to nested objects, Fluid automatically adds hidden fields with the identifiers of all affected objects so that the persistence layer can update all objects correctly. When a form was redisplayed due to property mapping errors, the identity fields for the nested sub objects were no longer created. This change fixes this by making sure all identity fields are rendered recursively also after property mapping errors. Backport from #29290 Resolves: #59253 Releases: master Change-Id: Ib4b2a065d967e87aa42bdc889fef3f0b727b748b Reviewed-on: http://review.typo3.org/30502 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
Stanislas Rolland authored
Support for allowClipboard policy has been removed from Firefox since version 29. This is a follow-up to change https://review.typo3.org/#/c/33367/ Releases: master, 6.2 Resolves: #62296 Change-Id: I71941c911bc9596495dfea5839d3dba678463357 Reviewed-on: http://review.typo3.org/33754 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Mathias Schreiber authored
EXT:rsaauth has several minor flaws codewise that make PHPStorms inspection go wild: * Clean up direct usage of $GLOBALS[TYPO3_DB]. * TCA of tx_rsaauth_keys is not needed and can be removed, as a result, "Oops! You should not see this" no longer shows up in db_lowlevel. Resolves: #62623 Releases: master Change-Id: I865a9bd3f3f0ff681ba0838a8cbb3a14b885e44f Reviewed-on: http://review.typo3.org/33712 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Mathias Schreiber <mathias.schreiber@wmdb.de>
-
Stanislas Rolland authored
Replace ExjJs outdated user agent identification. Releases: master Resolves: #62630 Change-Id: Ib057fd1ea2c2fc78b0bfdf1e275c69e98331c1c2 Reviewed-on: http://review.typo3.org/33720 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
Stanislas Rolland <typo3@sjbr.ca>
-
Benedict Burckhart authored
Adds the failed tests messages to the mail. Change-Id: I104b7ad98b2ce1ab8014a0751f7adc8c72ad6ca2 Resolves: #58786 Related: #62101 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/33400 Reviewed-by:
Benedict Burckhart <bb@code-plant.de> Reviewed-by:
Frederic Gaus <gaus@flagbit.de> Tested-by:
Frederic Gaus <gaus@flagbit.de> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
Markus Klein authored
This change removes the cache flush after extension configuration changes. Furthermore we avoid duplicate cache flushing on extension installation. Resolves: #59966 Releases: master Change-Id: I6b214ac76fb7305c40f0ce7a33b895323979cbe6 Reviewed-on: http://review.typo3.org/31180 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-