- May 03, 2014
-
-
Nicole Cordes authored
Solve some issues running function tests on windows OS * Disable colors, this is hardly supported in windows CLI, enable in .travis.yml explicitly * Convert the web root path into a unix styled one to prevent a mix between backslashes and forward slashes * Improve finding the PHP binary as the system constants PHP_BINDIR is defined with "C:\php" even if PHP is installed in a different folder * Improves command line argument escaping for special windows requirements. Resolves: #57524 Releases: 6.2 Change-Id: I80b1652e35b816f8ca93929950d014c45b9535d1 Reviewed-on: https://review.typo3.org/29057 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Wouter Wolters authored
Deleting an extension in the Extension Manager doesn't delete the entry in PackageStates file. Use the package manager to delete the extension. This will take care of linked extensions (just remove the link) too. The package manager will take care to remove the entry from the PackageStates file. If an extension is not listed in the PackageStates file (e.g. because we uploaded it via FTP and forgot to clear the system caches), directly remove the folder. Resolves: #53459 Releases: 6.2 Change-Id: I10d5ef33ccf6438fece512478408c57d5d7486de Reviewed-on: https://review.typo3.org/26921 Reviewed-by: Jan Runte Tested-by: Jan Runte Reviewed-by: Helmut Hummel Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Wouter Wolters authored
Resolves: #58344 Releases: 6.2 Change-Id: Ic2cbc0a9d8a27c67e145ea9fef55c60d13466c33 Reviewed-on: https://review.typo3.org/29731 Reviewed-by: Oliver Klee Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Roland Waldner authored
Resolves: #58459 Related: #50248 Releases: 6.2 Change-Id: I3b72ecd65dff934a4eff10be7cb3c46ded948a34 Reviewed-on: https://review.typo3.org/29815 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Sascha Wilking authored
reinitializeClassLoaderAndCachesAndPackageManagement not only reloads the class loader and package management but also reloads LocalConfiguratzion and AdditionalConfiguration. This can lead to errors if AdditionalConfiguration contains require_once calls. The method is only used by ClearCacheService which does not need the configuration reload. Solution is to remove the method and introduce a new one to unregister only the class loader. The other bootstrap methods are now called directly in clear cache of install tool. Resolves: #58337 Releases: 6.2 Change-Id: I59cec5f3fc7dacbf83854c0559b4a8b3f143707d Reviewed-on: https://review.typo3.org/29811 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Jan Runte Tested-by: Jan Runte Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Nicole Cordes authored
This patch changes the default configuration to prevent any redirect loops during the first installation process. Resolves: #58380 Releases: 6.2 Change-Id: I8c0cbb779ee40b3310d2cb7ad6600d3bcaf4ec41 Reviewed-on: https://review.typo3.org/29802 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Helmut Hummel authored
The Extbase help command controller has the calling script hardcoded in several places. This may cause confusion if the calling script was different. Use the real script from argv[0] instead. Resolves: #58456 Releases: 6.2 Change-Id: I622484cb75ad87078ed8b5f923f1f3b972c64124 Reviewed-on: https://review.typo3.org/29809 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Anja Leichsenring authored
The patch breaks Travis due to incomplete mocking. Additionally was considered 'not ready' post merge. We work some more on it. This reverts commit 22695e3b Change-Id: I8194801b6be9d4c3b4f57d14d26df42df36f4b09 Reviewed-on: https://review.typo3.org/29813 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Stefan Froemken authored
In case of sys_category and all other MM-relations with MM_match_fields, parseConstraint has no implementation for this property. This patch adds MM_match_fields for matching and deletion. Resolves: #10487 Releases: 6.2 Change-Id: Id4f53fd4ed42dd6e785011b5efbc61f6ce62e022 Reviewed-on: https://review.typo3.org/29713 Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Nicole Cordes authored
This patch extends the extension manager in three different ways. First all dependencies are checked and error messages are bundled to show all problems to the user. Secondly on uploading an extension file the installation process is started automatically. The main change of this patch is to introduce a new function to prevent (system) dependency checks. This means the checks for TYPO3 and PHP version don't throw an exception anymore. Required extensions are tried to be fetched from TER but don't stop installation either. If errors occur on first installation process, a link to force the installation is added to the notification. Before any installation can be run, a dialog with a "break warning" is shown and has to be confirmed by clicking the unfocussed field. To be able to skip the system dependency check, a new property for ExtensionManagementService and DependencyUtility is introduced which controls disabling the system dependency check. All extension dependencies are still resolved and needed extensions are tried to be fetched from TER. Resolves: #54512 Releases: 6.2 Change-Id: Ia11b7770a2773538bda48d889282ff51bf187c84 Reviewed-on: https://review.typo3.org/28924 Reviewed-by: Sascha Wilking Tested-by: Sascha Wilking Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Oliver Hader authored
Images in TypoScript are rendered using method cImage() of the ContentObjectRender. This method has the possibility to modify the HTML parameters to be set. However, the parameters are not recognized, if those are only rendered using stdWrap functions, e.g. using params.dataWrap This change moves method stdWrapValue() from the FILES cObject to the parent ContentObjectRenderer and delegates the call to the new location of that method. Besides that, a superfluous space has been removed from the template markers definition. Resolves: #58420 Releases: 6.2 Change-Id: I56229ef5aa5133205114c6ee945a68983ef3f52e Reviewed-on: https://review.typo3.org/29796 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Jan Runte Tested-by: Jan Runte Reviewed-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Roland Waldner authored
Added padding-top to start the first li in the menue at the bottom line of the first grey space in the content-area Resolves: #57098 Releases: 6.2 Change-Id: I8ec5defea0cfae9483cfd19bdb918ee063b22f70 Reviewed-on: https://review.typo3.org/28556 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Felix Oertel authored
To allow running of all functional tests, instead of relying on travis.yml, we want to clean up broken and abandoned tests. This one was not touched for over a year, does not work anymore and noone really knows, if it is even suitable anymore. Releases: 6.2 Resolves: #58446 Relates: #58445 Change-Id: Ie3926f557c0cc91d40ad4e4554f0f39de1901adf Reviewed-on: https://review.typo3.org/29795 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Oliver Hader Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Marc Bastian Heinrichs authored
Resolves: #58450 Releases: 6.2 Change-Id: I78d39b0be0d4fc9a425ff3fa1e2424ee017d3180 Reviewed-on: https://review.typo3.org/29798 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Alexander Bigga authored
If an editor ignores the "Copy default content elements"-button, it is not possible to get a new content element in the alternative language related to it's parent. The existing l18n_parent field is never shown. This seems to be a bug which was introduced in TYPO3 4.5 and exists up to now. The patch adds the l18n_parent field to the general tab. Resolves: #26709 Releases: 6.2 Change-Id: Id5f171cd4d1a6441cb58123aaa2b9bd337271556 Reviewed-on: https://review.typo3.org/29054 Reviewed-by: Frans Saris Reviewed-by: Nadir S. Tested-by: Nadir S. Reviewed-by: Sascha Wilking Tested-by: Sascha Wilking Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Nicole Cordes authored
This patch adds a notification to install the impexp extension before the distribution list is shown. Resolves: #57375 Releases: 6.2 Change-Id: I04da4afcf9ac43ff99190844fad9582665c0c346 Reviewed-on: https://review.typo3.org/29781 Reviewed-by: Sascha Wilking Tested-by: Sascha Wilking Reviewed-by: Jan Runte Tested-by: Jan Runte Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- May 02, 2014
-
-
Tymoteusz Motylewski authored
HHVM doesn't support calling array functions like key() on objects, we need to cast object to array first. Resolves: #57993 Related: #57992 Releases: 6.2 Change-Id: I8551860b103745622624dafd8f285db1a7b8f275 Reviewed-on: https://review.typo3.org/29508 Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Christian Kuhn authored
Optimize functional test bootstrap to improve performance: * Database schema for single tests of a test case are always identical by design. So a database can be re-used between single tests to save the table creation overhead. Database tables are truncated instead which is quicker. * Load less extensions by default, so less tables are created. * Enable class loader caches. Typically, tests instances with mysql on a ramdisk, tests are ~25% quicker, for native mysql on hdd the performance impact is ~50%. Change-Id: Ife1ea755c5336f7d4362b2affe7bba9e94862e92 Resolves: #58433 Releases: 6.2 Reviewed-on: https://review.typo3.org/29575 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Sascha Wilking authored
XmlParser has an issue with PHP < 5.4.28 leading to unexpected empty arrays raising warnings. If development preset is activated, warnings are turned into exceptions, so the extension list parser stops importing. Resolves: #58418 Releases: 6.2, 6.1 Change-Id: Idc6453bd8dcc46a933a1d6d72361ffff5842e39d Reviewed-on: https://review.typo3.org/29783 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Benjamin Mack authored
The ExtJS functionality for adding active classes can be done via CSS hover pseudo classes. This is faster (native browser functionality) and also removes some ExtJS code. With this change however, the hovering is not disabled anymore when dragging. Releases: 6.2 Resolves: #58359 Change-Id: Ifcc0307b436cf68dfcfe561444e779410978d576 Reviewed-on: https://review.typo3.org/29744 Tested-by: Stefan Neufeind Reviewed-by: Nadir S. Tested-by: Nadir S. Reviewed-by: Nico Schober Tested-by: Nico Schober Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes
-
Oliver Hader authored
If comparing localization of regular tables (like tt_content) to pages and its specific overlay table pages_language_overlay, the main difference is, that regular tables are copied directly and page translation are shown in the edit view first - without persisting to the database and thus not having a proper uid at this time, yet. This means, that "localizeChildrenAtParentLocalization" in the TCA field configuration won't have any effect. This change brings back the IRRE localization icons for children and "localize all" link for the media field. However, those are only displayed if the new page overlay has been saved once. Resolves: #57488 Releases: 6.2 Change-Id: I29886776b40accce48ce5cd10937ff65b20430fb Reviewed-on: https://review.typo3.org/29719 Reviewed-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Tested-by: Nadir S. Reviewed-by: Frans Saris Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Stanislas Rolland authored
When inserting an image in the RTE, the default image title should be the image file title, not the image file name. Resolves: #58373 Releases: 6.1, 6.2 Change-Id: I5aa3aae4db83cbd36244b89cc37c78184b290228 Reviewed-on: https://review.typo3.org/29759 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Nadir S. Tested-by: Nadir S. Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Benjamin Mack authored
The headline in the backend login screen that contains the sys_news information has a bottom margin and does not have the right size. Releases: 6.2 Resolves: #58362 Change-Id: I0977a3be627a469b902fb39b14417dc9feb738da Reviewed-on: https://review.typo3.org/29745 Reviewed-by: Nico Schober Tested-by: Nico Schober Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Anja Leichsenring authored
Category API was changed to silently fail instead of throwing an exception, but the corresponding tests were not removed. Releases: 6.2 Resolves: #58416 Relates: #58384 Change-Id: I52c0fac32c7f4385868ef5f28c6f94b583948e75 Reviewed-on: https://review.typo3.org/29772 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
The idea was to fail when the category registry is used in a wrong way. This however causes troubles when the core itself reloads extension tables during extension installation process. Remove the exceptions, fail silently on wrong usage and let the installation work again. Resolves: #58384 Releases: 6.2 Change-Id: Icd6ec77fea9d95c9a58e75a85546c0ecc2a5c6d7 Reviewed-on: https://review.typo3.org/29765 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Markus Klein authored
Database compare does not work with DBAL in native mode as the ALTER TABLE statement is not processed correctly. The SQL statement is wrongly interpreted as array, but is of type string. Fix this by extending the check which determines the type. Resolves: #58147 Releases: 6.2 Change-Id: I467494c633b8af9e5a17dce64f071667dd985177 Reviewed-on: https://review.typo3.org/29631 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
- Apr 30, 2014
-
-
Torben Hansen authored
This patch sets [MAIL][defaultMailFromAddress] as a sender for successful and failed login mails for the install tool. If no defaultMailFromAddress is set, the fallback sender address is set to no-reply@example.com Resolves: #57401 Releases: 6.2 Change-Id: Ie4e7700fff9858772688486e5efb4a068d2fe7ff Reviewed-on: https://review.typo3.org/28926 Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
Improve the Install Tool system environment check for PHP maximum upload size. Resolves: #58260 Releases: 6.2 Change-Id: I9f0c0694298faa817d9ac827e2f0e7f589cd0611 Reviewed-on: https://review.typo3.org/29696 Reviewed-by: Jost Baron Tested-by: Jost Baron Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Steffen Müller authored
The core uses values of environment variables for disabling the core updater and to determine the application context. When setting the variable with mod_rewrite, certain server environments prefix the variable name with REDIRECT_. To ensure compatibility for this case, REDIRECT_ prefix is prepended as a fallback if the regular variable is not set. Resolves: #53188 Resolves: #58358 Resolves: #53974 Releases: 6.2 Change-Id: Iaba7f936ff1362d1f70426ec8ad1b1821e4e0d3c Reviewed-on: https://review.typo3.org/25123 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Steffen Müller Tested-by: Steffen Müller
-
Markus Klein authored
* Add missing annotations * Shorten unnecessary namespace annotations Resolves: #57861 Releases: 6.2 Change-Id: Ic8e24e76e3ccc09122dc0a288f1e0b538685c478 Reviewed-on: https://review.typo3.org/29431 Reviewed-by: Oliver Klee Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Helmut Hummel authored
This change makes it again possible to call makeCategorizable from ext_tables.php files. This is done by directly applying additions to the TCA if the default TCA has already been applied. For details read the comparison matrix in the referenced bug report. Resolves: #58004 Releases: 6.2 Change-Id: I0cb69d0421a0df3f930cc9cac1b1811108572530 Reviewed-on: https://review.typo3.org/29560 Reviewed-by: Wouter Wolters Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Stefan Froemken authored
remove additional enableFields from where clause in ProcessedFileRepository as long as sys_file_processedfile is not part of TCA Resolves: #57906 Releases: 6.2 Change-Id: I393f7f952a59ca2f79bf35c8653375a54fec4170 Reviewed-on: https://review.typo3.org/29461 Reviewed-by: Oliver Klee Reviewed-by: Stefan Neufeind Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Philipp Gampe authored
The extension manager fails to show any error message if an extension update fails. Convert exceptions (e.g. dependency fails, TER download fails) into a nice flashmessage. Convert any server errors (uncatchable PHP errors) into a flashmessage. Resolves: #56823 Releases: 6.2, 6.1 Change-Id: Ife3c6d3dcd23177ba22192dd6ae720352931b538 Reviewed-on: https://review.typo3.org/28738 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Jost Baron Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Nico de Haen authored
The container ViewHelper does not provide a configuration attribute for includeCsh (Context sensitive help). As consequence ExtJS and ExtDirect code is always loaded in Backend Modules. Resolves: #58075 Releases: 6.2 Change-Id: I1978bdc0bf3fca40f78cdae9b214a808f58abe49 Reviewed-on: https://review.typo3.org/29590 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Apr 29, 2014
-
-
Markus Klein authored
ActionMenuViewHelper contains a wrong example for the usage of the viewhelper. It uses a '=' where a ':' would be correct. Resolves: #58166 Releases: 6.2, 6.1 Change-Id: I135310be0ac2e8df59f81dfbf694a0febbcde99a Reviewed-on: https://review.typo3.org/29646 Reviewed-by: Kay Strobach Tested-by: Kay Strobach Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
Some extensions need page TSconfig in FE. This was restricted to BE only with #55593. Undo this change. Resolves: #58338 Releases: 6.2 Change-Id: Ia14d7d36c659598415f86f8fabf515879776d148 Reviewed-on: https://review.typo3.org/29729 Reviewed-by: Gerrit Mohrmann Tested-by: Gerrit Mohrmann Reviewed-by: Fabien Udriot Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Froemken authored
We have removed startRange and endRange too early in NumberRangeValidator. As long as TYPO3 6.3 is not reached we have to reimplement these options again. Resolves: #58313 Releases: 6.2 Change-Id: Id012da11227230890b27aa24e1dba1787210f931 Reviewed-on: https://review.typo3.org/29722 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Apr 28, 2014
-
-
Jigal van Hemert authored
The reason for this behaviour is the combination of prototype.js and ExtJS. The ExtJS defer() method takes precedence. Calling the defer() method without any arguments would have resulted in using a default value of "0.01" seconds in standalone prototype.js, but results in directly calling the submitted function. The stack overflow is caused by not delaying the function call and thus ending in a recursive endless loop. Resolves: #58187 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I6db191ff67a3e869072877936d949fc733cda74f Reviewed-on: https://review.typo3.org/29655 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Markus Klein authored
In case login data is submitted and there is an existing cookie/session the current session is discarded and the current cookie is unset. Subsequently the login data is processed and login succeeds and a new session is established, but the new cookie is not set. Fix this be correctly remembering that we need to set a new cookie, after we disposed the current one. Resolves: #57751 Releases: 6.2 Change-Id: I2e4b4a381b4e557aeb95c4186c6e5365dbea442a Reviewed-on: https://review.typo3.org/29626 Reviewed-by: Fabien Udriot Reviewed-by: Stefan Neufeind Reviewed-by: Robbert V Tested-by: Robbert V Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Markus Klein authored
DatabaseRecordList (List module) generates returnUrls for localization links. These must not contain the 'justLocalized' parameter, as this would cause redirects to edit form over and over again. This fix removes the inclusion of all the GET parameters - introduced with #55314 - again. Only the module parameter is used from GET/POST. Additional API enables extbase plugins to add necessary parameters. The TableListViewHelper does not need any more parameters besides the module name and hence still works after this patch. Resolves: #58257 Related: #55314 Releases: 6.2 Change-Id: I641e4ce37e48c9ea4f9aabce41b11d8f824bf64d Reviewed-on: https://review.typo3.org/29701 Reviewed-by: Marc Bastian Heinrichs Reviewed-by: Oliver Hader Tested-by: Oliver Hader Reviewed-by: Wouter Wolters
-