- Jun 05, 2024
-
-
Marcin Sągol authored
It might not be clear to users how the allowed_languages field works by default when setting permissions for a backend user or group. If no languages are selected from the allowed_languages list, all languages will be available for the given user or group. To make this clearer, a description has been added to explain it straightforwardly. Resolves: #103757 Releases: main, 12.4 Change-Id: If0c0fd9c998f51a0e44617faae3365f2e02bc82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84503 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
core-ci <typo3@b13.com>
-
ullio authored
Adds required CSS class `t3js-topbar-opendocs-item` to each open document item. OpendocsMenu JavaScript module counts these items to show count of open documents in badge. Resolves: #103980 Releases: 12.4 Change-Id: I57ac7b7e92c1bb268c0abc9476068616efbfec15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84500 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Christian Kuhn authored
Sometimes - for unknown reasons - a session gets lost in acceptance tests. Tests then hang in BE login waiting for BE load and fail with a timeout. We now catch this timeout and relogin, and also enable cookie debug output to increase chances to fix the real issue. Resolves: #103981 Related: #103086 Releases: main, 12.4, 11.5 Change-Id: I0b10118968933b52523bbee8f8f608db60ad884e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84501 Reviewed-by:
-
Christian Kuhn authored
Frontend TypoScript 'constants' do support conditions. But constants can not be used within conditions, just like constants in general can not be used within constants. The patch adapts the "new TS parser" ReST to clarify. Resolves: #103953 Related: #97816 Releases: main, 12.4 Change-Id: I0e21a320582f2f0edbde432fe36767540ab7993b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84460 Tested-by:
-
Garvin Hicking authored
We missed a TypoScript feature with the new parser. Function operator modifier values can use constants: foo = 42 foo := addToList({$my.constant}) The solution is two fold: Until now, the value of a function body was a single T_VALUE token. This is turned into a stream of tokens that can consist of multiple T_VALUE and T_CONSTANT tokens. This is handled in the tokenizers. Secondly, the AST builders need to deal with these token streams now, and take care available constants are hand over to ConstantAwareTokenStream before the stream is cast to string and single functions are evaluated. The BE modules *do* reflect constant substitutions in function modifier bodies, but not in an ideal way. An @todo within the responsible CommentAwareAstBuilder outlines ideas how this could be improved. Note TYPO3 v13 supports constant fallbacks here as well, this syntax feature came with #103671. This works, but is NOT supported in v12: foo := addToList({$my.constant ?? $fallback.constant}) Resolves: #102742 Related: #97816 Related: #103671 Releases: main, 12.4 Change-Id: Ib5e0872fe1ea2b78bd0a7e05caccd9874b5668d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84498 Tested-by:
-
- Jun 04, 2024
-
-
Christian Kuhn authored
There is a subtle difference between a PHP error and a dedicated thrown exception: When an object knows it should return something, but can't, because it has not been set up correctly, then the implementation is responsible of throwing a "i'm incomplete" exception: This is not an error in the class, but a wrong set up usage, and this should throw, and should not error out with a return type mismatch error. The patch changes two getters of TS parser related IdentifierFunctionLine to obey this difference and now throws in case it "has been set up incompletely". In this case, an IdentifierFunctionLine is only "complete" after at least an identifier token stream and a function name token has been set: After being fully set up, these two properties must have a value. The object knows this and the two getters now throw an exception instead of failing with a type error. Resolves: #103977 Related: #97816 Releases: main, 12.4 Change-Id: I772d774fbaae3c2ec7ff4c9abc6ef4964254259d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84496 Tested-by:
-
Christian Kuhn authored
Add a missing return value in ConstantAwareTokenStream->setFlatConstants(). Resolves: #103976 Related: #97816 Releases: main, 12.4 Change-Id: Ia4d10f846db2bf26f721c5eb03781d3592073a08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84494 Reviewed-by:
-
Christian Kuhn authored
The 'original value token stream' is a helper used in BE TypoScript modules to render a possible constant substitution. It is enough if the CommentAwareAstBuilder handles this, which is used in those cases: getOriginalValueTokenStream() is only called by fluid as 'child.originalValueTokenStream' when rendering TS trees in the backend. Those use CommentAwareAstBuilder and not "production" AstBuilder. The patch avoids calling setOriginalValueTokenStream() as a minor micro optimization which may also help the garbage collection to clean up some objects more early in FE. Resolves: #103975 Related: #97816 Releases: main, 12.4 Change-Id: Ifa54b36877d5eb1c1d712433efa2d07fd1ad8bd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84492 Reviewed-by:
-
Andreas Kienast authored
The stylesheet loading process in IRRE was kept for several years and moved from version to version. A recent change in #103375 migrated a usage of `delete` to `.splice()`, breaking stylesheet loading as the original iterated object was modified. Since the code was quite dated and had other potental bugs, the whole loading sequence has been transformed to functional programming style to reduce complicated, potentially error-prone, array operations. Resolves: #103971 Related: #103375 Releases: main, 12.4 Change-Id: I18caafc68ceebce53723b7208270043faafc7458 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84488 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Anja Leichsenring authored
Additional potential functionality (DI, XClass resolving, etc.) of GU::makeInstance is usually not a wanted behaviour in unit tests. For creation of system under test `new` should be used. Dependencies, if necessary, should be mocks. This patch reduces the obvious cases, more complicated ones will be tackled with follow ups. Resolves: #103902 Releases: main, 12.4 Change-Id: I07cbe6f10fe11e1239cdd5f0fe7496948eed5a44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84485 Reviewed-by:
-
Andreas Kienast authored
This commit updates ckeditor to 41.4. See changelog at [1]. Executed commands: # Override ckeditor5 package to avoid pulling in all/too # many available packages. See: # https://github.com/ckeditor/ckeditor5/issues/16360 npm --prefix overrides/ckeditor5 version 41.4.2 npm install --save ./overrides/ckeditor5 npm install --save \ @ckeditor/ckeditor5-alignment@^41.4.2 \ @ckeditor/ckeditor5-autoformat@^41.4.2 \ @ckeditor/ckeditor5-basic-styles@^41.4.2 \ @ckeditor/ckeditor5-block-quote@^41.4.2 \ @ckeditor/ckeditor5-clipboard@^41.4.2 \ @ckeditor/ckeditor5-code-block@^41.4.2 \ @ckeditor/ckeditor5-core@^41.4.2 \ @ckeditor/ckeditor5-editor-classic@^41.4.2 \ @ckeditor/ckeditor5-engine@^41.4.2 \ @ckeditor/ckeditor5-essentials@^41.4.2 \ @ckeditor/ckeditor5-find-and-replace@^41.4.2 \ @ckeditor/ckeditor5-font@^41.4.2 \ @ckeditor/ckeditor5-heading@^41.4.2 \ ...
-
- Jun 03, 2024
-
-
Stefan Bürk authored
The `symfony/yaml` package provides the `yaml-lint` commandline tool to lint yaml files. This change introduces yaml file linting checks using the symfony tool, differencing `Services.yaml` from other yaml files. Resolves: #103931 Releases: main, 12.4, 11.5 Change-Id: I9442b38c439fb5f2d5507ca0ab70235b2dfd194a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84481 Tested-by:
-
Imko Schumacher authored
The value of the `time` input is sent as an ISO date to the FormEngine, except for the time "00:00", which is just submitted as "0". This has lead to the input field not getting populated by the JavaScript initialization, and the input "00:00" was lost. In cases where such a `time` input is set as a required field, the validation would then fail because of the field getting interpreted as being empty/unset. With this patch, a "0" value is also interpreted as a valid "1970-01-01T00:00:00+00:00" string, that is parseable by FormEngine. Note this only affects display within the FormEngine; the format of the stored data is not changed (converted by DataHandler to proper values and covered by existing tests). IMPORTANT: This only applies to NULLABLE time|timesec inputs. Only for this configuration it is possible to decide, that a stored "0" value in the database is actually "00:00" and not an unset entry. Integrators/developers need to set 'nullable' TCA key to 'true' of the corresponding 'config' array, in case they want to make a time/timesec input picker be able to store and retrieve "00:00" as a valid timestamp. Resolves: #102602 Releases: main, 12.4 Change-Id: Id5dae6564a5da9ab3abd99bdc14b718cc7064464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84459 Tested-by:
-
Garvin Hicking authored
The current implementation does not properly split UTF-8 formatted strings into multi-lines. This patch now utilizes the corresponding mb_* PHP functions to ensure proper splitting. Tests are added to verify this behaviour. Resolves: #103952 Releases: main, 12.4 Change-Id: I493dac05177ae60942513f93ac2c322b63a7a60b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84456 Tested-by:
-
- May 31, 2024
-
-
Benjamin Franzke authored
Allow proxies to cache the TYPO3 content by stripping the nonce from the generated CSP header if the nonce was not actually consumed. Also ensure that the nonce value substitution consumes a nonce to ensure that a (replaced) nonces in cached-content receive a matching CSP header as well. Resolves: #103942 Releases: main, 12.4 Change-Id: I437c83de522ff4a6f4ee0ef2f13881d24bfb990c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84455 Tested-by:
-
Georg Ringer authored
The stdWrap options stripHtml and htmlSpecialChars requires the value to be a string. A typecast forces the string to avoid exceptions. Resolves: #103085 Releases: main, 12.4 Change-Id: Ia936a19e06fdf954ca3aef442cad34c164e9c54e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84458 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Andreas Kienast authored
With migration away from prophecy during v12 development, the variable `$siteMockRevelation` is not needed anymore as phpunit mocks don't know the concept of revelations. Resolves: #103958 Releases: main, 12.4 Change-Id: I92497737dfbba3ef1cd99e4fbd96751e00057a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84457 Tested-by:
-
- May 29, 2024
-
-
Garvin Hicking authored
Using '%env(SOME_VARIABLE)%' within a site configuration YAML did not resolve contents in SOME_VARIABLE that were falsy ('false', '0', 0). This patch now properly converts those falsy values to actual values. Tests are added to verify the new behavior and prevent future regressions. Drive-by fix on Unit tests which did not actually remove env vars after testing, putenv('var') is needed instead of putenv('var='), because the latter will keep the environment var around (with an empty value). Resolves: #91710 Releases: main, 12.4 Change-Id: I99d64f080737ada38fd58a63f4e04e5b0d8c9ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84453 Tested-by: -
Georg Ringer authored
If no icon is provided for submodule, use a fallback to the icon of the parent module instead of directly using the empty-empty icon. Resolves: #103904 Releases: main, 12.4 Change-Id: I4e989483880fd88df904e9028f1d2cf6cd5c29f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84454 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- May 28, 2024
-
-
Christian Kuhn authored
Detail methods of the two TypoScript tokenizers tend to add mental load since they often update `$this` state. The patch changes `splitLines()` and `parseValueForConstants()` to return updated things instead, for consuming methods to take care of this. This is a pre-patch to simplify #102742. Resolves: #103944 Related: #102742 Releases: main, 12.4 Change-Id: I1a5dbccc1bdfbfc52681e323eb1fe9a2b0bb7dc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84440 Tested-by:
-
Christian Kuhn authored
<INCLUDE_TYPOSCRIPT: source="DIR:..." condition="[tree.level > 2]"> The TypoScript tokenizers fail here since ">" within the condition is interpreted as "end of INCLUDE_TYPOSCRIPT". Add a couple of tests and fix it. Resolves: #103875 Releases: main, 12.4 Change-Id: I43c59bd61645bee9ce9c175b00ce1d2cba44c023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84436 Tested-by:
-
- May 27, 2024
-
-
Benjamin Franzke authored
Add a filename context to page.tsconfig include nodes (autoloaded from extensions Configuration folder or from site sets) in order to allow relative imports to be resolved. Releases: main, 12.4 Resolves: #79737 Change-Id: Id6404127b667a61e013d4e5b528048201ad0e6c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84036 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator and removes the null default value for the first parameter, which mitigates both issues. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103927 Releases: main, 12.4, 11.5 Change-Id: I0ba574769e5b95852379aa30f03d45715aec2055 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84362 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change removes the `null` default value and adds the `?` nullable operator to the previousException parameter for the `\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException` constructor. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103926 Releases: main, 12.4, 11.5 Change-Id: I4d1506b24b3113a74b37b986fa4f23f24e6219fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84360 Tested-by:
-
Stefan Bürk authored
`\TYPO3\CMS\Core\Tests\Unit\Database\ConnectionTest` containes code to mock Connection methods conditionally, based on their existance surrounded by a `@todo` comment to remove this, when `doctrine/dbal` has been required with 2.11.0 as minimal version. The version raise has been done already a long time ago, however the removal of this conditional test mock has been missed. This change removes the conditional mocking now. Resolves: #103929 Releases: main, 12.4, 11.5 Change-Id: I4cc2d5942149f69e044c25379c82388f1c4b9f45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84422 Reviewed-by:
-
- May 26, 2024
-
-
Christian Kuhn authored
$this->count() in phpunit always returns 1 and has no arguments as correctly found by phpstan. Fix a test to actually assert subject result count. Resolves: #103924 Releases: main, 12.4 Change-Id: I396b695eaeaa986a4cd9883e028ed6032d2f6339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84413 Tested-by:
-
Christian Kuhn authored
GeneralUtility::callUserFunction() has only three parameters, as detected by phpstan. Resolves: #103923 Releases: main, 12.4 Change-Id: I31fc48f343558dd2e0d73feeb3933e249fa625a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84411 Reviewed-by:
-
Christian Kuhn authored
And rename the method since those general getButtons() methods are ugly. Resolves: #103914 Related: #103903 Releases: main, 12.4 Change-Id: Iaa428d711b98d2bf178aa0ba54ab507f7ca1c09b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84358 Tested-by:
-
- May 25, 2024
-
-
Georg Ringer authored
The shortcut button requires the resolved name as display name and not the LLL path. Resolves: #103903 Releases: main, 12.4 Change-Id: I59e38bf9c40f0a940fecb6ac3178b2976f168069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84398 Tested-by:
-
Georg Ringer authored
The configuration `foreign_table` of the type `select` is optional. Add a check to avoid PHP warnings. Resolves: #103825 Releases: main, 12.4, 11.5 Change-Id: I65925bae287a0ed340c67923ac4e4a2c72ce9d28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84395 Tested-by:
-
Anja Leichsenring authored
The test setup used a dataProvider and in order to get it's own setup right, it reverses and resets leftover instances from the previous run. It is way easier to split the test setup according the admin flag, that decides about the resets, and run on a clear dedicated environment. Additionally, the system under test is in itself a mocked instance, which is neither necessary in this case, nor generally recommended. The mock has been resolved. Resolves: #103901 Releases: main, 12.4, 11.5 Change-Id: If40ef38a0e0fc2e73dd5f0bc8caff923cc48d661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84392 Tested-by:
-
- May 24, 2024
-
-
Georg Ringer authored
Instead of prefixing the type (user, group) for every option an optgroup is used. With this change it is possible to use the keyboard to jump to a specific letter. Furthermore BackendUtility::getRecordTitle is used to retrieve the label instead of using a hardcoded field name. Resolves: #103893 Releases: main, 12.4 Change-Id: I6e9bcd46c2b953660c1b4419eaf567c2d8dc8c80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84357 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Stefan Bürk authored
This change adds some tests for the `EXT:backend` ThumbnailViewHelper, mainly to cover fix #102571. Resolves: #103846 Related: #102571 Releases: main, 12.4 Change-Id: Id1acf6ddf6bc68c2dff0bfb7875859e07768e2af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84353 Tested-by:
-
Torben Hansen authored
This change removes a 5 years old todo in extbase persistence backend. Although the affected feature `newRecordStoragePid` currently is not documented, it is used in various TER extensions and most likely also in custom projects. In relation to this change, a PR for the TYPO3 documentation has been created on GitHub, so the setting will be documented. Resolves: #103895 Releases: main, 12.4 Change-Id: I5c5cf7e87fdb50ab08e409e69aff2b373d39a022 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84356 Tested-by:
-
Lina Wolf authored
There is no word 'postparation' according to native speaker Sarah McCarthy. And also the sentence was hard to understand for non-native speakers. The command is not only useful during deployment so we mention other usecases. Resolves: #103857 Releases: main, 12.4 Change-Id: I602d8fe70ccbe6831278669fb2078318be4bcf63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84355 Tested-by:
-
Oliver Bartsch authored
The GenericMetaTagManager as well as the abstract class (used by extensions) does now properly respect the current doctype and therefore omits the ending slash at the end for HTML5. Resolves: #102058 Releases: main, 12.4 Change-Id: I4ce6bcb61a44aff6eda738f52fe2f2548818ee95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84354 Tested-by:
-
- May 22, 2024
-
-
Sascha Egerer authored
`\TYPO3\CMS\Extbase\Persistence\Generic\Query::execute()` has a boolean flag to define if the result should be a raw result without data mapping to an object. In this case a raw array is returned and not an array with objects. The annotation has been fixed at several places to be in sync with underlying \Doctrine\DBAL\Result::fetchAllAssociative() return type. Resolves: #103874 Releases: main, 12.4 Change-Id: Iea3eda9e805ca064d290f088d6130a44c06c1a42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84348 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benjamin Franzke authored
The cache identifier of TSCconfig strings is now hashed with the current TYPO3 version number in preparation for an upcoming cache-content change (#79737) which is to be included in an upcoming v12 release. Resolves: #103839 Related: #79737 Releases: main, 12.4 Change-Id: I0864deddc350c6775c5cfe42fc05cfa1b974050e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84340 Tested-by:
-
- May 21, 2024
-
-
Oliver Bartsch authored
The value of an `label_alt` field might be an array, e.g. for TCA type `select` fields. Those values must not be formatted as this is done by `BU::getProcessedValue()` after resolving the correct record relation. Resolves: #103838 Releases: main, 12.4 Change-Id: Ibfec36d2df94661fde2d82eb60bb2736205d17c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84352 Reviewed-by:
-
- May 17, 2024
-
-
markuskappe authored
The documentation of EXT:scheduler falsely referred to the Admin Panel extension, which is now corrected. Releases: main, 12.4 Resolves: #103854 Change-Id: I81fe65069bfe0309ba62a5e376e30da4e6f65075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84295 Tested-by:
-
