- Jun 19, 2020
-
-
Benni Mack authored
The current workspace preview middleware runs at a point after the Page ID (and PageArguments) has been resolved by the URL already. This means a workspace preview with a preview user (and not a backend user) does not work, as the user is registered too late in the Middleware workflow. In order to restore the functionality, the preview user is now created BEFORE the PageResolver middleware, and does everything (incl. sending the preview cookie, which is now attached to the response, and not done during processing of the request). However, as the webmount of the current page ID needs to be registered, a second middleware is added which runs before TSFE->determineId() but after the PageResolver and PageArgumentValidator middlewares. Resolves: #91662 Releases: master, 10.4 Change-Id: Ic0108d2cd468f3ecf84e5a0e06c0fd5329046606 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64900 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
David Steeb <david.steeb@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jun 14, 2020
-
-
Daniel Siepmann authored
A wrong label was used when using "Fluid based page module". This resulted in "[]" instead of "[Hidden]" for records with hidden headline. This is fixed by using the proper label reference. Resolves: #91628 Releases: master, 10.4 Change-Id: I7749cbf4441335f8493eadbb9386d95835dff9a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64850 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Jun 09, 2020
-
-
Oliver Hader authored
Overriding route requirements with `.+` allows to have slashes in route parameters. This is different to Symfony's default behavior not allowing slashes here at all. However, when having multiple route parameters it can lead to resolving false-positive routes like shown in the following example: routePath: '{first}/{second}' URI: https://example.com/first/second/third resolves to parameters + first: 'first/second' + second: 'third' This change passes existing TYPO3 route `requirements` and uses pattern `.+` only for those parameters not having a definition - both applies to parameters using `aspects` only. Besides that tests in `EnhancerLinkGeneratorTest` mixed internal argument values with URL parameters (`100` <=> `hundred`) are were "wrong" before. Resolves: #91246 Releases: master, 10.4, 9.5 Change-Id: Ic1fe15790cc16dd52c624cd3be9ed060ae9b9d69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64654 Tested-by:Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
- Jun 08, 2020
-
-
Simon Gilli authored
Setting up backend layouts with colPos not set will show the content of column 0 because of an excplicit cast of the colPos. This patch checks if colPos is set and if not skips the assignment of records. Resolves: #91176 Releases: master, 10.4 Change-Id: I75d9818c4330bb8a4d9a7a60130a547167a83e58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64305 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Hader authored
Direct hash comparison is replaced by cryptographic-safe `hash_equals`. Changes in this patch set basically don't have much impact regarding security aspects. This is a preparation for starting with RIPS scanner. Resolves: #91565 Releases: master, 10.4, 9.5 Change-Id: I5666e586b6b6b462f7864a597139763fd2cd2f98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64668 Tested-by:
-
- Jun 07, 2020
-
-
Markus Klein authored
Use only the body and the content-type header of the internal sub-request. Everything else of the sub-request can be discarded. Resolves: #91582 Related: #81644 Releases: master, 10.4 Change-Id: I393acb340c04b3c7aa0cde1e1de1df9fcc92ca7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64672 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
- Jun 05, 2020
-
-
Benni Mack authored
TypoScriptFrontendController has had functionality to dynamically load JavaScript and CSS code, also in non-cacheable (USER_INT) content. This has been largely superseded via the AssetCollector API and PageRenderer API which is built in a way to deal with non-cacheable and cacheable content with proper method calls. For this reason, the legacy functionality is removed: * TSFE->setJS (used via TSFE->setJS('openpic') in core) * TSFE->additionalJavaScript * TSFE->additionalCSS * TSFE->JSCode * TSFE->inlineJS Although all methods and properties have been marked as internal in TYPO3 v10, a Breaking RST is still added. Resolves: #91563 Releases: master Change-Id: I167dae29e3daa5e1d5ad4c6848dcc49fbfec3183 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64660 Tested-by:Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Benni Mack authored
In order to reduce the amount of accessing globals in the future, and especially TYPO3_REQUEST which was born because of missing structure of TYPO3 Core, the currrent request object is now handed in (optionally) to methods, to work directly with them in TSFE context. Resolves: #91568 Releases: master, 10.4 Change-Id: I760dbd70c9748d69c669bc6f65d65d20dd8ab530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64662 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Benni Mack authored
PageRenderer does not need to care about the actual content. Instead of re-running everything in PageRenderer, ModuleTemplate only calls PageRenderer->render() once. This simplifies the PageRenderer logic and adds a bit of performance improvements. Resolves: #91584 Releases: master Change-Id: I2397f43a4e26f40bb885b21a67ae7a503349a614 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64735 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
This leaves TYPO3 to only handle "XLF" files for language labels natively. Resolves: #91482 Related: #91473 Releases: master Change-Id: Ibf2d0f087e333ab4874c614880022186634e3dbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64631 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Christian Toffolo authored
Resolves: #91550 Releases: master, 10.4, 9.5 Change-Id: I1de1eadbac4b4973250bba2dbf887efb19df872d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64628 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
-
Oliver Hader authored
Internal components using `unserialize` are enforced to disallow classes in their internal state representation. This is a preparation for starting with RIPS scanner. Resolves: #91571 Releases: master, 10.4, 9.5 Change-Id: I3a5026e34a381e79817b46025d81083b2bc5b290 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64778 Tested-by:
-
Nicole Cordes authored
This patch ensures the linkText is returned and used if the target page is not available in the current language. Resolves: #90182 Releases: master, 10.4 Change-Id: Ifed1921ff42746582dd5abab93fafe7a29c12233 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63016 Reviewed-by:
-
- Jun 04, 2020
-
-
Oliver Hader authored
This is a preparation for starting with RIPS scanner. Resolves: #91566 Releases: master, 10.4, 9.5 Change-Id: I6f994cec9c977242c278963c8aa55cb138bdabe2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64669 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Henri Nathanson authored
This fixes encoding issues in paths with URL-encoded spaces and other characters when indexed_search translates indexable file URLs into local paths. Resolves: #91586 Releases: master, 10.4, 9.5 Change-Id: Id20034137556f5705ee34b3adcca6250c77d83f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64772 Tested-by:
-
Benni Mack authored
The cObject "TEMPLATE" in TypoScript is now removed. It only had little use without a given "FILE" cObject. TEMPLATE works on a marker-basis, and was promoted 15 years ago as "Modern Template Building". However, it has been superseded since TYPO3 v7 with FLUIDTEMPLATE. Resolves: #91562 Releases: master Change-Id: I328d56a11f879f329572ea6d2dbf991a945891ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64661 Tested-by:
-
Benni Mack authored
Common URLs like typo3.org, tools.ietf.org or php.net are nowadays available as HTTPS, however some places in TYPO3 still use http:// as reference. This should be streamlined to resemble https:// everywhere. Resolves: #91581 Releases: master, 10.4 Change-Id: I76b5211f7e14cab0c6d190059d2be761bc664b53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64733 Tested-by:
-
- Jun 03, 2020
-
-
Tymoteusz Motylewski authored
Filter out pages user has no access to on query time in page tree. This patch reintroduce a change which was reverted with https://review.typo3.org/c/Packages/TYPO3.CMS/+/64369 Resolves: #91221 Related: #90880 Related: #91348 Releases: master, 10.4, 9.5 Change-Id: Id90752c331bc6fc12b0d3a7d047adacf08cb7804 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64346 Tested-by:
Uwe Trotzek <trotzek@citeq.de> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Oliver Bartsch authored
The plugin configuration of felogin is moved to the common used "Plugin" tab, to unify the position through the core. Resolves: #91416 Releases: master, 10.4 Change-Id: Ibbf26be6787795021e7ba6a0d3138bbf18121087 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64500 Tested-by:
-
Alexander Schnitzler authored
The property injection with non-public properties had been deprecated with #82975 and has been forgotten to be removed until now. With this patch only public properties can be used for extbase dependency injection. Releases: master Resolves: #90799 Change-Id: I21d4b8bcdd07a20ba9ad7ebd87465cc291572bba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63821 Tested-by:
-
Nikita Hovratov authored
It is possible for values returned by stdWrap to be of type int. RequestHandler->generateMetaTagHtml() expects meta tag values to be of type string. In order to avoid php errors, return values are now casted to strings. Resolves: #91533 Releases: master, 10.4, 9.5 Change-Id: I642d5fe0189955e26689a6cf65cdbe23255356a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64656 Tested-by:
-
Benni Mack authored
PageRepository->fixVersioningPid() needs "t3ver_wsid" and "t3ver_oid" to resolve a version, otherwise previewing in workspace context takes another SQL query per page slug candidate. Resolves: #91556 Releases: master, 10.4, 9.5 Change-Id: Ie95365fe76cd2e6e502324c5dbe145651795cff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64657 Tested-by:
-
- Jun 02, 2020
-
-
Benni Mack authored
In change https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e6e40cd214acc8581729ef9f6e98c5d9324ec11c of bugfix #90656 the title attribute of the result was changed to always be added, which should only be added when the title is not empty. Resolves: #91506 Related: #90656 Releases: master, 10.4 Change-Id: Ie267f89b5ae82daeb036c820391099f06bfccbaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64653 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benni Mack authored
All code that is using the constant TYPO3_MODE is hard to test, as this needs to be encapsulated into various places. All testing framework places run with TYPO3_MODE=FE which makes it impossible to even consider making parts of the testing framework compatible running a pure Frontend-based request in the future. On top, the constant covers up cross-dependency between core dependencies (whereas $GLOBALS[TSFE]->fe_user is actually a dependency to EXT:frontend). Another testing-helper in Extbase's EnvironmentService allows to switch within Extbase to simulate Frontend behaviour. Resolves: #91521 Releases: master, 10.4 Change-Id: I85a34029e399b40d0780f907480f9059bfdb0edb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64598 Tested-by:
-
Oliver Hader authored
Scalar values sent via HTTP query parameters to FileSystemNavigationFrameController are using `json_encode` instead of `unserialize`. The parameter stream is still secured with an HMAC before being deserialized. Resolves: #91548 Releases: master, 10.4, 9.5 Change-Id: I57be68aac1787bdc27f2bbae40f8d71b1b33f79f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64624 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jun 01, 2020
-
-
Frank Naegler authored
Resolves: #91551 Releases: master Change-Id: If26ad358d0a8ef750d983a7221e4d000d4b8cd4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64629 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
Benni Mack authored
The T3_RETURN_URL and T3_THIS_LOCATION javascript constants are removed, in addition to all code relevant in ModuleController, and dblist (and its controllers / ViewHelpers) where this is executed. Resolves: #91545 Related: #91473 Releases: master Change-Id: Ie14c1c365796ac5a124573a2e01cfc9bf7e9afc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64619 Tested-by:
-
Benni Mack authored
When a live record that is hidden, but gets unhidden in a workspace version, the record should also be resolved within move placeholder resolving. Resolves: #88054 Releases: master, 10.4, 9.5 Change-Id: Ia5396c6d0cc6b6a915ac8af21008ff5c592c1fe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64620 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Tested-by:
-
Benni Mack authored
Resolves: #91544 Related: #91473 Releases: master Change-Id: I04ce71e83d6e98835c8a8c29e82398d43de2af5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64615 Tested-by:
-
- May 31, 2020
-
-
Benni Mack authored
Various classes and methods are removed, that have been marked as deprecated before. Resolves: #91543 Related: #91473 Releases: master Change-Id: I1dd8b773326c8960b01173003a3251b6ee1d69f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64616 Tested-by:
-
Benni Mack authored
The feature "felogin.extbase" is now always activated. The class * TYPO3\CMS\Felogin\Controller\FrontendLoginController and the hooks inside the class are removed. The CType "login" is now unused in favor of "felogin_login". Resolves: #91542 Related: #91473 Releases: master Change-Id: I7fcd5b9631341b99b953693135f5454d912aa4b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64617 Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. * moves inline JavaScript for avatar handling to new SetupModule * avoids using configuration options `onClick`, `onClickLabels` and `confirmData.jsCodeAfterOk` which contain inline JavaScript * introduces configuration options `conformationData.eventName` and `clickData.eventName` to substitute mentioned deprecations * adds PSR-14 `AddJavaScriptModulesEvent` which allows to apply custom RequireJS modules to handle mentioned new custom events Resolves: #91132 Releases: master, 10.4 Change-Id: Ia68d0c473db862e0381671604347bd15ec89be35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225 Tested-by:
-
Alexander Schnitzler authored
The Fluid widget <f:widget.autocomplete> has been deprecated in TYPO3 10 and is now removed without any replacement. Releases: master Resolves: #91439 Relates: #90856 Change-Id: I20b7ee0f5519ee5b8a8b6cee96c774bc06044ff8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64521 Tested-by:
-
Benjamin Franzke authored
Configuration via Commands.php had been superseded by tag based DI service configuration which allowed to configure DI and dependencies for CLI commands in one place. The CommandRegistry is refactored as the runtime merging logic can now be dropped and handled in addLazyCommand – which is called by the symfony DI generated factory – instead. Resolves: #91534 Related: #91473 Related: #89139 Releases: master Change-Id: I24fc554902650c66b8dc397708d80968514c6744 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64603 Tested-by:
-
Nikita Hovratov authored
eot, otf and ttf font formats were used to support very old browsers like <= IE8. Since TYPO3 v10 does only support modern browsers, these formats can be safely removed. Used commands: >yarn remove npm-font-source-sans-pro >yarn add source-sans-pro >grunt build Resolves: #90904 Releases: master, 10.4 Change-Id: I0676bcdb2bc70454f73027e8e216bb889c419a57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64596 Tested-by:
-
- May 30, 2020
-
-
Benni Mack authored
The following classes are removed: - TYPO3\CMS\Extbase\Domain\Model\AbstractFileCollection - TYPO3\CMS\Extbase\Domain\Model\FileMount - TYPO3\CMS\Extbase\Domain\Model\FolderBasedFileCollection - TYPO3\CMS\Extbase\Domain\Model\StaticFileCollection - TYPO3\CMS\Extbase\Domain\Repository\FileMountRepository - TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileCollectionConverter - TYPO3\CMS\Extbase\Property\TypeConverter\FolderBasedFileCollectionConverter - TYPO3\CMS\Extbase\Property\TypeConverter\StaticFileCollectionConverter Resolves: #91538 Related: #91473 Releases: master Change-Id: I713ab5cd0dc28d6ec2bbbd33cb528e40f3b7ff3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64607 Tested-by:
-
Benni Mack authored
The following FAL related core methods have been removed: * Resource\File-> _getMetaData * Resource\FileRepository->searchByName * Resource\Index\FileIndexRepository->findBySearchWordInMetaData * Resource\ResourceFactory->getInstance * Resource\ResourceStorage->checkFileAndFolderNameFilters Resolves: #91541 Related: #91473 Releases: master Change-Id: Iface7353c1db7ce5c3327a63e9ae360dadc86b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64612 Tested-by:
-
Wouter Wolters authored
The following class aliases are removed: * `TYPO3\CMS\Frontend\Page\PageRepository` * `TYPO3\CMS\Frontend\Page\PageRepositoryGetPageHookInterface` * `TYPO3\CMS\Frontend\Page\PageRepositoryGetPageOverlayHookInterface` * `TYPO3\CMS\Frontend\Page\PageRepositoryInitHookInterface` * `TYPO3\CMS\Frontend\Page\PageRepositoryGetRecordOverlayHookInterface` * `TYPO3\CMS\Lowlevel\Utility\ArrayBrowser` Resolves: #91539 Releases: master Change-Id: Ie11c410576eb0713746fd9261691c5bec72a34d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64610 Tested-by:
-
Benni Mack authored
The unused properties are removed * $TSFE->divSection * $TSFE->domainStartPage * $TSFE->fePreview * $TSFE->sys_language_isocode Resolves: #91524 Related: #91473 Releases: master Change-Id: Iab287f24c45442ce39e82a9ca24c696240f41614 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64613 Tested-by:
-
Andreas Fernandez authored
This patch rephrases the notifications rendered in the Admin Tools. Some notifications now contain a better description of their respective meaning or what the consequences of certain actions are. Additionally, useless rendering of notifications that are never available in some responses have been removed. Resolves: #91461 Releases: master, 10.4 Change-Id: I94be58c4ecba2f7c0639866aef830168d2459dba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64566 Tested-by:
-
