CSS Styled Content delivers its TypoScript
and got a cleanup in 4.6 due to removal
of old plugins.
However, the replacement (in the default
TS from 4.6 to 6.2) has superfluous code
and is not backwards-compatible if the
layout field is used differently or not used
at all (e.g. NULL value instead of 0) for
installations that have been upgraded
since 4.0.

The patch simplifies and unifies
the default TypoScript for
tt_content.shortcut.

Releases: 6.2
Change-Id: I3ed49e265329155af683a993476ffbb13226462c
Reviewed-on: https://review.typo3.org/27211
Reviewed-by: Sebastian Dudda
Tested-by: Sebastian Dudda
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

The key should be named determineSiteRoot instead of determainSiteRoot.

Change-Id: Ia78832920ad73b76d712041e7546c578a6c4d50f
Resolves: #55534
Relates: #55180
Releases: 6.2
Reviewed-on: https://review.typo3.org/27213
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

BackendUtility::getLabelsFromItemsList() does not take
itemsProcFunc into account. This means no value is
returned when there is no matching item found.

With this change the plain db value is returned
when no matching item is found.

Resolves: #54131
Releases: 6.2, 6.1
Change-Id: Ieb04394fa104627b765f6bc05d0d5886f29099c9
Reviewed-on: https://review.typo3.org/25866
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

To detects the siteroot by querying the pages table with the
columns deleted, hidden, is_siteroot. This patch introduces
a combined index on those colums

Resolves: #55180
Releases: 6.2
Change-Id: Icae63670419cf9bc0029e2aa570cdf0108b9d62a
Reviewed-on: https://review.typo3.org/27154
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Also remove one unused css style.

Change-Id: I4a8ccf3861d3e49b4fdab7d542fe2024c5f02f93
Resolves: #55482
Releases: 6.2
Reviewed-on: https://review.typo3.org/27171
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

resolveBackPath() is run a couple hundred times per script run,
especially in the backend. As this method is only really necessary in a
few special cases (when a path really contains "../"), we can skip it
for all other paths with an early return.

The check is really weak (it will not skip the call for things like
"/some/dir..with..dots..inbetween/"), but this is ok because we just use
it to skip all *really* obvious cases while at best not missing *any*
legitimate use-case, which should be achieved with this commit.

Change-Id: I4e7fbd2076323e682fcf66bc57605f817cd3e03c
Resolves: #55519
Releases: 6.2
Reviewed-on: https://review.typo3.org/27197
Reviewed-by: Jan Helke
Tested-by: Jan Helke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The new JavaScript encoder using json_encode also encodes the forward
slash to unicode: \u00F2.

This creates problems, since json_encode already 'escapes' the forward
slash with a backslash.

This patch removes the ecoding of the forward slash from quoteJSvalue

Unit tests have been adjusted to match the output of json_encode:
* forward slash is escaped with a backslash

Change-Id: Ibc19f69c0b68f5bbfa67a39750884dcc030f38cb
Resolves: #55499
Releases: 6.2
Reviewed-on: https://review.typo3.org/27183
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Daniel Siepmann
Reviewed-by: Frans Saris
Tested-by: Frans Saris

The task #52497 introduced a regression. The font-size set in body is
overridden in ext-all-notheme.css with font-size: 0px and thus needs to
be reset again in xtheme-t3skin.css.

Resolves: #55263
Related: #52497
Releases: 6.2
Change-Id: Id17d2ac9d6482c8cc54f4f5a92b3b3ef01f39d2b
Reviewed-on: https://review.typo3.org/27166
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When a storage folder is not accessible for the user a exception
is displayed. Same if the folder is missing.

This patch changes the exception to
\TYPO3\CMS\Core\Resource\Exception.

The user will get a flash message and FAL tries to display the
parent folder of the restricted folder. If the folder is
missing the parent folder is displayed.

Resolves: #51762, #51319
Releases: 6.2
Change-Id: I1fb930f8c13049eeddb27521326f1d0fc8707933
Reviewed-on: https://review.typo3.org/27189
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Several changes in core broke the ajax upload handler response.
There is no error response and it tries to json_encode complete
File objects.

This changes reverts some of the "cleanup" changes fixes the
response and makes sure only the error message from current
request are used.

Resolves: #55371
Releases: 6.2, 6.1
Change-Id: Ia09f5ffd5e002b1ba50d4fafa747340462d15148
Reviewed-on: https://review.typo3.org/27080
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Analysing the SQL logs shows that there are very much queries to the
sys_file_storage even though the information is quite static. Since
there in general there are not much storages - in most cases it only
will be fileadmin/.

This change will get all storage records from database with one call
and cache this in a runtime cache. Afterwards all requests are resolved
by the static member variable of the StorageRepository. If no storage
is present the default storage is created

Resolves: #55186
Releases: 6.2
Change-Id: I066b57215ba39f7cad608cfe5e83a0f3508b2c62
Reviewed-on: https://review.typo3.org/27025
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

To prevent Exceptions in the ElementBrowser resource Exceptions are
catched in two places:

The Exception is catched in the ElementBrowser itsself when the
previously selected folder is not accessible.

Additionally the Exception is cached in the getDefaultUploadFolder()
method in BackendUserAuthentication when the default folder of a
storage is not accessible.

Resolves: #55439
Releases: 6.2
Change-Id: I64848c3a88cc2cc571c0bf692101647b95666972
Reviewed-on: https://review.typo3.org/27145
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Frans Saris
Tested-by: Frans Saris

Currently a backend user can only access files within filemounts
but not the filemount directory itself.

After that fix LocalDriver::isWithin returns true, if the folder
itself is requested.

Resolves: #55416
Releases: 6.2
Change-Id: I455664359ec620c413bfc01787bda8766462fbab
Reviewed-on: https://review.typo3.org/27120
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

If a BE editor has only access to sys_language uid 2 and 3
but not 1, it is not respected in the file list module,
as the BE user can see all flags.

The attached patch filters all inaccessible translation records.

Resolves: #55012
Releases: 6.2
Change-Id: Ib5f5be40fdd09504dd08f005eb73b2fa926703cd
Reviewed-on: https://review.typo3.org/26831
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

With TYPO3 4.0 and the new CSS styled content
and the new RTE HTMLArea, some fields were still
included in the core, but disabled by default as
soon as CSS Styled Content was installed. If not
specifically activated, the fields were disabled
in the last 10 versions and are never rendered
anymore by default via CSS Styled Content.

The DB fields are:
  * text_align
  * text_face
  * text_size
  * text_color
  * text_properties

As they are not in use at all (since a long time)
the patch removes any info about these fields
without further notice or any upgrade wizard.

If somebody needs the fields, he/she needs
to create an own extension with the fields.

Releases: 6.2
Resolves: #55479
Change-Id: I77655cec0a27903a0a1df017808f9603564ef739
Reviewed-on: https://review.typo3.org/27168
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Make HR a single line instead of two lines.

Change-Id: I433d025eb91afc2fd35e794089f330e77d42a966
Resolves: #55486
Releases: 6.2
Reviewed-on: https://review.typo3.org/27175
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Shorten some constructs, make them easier to read
and less error-prone.

Resolves: #46400
Releases: 6.2
Change-Id: I7b0126ccfeaefdfdb89321d7287c6347d8aee050
Reviewed-on: https://review.typo3.org/19007
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

To prevent a sql error the insert query for creating sys_history
records in Datahandler must only be executed, if argument
$logId is a valid uid. This could happen, if logging in
Datahandler is disabled.

Resolves: #55472
Releases: 6.2
Change-Id: Idacced5cb0af24a6c9f34165a8d0598ae9c91998
Reviewed-on: https://review.typo3.org/27162
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The fix for issue #54226 introduced a bug
with FileReferences as it did not implement the
change of the interface.

Resolves: #54226
Releases: 6.2
Change-Id: I9f67f3f23b96569cdfadba1505e4881103a86ccb
Reviewed-on: https://review.typo3.org/27170
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

TYPO3 checks if a redirect is needed for a domain by issuing a
select on sys_domain. In the where clause the columns redirectTo
and hidden are used. These columns have no index, thus the
select is slow.

This patch adds the combined key to the sql definition.

Resolves: #55181
Releases: 6.2
Change-Id: I7d7463e0d3e6abb53c4b0fccf205e4b1eb867878
Reviewed-on: https://review.typo3.org/27167
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

We don't have the t3lib-directory anymore.

Change-Id: Icef845e0ae1fc25a51cd01fa2452751d14b362c5
Resolves: #55433
Releases: 6.2
Reviewed-on: https://review.typo3.org/27125
Tested-by: Georg Ringer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

If a user has listing rights on a folder which contains
folders he does not have access to the user currently
will end up with Exceptions in folder trees, file lists
as well as element browsers.

Before FAL these folders just have been shown "locked".

This change introduces an "InaccessibleFolder" object
which will be created by the storage if a Folder is
requested which exists but there is no read access while
the user is allowed to list the contents of the parent
folder.

In addition the components have been adapted to use this
new information for a graceful behaviour.

WIP: Did not adapt the tests yet, since I need to do some
urgent customer work. Feel free to go on with that.

Resolves: #51512, #53854
Releases: 6.2
Change-Id: If5c234fe66d1930e4cc0cb16279d2f77874d82db
Reviewed-on: https://review.typo3.org/26905
Tested-by: Ingo Schmitt
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ingo Schmitt
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When you have a folder opened in the filelist and then delete it
via the folder-tree the file-module shows an error after its reload.

This patch checks for existence of the folder before it is created.
If it is not existent it checks wether the parent folder exists and
is accessible. If, so the parent folder will be shown instead.

If the parent folder is not accessible the usual exception is thrown.

Releases: 6.2
Resolves: #54554
Change-Id: I7a21c76fd476ebce439489040f3b4c6786afd10a
Reviewed-on: https://review.typo3.org/27030
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Marcel Wieser
Tested-by: Marcel Wieser
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When the processing folder does not exist,
it is created on the fly in ResourceStorage.

However the returned object is at a later point
as string, leading to a fatal error in the end.

Solution is to just store the retuned object directly.

Resolves: #55471
Releases: 6.2
Change-Id: I97b4b5c7992db942812ae033fb963908a4abffde
Reviewed-on: https://review.typo3.org/27137
Reviewed-by: Steffen Ritter
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Currently if some code needs the parent directory or folder
object of some files or folders it either needs to query the
storage object for the identifier of the parent folder and then
create the folder object manually or needs to fiddle around with
the identifier manually, assuming that all identifiers are a
representation of a hierarchical path as it is for the local
driver.

The latter not only will fail for all storages having non-path
identifiers it is more overhead to create the folder objects
manually anyhow.

This patch adds "getParentFolder" to the ResourceInterface and
implements the method in AbstractFile and Folder as well as it
replaces the manual resolval in the file list module.

Releases: 6.2
Resolves: #54226
Change-Id: I651d62340186dd9ac57277b498f8f98ee160dfd2
Reviewed-on: https://review.typo3.org/26724
Reviewed-by: Alexander Opitz
Reviewed-by: Marcin Sągol
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

The FileAbstractionLayer currently only provides the possibility to
retrieve the contents of a file as a string. If you want to output
a file this would lead to a massive memory overhead for large files
when building some kind of download/jumpurl/access-restricted download
script.

This change adds a method "dumpFileContents" to the ResourceStorage
allowing to directly output the contents of the file including setting
correct headers.

In addition it introduces a new method (same name) in the DriverInterface
and implements it in the LocalDriver.

Resolves: #52589
Releases: 6.2
Change-Id: I050da59b136fafbf3f05ac814bd3f11f20ae2396
Reviewed-on: https://review.typo3.org/26835
Reviewed-by: Frans Saris
Reviewed-by: Philipp Gampe
Reviewed-by: Ingo Schmitt
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

When a BE User deletes a file in the file module all file references
as well as processed files are removed, too. If then aprocessed files
is missing for some reason an alert is displayed in the backend module:

Could not delete file "foo.jpg". Write-permission problem?

The patch fixes the situation by adding a check whether before deleting.

Change-Id: I228624a3470340382950d3f54d8b428bfe831715
Releases: 6.2
Resolves: #55428
Reviewed-on: https://review.typo3.org/27123
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

This reverts commit 495afb59

The patch is reverted because it does not work when there is paging in 
the filelist or a file has no thumb shown.
Further the filename canonicalization done by the storage driver is 
not respected when checking the new file name.

Change-Id: I6f4b91bbf28e7b6f0cb8d7bcfb42f0cfb5eeacc6
Reviewed-on: https://review.typo3.org/27158
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

In previous efforts the calls to the FileRepository, when retrieving
File objects have been relocated to the ResourceFactory, since the
coexistence causes problems when it comes to metadata and multiple
instances of the same entity.

As findByUid is defined in the AbstractRepository it was overlooked
until now. This patch overrides the base method, deprecated it and
calls the ResourceFactory, too.
In addition all calls in core are replaced with the direct call.

Resolves: #53690
Releases: 6.2
Change-Id: I89a665211bd7d400f339e27bd2b155958fe5daf1
Reviewed-on: https://review.typo3.org/26850
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Frans Saris
Tested-by: Frans Saris

When the meta-data extraction services have been introduced it
silently has been assumed that the defined priority can be
used as execution order. In fact the priority just defines which
data takes precedence of another. In fact you might have an
extraction service which has highest priority for the fields it
serves but on the opposite should run as first, so other
extraction services already can use the data.

This change adds a second "priority" for that purpose and adapts
the indexing process accordingly.

Resolves: #54228
Releases: 6.2
Change-Id: I649fc8b91103ab518e5a692bf73c54851e8b70b1
Reviewed-on: https://review.typo3.org/26696
Reviewed-by: Frans Saris
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Ingo Schmitt
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The rendering of the plugin menu gets messed up if a plugin hasn't any
description. This patch clears floating for every list item to ensure
it is displayed on the left side.

Resolves: #53895
Releases: 6.2
Change-Id: Ib64b99865fda1359ade4b7c22d160fbfe28350c9
Reviewed-on: https://review.typo3.org/25655
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Resolves: #55464
Releases: 6.2
Change-Id: I1891763db8a8edc5ddb8077a1cc32c8184a7e0c1
Reviewed-on: https://review.typo3.org/27156
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Adds toggle all functionality.

Resolves: #55453
Releases: 6.2
Change-Id: Ie798e229a8a8751f82ffc6c14d1b1ca0caf949e1
Reviewed-on: https://review.typo3.org/27147
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

On splitting sys_file table to extract metadata tca ctrl settings
crdate and cruser_id have been left out, but the columns were
removed. This results in a SQL error on creating sys_file records
with the datahandler.

Resolves: #55462
Related: #52726
Releases: 6.2
Change-Id: I9e856f607868c545ee4e1398a5031e47fc8c39fc
Reviewed-on: https://review.typo3.org/27151
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Change-Id: I252da74973c3dc4157717139c95ad0605e16fce1
Releases: 6.2, 6.1, 4.5
Resolves: #55458
Reviewed-on: https://review.typo3.org/27148
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Move background-style from JS to CSS. Since other skinning-
extensions might override color-settings in TBE_STYLES we need
to generate CSS dynamically and late in the process inside t3skin.

Since backend-CSS is concatenated/compressed this will be included
in the generated merged CSS-file.

Change-Id: Ib04bdf0be172081eb463bdeb9dbd846f7c32cea3
Resolves: #54286
Releases: 6.2
Reviewed-on: https://review.typo3.org/26092
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

For FAL, the concept of "hidden" files was introduced with the sysext
"metadata". The field is called "visible", its usage is to be
implemented by the plugin.

The default value for visible is FALSE, making it error-prone for users
uploading new files: They are hidden by default, requiring additional
work by the end-user (or the plugin/backend module doing the work) to
un-hide the files.

This commit changes the default of ``sys_file_metadata:visible`` to
``1``, making *new* files visible by default.

Change-Id: Id760ac92042e3235259ae78509187d3535cc25ca
Releases: 6.2
Resolves: #55410
Reviewed-on: https://review.typo3.org/27111
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

The message when having a hook for the wizard items
is still the same, although the interface has been
renamed. So the check is valid, but if the check
fails then the message is misleading.

Releases: 6.2
Resolves: #55455
Change-Id: If1b9e4285c02e8a3ab92eee562b6516f24bae9a8
Reviewed-on: https://review.typo3.org/27146
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

tx_saltedpasswords_autoloader was used in old install tool only
and is obsolete now.

Change-Id: If398a197a18bfda20789afd0aa0104fcd8ba5993
Resolves: #55446
Releases: 6.2
Reviewed-on: https://review.typo3.org/27138
Reviewed-by: Thomas Maroschik
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch does not change functionality.
It just fixes formatting issues of the code and
corrects phpdoc.

Resolves: #53580
Releases: 6.2
Change-Id: I39a7ec757e6dfce8282053c3259a84edc2ba5588
Reviewed-on: https://review.typo3.org/25360
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack