Add missing label action_1_5 and fix label action_1_4.

Resolves: #55698
Releases: 6.2, 6.1
Change-Id: I7f04aaf9d8b53cbe3109dbf72f4fddb0c089e9ad
Reviewed-on: https://review.typo3.org/27361
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Jan Bartnik
Tested-by: Jan Bartnik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Scheduler backend module comes with an execute button.
Add icon to the button.

Change-Id: I842683c4b332a87653474237a893dd65d5bd1b5d
Resolves: #55789
Releases: 6.2
Reviewed-on: https://review.typo3.org/27451
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Fixed typo from
"Drop & Drop to upload files"
to
"Drag & drop to upload files"

Resolves: #55756
Releases: 6.2
Change-Id: I35ebde8ee46fe673764c25019551130810241677
Reviewed-on: https://review.typo3.org/27441
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The count in LazyObjectStorage for relation type HAS_MANY has
to use the count on storage items after initialization. Otherwise
the wrong count is returned for a not persisted storage.

Resolves: #54724
Releases: 6.2, 6.1, 6.0
Change-Id: I817ce86dde11b175e6a5765a8f6518770ba75f28
Reviewed-on: https://review.typo3.org/27357
Reviewed-by: Wouter Wolters
Reviewed-by: Nico de Haen
Tested-by: Nico de Haen
Tested-by: Peter Beernink
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcin Sągol
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

Parts of the JavaScript code used in TCEforms is put
inline, coming from the PHP file. There is no concept of
using HTML5-data attributes  to store information.
Plus, most of the JS functions are inline in the HTML
output and called in onclick etc. handlers in the HTML
elements.

Thus, the functionality cannot be abstracted from the
markup, and the JS functionality cannot be cached by
the browser.

Previously, the JS functionality is based on plain
MSIE4-compatible JS code without any framework
(no prototype, jQuery etc), and are not in any namespace.

This approach extracts TCEforms JS code to an external
file (AMD module / RequireJS), and rewrite it to current
jQuery and JS standards. But since the JS code
of TCEforms is very complicated,
it is hard to do it all at once, and the task is split
into separate parts.

The beginning marks the functionality around select
fields in TCEforms, the functions for importing values
from the Element browser, from any other source.

The patch does this:

* Extract the static functions from the PHP code to
an external JS file, in a new RequireJS module named
"TYPO3/CMS/Backend/FormEngine.js"
* Add options that are page-specific (backPath,
formName, callback fn) to PHP so JS can access it.
* Add classes and data-attributes and remove
onclick... functionality in order to reduce the HTML
code and split the data from the logic.
* Functionality for icons like "move up" etc are rewritten
* Functionality for adding elements from a two-select
(like "Access" element in pages) is rewritten, using
CSS classes and data attributes.

By keeping the global variables for the old functionality,
the old functions still work as expected.

Resolves: #46357
Releases: 6.2
Change-Id: I3b9936143342d99eec3058cd55fefdb006060cd4
Reviewed-on: https://review.typo3.org/18971
Reviewed-by: Andreas Wolf
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Tested-by: Felix Kopp
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

When creating a new page inside the top level of a DB mount which is
only a sub tree, the pages up and down from the DB mount root will be
displayed in the position selector if the logged-in user has read
permissions for these pages. This is unwanted information disclosure as
the permissions should not matter for pages which are outside the DB
mount.

Resolves: #18797
Releases: 6.2, 6.1, 6.0
Change-Id: I98008bc7f4308c9fb32dae645325e7cb1b44e413
Reviewed-on: https://review.typo3.org/22632
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Change-Id: I2fdd722f56e69c2c6b2bae23d9944973eed3c066
Resolves: #55745
Releases: 6.2
Reviewed-on: https://review.typo3.org/27387
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The RTE magic still copies images to the old upload folder and
does not use the processed file functions of FAL.

This patch changes the RTE magic so storage 0 is not used any more
and that the FAL API is used for processing the images.

Resolves: #51807
Releases: 6.2
Change-Id: I07d609f9e638d79e785be4ebfd25631c70e3d141
Reviewed-on: https://review.typo3.org/23663
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

In ResourceStorage in the method getUniqueName second argument
passed to fileExistsInFolder should be string instead of object.

This fixes an exception thrown when trying to insert magic image
in the RTE.

Resolves: #55763
Releases: 6.2
Change-Id: I4ed624d4ea5a3602936cf8493052ef111a391990
Reviewed-on: https://review.typo3.org/27412
Reviewed-by: Michiel Roos
Reviewed-by: Marcin Sągol
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The TMENU code has "RO" functionality in its class.
This code might be used from TMENU_LAYERS, but
not from the core itself. The core should remove the
according places. If extensions need this functionality
they could implement their own menu functionality.

The patch itself just removes the functionality of
rollovers, which is currently not documented nor used.

The idea of the content object with its extProc classes
is outdated and should be replaced by hooks and/or
signal slots.

As all methods that are removed, are private, they can
IMHO be removed directly.

In a second patch, there will be a hook interface
in order to manipulate the items.

Releases: 6.2
Resolves: #55751
Change-Id: Ibd5862124a6f8bc9f06254234cfbf179893c27cc
Reviewed-on: https://review.typo3.org/27396
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

$this->typ needs to be $this->type

Resolves: #55753
Releases: 6.2
Change-Id: I5414de0a00b4d0b7adecd783243990397cccb0b7
Reviewed-on: https://review.typo3.org/27403
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Replace JscharCode() with GeneralUtility::quoteJSvalue()

Instead of making JavaScript use a String.fromCharCode, it will now use
a sanitized quoted string.

Change-Id: Idf81d5524d4bbb60b515670aa13648aa52064905
Resolves: #55009
Releases: 6.2
Reviewed-on: https://review.typo3.org/27380
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch updates the named constant TYPO3_copyright_year and
updates the second year number to the current year: 1998-2014.

Resolves: #55747
Releases: 6.2
Change-Id: If3b9d9b25b6ec6a7d2c8a0327dc7b330f0f09f8c
Reviewed-on: https://review.typo3.org/27392
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

In addition to the functional test cases for data handling in
live, these test cases re-use the test scenarios to check the
behaviour in a particular workspace.

The current assertions only check the current behaviour. Parts
that are identified as faults are marked out with the ignore
operator "\*" in the CSV files.

Thus, these tests shall be used to compare the current state
with the target state in combination with accordant bug-fixes
for workspace data handling.

Resolves: #55563
Releases: 6.2
Change-Id: I5e35f0f450093416e5165fc399da3b454715a5d7
Reviewed-on: https://review.typo3.org/27241
Reviewed-by: Peter Kuehn
Tested-by: Peter Kuehn
Reviewed-by: Jigal van Hemert
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

As with JS libraries, the PageRenderer should support
CSS files that should be included above CSS files.
This is necessary for e.g. normalize.css

The patch also adds the same procedure for
"includeCSSLibs" as with "includeCSSLibs" for the
frontend.

Releases: 6.2
Resolves: #55474
Change-Id: I3451b8170daa4fc8cf08f4f96771bed53ac04cdc
Reviewed-on: https://review.typo3.org/27163
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

When using the content element "table", a
field within the flexform shows the possibility
to add an additional css class for the table.
however only one css class can be added.
When adding "myclass1 myclass2" this is not
possible as the evaluation is too strict.

Releases: 6.2
Resolves: #55470
Change-Id: I697184398067add518e750054dd327e741a91de7
Reviewed-on: https://review.typo3.org/27161
Reviewed-by: Benjamin Kott
Tested-by: Benjamin Kott
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Currently the FE session cookie is set on every request
and since 4.2 the sessionID is generated again on every
request unless the user is logged in. This is implemented
for avoiding the security problem of the
session fixation (see #19831).

If an installation does not use FE session cookies at all,
an option (TYPO3_CONF_VARS->FE->dontSetCookie)
never sets the cookie.

As the current behavior for non-logged-in FE calls
is not usable, the behaviour is changed to only set
the cookie if the user is logged in or the session data
is modified. The last example is helpful for websites
with e.g. a shopping cart on non-logged-in pages.
Currently, if an extension is trying to implement the
latter, the extension needs to hook or XCLASS the
FrontendUserAuthentication class to set the cookie
whenever needed.

Additionally, the security problem still exists if the
cookie is not set by TYPO3 itself, that's why the
cookie can only be set if there is a valid entry in
fe_user_sessions.

if using external caching (e.g. reverse proxies),
a "unneeded" cookie is always set currently,
which extensions like EXT:moc_varnish or
EXT:cachinfo mock to only set the cookie
if needed.

The attached patch removes the default-setting
of a cookie in the frontend, and only triggers
the setcookie() function when sessionData is
added or a user is logged-in.

Resolves: #55549
Releases: 6.2
Change-Id: If478bc00c2c55dda0cc38a898a1288098891671f
Reviewed-on: https://review.typo3.org/27230
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

The new menu "categories-based tt_content menu" uses a "speaking" key
for its type. The same should be applied to the other new menu type
introduced in TYPO3 CMS 6.2 (i.e. categories-based page menu).

Resolves: #54611
Releases: 6.2
Change-Id: I489a528050dcfeef83c1919155a3b11e599b195c
Reviewed-on: https://review.typo3.org/26566
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Michiel Roos
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Either some deprecated properties were found, but the wizard was unable
to replace them all automatically, in which case the wizard should
report a failure, or no deprecated properties were found or there are
no more deprecated properties left after the update, in which cases the
wizard should report a success.

Resolves: #51364
Release: 6.2
Change-Id: Ifcddd75f8b257de8ca12038550816f158306d8b5
Reviewed-on: https://review.typo3.org/27369
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Solution: Catch exceptions raised when the potential target folder or
the default user upload folder does not exist.

Resolves: #48512
Releases: 6.2
Change-Id: Ic0218f218b045562d0ea5499ac0440848ddf3028
Reviewed-on: https://review.typo3.org/27323
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Resolves: #55359
Resolves: #55614
Releases: 6.2
Change-Id: I8aceb208ba2f28967f08e9ac458d9a9da3de507b
Reviewed-on: https://review.typo3.org/27359
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Solution: Use same logic as for the link dialogue

Resolves: #53259
Release: 6.2
Change-Id: I3c283536895edb849782da7159866992e3d3d051
Reviewed-on: https://review.typo3.org/27346
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

In #55569 we got rid of the empty TypoScript generated by
default. The configurationManager relies on the empty
arrays to be present, before merging. This patch removes
this necessity.

Resolves: #55687
Releases: 6.2
Change-Id: I7f5ec4f7d120ffa45c8b526817debbc5fd38fe4f
Reviewed-on: https://review.typo3.org/27350
Tested-by: Christian Weiske
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Before the inline drag and drop upload functionality to the default
upload folder is enabled it is made sure that the upload folder
is initialized and that the user is allowed to add files.

Resolves: #55628
Releases: 6.2
Change-Id: Ia18678dc432c6f0addea33aa0389db54297435e3
Reviewed-on: https://review.typo3.org/27302
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Change-Id: I19dc6d19251bc6bb7ab26d1b98d1ccf4a37c06d4
Reviewed-on: https://review.typo3.org/27328
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: If8aa7427548911d665cb84db21c0553b16a4b964
Reviewed-on: https://review.typo3.org/27327
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

This reverts commit 373a90b8

Benni is working on a better solution to the problem.

Related: #55557
Change-Id: I749ea9beb3879d7503294a51107a4a3855f0105e
Reviewed-on: https://review.typo3.org/27319
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Bug was introduced by #54265, one "(int)" was forgotten.

Releases: 6.2
Resolves: #55642
Change-Id: Ie56b36be9d2f11b46687c2966d84e49f301ffede
Reviewed-on: https://review.typo3.org/27317
Reviewed-by: Daniel Siepmann
Tested-by: Daniel Siepmann
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

As felogin has no dependency for CSS Styled Content
it registers itself via
ExtensionManagementUtility::addTypoScript()
and does not hook in after css_styled_content, because
CSS styled content itself hasn't been initialized at that
time. Thus, felogin needs to have a dependency on
css_styled_content in order to still work as before.

Additionally, some unnecessary TypoScript code
was removed / cleaned up at the same time.

How to reproduce:
Add a login CE and you'll get a yellow error
message. Apply the patch, and the form will
show up (you need to uninstall / install an
extension first in order to have the dependecy
resolving take place).

Releases: 6.2
Resolves: #55557
Change-Id: I81e590038c10e793538419523ba37d3b29700b48
Reviewed-on: https://review.typo3.org/27233
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The whole header is clickable, thererfore move the css rule
to this place.

Change-Id: Ia864faba4976fc5e2e84299a42e2661a9566be1c
Resolves: #55611
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/27285
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Mention PHP extensions bcmath and gmp in INSTALL.md,
because openid requires one of them to be installed.

Resolves: #55635
Releases: 6.2
Change-Id: I6ab651d3cb863a570b82fc33231e746e897bee96
Reviewed-on: https://review.typo3.org/27309
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

In some rare cases the database connection might be down, but
DatabaseConnection still has isConnected set to TRUE.
A call to isConnected() simply returns the member variable's value.

Improve the getter to also ping() the database if the class thinks
it is connected to verify the connection state.

The other methods of the class will still use the member variable
and not the getter method to avoid a ping() to the database on every
database interaction.

Resolves: #54323
Releases: 6.2, 6.1
Change-Id: I6bf090e5ab5f1d5539319ff10a1fb224036c4634
Reviewed-on: https://review.typo3.org/26447
Reviewed-by: Bill Dagou
Tested-by: Bill Dagou
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The cleaned up addModule() method no longer adds the module after a
module, when the target module does not exist.

Expected behaviour: module added to the list.

Observed behaviour: module not added at all.

Change-Id: Ie0d1d0c98f9c7dde81636a40eb18a3a7816392f6
Resolves: #55608
Related: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27284
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Change-Id: Ib58894a67f0292b9d62da81511ce12d3f16590ef
Resolves: #55445
Releases: 6.2
Reviewed-on: https://review.typo3.org/27136
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

TypoScript configuration for TDParams is assigned to the PHP variable
$TDParams which is never used. The rest of the method uses $TDparams.

Change-Id: Ice8cd2ad2b4f1a8d68d62c3f2cfc4cfec3c3c210
Resolves: #54824
Releases: 6.2
Reviewed-on: https://review.typo3.org/26686
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

This reverts commit de4811fc

This is not in line with the rest of the backend yet.
The "UX vision" is for after 6.2.

Change-Id: Iab8880163b0cb668237617b1260b4126b16d1cb3
Reviewed-on: https://review.typo3.org/27306
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

This reverts commit 590f76cc

This is not in line with the rest of the backend yet.
The "UX vision" is for after 6.2.

Change-Id: Iabb64ac3a278a3a3e1423283a9267aa5996343f1
Reviewed-on: https://review.typo3.org/27307
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Removes share font from buttons. The current font does
not render adequately.

Change-Id: I8d2a998275e52fbb831abb9046f3711e82acc401
Resolves: #55624
Releases: 6.2
Reviewed-on: https://review.typo3.org/27301
Tested-by: Markus Klein
Reviewed-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

In the package dependency resolver, the method
buildDependencyGraph builds the dependency graph
first for the framework packages and afterwards
for all left packages.

The filtering if a package is a framework package
happens by comparing the package path with PATH_typo3
and a sysext folder contant. But as PATH_typo3 is
absolute and the package path from the package states
configuration is relative to PATH_site, this filter
does not work.

The patch changes the path to a relativ one.

Fixes: #55623
Releases: 6.2
Change-Id: I2f57dee433054463ebfd17aab5f76b19986c2747
Reviewed-on: https://review.typo3.org/27300
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Styles all buttons in the backend similar to UX vision paper.
Inverts buttons colors and changes font-family.

This patch does not bring styling to primary button: orange
or secondary button: silver.

Change-Id: I273e76a02083aedca4c6759948172b418e990ede
Resolves: #55592
Releases: 6.2
Reviewed-on: https://review.typo3.org/27265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer