Change-Id: Id2eebe9044ef8c2710bcc16e2caca8d8e22eb28b
Reviewed-on: http://review.typo3.org/5121
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

Change-Id: I68120670e097815523ebd628135b90ed939c8905
Reviewed-on: http://review.typo3.org/5120
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

The 1-2-3 installer checks for the presence of the required PHP modules. The
Reports module needs to perform this check to catch problems in many
situations.

Change-Id: I0b19bfb4d0f6a5bdd48ba8df9869ecfc4dd3a2d6
Fixes: #30054
Releases: 4.6
Reviewed-on: http://review.typo3.org/5094
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

For the beta3 release of the 4.6 core, all sysexts should have the state
stable. Further the t3editor version number needs to be adjusted for the
upcoming 4.6.0 release.

Change-Id: I20c0c4dba4600c95ee2411591004542f0e5dc354
Resolves: #30077
Releases: 4.6
Reviewed-on: http://review.typo3.org/5100
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Adds a negative lookahead for trailing slash to the regular
Expressions in method "cssFixRelativeUrlPaths" to exclude
absolute paths from being rewritten.

Change-Id: I36355f46da53d167a9fb318228383a6181920398
Resolves: #29904
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/5051
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The ability to render custom content elements in the system extension form fails.

Change-Id: Ib2ff3cc391705be458140c9a0dea0e6255948e83
Resolves: #30088
Releases: 4.6
Reviewed-on: http://review.typo3.org/5117
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Misconfigurations in e.g. TypoScript lead to cased "Array" strings.

Change-Id: I3e161b855d7628d2b2bfc10df9dab3e9ef1d5356
Resolves: #30086
Releases: 4.6
Reviewed-on: http://review.typo3.org/5109
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Since PHP 5.3, PHP INI setting magic_quotes_gpc is deprecated but still
defaults to "On". A report should be added to raise awareness of the
administrators.

Change-Id: Icdaeee1ea054bda1f26c5d3060e74006e7077e26
Resolves: #30079
Releases: 4.6
Reviewed-on: http://review.typo3.org/5101
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

If you set
    'disable_controls'=>'list'
you can _once_ upload an image (or file). But because of a missing Delete-Button
you never are able to change this image (or file) later.

Solution is, to add the delete Button, even if the list is not shown.
To remove even the delete button, use
    'disable_controls'=>'list,delete'

Change-Id: Ia13a9a25a64742eb49e64b7f26c085f15ca72b87
Resolves: #22679, #M14430
Releases: 4.6
Reviewed-on: http://review.typo3.org/3347
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

The old Extension Manager should be officially deprecated in order to
concentrate on enhancing the ExtJS-based one.

Change-Id: I6e5b2daf149faa92973f4a3f1c41aaa82cb90ae8
Resolves: #30027
Releases: 4.6
Reviewed-on: http://review.typo3.org/5057
Reviewed-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Wrong method is used to retrieve label status_configuration_PhpSafeModeEnabled.

Change-Id: Ie14d4d446a9d5e51e60594576a1cf3d42468f952
Fixes: #30081
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5102
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Invalid use of variable passed by reference in the method signature throws
a PHP Runtime Notice in tx_em_Repository_Utility.

Change-Id: I37f0ebb551b2d4fc06baa2c13c4c8bfcb15266ee
Fixes: #30072
Releases: 4.6
Reviewed-on: http://review.typo3.org/5099
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Add type hints and fix obviously wrong references (missing "tx_"
and wrong case in class name).

Change-Id: I702ccf454d9a547a075537e36a250169442ba1e1
Resolves: #30074
Releases: 4.6
Reviewed-on: http://review.typo3.org/5098
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Updated the syntax completion database of t3editor to the changes of
TYPO3 4.6.

Change-Id: I798196aafd16c75f924f49c2f01389e43fb901c5
Resolves: #29995
Releases: 4.6
Reviewed-on: http://review.typo3.org/5037
Tested-by: Stephan Petzl
Tested-by: Jigal van Hemert
Reviewed-by: Björn Pedersen
Reviewed-by: Jigal van Hemert

There are pathes through analyseTypoLinks where currentR is
 not set, it can happen that the fetchType hook gets
called with currentR=null.

This throws an API error as the fetchType interface
requires the first arg to be an array.

Change-Id: I2d517b8c57678e645c590b51d50343c42a3d36a9
Resolves: #30043
Releases: 4.6
Reviewed-on: http://review.typo3.org/5097
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

* fix some PHPdoc comments
* remove @author annotations

Change-Id: If0600e654b785683e1b394154022c650fee7dcda
Resolves: #30066
Releases: 4.6
Reviewed-on: http://review.typo3.org/5093
Reviewed-by: Björn Pedersen
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

t3lib_utility_Mail::breakLinesForPlainEmail() is not defined.

Change-Id: I7d375aa53e7ab32f8cce383afd0a458da21a80f3
Resolves: #30065
Releases: 4.6
Reviewed-on: http://review.typo3.org/5092
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

t3lib_TStemplate::sortedKeyList() is used in a static context
but is not declared to be static.

Change-Id: I2659730d60e750d42d7c46372067e926a0d2411d
Resolves: #30064
Releases: 4.6
Reviewed-on: http://review.typo3.org/5091
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

* remove superfluous __construct() methods
* fix PHPdoc comments and add type hints
* remove unused classes
* fix CGL issues

Change-Id: Ie859ea0a54a8234b5c5c8d6d16f0be6c947a9bc5
Resolves: #30046
Reviewed-on: http://review.typo3.org/5077
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Fix the method signatures that are statically called throughout the Core.

Change-Id: Ic415b271eb66950de9dbaf1a82b130112b026f35
Fixes: #30063
Releases: 4.6
Reviewed-on: http://review.typo3.org/5090
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Method t3lib_treeView::init() is not properly overriden in subclasses.

Change-Id: Ia39eb8ba775e1f217fb77f402dd8f2ab4e1d24ae
Fixes: #30062
Releases: 4.6
Reviewed-on: http://review.typo3.org/5089
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Method toArray() from t3lib_tree_Node is not properly overriden in subclasses.

Furthermore, many phpDoc comments are wrongly returning void instead of bool.

Change-Id: I99bea296df305673d5c111fc9e5b92ea42599c5f
Fixes: #30060
Releases: 4.6
Reviewed-on: http://review.typo3.org/5088
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Invalid method override signature.

Change-Id: Ifb82ee48c8a83c626004cf67e6529f386d8edb40
Fixes: #30061
Releases: 4.6
Reviewed-on: http://review.typo3.org/5087
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Methods of class tx_em_Database miss the static keyword and, sometimes,
the visibility as well.

Change-Id: I477ca961ae9dc6fc456c3e90fd8f0871be2cc145
Fixes: #30059
Releases: 4.6
Reviewed-on: http://review.typo3.org/5086
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

A few methods in t3lib_TSparser are called statically but are not
declared as being static. This leads to PHP notices.

Change-Id: I7ea7cb659a830e74c4f8797f118662b517015614
Fixes: #30058
Releases: 4.6
Reviewed-on: http://review.typo3.org/5085
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

PHP Runtime Notice: Declaration of tx_rsaauth_sv1::authUser() should
be compatible with that of tx_sv_auth::authUser().

Change-Id: Idbd7ca2b69d3142497b1770088d991901950a852
Fixes: #30057
Releases: 4.6
Reviewed-on: http://review.typo3.org/5084
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

PHP Runtime Notice: Only variables should be passed by reference.

Change-Id: Ib1e9af4b58202f085d1afbba2b9bd0b288a8ef58
Fixes: #30056
Releases: 4.6
Reviewed-on: http://review.typo3.org/5083
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Due to improper method signature in the parent class of t3lib_userAuthGroup,
a PHP notice is generated when calling method checkLogFailures().

Change-Id: Ic41cb88889ee18f2508ae5b2e96858e8bf16c349
Fixes: #30055
Releases: 4.6
Reviewed-on: http://review.typo3.org/5082
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Method tx_coreupdates_installsysexts::performUpdate() cannot be properly overriden
because its signature is incomplete.

This leads to PHP notices.

Change-Id: Iaf13c166c07d04ee194bec1543ac5ae450f1e38b
Fixes: #30053
Releases: 4.6
Reviewed-on: http://review.typo3.org/5078
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

A few methods don't have the static keyword. This leads to PHP notices.

Change-Id: I90a99601a39cd26abed665b42a8b054385f561ff
Fixes: #30050
Releases: 4.6
Reviewed-on: http://review.typo3.org/5075
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Because of an information disclosure problem in the backend login
we moved the session_start() in t3lib_userauth in a place which caused
unwanted side effects with 3rd party extensions.

Revert that change to avoid compatibility and performance problems
and instead send no cache headers earlier in t3lib_userauth 
to also fix the information disclosure.


Releases: 4.3, 4.4, 4.5, 4.6
Resolves: #29274
Related: #24456, #28694

Change-Id: I87226a21d9b1955773ceb3c377fa1b4c9938e6b2
Reviewed-on: http://review.typo3.org/5007
Reviewed-by: Christopher Hlubek
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Change-Id: Ic41b317fdb608dcc5630859168d3d5674bfe0593
Resolves: #28679
Reviewed-on: http://review.typo3.org/4024
Reviewed-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The template for t3editor contains CRLF line endings on Windows systems. To
prevent JS errors and to make the t3editor visible the CR parts of the line
endings must be removed.

Change-Id: If4f126c46ab243e616292a60563ebe4bea3fd624
Fixes: #30026
Branches: 4.6
Reviewed-on: http://review.typo3.org/5058
Reviewed-by: Oliver Hader
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig

Change-Id: Ie72691fc5146bed17e11e959081f655371bfafed
Resolves: #29802
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5062
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The Version Compatibility always appears at the first place and tells
you that you should upgrade your compatVersion or that everything is
okay, but you might.. if you really really want this.. in case of, don't
know, whatever reason.. downgrad again.

Remove this ugly thing. compat_version can still be changed again using
"All configuration".

Change-Id: Ie45a50ab20a0c8d59021362e45b7bed743e43199
Resolves: #24834
Releases: 4.6
Reviewed-on: http://review.typo3.org/5038
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The "Enable Install Tool" button in the User Settings is useless, as the
Install Tool is automatically enabled (after request) since #28621
and #28689.

Change-Id: I596a0b45d9b947e58b30e0082f23413b56e6f325
Resolves: #29996
Releases: 4.6
Reviewed-on: http://review.typo3.org/5040
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Function t3lib_autoloader::getAutoloadCacheIdentifier now respects the constant
PATH_site. This is needed because otherwise a fatal error occures when the
path to webroot changes (e.g. moving site to another webserver)

Change-Id: I9755da82cbf71914d47bc0523bacc8413addcf63
Resolves: #29901
Releases: 4.6
Reviewed-on: http://review.typo3.org/5000
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

After 1-2-3 installation it is not possible to start using TYPO3
because caching framework tables are missing. TYPO3 backend shows
SQL errors in the debug console (if enabled).

Resolves: #29894
Releases: 4.6

Change-Id: I343ddd6ab3171b5337c53cb58e3e120ea3e6469a
Reviewed-on: http://review.typo3.org/4996
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Add some space between the Template Analyzer options and vertically
align the labels.

Change-Id: Ifb6124beed73f2b176826096e9c20e3a17fcd2af
Resolves: #27588
Reviewed-on: http://review.typo3.org/5006
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Change-Id: I06c172211fb737ed51afd846c44e00ba2e0dbd0e
Resolves: #27603
Reviewed-on: http://review.typo3.org/5013
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert