This was decided at the latest release manager meeting:
To get rid of the top level tests/ directory, the UnitTests.xml
file is moved to the core extension to a new folder Build/. This
directory will later be used for other build specific things.

Change-Id: Id541f1e0bab3b1d2891f13697f48ea16e6c86d5e
Resolves: #40837
Releases: 6.0
Reviewed-on: http://review.typo3.org/14528
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

* Move BaseSetupTest to SystemEnvironmentBuilderTest and namespace it.
* Introduce an AccessibleProxy for the protected methods instead of eval.
* Merge config_defaultTest to SystemEnvironmentBuilderTest

Change-Id: Ie90857962087e235a7f4a8eb53df120624fd8780
Resolves: #40836
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14527
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I26b501e49d41656eb50996be4d56b4c18f1563ba
Fixes: #40364
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14178
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

There are still some fixture files within the root tests/ directory.
The patch moves them to Fixtures/ folders below the using tests
within the affected core and backend extensions.

Change-Id: Ied23b542a65becac02c9af576728da886552484d
Resolves: #40834
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14525
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of
strtime/gmstrftime.)

Change-Id: I7cc43a09f75d21ab8db84c0191fa0c1c5d67ddb0
Fixes: #38717
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12713
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

In the past it happened quite often that some test did not take care
of proper backing up globals or other environment settings. This
usually leads to failing tests if they are run afterwards. Those
side effects are often hard to track down and take quite some time
if searching for the one test that breaks the environment.

Therefor, a new "Integrity" test is added to the system that is
executed as the very last test in the list of test suites. It checks
that important things that were messed up in the past are still working.

Currently it checks that the registered singleton instances are still
there, that $GLOBALS['TYPO3_DB'] still has a valid resource link to
the database, and $GLOBALS['typo3CacheManager'] is still a valid
class instance.

If one of this test fails after any merge (especially combined with
travis), it is now obvious that this merge broke the environment, so
the evil test can be found much quicker and the evil merge can be
reverted directly.

Change-Id: I0dc733081ea9ad0c050a7dbcf4d95dd8f819f1bf
Resolves: #40832
Releases: 6.0
Reviewed-on: http://review.typo3.org/14524
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The FrontendEditingController calls TSFE->includeTCA right
before the index_ts.php calls TSFE->getCompressedTCA().

Because of the missing parameter within the
FrontendEditingController, getCompressedTCA wil not be
executed anymore. As an result the TSFE->TCAcachedExtras
are not available when FE-editing is active.

This prevents the a working language overlay, which only
looks to that array, which fields are configured to be
overlayed.

Change-Id: Ib130b11dd76c0b533b9a699a113f03e750ba2516
Fixes: #40733
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/14432
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

This patch replaces the language selection field in language module.

Change-Id: I52fd08df4bfd4687c65588cd3e479d08b48d68df
Resolves: #40430
Related: #39963
Releases: 6.0
Reviewed-on: http://review.typo3.org/14293
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch replaces the icon in extensionmanager and admin tools menu
(module icon) with a more attractive one.
The new icon is from the http://www.famfamfam.com/lab/icons/silk/ silk
icon set, so it is free, credits to famfamfam are already give in
TYPO3 core, and it fits to the rest of the core icons.

Change-Id: Ic379c457b91eb5ba87d56d646a3b76a0909cb021
Resolves: #40546
Related: #39963
Releases: 6.0
Reviewed-on: http://review.typo3.org/14300
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Labels improve the usuability, so add them

Change-Id: I7d06f26959eb46cab449a2870942df02917023b0
Resolves: #39874
Releases: 6.0
Reviewed-on: http://review.typo3.org/13831
Reviewed-by: Stefan Neufeind
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

One place has been missing while changing all the
class names

Change-Id: I73d5e3f006377ea46079ac9f17f30c817ada7d4a
Resolves: #40795
ReleaseS: 6.0
Reviewed-on: http://review.typo3.org/14508
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

After fixing lots of side effects and invalid environment changes
of existing unit tests and updating the introduction package database
and the travis test environment, it finally seems to be possible to
activate the extensionmanager tests for every travis build.
Let's see if this works out now ...

Change-Id: Ic8beb96121df3e8ef8b76b0ff4c2ef7d0daa8dab
Resolves: #40810
Releases: 6.0
Reviewed-on: http://review.typo3.org/14507
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ic37ed816e8ccce1c976c1e66155ebe77788738bc
Reviewed-on: http://review.typo3.org/14499
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

TYPO3\CMS\Core\Utility\GeneralUtility::setSingletonInstance() is a method
for unit tests to inject singleton mocks for classes that are
instantiated with makeInstance. purgeInstances() can be used to reset all
registered singletons, so makeInstance() creates new objects after that.
purgeInstances() can change the behaviour of tests that are executed
afterwards, because *all* registered singletons are reset. Currently the
helper methods for singletons around makeInstance() are not able to get
the list of registered singletons, and reset them to the previous list.

The patch introduces method getSingletonInstances() that returns a list
of all registered singletons (used in setUp()), and method
resetSingletonInstances() that resets registered singletons to a given
stored list (used in tearDown()). This way it is possible to fiddle in
tests with purgeInstances() without introducing side effects to other
tests.

All unit tests that used purgeInstances() are adapted to take care
of re constitution of changed objects this way.

Change-Id: I19dc869423a537226bb019e227d84b6f74fe9afc
Resolves: #40780
Releases: 6.0
Reviewed-on: http://review.typo3.org/14487
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The PHP parser caches NULL instead of an array when the Backend
language is not available for a given extension using PHP array
localization files (e.g., tscobj with German "de").

This leads to PHP warning when reading the labels as NULL cannot
be used in a foreach statement.

Change-Id: I1678674ecfba71e04c9c13aed44dd7f0aa574cbc
Fixes: #40643
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/14360
Reviewed-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: I61bfb67d9e633ddb25eebf2c82092c67c9ea8970
Releases: 6.0
Reviewed-on: http://review.typo3.org/14480
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch moves most unit tests of the tests/Unit/t3lib/*
directory to the core extension, following the new name scheme.

Change-Id: Ia03bc00ccb256c68684f7243fea77804081cb287
Resolves: #40770
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14475
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch moves most unit tests of the tests/Unit/t3lib/*
directory to the core extension, following the new name scheme.

Change-Id: Ia08a3c0251c577676e3920dc880bb54e1651e5c2
Resolves: #40620
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14339
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The patch fixes some rather obvious problems in EXT:extensionmanager
to stabilize the tests. Furthermore the extension dependency
calculation did not work due to missing TCA definition.

Change-Id: I8364f603c5d3c104554838e303f156114f047c16
Resolves: #40771
Releases: 6.0
Reviewed-on: http://review.typo3.org/14476
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

StringUtility::isLastPartOfString does not sanitize the input arguments
enough and throws warnings if calling strlen() for example with arrays.
The patch changes the (new 6.0) method to sanitize the arguments and now
throws Exceptions if they can not be interpreted as string.
The tests are adapted to test for the exception and adds a test with
an object to the data provider.

Change-Id: I497a1478a7804c4bbeddc2d1e340e29d73efa200
Resolves: #40767
Releases: 6.0
Reviewed-on: http://review.typo3.org/14467
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

checkFolderPermissionsRespectsFilesystemPermissions throws a warning
that the third argument from the data provider is missing with its first
data set. The third argument is not always needed and set to a sane
default now.

Change-Id: I25d6c21addcefc5bec6d8f3a8adc48bfc0f38481
Resolves: #40766
Releases: 6.0
Reviewed-on: http://review.typo3.org/14465
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

finfo() in FAL LocalDriver can not deal with vfs streams and throws
warnings. It is used to fetch the mime type of files.
The patch moves the finfo call to an own method and mocks the methods
in all tests that triggered the warnings.
Additionally, the statReturnsCorrectFileInfo() test is splitted into
four tests and renamed to getLowLevelFileInfoReturnsCorrectFile*. An
additional test is added to test for correct retrieval of mime type
with a prepared dummy file.

Change-Id: Ib3dcd0998dee3d2fa7e0e60eabcf783b712c5fdd
Resolves: #40765
Releases: 6.0
Reviewed-on: http://review.typo3.org/14460
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The cshmanual extension must be loaded by default to make the CSH
popups work.

Change-Id: Iad8d12bc2caac8b24cf14ac14a6c3b6afdab5924
Fixes: #40665
Releases: 6.0
Reviewed-on: http://review.typo3.org/14457
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

t3lib_cacheHashTest::cacheHashCalculationWorks() expects three parameters
from the data provider, but the data provider delivers only two. The
third parameter is superfluous and removed with the patch.

Change-Id: I89a651b58522e394130438fe305796e280a947eb
Resolves: #40757
Releases: 6.0
Reviewed-on: http://review.typo3.org/14453
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Most CategoryCollectionTests need dummy records and dummy database
tables to work. They do not only test the category collection class
itself, but also the underlying database functionality and queries.
They are functional tests, and moved to the functional section.

Change-Id: I53b04e701ef1475914c7125ab1a6ae6f908d9a3f
Resolves: #40756
Releases: 6.0
Reviewed-on: http://review.typo3.org/14448
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In Chrome 21, the FlashUploader button is collapsed to a few pixels of
height. So it is nearly impossible to hit the button.

Change-Id: Ia287c1c15b086315442a6b9edba1922de21f3501
Releases: 6.0, 4.7, 4.6, 4.5
Resolves: #39659
Reviewed-on: http://review.typo3.org/13789
Reviewed-by: Thomas Scheibitz
Tested-by: Thomas Scheibitz
Reviewed-by: Torben Hansen
Tested-by: Torben Hansen
Reviewed-by: Marcel Wieser
Tested-by: Marcel Wieser
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcus Schwemer
Reviewed-by: Oliver Klee
Reviewed-by: Laurent Cherpit
Tested-by: Laurent Cherpit
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Due to a missing TCA-definition it is not possible to
select more than one collection in a content element
of type "uploads".

With adding the missing TCA this works again.

Change-Id: I12907a15fa7efd4e30ff028ccc7aafa77919be8f
Fixes: #40545
Releases: 6.0
Reviewed-on: http://review.typo3.org/14299
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

When using a file a sys_file_reference entry is created.
The fields of that record are pre-filled with values from
the original file.
The title field of the reference currently does not refer
to the title, but to the file-name.

Change-Id: I632e55312af99e31d6e02b35883131411eb4dced
Fixes: #40675
Releases: 6.0
Reviewed-on: http://review.typo3.org/14416
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The auto-generated compat layer for the namespace switch
requires the clickmenu classes within the "Classes" folder
while the reside in "classes". This fails on an system with
case sensitive file system.

Change the reference to the correct folder.

Change-Id: If523418694684b767aeb16298db2a9fb30a443d5
Fixes: #40575
Release: 6.0
Reviewed-on: http://review.typo3.org/14325
Reviewed-by: Anja Leichsenring
Tested-by: Marcel Burkhalter
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

The parsers extending the localization parser interface do not have a
compatible third parameter of method getParsedData() as it is optional
with the 3 implementations (PHP, ll-XML, XLIFF) but is not defined as
this in the interface.

Change-Id: Ifb2f2e9b94c61f53d626aa387513322fa0737c83
Fixes: #40641
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/14358
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

FollowUp to issue #33392 in master - the merged condition
in if always results to true --> every page is considered
as workspace spage. This results in a broken preview
functionality for normal live pages.

Should be integrated in 4.7, 4.6 and 4.5 directly when
backporting the original issue.

Change-Id: Ibe57c575020caf0184ddce54744f52b176027d7a
Fixes: #33392
Releases: 6.0
Reviewed-on: http://review.typo3.org/14357
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

IRRE hide/unhide feature just changes the input of the
hidden field. If the field is not present in the rendered
form, the change is not saved to database.

Therefore add the hidden field of sys_file_references to
the hidden palette.

Change-Id: I46ac1e87c49b995c0b5ec9bf0d454de705c88b68
Fixes: #40564
Releases: 6.0
Reviewed-on: http://review.typo3.org/14317
Tested-by: Marcel Burkhalter
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Since the namespace changes, the custom form-field-
evaluators for passwords shipped by saltedpasswords are
registered using the namespaced classes.

As the registered class name is used by tceForms to build
an internal JS function, the JS is broken due to the fact
that backslashes are not allowed in JS function names.

This patch reverts back to "classic" classnames as eval
identifier.

Change-Id: Ica52c01456be7a8ee2b7988cc9773586852621a6
Fixes: #40561
Releases: 6.0
Reviewed-on: http://review.typo3.org/14315
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Tested-by: Marcel Burkhalter
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Allow setting the subject of an Email
by adding a 3rd input field to the
post processor section of the form tab.

Change-Id: If98fb9de576607a254ba5fcbb72df85584c12037
Releases: 6.0, 4.7, 4.6, 4.5
Resolves: #35787
Reviewed-on: http://review.typo3.org/11245
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Change-Id: I62d28c206a43d178ae5ec830126b9e86013de6bc
Resolves: #40168
Releases: 6.0
Reviewed-on: http://review.typo3.org/14066
Tested-by: Mario Rimann
Reviewed-by: Mario Rimann
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

With the introduction of namespaces, the references to SPL exceptions
like InvalidArgumentException were not prepended with a backslash. This
renders these references invalid (the class cannot be found in current
namespace) and leads to warnings in most IDEs.

Change-Id: I361f81ed514788852a851aebbb8677b6f533f79a
Resolves: #40536
Releases: 6.0
Reviewed-on: http://review.typo3.org/14292
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The TCA configuration of sys_file allows direct editing of the file
name. As t3lib_TCEmain does not recognize this change as a
filesystem-related change on saving, the file is not renamed on disk.
Instead, the index record is changed, so the file is not recognized
anymore, leading to a reindexing. Because of this, all references to the
old record seem to break.

This commit makes the name field read-only and adds the title field
(which is not present in the TCA at all currently).

Change-Id: Ice110fa7ea0cc335f8b9fa8a57ecc9fe7527de76
Resolves: #39884
Resolves: #36795
Resolves: #39859
Releases: 6.0
Reviewed-on: http://review.typo3.org/14260
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The FileExtensionFilter filterInlineChildren() raises a warning if
$parameters['values'] is not an array. This is triggered by test
areInlineChildrenFilteredWithInvalidParameters() and is sanitized
with this patch.

Change-Id: Ic18575f041eb9e284dc45190d598927c2c0649c5
Resolves: #40543
Releases: 6.0
Reviewed-on: http://review.typo3.org/14298
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Service/IndexerServiceTest mocks $GLOBALS['TYPO3_DB'] without a correct
backup and destroys the database resource handle. The patch takes care
that the mock is created correctly, and the orgininal database handle
is re constituted during tearDown().

Change-Id: Id16d6970d6c0614b593a4bc25b69ee1c17963fbe
Resolves: #40542
Releases: 6.0
Reviewed-on: http://review.typo3.org/14297
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

AbstractMenuContentObjectTest of frontend extension mocks TSFE
(TypoScriptFrontendController) but does not provide all needed
constructor parameters, which raises warnings.
The patch now gives add sane parameters.

Change-Id: I80bc3baa701c5994af9299ba0ba3d79aef12c917
Resolves: #40541
Releases: 6.0
Reviewed-on: http://review.typo3.org/14296
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn