- Feb 26, 2017
-
-
Christian Kuhn authored
Controller class UpgradeWizard of install tool method performUpdate() calls getDatabaseConnection() (old TYPO3_DB) and connects. This was done in the past to receive the list of executed queries during upgrade and is now implemented in the single upgrade classes directly. If running postgres, the connect attempt of old database class tries to connect to a mysql instance and runs into a timeout. Remove this TYPO3_DB left over from the install tool to successfully execute upgrade wizards on non-mysql platforms. Change-Id: Ia87ae4bce1c4f4992527f0fa6fbddebdb6e3733c Resolves: #80026 Releases: master Reviewed-on: https://review.typo3.org/51862 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Aug 30, 2016
-
-
Christian Kuhn authored
We don't want to still have fresh installations that enable ext:dbal. The patch removes the ext:dbal specific handling from the install tool steps. With an active loaded ext:dbal, the install tool still works fine and runs through the steps, only new installations can no longer choose "i do not use mysql". Change-Id: I4b694d377df41b8ce3bd6360c7f81c9e4cd28843 Resolves: #77622 Releases: master Reviewed-on: https://review.typo3.org/49578 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- Apr 12, 2016
-
-
Morton Jonuschat authored
The Doctrine DBAL library is added as a composer dependency as a foundation to replace the current DatabaseConnection class, EXT:dbal and EXT:adodb. Doctrine DBAL is encapsulated within a ConnectionPool class that manages the connections to all defined database connections. The main parts of the patch consist of the connection management, convenience methods for simple SQL queries, a QueryBuilder to build complex queries in a database platform independent way and a QueryRestriction Builder that aims to replace deleteClause and BEenableFields in the backend context as well as enableFields in frontend context. Documentation and an example implementation of using the API will follow in separate patches. Releases: master Resolves: #75454 Change-Id: I47837d9e77331132807bbb7fb956c359031b4f16 Reviewed-on: https://review.typo3.org/47111 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Mar 01, 2016
-
-
Claus Due authored
This change removes usages of ObjectManager and general dependency injection with injection methods across the install tool (including AJAX actions). Where necessary, constructor dependency injection has been implemented with automatic dependency instantiation if not passed as constructor argument. Change-Id: I859f07789120f538a1d735f386ff3ba3163bd00e Resolves: #73605 Releases: master Reviewed-on: https://review.typo3.org/46883 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jan 29, 2016
-
-
Claus Due authored
This change: * Adds `typo3fluid/fluid` as dependency * Converts system extension `fluid` to a so-called Fluid adapter * Adds TYPO3-specific Fluid integrations as compatibility layer * Turns Fluid's RenderingContext into a very flexible API * Updates a few templates and core ViewHelpers for compatibility On a more general level the change allows using a wide array of new template syntaxes and integration features (see feature documentation included with this commit in `core` extension). The breaking changes are minimal; mostly caused by removal of deprecated code from the `fluid` system extension (rather than fundamental changes to how Fluid itself works). Custom templates should work with little or no migration required. Change-Id: Ib505cb66dabcc711868924d2fab3015ce549fbde Releases: master Resolves: #62940 Resolves: #69863 Resolves: #58752 Resolves: #48221 Resolves: #49903 Resolves: #54509 Resolves: #55343 Resolves: #55660 Resolves: #57446 Resolves: #70036 Resolves: #61144 Resolves: #60082 Resolves: #11287 Resolves: #70960 Resolves: #71552 Resolves: #67930 Resolves: #48656 Resolves: #71821 Resolves: #59540 Reviewed-on: https://review.typo3.org/42425 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Marc Neuhaus <apocalip@gmail.com> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jan 15, 2016
-
-
Christian Kuhn authored
Install tool has a fallback layer to a php based template in case fluid does not work due to broken reflection for @inject annotations. Since @inject isn't used anymore in install tool this layer can be dropped now. Change-Id: Iedf0e9ea75fa105f649324c993963fb29e666607 Resolves: #72724 Related: #55352 Releases: master Reviewed-on: https://review.typo3.org/45868 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
TYPO3 Release Team <typo3cms@typo3.org>
-
- Jul 14, 2015
-
-
Helmut Hummel authored
Remove the possibility for extensions to provide error and exception handling configuration in ext_localconf.php of an extension. This only worked anyway only for errors or exceptions at a later point in the bootstrap. We now by definition make it only possible in LocalConfiguration.php (or AdditionalConfiguration.php). In addition make the configuration more reliable and understandable: * Register error handler even if exception handling is not configured. * Remove option 2 for displayErrors option * Configure everything only once and early in the bootstrap. Releases: master Resolves: #68131 Change-Id: I204f17510fcb10fa8601162687793910fbcf4464 Reviewed-on: http://review.typo3.org/31844 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jun 10, 2015
-
-
Helmut Hummel authored
Use composer class loader instead of the TYPO3 class loader when TYPO3 is not installed via composer, thus building the same class information logic during runtime (and caching it away) as composer does with its "dump-autoload" command. Releases: master Resolves: #67212 Change-Id: Id032411a690d67ca690a724748c3c796d2bb5f6e Reviewed-on: http://review.typo3.org/39827 Reviewed-by:
Thomas Maroschik <tmaroschik@dfau.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org>
-
- May 06, 2015
-
-
Christian Kuhn authored
Install Tool bootstrap initializes the cache system and sets all caches to NullBackend for increased stability of the tool. Install Tool submodules however, that later call a bootstrap method to additionally load ext_tables and friends for some scenarios, indirectly call a method to set caches to the default values without NullBackend again. As result, Fluid views are sometimes cached again. The patch supresses this by opening further detail methods of the Bootstrap and calls them directly without pushing a cache configuration again. Resolves: #66809 Releases: master Change-Id: I64acf470eba939eb7ba246aedb2bbb0fdf83384f Reviewed-on: http://review.typo3.org/39283 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- May 05, 2015
-
-
Christian Kuhn authored
The extension compatibility misuses the install tool message system for its tests and hands over on-the-fly arrays instead of proper message objects. The patch moves the message creation to the controller and hands them over to view instead. Resolves: #66805 Releases: master Change-Id: Icea9955e7e1206327f859abf4ec3bcada50a65e6 Reviewed-on: http://review.typo3.org/39279 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de>
-
- Dec 17, 2014
-
-
Roland Waldner authored
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Dec 13, 2014
-
-
Roland Waldner authored
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org>
-
- Nov 21, 2014
-
-
Wouter Wolters authored
Since PHP 5.5 is a requirement, calls with the objectManager should use the ::class construct instead of a string argument. Resolves: #63112 Releases: master Change-Id: Iedbb896607adddce2b23ab67f990fa2296c0d1bb Reviewed-on: http://review.typo3.org/34414 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Oct 28, 2014
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
Frank Nägler <typo3@naegler.net>
-
- Jun 22, 2014
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59778 for further details. Resolves: #59778 Releases: 6.3, 6.2 Change-Id: I155df27e66ec103a4f83356adef7dc441585b54a Reviewed-on: https://review.typo3.org/31023 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 21, 2014
-
-
Wouter Wolters authored
Resolves: #57166 Releases: 6.2 Change-Id: I72aa55cff3322bbe46d271758fd04f3aba860ae7 Reviewed-on: https://review.typo3.org/28619 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Ernesto Baschny authored
For a first installer the directory structure is empty and the first step will try to create it. We do not need to show these as errors to the user, only if the root directory cannot be written. To achieve this we raise "Warnings" instead (which are not shown in first step). To keep the Folder Structure menu item on the left menu in the Install Tool showing a red badge for non existing directories, we change this to also include Warnings. Resolves: #57152 Releases: 6.2 Change-Id: Idd628ecdf946f9befdb7fefd7a9bb7bccc175c2b Reviewed-on: https://review.typo3.org/28605 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
- Mar 20, 2014
-
-
Xavier Perseguers authored
Resolves: #57119 Releases: 6.2 Change-Id: I9be8b51fd695e2470e22fe084eeec507fd78f6f2 Reviewed-on: https://review.typo3.org/28578 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Mar 19, 2014
-
-
Markus Klein authored
AbstractCoreUpdate redefines the $view member to be a JsonView, but does not re-implement the parent methods that rely on $view being an AbstractView. Fix this by re-implementing the initializeHandle() method. This method can be merged with the former initializeCoreUpdate(), which wasn't called at all in most actions. Resolves: #56865 Releases: 6.2 Change-Id: I85260a0e57e915ac941569cfbdde1f96cdaec5e6 Reviewed-on: https://review.typo3.org/28393 Reviewed-by: Philipp Gampe Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 15, 2014
-
-
Ernesto Baschny authored
* Adjust default permissions back to "world readable" (775/664) * Do not attempt to fix permissions on an existing folder structure * Streamline the separation of Notices, Warnings and Errors * Cosmetical optimizations in the "Folder Structure" item * Also report if the default permissions are too insecure (i.e. world writeable / readable). Note that the new defaults (775/664) are set to make the system work by default on almost most scenarios, but the recommended secure setup is still 770/660. This is on purpose to make the administrator aware of it but will require manual intervention (i.e. "thinking") if this setup will work or not (we cannot detect that automatically). Resolves: #52668 Releases: 6.2 Change-Id: I77c72617fa58fd808ebc5fd818e94b48c2644102 Reviewed-on: https://review.typo3.org/25416 Reviewed-by: Christian Kuhn Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Philipp Gampe Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
- Mar 11, 2014
-
-
Xavier Perseguers authored
The install tool forgets to initialize the database connection. Change-Id: Ib7355e4f931c7152a6d13df99ed550c1b61eacf9 Fixes: #56763 Releases: 6.2 Reviewed-on: https://review.typo3.org/28254 Reviewed-by: Andreas Fernandez Tested-by: Andreas Fernandez Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 08, 2014
-
-
Helmut Hummel authored
The installer does not work, if doc comment reflection is broken, so we need to make the first install step more robust by using inject methods and introducing a failsafe view which does simple php templating in case critical errors (like doc comments disabled) occur. Resolves: #55352 Releases: 6.2 Change-Id: I424d6a290b65ae023ec19a745477cfaecdef72c7 Reviewed-on: https://review.typo3.org/27067 Tested-by: Alexander Opitz Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 04, 2014
-
-
Markus Klein authored
Refine the class and interface structure of Install Tool actions. Resolves: #52736 Releases: 6.2 Change-Id: Id1b0107670859e140169767233ba9944822e0d8d Reviewed-on: https://review.typo3.org/24665 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Jan 29, 2014
-
-
Thomas Maroschik authored
In the installer fatals can happen during updates of very outdated extensions. Many updates can lead to a redirect to the extension check where the user gets displayed a message that a fatal has been detected. But the detected fatal error itself is not displayed. This patch passes the error as url parameter to the extension check and displays it there. Fixes: #54943 Releases: 6.2 Change-Id: I111df5d5411015b21c4b2b5e9be3b83b311c8bc5 Reviewed-on: https://review.typo3.org/26781 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Thomas Maroschik Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Oct 08, 2013
-
-
Christian Kuhn authored
The patch provides the code infrastructure to test for possible core updates using information from get.typo3.org and implements a "one-click" update within "important actions". The update itself is implemented as a list of ajax calls performed after each other to have minimal impact and side effects to current core code. The service classes "CoreVersionService" and "CoreUpdateService" contain the main business logic and may be used in a reports module or scheduler task later on. Change-Id: I5947252ca805b237b513fdafcf2696e9da586fc0 Resolves: #52547 Releases: 6.2 Reviewed-on: https://review.typo3.org/24396 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Oct 01, 2013
-
-
Christian Kuhn authored
Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b Resolves: #52360 Releases: 6.2 Reviewed-on: https://review.typo3.org/24212 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Sep 29, 2013
-
-
Christian Kuhn authored
Similar to the environment status the number of folder structure errors are now shown in the left menu. Change-Id: I665c32e8a3c4389941437a2bb6caeb32b862b673 Resolves: #52368 Releases: 6.2 Reviewed-on: https://review.typo3.org/24136 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Sep 13, 2013
-
-
Ernesto Baschny authored
* Streamlines install tool main template. * Adds a ContextService and use that in the templates. No more huge if/then/else constructs to differentiate standalone and backend modes. * Fixes the left menu (and TYPO3 logo), letting the rest scroll up and down. * In backend mode the menu and content starts right on top (no further headers to make scrolling look good) Releases: 6.2 Resolves: #50910 Change-Id: Ie2ec277026a82332b533af51a37e7f308dd24e8c Reviewed-on: https://review.typo3.org/23798 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
- Aug 27, 2013
-
-
Nicole Cordes authored
In the installation wizard (123 steps) the admin user is created with a md5 hashed password. For security reason this should be changed to a salted password. As this function is used in #31407 as well it was refactored to the AbstractAction class. Resolves: #50612 Releases: 6.2 Change-Id: Ide966eb1c1e05d2190f0d22446bc2b3e92643451 Reviewed-on: https://review.typo3.org/22738 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Rotsch authored
With displaying the count of failed error checks in the navigation menu (like the count of unread messages in an email inbox) a user will more likely enter the "System environment" section of the install tool and take care about the found errors and warnings. Change-Id: I3d9b628b428da13992c3dc1e7e5ab6beaeda5ce1 Resolves: #51410 Releases: 6.2 Reviewed-on: https://review.typo3.org/23380 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Rotsch authored
Purpose of the initialize() method in the AbstractAction class is the initialization of a handle. It is not intended to be used for generally initializing classes derived from AbstractAction. By refactoring the method name, the method's purpose will be indicated more clearer. Change-Id: I1603090e4dfccb5b57da4fa9c3792ec73647c524 Resolves: #51396 Releases: 6.2 Reviewed-on: https://review.typo3.org/23364 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Jul 05, 2013
-
-
Philipp Gampe authored
With the switch to mysqli in 6.1, the connection to mysql server via socket broke. With mysqli, the definition is now: * If hostname is "localhost", a socket is used and the socket file can be given optionally if it is different from the default. * If hostname is not "localhost" but an IP address, a port can be given that may be different from the default mysql 3306. The patch now reflects this in the database connect step and adds a parameter for the optional socket location. The patch will be adapted for 6.1 to include only the additional optional socket parameter. Resolves: #48117 Related: #49162 Releases: 6.2, 6.1 Change-Id: I968a72dbaf90b3f319c03e697137630534d325c1 Reviewed-on: https://review.typo3.org/20933 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 19, 2013
-
-
Christian Kuhn authored
Main features: * The god class "Installer" is gone and split into two major parts. A step controller handling major upgrade and install tasks, and a tool controller handling the known install tool actions. * The step controller is designed to be always called prior to the tool controller, if a step needs execution, it comes up, otherwise the tool controller will be executed. * The entry point typo3/install/index.php is gone and substituted by typo3/sysext/install/Start/Install.php. The file contains a lengthy comment to document the main request flow and used GET/POST parameters. * Most parts of the install tool do not bootstrap the whole system anymore, in general only the base bootstrap, dbal (if loaded), extbase and fluid ext_localconf.php are loaded. This makes sure the install tool can not fatal if some extensions ext_localconf is broken. The whole install tool runs without any caching, so a fatal in some cache file can not kill the install tool execution. * Installing TYPO3 CMS on a dbal enabled system is now handled in the step installer directly to make the according code easier to understand. * Rendering is done with a simplified fluid standalone view. * All install tool forms are CSRF protected. * A new and fully unit tested class structure is introduced, designed to take care of the basic file and folder structure of the instance. It is used during installation to create the needed structure and can be called in the install tool to compare and fix the current instance structure with the expected structure. In effect, the "dummy" package is obsolete. An instance can be created by just linking index.php, typo3_src/ and typo3/ within the document root, the installer takes care of creating everything else. * The installation procedure is released from the package handling. Packages will be handled by the extension manager after initial installation with another patch. Loose ends: * The whole package handling needs to be implemented in the extension manager. * Not all upgrade wizards work, this code area needs some love. * A 'core' auto updater could be implemented now. A GSoC project is currently running to realize this. * The SQL schema migration API is a mess and should be refactored. For now, another helper class is introduced to encapsulate some of the nasty details. * An auto configuration and configuration suggestion system is planned and needs to be done. It should suggest best configuration options in the install tool, and should auto configure the system during installation in the last install step. * If the backend or frontend fatals due to some extension that triggers a fatal in ext_localconf or ext_tables (for example due to a require() of a no longer existing file), a small helper action in the install tool could find those extensions and suggest to unload them. Change-Id: Ice3248caa903449ad6a83ea4f234c7bd125bdb66 Resolves: #49162 Releases: 6.2 Reviewed-on: https://review.typo3.org/21468 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Tested-by: Alexander Opitz Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-