- Apr 17, 2024
-
-
Jasmina Ließmann authored
With #92993 the table 'index_stat_search' was removed. The related field 'index_stat_search_id' in table 'index_stat_word' is left as an orphaned remnant. This patch now removes the field. Resolves: #103649 Related: #92993 Releases: main Change-Id: Idc04a6675c6b75fefd13149cd68a93a2cca3123d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83847 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Christian Kuhn authored
TCA type=select has no config field 'foreign_field'. A check in RootlineUtility can be simplified a bit. Resolves: #103647 Releases: main Change-Id: Ia34a79f1797a9dfb8d9fbadb76d12fd1b2b175b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83845 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Jasmina Ließmann authored
The element information modal displays both field information for the current record and its references. The more fields there are in a table and the more content the specific record contains, the more the reference sections disappear from view. The three sections are now displayed as accordions to enable the user to decide for themselves which sections are relevant to them. In addition, the display of non-existent records in the reference sections has been adjusted and information about the paths/storage locations has been removed, as these can already be viewed in the record's editing mask. Resolves: #102469 Releases: main Change-Id: Ia4ba85921d7be2ab30477e8248d4fb8734f6eaaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81873 Tested-by:
-
Jasmina Ließmann authored
Several minor adjustments have been made to the submodules of the “Indexing” backend module to improve the UX and accessibility. This includes, among other things, the following: * move action links to a dedicated control/button-group column * use badges for label 'Not indexed' * set unique h1 in all submodules * use correct heading levels (h2/h3) * show infobox when either no page has been selected or no results exists and unify locallang labels * add label to back-button in statisticDetailsAction * move back-button to docheader in wordDetailAction Resolves: #103593 Releases: main Change-Id: I078ba09de3c0a9e3ae000231c63b29bc203af8d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83733 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Apr 16, 2024
-
-
Stefan Bürk authored
Default value support for TEXT, JSON and BLOB fields has been added with #103578 by implementing the use of default value expression for MySQL. That required to add custom normalization on data schema reads to be comparable. MySQL requires to use a single-quote to quote a single quote in a value string, and due to the expression way this needs to be properly decoded now in two steps: * Revert escape sequences in the retrieved default value * Unquote the unescaped retrieved default value JSON field defaults shows a similar issue for double quotes in the json value and can be fixed in the same way. Added test revealed, that Doctrine DBAL has an issue with double single-quotes for PostgreSQL too. To fix this the issue has been reported [1] and a pull-request provided [2]. This change ensure correct unescaping and unquoting of the retrieved column default value for TEXT, JSON and BLOB column types for MySQL connections, enriched with further tests. The extended PostreSQLSchemaManager now clones method `_getPortableTableColumnDefinition()` to incorporate the bugfix directly until a fixed Doctrine DBAL version has been released. [1] https://github.com/doctrine/dbal/issues/6357 [2] https://github.com/doctrine/dbal/pull/6358 Resolves: #103610 Related: #103578 Releases: main Change-Id: Icb39cdb8c87ae7907f84e5c38adcde4ef545ed1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83745 Tested-by:
-
Benjamin Kott authored
Resolves: #103638 Releases: main, 12.4 Change-Id: Ib5880f2ea62c8d9b54b7db6f6488fc6d5a479827 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83836 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Willi Wehmeier authored
Add proper focus styles to the nav links in the Link Browser modal window. Resolves: #103631 Releases: main, 12.4 Change-Id: I0abb597124e335c3955c73438ac3cd2f0dad93bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83786 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Christian Rath-Ulrich authored
To trigger a search, usually an icon-only button is placed next to the search input field. To improve the accessibility of these icon-only buttons, a visually hidden label is added. Resolves: #102410 Releases: main, 12.4 Change-Id: Ifd7faee3d4c727dd2e86ad7304e19f970b61699e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81800 Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Lina Wolf authored
Remove excess bracket Releases: main, 12.4 Resolves: #103635 Change-Id: Ie9ea1f03457177eeb6be7abb788c05bd2bf64e8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83832 Tested-by:
-
Torben Hansen authored
The new core `HashService` and the deprecated extbase `HashService` have the function `validateAndStripHmac` to validate and strip a given HMAC appended string. The function will throw an exception, if the given string is either too short or the appended HMAC in the string is not valid. In context of a TYPO3 extension, those exceptions are usually thrown, when a given HMAC appended string has been tampered. Logging those exceptions to sys_log or logfiles make no sense, since a TYPO3 site owner have no reasonable possibility to prevent a tampered HMAC appended string being passed to the `validateAndStripHmac` function. This change prevents logging of four exceptions caused by potential manipulated HMAC appended strings. Additionally, a note has been added to extbase `HashService`, that exception codes from that class must be removed in v14 in `AbstractExceptionHandler::IGNORED_HMAC_EXCEPTION_CODES`. Resolves: #103592 Releases: main, 12.4 Change-Id: I2870db815f3348cac2465b1caca711f4736f16db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83774 Reviewed-by:
Christoph Lehmann <christoph.lehmann@networkteam.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Chris Müller authored
As "Hotkeys" is the default export inside hotkeys.js, it must be outside the curly braces. Resolves: #103623 Related: #101507 Releases: main Change-Id: I43cfea685503caa54bc1f7e786e16a01c5e06c61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83780 Tested-by:
-
Oliver Bartsch authored
While introducing the new module registration API, the previously used page TSconfig options to hide modules has been replaced by an extended user TSconfig option. This change (page TSconfig -> user TSconfig) is now clarified in the corresponding changelog. Resolves: #103627 Releases: main, 12.4 Change-Id: Ic701cf0674c8ff1ed18273ad2629b2217947f7c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83812 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
- Apr 15, 2024
-
-
Oliver Bartsch authored
The search word is now properly kept on switching between advanced and normal search mode in EXT:indexed_search. Resolves: #103633 Releases: main, 12.4 Change-Id: Ic694e40da3a7bdeee3d76be2402fd4bf8e150e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83787 Tested-by:
-
Kevin Appelt authored
Resolves: #103628 Releases: main Change-Id: I5728324bc922682fcccea2ee90a5cb9eb3f77923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83782 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Andreas Kienast authored
The "Upgrade Wiards" view automatically checks whether mandatory database changes are pending. In that case, a list of tables, fields and indices are rendered. Before the removal of jQuery, a line break was rendered between the list items. However, the migration was not complete, as the line breaks are now rendered as `<br>`. The commit fixes this by creating real `<br>` elements. Resolves: #103613 Releases: main Change-Id: I6896ceeaed30606f55ac4376002552f92224c878 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83784 Tested-by:
-
Benjamin Franzke authored
An invalid site-set fluid condition was added in #103439 that cause the site-set related label to also be printed for `sys_template` record where a button was to be shown instead. Releases: main Resolves: #103629 Related: #103439 Change-Id: I44b970a5fcc9bd84abe12301b98b6967da92e7dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83783 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Apr 13, 2024
-
-
Philipp Kitzberger authored
It's now possible to filter the page tree not only by strings and single uids but by comma-separated lists of uids. Resolves: #103220 Releases: main Change-Id: I6cae67676d438dd3ce3992aee8fe160173ad142c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83153 Reviewed-by:
-
Jasmina Ließmann authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files. An attribute was used twice, this is hereby corrected. Resolves: #103620 Related: #103615 Releases: main, 12.4 Change-Id: I4d813f29db0d64f486c1d5593bc8c2b955a8eafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83777 Tested-by:
-
- Apr 12, 2024
-
-
Andreas Kienast authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files, but one had a typo. It's fixed now. Resolves: #103616 Related: #103615 Releases: main, 12.4 Change-Id: I2e2ab733e5b7186193cd4f8482b4ff6c0a6e0b28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83773 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
Andreas Kienast authored
Resolves: #103615 Releases: main, 12.4, 11.5 Change-Id: I11f609625051f7dc6418596229bed49f282bc842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83772 Reviewed-by:
-
Christian Kuhn authored
New version phpdocumentor/reflection-docblock:5.4.0 changed the signature of DocBlockFactory::createInstance(), which now points out a misuse in extbase. The patch changes the instantiation and avoids calling registerTagHandler() since this can and should be hand over to createInstance() directly. Resolves: #103614 Releases: main, 12.4 Change-Id: I344ef7df23dedd950c2775fe2fab93f7bb808786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83750 Tested-by:
-
Georg Ringer authored
`DateTimeImmutable::setTimestamp()` requires the timestamp to be an integer. Resolves: #103588 Related: #99627 Related: #98045 Releases: main, 12.4, 11.5 Change-Id: I2dba1b3836063872fa04ea38d58b5bd499a8f7d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83742 Reviewed-by:
Rafał Jania <rr.jania@gmail.com> Tested-by:
-
Andreas Kienast authored
This commit replaces the abandoned package `@ronilaukkarinen/stylefmt` with the already installed `stylelint` tool. Please note that this is an intermediate step to give the build toolchain some love it deserves. Executed commands: npm remove @ronilaukkarinen/stylefmt npm install --save-dev \ autoprefixer@^10.4.19 \ postcss-scss@^4.0.9 \ stylelint@^14.16.1 \ stylelint-scss@^5.3.1 Resolves: #103612 Releases: main, 12.4 Change-Id: I1f283d50a1a6504c4c000e674c75a40923f6c7e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83748 Reviewed-by:
-
- Apr 11, 2024
-
-
Stefan Bürk authored
Test covering the SQL file parser has been streamlined and enriched with #103602, adding a disabled test with a todo to enable it when the SuT is fixed. Turns out the parser already handles the case well, the patch just enables the test. Resolves: #103605 Related: #103602 Releases: main, 12.4 Change-Id: I4b39dce5265c2504a9dc5f11a70dfe94702d0451 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83746 Tested-by:
-
Benjamin Franzke authored
Treat site sets (#103439) as a default content rendering template, in order to load Extbase plugin registrations prior to site sets. Also add a possibility to opt out from being loaded globally in site sets in ExtensionManagementUtility::addTypoScriptSetup and ExtensionManagementUtility::addTypoScriptConstants in order to reduce global TypoScript in upcoming commits (#103556). Resolves: #103580 Related: #103439 Related: #103556 Releases: main Change-Id: Ib9297c775d89f1689410f83e83955d6be829d2e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83722 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Stefan Bürk authored
* Add variable names as dataprovider set array keys to increase readability. * Add dataset for double-quote parsing in default values. * Add a disabled dataset for single-quote parsing in default values with todo to enable it with the bugfix. Resolves: #103602 Releases: main, 12.4 Change-Id: Ie85deff13598238fc437f6781b6ccf8349801846 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83741 Reviewed-by:
-
Christian Kuhn authored
RootlineUtility uses RelationHandler to resolve relations attached to pages. The tests from #103598 show that relations which are set to deleted ("delete placeholder", t3ver_state=2) are not considered and still part of the result set. The patch adds a missing call to prevent these. Resolves: #103599 Related: #103598 Releases: main, 12.4 Change-Id: Ie580e4d9b64c477d8c9d6d4092114c18f43a2a70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83738 Tested-by: -
Christian Kuhn authored
* Increase abstraction in imported CSV fixture to separate scenarios from each other. * Turn single tests into a single test powered by a data provider. * Add tests for pages['media'] relation resolving. * Point out a bug related to a deleted workspace relation. Resolves: #103598 Related: #103566 Releases: main, 12.4 Change-Id: I679534f1837a4dc73e1d875bf5ee26f45566889d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83735 Reviewed-by:
-
Andreas Kienast authored
This commit updates ckeditor to 41.3. See changelog at [1]. Executed commands: npm install --save \ @ckeditor/ckeditor5-alignment@^41.3.0 \ @ckeditor/ckeditor5-autoformat@^41.3.0 \ @ckeditor/ckeditor5-basic-styles@^41.3.0 \ @ckeditor/ckeditor5-block-quote@^41.3.0 \ @ckeditor/ckeditor5-clipboard@^41.3.0 \ @ckeditor/ckeditor5-code-block@^41.3.0 \ @ckeditor/ckeditor5-core@^41.3.0 \ @ckeditor/ckeditor5-editor-classic@^41.3.0 \ @ckeditor/ckeditor5-engine@^41.3.0 \ @ckeditor/ckeditor5-essentials@^41.3.0 \ @ckeditor/ckeditor5-find-and-replace@^41.3.0 \ @ckeditor/ckeditor5-font@^41.3.0 \ @ckeditor/ckeditor5-heading@^41.3.0 \ @ckeditor/ckeditor5-horizontal-line@^41.3.0 \ @ckeditor/ckeditor5-html-support@^41.3.0 \ @ckeditor/ckeditor5-indent@^41.3.0 \ @ckeditor/ckeditor5-link@^41.3.0 \ @ckeditor/ckeditor5-list@^41.3.0 \ @ckeditor/ckeditor5-paragraph@^41.3.0 \ @ckeditor/ckeditor5-paste-from-office@^41.3.0 \ @ckeditor/ckeditor5-remove-format@^41.3.0 \ @ckeditor/ckeditor5-show-blocks@^41.3.0 \ @ckeditor/ckeditor5-source-editing@^41.3.0 \ @ckeditor/ckeditor5-special-characters@^41.3.0 \ @ckeditor/ckeditor5-style@^41.3.0 \ @ckeditor/ckeditor5-table@^41.3.0 \ @ckeditor/ckeditor5-theme-lark@^41.3.0 \ @ckeditor/ckeditor5-ui@^41.3.0 \ @ckeditor/ckeditor5-undo@^41.3.0 \ @ckeditor/ckeditor5-utils@^41.3.0 \ @ckeditor/ckeditor5-word-count@^41.3.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.0 Resolves: #103589 Releases: main, 12.4 Change-Id: Id24aac98727af0d0b9284e68dd8c4a4e138a6c15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83730 Tested-by:
-
- Apr 10, 2024
-
-
Jasmina Ließmann authored
If no page has been selected in the "Indexing" backend module, an information is displayed. This text is now displayed in the typical infobox style instead of as a heading. Resolves: #103590 Releases: main, 12.4 Change-Id: I6e44c5ad8502eb7ecb71581cb11084543c3e13aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83732 Reviewed-by:
-
Stefan Bürk authored
Database default value configuration for TEXT, BLOB and JSON field types has been impossible to use in a cross database vendor manner due to lacking support from MySQL. Direct default values are still unsupported, but since `MySQL 8.0.13+` [1] it is possible to use a default value expression with a slightly different syntax. TYPO3 v13.0 already raised the minimal requirement to MySQL 8.0.17 paving the way to provide a compatible way to define default values on database level now. To align the TYPO3 Database Analyzer stack ... * the extended `MySQLSchemaManager` is modified to revert default value expression to concrete values to make them comparable. * default value expression are created for these field types by modifing the extended Doctrine MySQL platform classes using the `MySQLDefaultValueDeclarationSQLOverrideTrait`. This change now adds support for database level default values for TEXT, JSON and BLOB fields and is accompanied by additional tests. NOTE: This unblocks TCA type=input default schema management. [1] https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-13.html#mysqld-8-0-13-data-types Resolves: #103578 Releases: main Change-Id: I61c63335b6d0edc80608c246db2e2f6dbae88223 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83556 Tested-by:
-
Jasmina Ließmann authored
To better identify the different record types, the record icon is now displayed next to the record title and some unnecessary double quotes are removed. The actions are now displayed as badges. Also, in the h1 the table name and UID have been removed. Resolves: #103433 Related: #103291 Releases: main Change-Id: I5b09258ca688f0d4ecdd1737b00b8b5a156e6ace Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83528 Reviewed-by:
-
Jasmina Ließmann authored
To improve accessibility, labels have been added to various form fields in the "Full search" area. In this process, existing hard-coded label texts were moved to the corresponding XLF file and their names were partially updated. In the results list, all action buttons now have a link title. Form fields that previously ran across the entire screen width were limited in width to improve readability. Resolves: #103443 Releases: main Change-Id: I713d659a3d9ad4f00fb38cf60529fe24f81d8fd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83552 Reviewed-by:
-
Oliver Bartsch authored
Provide the missing template record variable, used in the info box of the constant editor, in case no template is selected (special UID -1). Happens for sites using site sets and therefore having no sys_template record to be selected. Resolves: #103568 Related: #103439 Releases: main Change-Id: I59379fa565159257e062e04a538f29901cb3fbd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83706 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
- Apr 09, 2024
-
-
Christian Kuhn authored
Brings a bugfix to improve dealing with .csv fixture files during import a bit better. > composer u typo3/testing-framework Resolves: #103575 Releases: main Change-Id: If1ae9202a9f43d707dc961504f5b40d5c223475c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83714 Reviewed-by:
-
- Apr 08, 2024
-
-
Stefan Bürk authored
This change adds additional tests to cover additional variants for `EXT:redirects` handling. Placing guards helps to avoid mitigating regressions for these cases. Resolves: #103564 Related: #103395 Related: #103555 Releases: main, 12.4 Change-Id: I4b6deb258610d1a3d416c16eec610aa2bfd9ef72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83703 Tested-by:
-
Christian Kuhn authored
RootlineUtility is *the* performance bottleneck in FE. But we have a cunning plan for improvements :) The patch streamlines some details to prepare things. RootlineUtility: * Protect getCacheIdentifier() and isMountedPage(), which were only public to unit test them. * Throw an exception if TCA pages columns is not set, which would indicate a serious misuse in early bootstrap. * Simplify minor details. Tests: * Merge remaining unit tests into functional tests. * Switch from YAML based DB scenario creation to direct CSV import to gain more control in tests. * Test reference index integrity of import CSV. Spoiler alert: This will become more important later. * Move some not related fixtures to a more suitable directory. Resolves: #103566 Releases: main Change-Id: Ife5c2e115abfcf3f399ebc49dcf5759461812293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83705 Reviewed-by:
-
Andreas Kienast authored
The method `HtmlParser->caseShift()` is used to normalize the casing of values that are about to get compared, depending on whether a case-sensitive comparison is wanted at all which isn't, by default [1]. Also, the method had a runtime cache that doesn't have a great benefit. Therefore, the method is removed and normalization is done at the former method calls. [1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/HtmlparserTags.html#fixattrib-attribute-casesensitivecomp Resolves: #103565 Releases: main Change-Id: I260daeaa677418e5f7a619176e1fae17e5f68bb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83704 Tested-by:
-
Christian Kuhn authored
Switch a couple of classes to use more DI. Note class Lexer was instantiated with a 'poor man' and oldschool approach similar to XCLASS before, which is now switched to DI. This is not considered breaking since all involved classes are marked `@internal`, there is not a single TER extension that actually uses this 'EXTCONF' based Lexer override, the class does not even have a proper interface, and any override most likely broke with previous v13 patches already. Resolves: #103562 Releases: main Change-Id: I4a09967e8b2d0b9c1da6e8be0634b2ba6edd05c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83700 Tested-by:
-
Andreas Kienast authored
Similar to editing regular content elements, it is now possible to save scheduler tasks being edited via keyboard shortcuts as well. Resolves: #103563 Releases: main Change-Id: Ia159293670f3f3dc762f3c23da35e0e71d5541fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83702 Reviewed-by:
-
