- Nov 20, 2022
-
-
Oliver Bartsch authored
The default duplication behaviour action for the file upload is now properly assigned to the view again. Resolves: #97357 Releases: main, 11.5 Change-Id: Id472dff8154dd4263827863a118f5da4390a7924 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76744 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Nov 19, 2022
-
-
Roman Büchler authored
This allows to use the mask property from the TypoScript imgResource function again. Resolves: #96116 Releases: main, 11.5 Change-Id: Ia069a687e98a91437959e1bbd4efc5d59fb2017c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76708 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Oliver Klee authored
Resolves: #99136 Releases: main, 11.5 Change-Id: I7851afb5f6417bb538895768fe4ae35d8b75d0b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76678 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Klee authored
This helps PHPStan better analyse code that uses this method. Resolves: #99133 Releases: main, 11.5 Change-Id: Ia6da1e1f25a9bfd0f493b2c1e244d79aab865c56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76677 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99134 Releases: main, 11.5 Change-Id: I4ec448a0d06f5614cdc35e7f695c692e4080fbc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76676 Tested-by:
-
Christian Kuhn authored
Resolves: #99138 Related: #96116 Releases: main, 11.5 Change-Id: I303c6cb4c0cbf9b278f66a34cd49345c18ea2a1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76675 Tested-by:
-
- Nov 18, 2022
-
-
Oliver Klee authored
The FAL-related Extbase models are documented in the "TYPO3 Explained" documentation, and they are the recommended way to use FAL in an Extbase context. So the following classes are not marked as `@internal` anymore in order to not send mixed signals to extension developers: - TYPO3\CMS\Extbase\Domain\Model\File - TYPO3\CMS\Extbase\Domain\Model\FileReference - TYPO3\CMS\Extbase\Domain\Model\Folder There is no point in forcing extension authors to re-implement those classes (and duplicating the code from the Core) when the Core implementation is stable now and has proven to work fine. Some history for what has happened: Those classes started out marked as experimental (when they were indeed still experimental). Then, in a cleanup bulk change in 3888dae8f3f71c3f5e1db1c00bcbfe7d0d8fed2e5966e6533c9353b6d7485f32, the classes were converted to use the `@internal` annotation, even though at least the three FAL Extbase models should have been made public API instead by that time. This is where the usage of the FAL models is documented in "TYPO3 Explained": https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Fal/UsingFal/Frontend.html Change-Id: I5e5dfcf292eabd57a080bed29572b7c1eecd9286 Resolves: #99126 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76674 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Nov 17, 2022
-
-
Ingo Fabbri authored
With `fallbackType` set to strict, only translated content is rendered. In AbstractMenuContentObject->sectionIndex content is fetched and overlayed. Once there is an element untranslated, the record overlay will return a $row = `null`. To mitigate, move all left over access to $row inside the guarded if-block. Resolves: #98043 Releases: main, 11.5 Change-Id: If4baf0fb88292cb8c6814539cf7efa610ae850f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76673 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Oliver Klee authored
Passing no action name is a perfectly fine use case as this allows to conveniently redirect from a controller action to any page. Making this explicit in the type annotations allows extension authors to use this pattern without type checkers like PHPStan creating a warnings about this. Resolves: #99110 Releases: main, 11.5 Change-Id: I12cded81cbe20f7f2f626cf71ab92532d9037ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76655 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Matthias Vogel authored
Releases: main, 11.5 Resolves: #99115 Change-Id: I7860824c5377896f94f2ee34b281bf69bae251a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76672 Tested-by:
-
Oliver Klee authored
Extbase controllers that call a never-returning method do not need a return statement after that call in order to avoid calling the rest of the action method. The new annotations ensure that PHPStan becomes aware of this control flow. > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99109 Releases: main, 11.5 Change-Id: I9b9d308440966c71051fe993abd31f23b13c82e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76653 Tested-by:
-
- Nov 16, 2022
-
-
J. Peter M. Schuler authored
Resolves: #99106 Releases: main, 11.5 Change-Id: Iabddf0b2f1c98db6e3e07f26162257f696d6fd9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76616 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99107 Releases: main, 11.5 Change-Id: If5e9d1acf81bf2913405e18cc38f2a7ad5ee62cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76615 Tested-by:
-
- Nov 15, 2022
-
-
Oliver Hader authored
* actually use `array_filter` internally * allow using `array_filter` modes `ARRAY_FILTER_USE_KEY` and `ARRAY_FILTER_USE_BOTH` Resolves: #99071 Releases: main, 11.5 Change-Id: I1b95ae0a7551250125a9eeabbd0ee7e66e25a6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76635 Tested-by:
-
Chris Müller authored
Resolves: #99085 Releases: main, 11.5 Change-Id: Ie3b337b93f43fb2c41d76427f29d793b57e9232b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76633 Tested-by:
-
Chris Müller authored
Resolves: #99037 Releases: main, 11.5 Change-Id: I86cf8b64c198d1707dc3c5f385c6ee19ffa5960c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76632 Tested-by:
-
Benni Mack authored
Change-Id: I7d30b077af9795dfc335a7f9941aba977dd5377e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76604 Tested-by:
-
Benni Mack authored
Change-Id: I357a4d7f4f74c94ad91aa3837b15b83231de4132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76603 Tested-by:
-
Christian Kuhn authored
Resolves: #99088 Releases: main, 11.5 Change-Id: I67f799fdca4d736c36775d50b5ac753eba93ba52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76614 Tested-by:
-
- Nov 14, 2022
-
-
Benni Mack authored
BackendUtility::getPossibleWorkspaceVersionIdsOfLiveRecordIds() is added to check for workspace versions within FormEngine foreign_field logic to first fetch a list of all records that have a versioned record within the workspace, and only apply BackendUtility::workspaceOL() for these cases. Without the patch, each live record triggers a database query to resolve a possible workspace overlay. With the patch, one query is done to see which records have workspace overlays, only those are queried for overlays. This reduces the number of performed queries a lot, since typically only a small number of records are overlaid. This only affects editing records in a workspace. Resolves: #99007 Releases: main, 11.5 Change-Id: Ia7c47e5de0082ca0ff2c68b30d9ff1bc5312981b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76613 Tested-by:
-
Benni Mack authored
This reverts commit 551f540f. Reason for revert: A regression was introduced Change-Id: I7aee1dec8f4197305156f204db27c6f0704762c2 Resolves: #99077 Reverts: #93457 Releases: 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76612 Tested-by:
-
- Nov 12, 2022
-
-
Oliver Klee authored
With the class in the general `EventDispatcher` namespace, extensions can now use this class for their tests. Also add unit tests for the moved class. Resolves: #99070 Releases: main, 11.5 Change-Id: I69b94f50f68dcacfe036e8eb489ba6b82fbb585a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76570 Tested-by:
-
Andreas Fernandez authored
The date-time-picker component now checks properly if the backend user's language could not get fetched from its UC by checking loose for a falsy value. Resolves: #99067 Releases: main, 11.5 Change-Id: I3ba104afde2321480099e96beff6ab77ecb126a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76568 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
This patch updates `moment-timezone`, having a fixed vulnerability, along with the related `moment` library. Executed commands: yarn add \ moment@^2.29.4 \ moment-timezone@^0.5.35 grunt build Resolves: #99061 Releases: main, 11.5, 10.4 Change-Id: I36376bad194aa63dda0146c8bc0f481b932dc89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76557 Tested-by: -
linawolf authored
Solves https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/issues/50 Occurences of `:ts:` are adressed in https://forge.typo3.org/issues/99068 Resolves: #99069 Releases: main, 11.5 Change-Id: I49a42ba29017081d338bec815e3b2c5f14bf7a68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76501 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace `:ts:` with ``:typoscript:` in ViewHelper class comments. `:ts` does not render properly, see for example https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/CObject.html Resolves: #99068 Releases: main, 11.5 Change-Id: Idfac843859a5e9054e6e48f29b19616b2b956dac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76500 Tested-by:
-
- Nov 10, 2022
-
-
Oliver Hader authored
Empty (in terms of PHP empty()) string values are shown as blank strings in the info section of the admin panel. For instance "0" is incorrectly shown as "". Resolves: #99052 Releases: main, 11.5 Change-Id: Ic330fb1874edca8b3e640e9c5793192616583ec0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76549 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Achim Fritz authored
EXT:redirects DataHandler hook to flush the redirects cache in case a redirect is modified does now also work for new redirect records by removing parts of the early return, which relied on records having a numeric uid while new records' uid is the known "NEW.*" string. Resolves: #99042 Releases: main, 11.5 Change-Id: I3624ceecaefd00c0ffce88fd656dc5d81a5b77de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76499 Tested-by:
-
Oliver Klee authored
This update makes a warning more specific. Run commands: > composer req --dev phpstan/phpstan:^1.9.2 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99045 Releases: main, 11.5 Change-Id: I4c5af9d69e0e5b8f4b0d78efd4caa4ed79aed795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76498 Tested-by:
-
Bastien Lutz authored
With Doctrine DBAL in TYPO3 v8, a default value for various fields were added to avoid SQL errors (nullable), setting them to their default value. However, there is a culprit. When editing e.g. be_users.file_permissions where you have selectCheckbox field with all options, it was never possible to unselect all, as the default value was then used. Through some workarounds, DataHandler now checks the modified records on the selectCheckbox type to not fall back on the default value. Resolves: #70812 Releases: main, 11.5 Change-Id: I2cd3bf87c31cd4fe5244b26eb3fe2e58e3d8755c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76497 Tested-by:
-
- Nov 09, 2022
-
-
Oliver Hader authored
Symfony's UrlMatcher takes multiple routes and returns the first match. However there might be better matches that are not considered at all. That's why a custom BestUrlMatcher is introduce, which resolves all matches for further reduction. Previously the route collection was sorted by names and identifiers, which now has been adjusted to focus on the actual matches when being compared to the current request. The fallback route (site base URI). This way, overlapping route definitions can be resolved better. Resolves: #93240 Releases: main, 11.5 Change-Id: Ib1a7361dc86ed48a474d5e55583a622df58e8939 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76513 Tested-by:
-
Benni Mack authored
The backend UI does not support handling of baseVariants for languages, however it is possible to define them in the config.yaml of a site configuration. However, when editing and saving a site, the baseVariants manually defined were removed. This has now been changed, as the baseVariants are kept when persisting the site configuration via the UI. Resolves: #93719 Releases: main, 11.5 Change-Id: I8a0b3be72ddfab46da59b3f8a69ad16121c7246b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76496 Tested-by:
-
- Nov 08, 2022
-
-
Oliver Bartsch authored
Due to changes in #98960 the resolved entity name might contain slashes, which need to be quoted to prevent PHP warnings. Resolves: #99023 Related: #98960 Releases: main, 11.5 Change-Id: I75eecbdbbddc82b5b1189388413fabd7370d4229 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76495 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Generation of a slug proposal based on defined generator fields does now also work for basic select fields, which were previously not considered by the JS component, because they do not use the FormEngine specific visible / hidden field combination. Resolves: #94371 Releases: main, 11.5 Change-Id: Iedd2d17e97db8abd9cf5c4a3b476825fcd854191 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76489 Tested-by:
-
Oliver Hader authored
Change-Id: Ic61feb8ab34ac3136641780bf0ccefb720514d6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76476 Tested-by:
-
Oliver Hader authored
Change-Id: I6e3dbcfbca33453671f63d27630692b2e19572c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76475 Tested-by:
-
Stefan Bürk authored
Default language page slug usage in combination with the siteLanguage base of non-default language has been resolved and delivering the language content. This made the page accessible with multiple urls. Available and existing translated pages should be only resolved by the language slug, not the default language page slug. However, if page is not translated, using the default language slug for the resolving should be only considered and working if fallback settings are provided. Resolves: #88715 Resolves: #96010 Releases: main, 11.5 Change-Id: Id618880fe2ba26fd3b6ab50b4813968923ec5acb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76494 Tested-by:
-
Benni Mack authored
FormEngine's TreeRendering for categories utilizes the TreeDataProvider logic, which is handed over a list of available items loaded by FormEngine's AbstractItemProvider. These records have already been validated and a full record was already loaded by FormEngine at this point. The TreeDataProvider construct then fetches ALL records again, as it only works with the "IDs", but not with already loaded full rows. This makes the construct expensive. It needs a bigger overhaul. To mitigate the performance impact of bigger category trees, the patch applies a hack to suppress loading single category rows multiple times by handing them over from FormEngine to the TreeDataProvider construct. As this change is also backported to 11.5, the optimizations are only done for type=category to minimize impact for other Tree usages. Resolves: #84558 Resolves: #90398 Resolves: #97003 Resolves: #76581 Resolves: #98807 Releases: main, 11.5 Change-Id: Ief183f1673d3a17036ca5e68c62dc18a4277def1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76473 Tested-by:
-
Alexander Schnitzler authored
Due to the dependency of those objects to the DataMapper and its own dependency chain, serialization of those objects lead to error: Serialization of \Closure not allowed. To ommit this issue and to reduce the footprint of the serialization data in general, the data mapper should be omitted and reinitialized via __serialize() and __unserialize() Releases: main, 11.5 Resolves: #97190 Resolves: #92148 Change-Id: If8b78a93308eb14d40080c9cceee95754b785ba8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76492 Tested-by:
-
Benni Mack authored
Resolves: #98175 Releases: main, 11.5 Change-Id: Iccc439eafbbb1f959c8c2bc12248b7c4aa560260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76493 Tested-by:
-
