PHP Runtime Notice: Only variables should be passed by reference.

Change-Id: Ib1e9af4b58202f085d1afbba2b9bd0b288a8ef58
Fixes: #30056
Releases: 4.6
Reviewed-on: http://review.typo3.org/5083
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Due to improper method signature in the parent class of t3lib_userAuthGroup,
a PHP notice is generated when calling method checkLogFailures().

Change-Id: Ic41cb88889ee18f2508ae5b2e96858e8bf16c349
Fixes: #30055
Releases: 4.6
Reviewed-on: http://review.typo3.org/5082
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Method tx_coreupdates_installsysexts::performUpdate() cannot be properly overriden
because its signature is incomplete.

This leads to PHP notices.

Change-Id: Iaf13c166c07d04ee194bec1543ac5ae450f1e38b
Fixes: #30053
Releases: 4.6
Reviewed-on: http://review.typo3.org/5078
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

A few methods don't have the static keyword. This leads to PHP notices.

Change-Id: I90a99601a39cd26abed665b42a8b054385f561ff
Fixes: #30050
Releases: 4.6
Reviewed-on: http://review.typo3.org/5075
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Because of an information disclosure problem in the backend login
we moved the session_start() in t3lib_userauth in a place which caused
unwanted side effects with 3rd party extensions.

Revert that change to avoid compatibility and performance problems
and instead send no cache headers earlier in t3lib_userauth 
to also fix the information disclosure.


Releases: 4.3, 4.4, 4.5, 4.6
Resolves: #29274
Related: #24456, #28694

Change-Id: I87226a21d9b1955773ceb3c377fa1b4c9938e6b2
Reviewed-on: http://review.typo3.org/5007
Reviewed-by: Christopher Hlubek
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Change-Id: Ic41b317fdb608dcc5630859168d3d5674bfe0593
Resolves: #28679
Reviewed-on: http://review.typo3.org/4024
Reviewed-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The template for t3editor contains CRLF line endings on Windows systems. To
prevent JS errors and to make the t3editor visible the CR parts of the line
endings must be removed.

Change-Id: If4f126c46ab243e616292a60563ebe4bea3fd624
Fixes: #30026
Branches: 4.6
Reviewed-on: http://review.typo3.org/5058
Reviewed-by: Oliver Hader
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig

Change-Id: Ie72691fc5146bed17e11e959081f655371bfafed
Resolves: #29802
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5062
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The Version Compatibility always appears at the first place and tells
you that you should upgrade your compatVersion or that everything is
okay, but you might.. if you really really want this.. in case of, don't
know, whatever reason.. downgrad again.

Remove this ugly thing. compat_version can still be changed again using
"All configuration".

Change-Id: Ie45a50ab20a0c8d59021362e45b7bed743e43199
Resolves: #24834
Releases: 4.6
Reviewed-on: http://review.typo3.org/5038
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The "Enable Install Tool" button in the User Settings is useless, as the
Install Tool is automatically enabled (after request) since #28621
and #28689.

Change-Id: I596a0b45d9b947e58b30e0082f23413b56e6f325
Resolves: #29996
Releases: 4.6
Reviewed-on: http://review.typo3.org/5040
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Function t3lib_autoloader::getAutoloadCacheIdentifier now respects the constant
PATH_site. This is needed because otherwise a fatal error occures when the
path to webroot changes (e.g. moving site to another webserver)

Change-Id: I9755da82cbf71914d47bc0523bacc8413addcf63
Resolves: #29901
Releases: 4.6
Reviewed-on: http://review.typo3.org/5000
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

After 1-2-3 installation it is not possible to start using TYPO3
because caching framework tables are missing. TYPO3 backend shows
SQL errors in the debug console (if enabled).

Resolves: #29894
Releases: 4.6

Change-Id: I343ddd6ab3171b5337c53cb58e3e120ea3e6469a
Reviewed-on: http://review.typo3.org/4996
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Add some space between the Template Analyzer options and vertically
align the labels.

Change-Id: Ifb6124beed73f2b176826096e9c20e3a17fcd2af
Resolves: #27588
Reviewed-on: http://review.typo3.org/5006
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Change-Id: I06c172211fb737ed51afd846c44e00ba2e0dbd0e
Resolves: #27603
Reviewed-on: http://review.typo3.org/5013
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

In an attempt to have the Remote Repository tab become a place to
search and install new extensions, the tiny upload .t3x icon next
to the filter textbox in "Local Extension List" should be moved.

Change-Id: I198dc95ecd8dcd953f699428d7118a9670d6b277
Resolves: #29587
Releases: 4.6
Reviewed-on: http://review.typo3.org/4893
Tested-by: Soren Malling
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The file name and dimension information need some space for better
separation in the "View Item" window.

Change-Id: I0d737d85b7444747c7292362a43f48528a0d4806
Resolves: #27602
Reviewed-on: http://review.typo3.org/4987
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The fix for #21381 causes "using filesort" in the List view for
"pages" table. This happens due to the "hidden" field in the
index. This field should be removed from the index because it is
not needed for the List module and it is not useful in FE due to
more expensive fe_group field.

Change-Id: Ia5fc87f7b1fa89e515c292248365d1d684872be0
Resolves: #29896
Related: #21381
Releases: 4.6
Reviewed-on: http://review.typo3.org/4997
Reviewed-by: Björn Pedersen
Reviewed-by: Frederic Gaus
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Adjust the background color of the module section table cells to match
the "body" background color.

Change-Id: Id688471665257a985004bf44cf5aec7fc646de08
Resolves: #27589
Reviewed-on: http://review.typo3.org/5004
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Curl is used when activated in the install tool.
The core should check if curl is available before using it.

Because the getUrl() refactoring will hopefully be ready in 4.7,
I found that this simple solution should at least fix it for 4.6.

Change-Id: I29e4d3b760aaf09f95a2ba6f560fe6562a7d5310
Resolves: #24984
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4956
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

As in typo3/init.php the TYPO3_mainDir is set to 'typo3/' the replacement in
renderForeignRecord could not work because it uses the TYPO3_mainDir . '%2Fajax.php'
which results in typo3//ajax.php
By this the backpath of the add wizard in IRRE foreign records is fixed.

Change-Id: Id2bb587243b7ffbf8458ac3cecfa9ddaa5266d5c
Resolves: #29770
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4976
Reviewed-by: Björn Pedersen
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Change-Id: I5a63a5ad1d491af6bbf9ac374b9df3d3f7a4d9b8
Resolves: #29495
Reviewed-on: http://review.typo3.org/4776
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

This fixes a bug introduced in #29695. There is a PHP bug
when using $filename as a reference and later on as a variable in
a foreach loop. The problem is described here:

http://www.php.net/manual/de/control-structures.foreach.php#101425

PHP 5.3.2 (used in current Ubuntu) and 5.3.3 (used in current Debian)
are affected. Other versions could be affected, too.

Avoiding the use of reference in the foreach loop fixes the bug.

Change-Id: I74c0ceee40e170b7cf2e7db91b1554d811a7c844
Resolves: #29832
Releases: 4.6
Related: #29695
Reviewed-on: http://review.typo3.org/4983
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Externally-referenced files such as jQuery included from a CDN fail to be
concatenated or compressed.

Change-Id: Idd02d85c98811167cccafd2e6a6a96fefda6a936
Fixes: #29695
Releases: 4.6
Reviewed-on: http://review.typo3.org/4924
Reviewed-by: Björn Pedersen
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: Iaa91761cd2dafbe7be1d6f6c5db169e3a8f48b0c
Resolves: #29400
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4961
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: I9df3d7b4bf1d565fc5a429bad6ee2d3d186f6044
Releases: 4.6, 4.5, 4.4, 4.3
Resolves: #29366
Reviewed-on: http://review.typo3.org/4705
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

When updating an extension, updates of database tables are not
shown and not offered to be updated. Thus they remain unnoticed
and this leads to unexpected results.

Show extension configuration and database updates after updating an extension.

Resolves: #29625
Releases: 4.5, 4.6

Change-Id: I82281494b71cd9fa38235ebafaa2b2423d15436d
Reviewed-on: http://review.typo3.org/4898
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I88562065fcedd8503554a7f9c9411d9599ca1292
Reviewed-on: http://review.typo3.org/4957
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

The TypoScript property select.selectFields does not consider workspaces
in the frontend rendering process.

Resolves: #17284
Releases: 4.6, 4.5, 4.4
Change-Id: Id9d1e7dcf56b5aeeec3070ff11416e82ec1bb978
Reviewed-on: http://review.typo3.org/2089
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

The "View Item" window shows information about a record or file.

Its height of 400px is very small, especially when an image preview is
shown. Increase height to 600px.

Change-Id: I4a97663e4a19c0319901cb82f4a3dc4d70cf3dd8
Resolves: #29627
Releases: 4.6
Reviewed-on: http://review.typo3.org/4900
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The rendering of the content element "plugin" can be highly improved
by changing just a fiew lines.

Changes:
- Remove "CODE:" when not needed
- Remove the "Insert plugin" as there is no additional information

Change-Id: I84795d537ecb15bace39d5e17cfafb5d90115a94
Resolves: #29556
Reviewed-on: http://review.typo3.org/4836
Tested-by: Soren Malling
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Solution: Remove external attribute when switching to other type
of link.

Change-Id: Ica76a8d862fd2547ad0baac55b3770dc2cedf79a
Resolves: #29167
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4769
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Problem: In IE, setting the link node href attribute may update the link
content when the content is recognized by IE as an url.
Solution: Workaround the IE feature and restore the link content.

Change-Id: I6f41dd2e43a64726e48dc3c714c7cfe89bbc860a
Resolves: #29527, #25464
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4863
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Since #28621, the Install Tool gets automatically unlocked, if an admin
user opens it from the Backend.

This reduces the admin's awareness of the Install Tool being
explicitly protected by the ENABLE_INSTALL_TOOL file. This change
introduces an additional step, in which the user is explicitly asked for
confirmation to unlock the Install Tool.

Change-Id: I289959f7cdc8ff05221005d4431f2e27b3f5cf95
Fixes: #28689
Related: #28621
Releases: 4.6
Reviewed-on: http://review.typo3.org/4777
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

After slightly refactoring the options and actions available in tabs
"Local Extension List" and "Remote Repository", the titles should be
updated:

Local Extension List -> Available Extension
Remote Repository -> Import Extensions

Resolves: #29588
Releases: 4.6

Change-Id: Ib4e98749ee72b701100db685b50bc0c76d8c1305
Reviewed-on: http://review.typo3.org/4896
Tested-by: Soren Malling
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Move the "Show updatable extensions" filter from tab "Remote Repository"
to "Local Extension List".

Change-Id: I8a8dd78549a7b07cae5f7f843f34c691e76fd850
Resolves: #29586
Releases: 4.6
Reviewed-on: http://review.typo3.org/4892
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

When looking at an extension's details, the developer information tab
lists all caching framework (CF) tables and the maintenance tab
proposes all CF tables for download. It doesn't make sense, even
for cache tables that are related to the current extension
(because they are created automatically and there's no reason
to dump a cache table's data).
The solution is to add a new flag to avoid listing CF tables
in some circumstances.

Change-Id: I3a8d43bc0d94d9bca99ae72a808e8e07057e9852
Resolves: #29592
Releases: 4.6
Reviewed-on: http://review.typo3.org/4886
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

JSMin is a major performance nightmare and no network connection can be
as slow as it would justify to spend so much time to execute JSmin
several times for each and every backend request.

As long as we have no fast replacement in core available, disable
compression for all JS snippets added with
t3lib_PageRenderer::addJsInlineCode in the Backend.

JSMin's share of execution time was about 20-25% of the page generation
time, for almost empty backend pages even ~50%.

Change-Id: I5623ad6c8b9d24777b6bcf46ea97bf51eb9c62d3
Resolves: #29498
Reviewed-on: http://review.typo3.org/4778
Reviewed-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

user_plaintext::renderImage uses ',' as char to
explode links but TYPO3 switched to a LF

Change-Id: Id531b7d76e3b5d1f04cf61448ff8ece172f6cb29
Resolves: #29597
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4887
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The UPDATE! script pop-up window in the Extension Manager is hard-coded
to some reduced size. Make it use the full screen instead. This also
makes it de facto modal, otherwise it can be launched several times.

Change-Id: I2bbe2189f421944389a648388e51893db43ad7bd
Resolves: #29593
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4880
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Simple copy and paste error: some variable names are wrong
inside the phpDocs.

Change-Id: Ifd8d27639d003cae90fb88704c8024e747e246d1
Releases: 4.6
Reviewed-on: http://review.typo3.org/4883
Reviewed-by: Francois Suter
Tested-by: Francois Suter