- Oct 11, 2021
-
-
Stefan Bürk authored
RedirectsServiceTests simulate frontend requests without executing them really, which prevents from running through the FE Bootstrap stack, thus not all needed stuff are setup correctly, thus throwing a warning that $GLOBALS['BE_USER'] is not defined. This patch initialize a backenduser for the RedirectServiceTest to setup a correct BackendUser object, thus mitigating this warning. Resolves: #95548 Releases: master Change-Id: I8318738e22761f172383db3b981779e331043f3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71518 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Stefan Bürk authored
Tests in SlugServiceTest from ext:redirects depend on an initialized LanguageService, which has not been done as there are no real frontend request executed, thus the normal FE Bootstrap was not run. This leads to undefined index errors because $GLOBALS['LANG'] is not initalized. The patch initalizes the LanguageService using the Bootstrap::initalizeLanguageObject() in the setup(). Resolves: #95547 Releases: master Change-Id: I53fb8877dd2692968c342e8df266f6268384ed1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71517 Reviewed-by:
-
Stefan Bürk authored
Initializing LanguageService in $GLOBALS['LANG'] with Bootstrap::initalizeLanguageObject() needs a proper setup $GLOBALS['BE_USER']. The patch moves Bootstrap::initialzeLanguageObject() from abstract testcase to the corresponding setUp() methods user and admin recycler tests after the corresponding backend user is set up. Furthermore some assertions are fine tuned to prevent array access warnings in tests. Resolves: #95549 Releases: master Change-Id: I3a9fed0a6f83e9481b169fb4a476ba2e2235e483 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71519 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Stefan Bürk authored
BrokenLinkRepositoryTest of ext:linkvalidator initalizes beuser dynamicly for tests and testdatasets. LanguageService has been initializied once as setup, before a valid beuser was initialized. Thus undefined index BE_USER warnings has been created. This patch (re)initializes the LanguageService using the corresponsign Bootstrap::initializeLanguageObject() method after each backend user initializing, and remove the single to early call from setUp(). Resolves: #95552 Releases: master Change-Id: I89f8e0e6092c1578ef57c20e52b950b9a73996a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71523 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Stefan Bürk authored
Install tool has been trying to connect to the database before checking if a bare minimum of configuration is given to. This has been done to decide if the database connect step needs to be shown. Starting with php8.1 this fails hard and the step is not shown, thus an installation cannot be finished. This patch change the checking order and checks for the bare minimum of configuration first, before try to connect to the database. Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d sqlite Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mariadb Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mysql Resolves: #95545 Releases: master, 10.4 Change-Id: I9923198b26f86e44fd6c1f6655195faa0c79895e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71514 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Helmut Hummel authored
It was a conceptual mistake to move storage 0 base path outside the document root (public path), because this complete compatibility layer relies on the fact that this storage is public. Moving it outside the public path, implicitly made this storage private, with all logical consequences like eID public URLs. This of course isn't desired and a breaking change of behaviour. With moving the base path back it means, that trying to access this BC layer with paths that are not within the public path, will not work any more. This is fine though, because this never worked before TYPO3 11.5 anyway. The reason why this was made working was EXT:form, which used the storage 0 compat layer for resolving form definitions from extensions, which did not work, when installing extensions into vendor folder (instead of the still current default, where extensions are installed in public folder). Accessing public resources from vendor installed extensions will still work with this change, because the public asset URL will automatically be calculated, but accessing private resources will thrown an exception to clarify that the storage 0 compat layer is not made to make this possible. Also fix form framework to not rely on FAL compatibility layer during form loading. Resolves: #95543 Relates: #95437 Releases: master Change-Id: Ie218dbb8ace9999f2bead77b671ae87f6ad46170 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71512 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Stefan Bürk authored
Public property $cObj for plugins has been deprecated in v11 with #94956 and setContentObjectRenderer() method has been introduced as replacement. If this method is missing, a deprecation message is triggered. This patch inserts the class name of the plugin into the message, to make it easier to determine where the new method is missing. Resolves: #95554 Releases: master Change-Id: Iffae1fcbd2f59bd4fe353e585dd5f41914bcc760 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71524 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Nikita Hovratov authored
This resolves a todo, where a test was blocking a method of Clipboard to be protected. The test is now adjusted as such that it now calls a real public method and extracts the needed information from it. Resolves: #95556 Releases: master Change-Id: I62dd988481ce807cb3716810fc7a6dd2bf4e8842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71526 Tested-by:
-
Helmut Hummel authored
* Use config API instead of env vars when building package artifact * Don't try to scan for extensions in Composer mode * Don't create extension directory in Composer mode, as the composer installer takes care of creating it if needed * Don't try to scan extension directory if it does not exist * Use package type instead of install path to distinguish core extensions Releases: master Resolves: #95483 Change-Id: I63ff42c301eba66e85471702fb03739374f7821c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71453 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Oct 10, 2021
-
-
Benni Mack authored
This change addresses a regression of https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829 where access-restricted pages (e.g. fe_groups restriction) under a sys-folder (e.g. 2021 for subpages categorized by the sys-folder 2020) to again return a 403 error to be properly handled by a proper error handler. This change adds tests to ensure this functionality is always working. Resolves: #92762 Related: #92225 Related: #84098 Related: #86346 Releases: master, 10.4 Change-Id: I7e9a96fddd24abc83f55c85148965b654a0fede7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69306 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Stefan Bürk authored
CleanerTasks build a query checking if tstamp tca config is checked. Using null coalescing operator to sanatize access in the condition. Resolves: #95550 Releases: master Change-Id: Ib4a34def6727d3a7f39f7a734a9a84bbb4697e3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71520 Reviewed-by:
-
Stefan Bürk authored
This patch fixes undefined index/offset warnings in ext:lowlevel QueryGenerator using null coalescing operator. Resolves: #95551 Releases: master Change-Id: I26fd0bd77bdc086916a57460680b06de689134db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71521 Tested-by:
-
- Oct 09, 2021
-
-
Oliver Bartsch authored
This correctly sets "subst" as a value of the softRefParams array. Previously "subst" was set as key, which only worked because of a non strict "in_array" check, which also returned TRUE for this case, but then broke with the refactoring in #94687. Additionally the regular expression of the UrlSoftReferenceParser, used to find urls in content, also got extended in #94687. This is now partially reset to not longer match links in tag attributes. This otherwise would lead to duplicate entries, since those urls are already matched by the TypolinkTagSoftReferenceParser. The impact of the changed regular expression was overlooked beforehand, due to the bug in LinkAnalyzer. Resolves: #95449 Related: #94687 Releases: master Change-Id: I3ca134cd1eed95b8563335708e393f5b5fa79420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71511 Tested-by:
-
Jochen Roth authored
Adding a file collection to the file links content element leads to undefined array key warning. This is fixed by setting the itemsCriteriaField name to "files". Resolves: #95514 Releases: master Change-Id: I3afb5c57e2be0a7ac776f5dbd75705aa9120dbc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71507 Tested-by:
-
Oliver Bartsch authored
The "displayThumbs" module setting is fetched two times in the FileBrowser. One time to determine whether thumbnails should be displayed and a second time to set the current value of the display thumbnails "toggle". However, the default values of those two cases differed, which then led to a default state where the "toggle" was active, while no thumbnails were displayed. This is now fixed by using the same default for both cases. Resolves: #95425 Releases: master Change-Id: I9cdf81a28aceb91d5f419332d24337b22de2a575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71515 Tested-by:
-
Nikita Hovratov authored
The coalesce operator has a relatively low precedence over other operators. If used as part of other expressions, it is almost always necessary to wrap it in parenthesis. Otherwise unexpected behaviour or undefined array key errors (in PHP 8.0) may occur. Resolves: #95482 Releases: master, 10.4 Change-Id: I4ddecdbeab03c215477f77742674ded01bc29257 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71449 Tested-by:
-
- Oct 08, 2021
-
-
Benni Mack authored
When showing required dependencies (= extensions) in Extension Manager, e.g. for distributions - downloading the Introduction Package, the remote (e.g. "ter") needs to be set for displaying purposes. Resolves: #95544 Releases: master Change-Id: I4cc2ca1af7d8acaaac3dfb4d8fe7ca3461749610 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71510 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Robert Kärner authored
Access to $GLOBALS['BE_USER'] must be protected by the neccessary fallbacks, as no backend user might be logged in when an exception is thrown in the frontend. Resolves: #95538 Releases: master Change-Id: I03e21c9ef8f1770ed3d2fa72bd6cd99d7e6fc3cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71505 Tested-by:
physikbuddha <r.kaerner@oranto.de> Reviewed-by:
-
Oliver Bartsch authored
The confirmation password, required for accessing the install tool through the backend, now uses the autocomplete attribute to prevent password managers from initiating a "change password" workflow. Resolves: #92969 Releases: master, 10.4 Change-Id: I27bc81e7ebaa9684b4e15c7208841ca5e3a4338d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71501 Tested-by:
-
Marcel Schüßler authored
When using the "saveAndClose" option for a newContentElementWizard item, the target link forwards directly to the record_commit route instead of FormEngine. Previously the parameters for this link were added to an array, which was then never reset after used for the link creation. This therefore resulted in multiple elements were created as soon as the "saveAndClose" option was set multiple times. This is now fixed by not using a single use variable anymore, but directly building the data array in the link, like it's already done for the FormEngine links. Releases: master Resolves: #95526 Related: #95277 Change-Id: I897acd376ce44c6f26c27dc7ddd927302e5be8bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71488 Tested-by:
-
Jochen Roth authored
The paths for source set images is currently prefixed with a slash which causes duplicated slashes at the beginng of the path so images are not displayed anymore. This has been fixed by removing the url prefix for source sets. Resolves: #95493 Releases: master Change-Id: Ieba7c4b380a9c8c14d73b83909b891dd634a041d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71508 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #95258 Change-Id: Idddbd4c449e2dc891c91f466614f04a8770d5815 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64429 Tested-by:
-
Oliver Bartsch authored
This fixes some undefined array key warnings, that appear on frontend requests. Resolves: #95542 Releases: master Change-Id: I40e6fb10b618f0487ecd763afea2b67ee2eabb7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71509 Tested-by:
-
Alexander Stehlik authored
Prevent access to undefined array keys in content renderer and menu objects. Resolves: #95489 Releases: master Change-Id: I1ec4b046478e7e83176e1178153d57a2890b269e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71454 Tested-by:
-
Robert Kärner authored
Several undefined array key warnings prevented the TCA suggestion wizard from showing results. These have been fixed. Resolves: #95537 Releases: master Change-Id: I6a9019b977c62529f6263d9f37eed30bbb88ba4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71503 Tested-by:
-
Oliver Bartsch authored
Some item providers (context menu) access clipboard information. Since the clipboard was previously not properly initialized, this led to exceptions, since no longer existing elements could falsely be retrieved. This is now fixed by cleaning up the clipboard before making it available for the context menu item providers. Resolves: #92805 Releases: master, 10.4 Change-Id: I31d4c8fa4fa89815cbc660dbc8a4af5d111e1462 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71502 Tested-by:
-
Oliver Bartsch authored
In #86291 the scheduler task list was refactored. A part of this refactoring was aligning the list with the one, known from the recordlist module. Therefore also the "toggle table" functionality from EXT:recordlist was added. However, since the updated state was never retrieved on building the table, the collapse state was saved but never used. While integrating the multi record selection in #94918, the corresponding "t3js-toggle-recordlist" class was removed to prevent cross dependencies. Since then, the collapse state was not just not retrieved, but no longer saved at all. This is now fixed by properly implementing this functionality in the corresponding scheduler JavaScript module, while the saved state is now properly taken into account on building the table. Resolves: #88351 Related: #86291 Related: #94918 Releases: master Change-Id: Ie8cb870bfba8170adec98410b6de2e53bbcf7938 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71506 Tested-by:
-
Oliver Bartsch authored
EXT:redirect is using the TargetPageIdViewHelper to get the page ID from a "t3://page?uid=" link. If this link is however somehow malformed, e.g. "t3://page=uid=", this previously lead to an exception being thrown, making the redirects module unusable for an editor. Since an editor usually does not have access to pid=0, it needed an administrator to make the module accessible again. This is now fixed by catching this exception in the view helper. Resolves: #95488 Releases: master, 10.4 Change-Id: I27625f22a8b6f6a197402742c781d5fe8adae7e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71500 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Nikita Hovratov authored
The values of tx_testdatahandler_group for the second content element in the default language now match with ImportDefault.csv. This fixes unexpected behaviour in those tests. Resolves: #94569 Releases: master Change-Id: I134259ace54e9c85df5f218acce154e53ac47688 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69902 Tested-by:
-
Nikita Hovratov authored
This unifies the approach of calculating the size attribute value when having autoSizeMax set. Resolves: #94476 Releases: master Change-Id: I4477b5376c78f1288d586522887ea4027dd0e96e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69712 Tested-by:
-
Oliver Bartsch authored
The page module displays a flash message for page translations with inconsistent ("mixed mode") content elements. The last sentence of the flash message reads: "We highlighted the problematic records for you". This however was no longer the case in the fluid based page module. Therefore, this patch restores highlighting of such records. Resolves: #91177 Releases: master Change-Id: Ic0ada77428a426254f9cbba256e23f938733f9aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71484 Tested-by:Rachel Foucard <rfoucard@w-seils.com> Tested-by:
-
Oliver Bartsch authored
This fixes the ExtendedTemplateService->ext_getSetup() method, which now properly handles array key accesses. A new early return now also checks for an empty key and returns the whole setup in this case. This is a special case, needed for e.g. the object browser, to still show the full setup when object lists exist. Resolves: #94971 Releases: master Change-Id: I7b6615022ba59dc99929b05744c1cb33805098aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71461 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Christian Kuhn authored
TypoScript options config.spamProtectEmailAddresses_atSubst and config.spamProtectEmailAddresses_lastDotSubst may not be set. Use null coalescing operator to sanitize access. Link/EmailViewHelperTest stumbles here and also needs a proper initialization of $GLOBALS['BE_USER']. Resolves: #95532 Releases: master Change-Id: I8169229c1a31c1243cf2c4fc4321d015f532dc12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71494 Tested-by:
-
Oliver Bartsch authored
EXT:felogin uses checkbox items in their FlexForm configuration. Since the item key does not start with 0 but with 1, it's no longer possible to save the items. This previously only worked because of another bug in the checkbox element, which however had been fixed in #95371. This is now fixed by correctly using 0 as the first item key for the checkbox items. Background: The item key is used for the "is checked" calculation wich uses arithmetic operators and requires the first item key to be 0. Resolves: #95510 Related: #95371 Releases: master Change-Id: Icb71d5b8d8beeba9f6b11bb03f72d45fbbdedb3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71499 Tested-by:
-
- Oct 07, 2021
-
-
Jochen Roth authored
Currently the fe_user field email has a eval value of "trim". So it does not verify the given email. This has been fixed by setting eval to "email" and trim the email before validation. On top of that the validation flash message now shows the correct value that was entered. Resolves: #95459 Releases: master Change-Id: I274ae040da9fe8d03a56e5ba9b4f17a828da57f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71483 Tested-by:
-
Christian Kuhn authored
The extbase UriBuilder can be used in backend context, ActionMenuItemViewHelper does that for instance. The code accesses $GLOBALS['TSFE'] at one point, which may not be set. The ActionMenuItemViewHelperTest triggers this, but it should be a general asset of UriBuilder to work without TSFE, so this is not considered an incomplete test setup, but fixed in UriBuilder directly. Resolves: #95529 Releases: master Change-Id: I59bcdf00b11fa0f1af13207021da8d7ef3e4c0f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71491 Tested-by:
-
Jochen Roth authored
A link to a folder created in RTE leads to undefined array key warning in frontend. This has been fixed by using null coalescing operator instead of ternary operator. Resolves: #95519 Releases: master Change-Id: I2f5315db87281825fc53a63fdf6edabc5a8a7b01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71496 Tested-by:
-
Georg Ringer authored
The links at the error page can be improved: - link to the official donation page - show typo3.org without protocol Resolves: #95480 Releases: master Change-Id: I6a4b3358c8dfc5dc0776a53e9aedb3b72e167166 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71447 Tested-by:
-
Christian Kuhn authored
* Arguments with default values are registered with their default values in fluid by default. Tests that circumvent argument initialization by setting them directly must set them. The patch adds this for the "exception" tests in ImageViewHelperTest. * The main tests of ImageViewHelperTest run in backend scope. The FAL logic triggers StoragePermissionsAspect in this scope, which needs a $GLOBALS['BE_USER'], but that is not set up by the tests. The patch initializes a backend user. Change-Id: I91280cf869bf4609c20387132d076267e54b9b7a Resolves: #95531 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71493 Tested-by:
-
Georg Ringer authored
Fix a regression introduced in #91834 to be able to use stdWrap for text. Resolves: #95497 Related: #91834 Releases: master Change-Id: I6bbfce97870e3b33b8e363bdafa648d1b88ea23f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71497 Tested-by:
-
