- Oct 28, 2014
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
Frank Nägler authored
Remove unnecessary fully qualified names from Utility classes. Resolves: #62505 Releases: master Change-Id: I3d4af98670911b3b49bd8043136c92422925cd2a Reviewed-on: http://review.typo3.org/33588 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
Felix Kopp authored
Resolves: #61443 Releases: master Change-Id: I2a524b3b066712a614534acb14eaef28c4fce86e Reviewed-on: http://review.typo3.org/33589 Reviewed-by:
-
Helmut Hummel authored
Browsers started to distinguish how opening a new window from JavaScript happens. They track "user initiated" opening and not user initiated opening and behave differently. A request to open a window by JavaScript which is not user initiated is caught by a pop up blocker most of the time nowadays. This means a user must explicitly allow the current page to open new windows by JavaScript. Additionally some browsers (e.g. Chrome) always open a new window instead of a new tab if the request is not user initiated, regardless of browser settings, which nowadays default to open a new tab. The "save and preview" button currently initiates a page reload which saves the document and add some JavaScript to to open a preview window in the HTML response of this action. This JavaScript action is then not considered to be user initiated any more as opening the new window does not follow a direct user click action. The result is, that if a preview window/tab was opened previously, then the preview/window tab is just reloaded with the new preview URL. If it is the first time the window/tab should be opened this request is caught by the popup blocker. Other preview buttons in the backend (from Click Menu or action toolbar) behave differently (correctly) as they are always identified as user initiated. For that reasons, change the "save and preview" button to directly open a new window on click (without URL) and let the HTML/ JavaScript response set the correct preview URL after that. By doing so we gain a consistent behavior no matter what preview button a user clicks first. The only downside is, that in case the preview window is opened the first time, it remains empty until the page is saved and then reloaded through the JavaScript code that is already present. Resolves: #62503 Releases: 6.2, master Change-Id: I7a96c347453b1ccdeaf0d8d1bd5b080f905563ca Reviewed-on: http://review.typo3.org/33576 Reviewed-by:
-
- Oct 27, 2014
-
-
Georg Ringer authored
The field "email" should use the input type "email". Resolves: #62504 Releases: master Change-Id: I1f443eac86508dd914a75c4a1ab7d0454c043f66 Reviewed-on: http://review.typo3.org/33587 Reviewed-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Georg Ringer authored
The icon for collapsed table must be also styled with a font awesome icon as the expand icon. Resolves: #62439 Releases: master Change-Id: I908bffadcfa05def7633002bfccdce5afe5ed4ae Reviewed-on: http://review.typo3.org/33585 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Helmut Hummel authored
InlineElement::updateInlineView() is only used once throughout the core and called statically, although the method is not declared to be static. Fix this by declaring it static. Resolves: #62501 Releases: 6.2, master Change-Id: Ifeb8551899ccf285d87a66767bf7de4e8e98b32f Reviewed-on: http://review.typo3.org/33582 Reviewed-by:
Cedric Ziel <cedric@cedric-ziel.com> Tested-by:
-
Helmut Hummel authored
When using the click menu to hide, unhide or delete a record, previously the page tree was refreshed, although those changes are only reflected in the pagetree if page properties are changed. Adapt the click menu to only refresh the tree if a page record is changed or deleted. Resolves: #40687 Releases: 6.2, master Change-Id: I32844b359abd790f1dbd6839eec6feeb6e62bd02 Reviewed-on: http://review.typo3.org/33573 Reviewed-by:
-
Stanislas Rolland authored
The HTMLparser properties must be defined under subproperty HTMLparser of enableWordClean and not directly under property enableWordClean. Releases: master, 6.2 Resolves: #58105 Change-Id: I0b21e5789aa4db867e0057e484d17f40a26b5c56 Reviewed-on: http://review.typo3.org/33565 Reviewed-by:
Stanislas Rolland <typo3@sjbr.ca> Tested-by:
-
Felix Kopp authored
Fixes several layout issues with the FormEngine form: Adds space between checkbox+label. Forms element browser link as default button. Form field header will be a headline h4. Repairs outer padding and inner padding and borders. Resolves: #62466 Releases: master Change-Id: I0dcf1cd2206c0cee63a8353516a3b41b94fd670b Reviewed-on: http://review.typo3.org/33520 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Felix Kopp authored
Allow video and audio playback in the backend (i) element information window. Uses the new introduced RenderingRegistry to find a matching rendering class (#61800). Brings default letter box background color for <Video> tags. Resolves: #61668 Releases: master Change-Id: I7c01fbaf2258b4e7c6f10da0e6438bdc55d12197 Reviewed-on: http://review.typo3.org/32816 Reviewed-by:
-
Felix Kopp authored
First step for Toolbar/Topbar refactoring. This is a first step to refactor HTML5 output - the path to gain HTML5 viewport without ExtJS and based on jQuery and Bootstrap. Migrates HTML from topbar to .navbar - keeps ids. Makes use of .dropdown and .dropdown-menu. Therefore removes duplicated CSS. Also increase size to fit our fingers & touch. This issue is not breaking since common css classes and interfaces are kept. Next step #62166: introduce "ToolbarItemInterface" and remove toolbar-item css and layouts. Resolves: #62481 Related: #62166 Releases: master Change-Id: I8c215b19da4a99ad81e53b000b281849991d8deb Reviewed-on: http://review.typo3.org/33564 Reviewed-by:
-
Frank Nägler authored
This is a follow-up patch for https://review.typo3.org/33522/ Resolves: #62467 Releases: master Change-Id: I19333d6e6c987f7e2f84faeabc01a9c724831bc4 Reviewed-on: http://review.typo3.org/33533 Reviewed-by:
-
Markus Klein authored
Resolves: #62414 Releases: master Change-Id: I5f77e85e59a014eeb86fd9ee4db839679c0eac98 Reviewed-on: http://review.typo3.org/33479 Reviewed-by:
-
Frank Nägler authored
This patch is a follow-up patch for https://review.typo3.org/33523/ Resolves: #62468 Releases: master Change-Id: Ib16ab5378047b91759f3e5c38952fb57d3afb7ce Reviewed-on: http://review.typo3.org/33527 Reviewed-by:
-
- Oct 26, 2014
-
-
Felix Kopp authored
Makes the (badge) elemente a tiny bubble in the top right corner of the toolbar-item links. Revoles: #62479 Releases: master Change-Id: I3cebab2382d8971b776a9bea45b290a585ca8b25 Reviewed-on: http://review.typo3.org/33561 Reviewed-by:
-
Georg Ringer authored
The module "User settings" currently uses tables to style the form. This must be changed to use a proper markup. Additionally fixed: * Typos * Strict comparison where nothing breaks for sure. Resolves: #62328 Releases: master Change-Id: I6af386b63cca6d2ca35eb169332f5e36f7d03542 Reviewed-on: http://review.typo3.org/33393 Reviewed-by:
Felix Kopp <felix-source@phorax.com> Tested-by:
-
Markus Klein authored
When having a suggest wizard inside a flexform on a new content element edit form, we have the problem that we can't load the wizard's config in the AJAX request due to missing record information. We don't know what flexform definition to load, as we don't know what ctype is requested. Two possible solutions exist: - Generate the blank record again in the AJAX request, which means we have to copy lots of code from the DataPreProcessor. Moreover we would still need to pass the defVal GET parameter of the EditDocumentController to the AJAX request handler somehow, since we need that information in the DataPreProcessor to generate the correct dummy record. - Push the record to the AJAX request as serialized array I chose the second implementation. Resolves: #50549 Releases: master, 6.2, 6.1 Change-Id: Ic27125d0a901aee10461f88ea49c0f354cb43a54 Reviewed-on: http://review.typo3.org/33505 Reviewed-by:
Steffen Müller <typo3@t3node.com> Tested-by:
-
Felix Kopp authored
To finalze the rebrush of sys notes a section headline is added: The delete action can be accessed right from the note. Resolves: #26796 Releases: master Change-Id: I80923ee523d21880d877a0e1cc9cc2f355f59b3a Reviewed-on: http://review.typo3.org/32980 Reviewed-by:
-
Frank Nägler authored
This patch adds ReflectionService::getClassTagsValues($className) and ReflectionService::getClassTagValues($className, $tag) to get class tag values via reflection. Also the unit test changed to test the new methods. Resolves: #60822 Releases: master Change-Id: I45962c30f2559ad1b10fe33a64c541425c80db90 Reviewed-on: http://review.typo3.org/32714 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Felix Kopp authored
Change path of fe_users icon in TCA to same as in page tree. See Edit page > Behaviour > Contains plugin Resolves: #27955 Releases: master, 6.2 Change-Id: Ib2c91ad279249c9ab6a71d23f7c9afca140cc2ec Reviewed-on: http://review.typo3.org/30728 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Wouter Wolters authored
The link refers directly to index.php instead of mod.php. Use BackendUtility::getModuleUrl() for the link to fix the problem. Resolves: #62459 Related: #38099 Releases: master, 6.2, 6.1 Change-Id: I3b86d97a4f35a96ca39af28e724067b5ec8a832f Reviewed-on: http://review.typo3.org/33510 Reviewed-by:
-
Georg Ringer authored
Since bootstrap is available it would make sense to use the alert classes instead of the custom implementation. Resolves: #61959 Releases: master Change-Id: I0a6723a1bdb7333bc48f71876b8392e78299e4f3 Reviewed-on: http://review.typo3.org/33048 Reviewed-by:
-
- Oct 25, 2014
-
-
Wouter Wolters authored
* Make real booleans * Adds strict comparison where possible Resolves: #62460 Releases: master Change-Id: I5dd88eb2300e86e344cc39972c337685e7b02498 Reviewed-on: http://review.typo3.org/33508 Reviewed-by:
-
Wouter Wolters authored
Resolves: #62467 Releases: master Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f Reviewed-on: http://review.typo3.org/33522 Reviewed-by:
-
Wouter Wolters authored
Resolves: #62468 Releases: master Change-Id: I2790ca5817e16cfe0dc1c43151d2587ca796294a Reviewed-on: http://review.typo3.org/33523 Reviewed-by:
-
Markus Klein authored
This is regression fix for #59701. The ID of new Content Elements now contain a dot character. Fix the generated JS code of the SuggestWizard to filter this dot. Resolves: #62438 Releases: master, 6.2 Change-Id: Ifd6937a7645c1bfd509fa1b5912d02f2d01c5e0d Reviewed-on: http://review.typo3.org/33503 Reviewed-by:
Bernhard Kraft <kraftb@think-open.at> Tested-by:
-
- Oct 24, 2014
-
-
Stefan Froemken authored
This patch introduce the multiple parameter for f:form.checkbox ViewHelper of fluid. Resolves: #61529 Releases: master,6.2 Change-Id: Ic02b9aaeb19f09be438c18212c5b2f5842bf7468 Reviewed-on: http://review.typo3.org/33257 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Ernesto Baschny <ernst@cron-it.de>
-
Wouter Wolters authored
The merge extra_page_cm_options was not correct. The second level is never rendered again. Fix this by moving it into the correct method. Resolves: #62458 Related: #55136 Releases: master Change-Id: I5ce3c71997f89c28f506b1419986b023d2073218 Reviewed-on: http://review.typo3.org/33509 Reviewed-by:
-
Stanislas Rolland authored
To filter some useless classes for authors, we can configure classes as non-selectable in block or text style selectors. Releases: master Resolves: #58122 Change-Id: I6b151cf0524fccac6681a813b73f847783a69b95 Reviewed-on: http://review.typo3.org/29633 Reviewed-by:
-
Stanislas Rolland authored
Content language is not correctly set by RTE controller. Releases: master, 6.2 Resolves: #62399 Change-Id: I85eb570dc266bdc71e4768a13d27c6f2937f7251 Reviewed-on: http://review.typo3.org/33488 Reviewed-by:
Jan Kiesewetter <jan@t3easy.de> Tested-by:
-
Georg Ringer authored
The TCA type "select" uses a table to render the belonging icons. Use divs instead for the markup. Change-Id: I9bd8fb58d314913ec7b0859361c0c25fcc90d73e Resolves: #62386 Releases: master Reviewed-on: http://review.typo3.org/33447 Reviewed-by:
-
- Oct 23, 2014
-
-
Oliver Hader authored
The file list module in the backend offers the possibility to delete files. An interesting use case is the deletion of files that still have references to other entities. However, currently proper warnings are only available for sys_file reference. a) before deleting a file, a popup should be shown this does not work since the API is called with the identifier instead of a proper UID value b) after calling the API for deleting a file, references should be pointed out references are checked, however the description on the file usage is missing due to hardcoded "sys_file_reference" triggers - thus, no other references are printed out Resolves: #58913 Releases: master, 6.2, 6.1 Change-Id: Id80361427abc17bda3461c2d00750c4790798c88 Reviewed-on: http://review.typo3.org/30204 Reviewed-by:
-
Benjamin Mack authored
For old systems without proper JS libraries or usages like GMENU_LAYERS TSFE provides an array to register handlers directly that are added to the body tag directly. This function is removed (only used for GMENU_LAYERS) from the core, as all according functions should do this via hook or JS-only. Resolves: #62363 Releases: master Change-Id: I746e27c88c372dce61dadb6025d9348d34566fdf Reviewed-on: http://review.typo3.org/33403 Reviewed-by:
-
Mathias Brodala authored
Resolves: #60296 Releases: master, 6.2, 6.1 Change-Id: I7bff792b33ffecbe53ac4aee848e6ad16318a538 Reviewed-on: http://review.typo3.org/31618 Reviewed-by:
-
Felix Kopp authored
Renames backend module Extension manager to "Extensions". Also lowers language barriere in "Manage Extensions". Resolves: #55236 Releases: master Change-Id: Id8ca9545128807adcc925f3e00f705febae93d2b Reviewed-on: http://review.typo3.org/33381 Reviewed-by:
Ingo Pfennigstorf <i.pfennigstorf@gmail.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Markus Klein authored
Ensure the ErrorHandler stops script execution if an error occurs. Resolves: #61213 Releases: master, 6.2, 6.1 Change-Id: I0324a571b494576db1d314d8af0a86273e3205d3 Reviewed-on: http://review.typo3.org/32465 Reviewed-by:
-
Markus Klein authored
An interface might already be defined, check for existence before trying to require it, which will cause PHP errors if the interface comes from a different file path. Resolves: #62212 Releases: master, 6.2 Change-Id: I9cf43402bbcbbb5e27dbebb4ea48a2e1b483f360 Reviewed-on: http://review.typo3.org/33309 Reviewed-by:
-
Thomas Maroschik authored
There are some overrides in the CMS extension that provide the old TCA for the image and media fields of tt_content and pages_language_overlay tables. These apply if the compat version is set to 6.0 and and FAL upgrade wizard is not yet run. Those are removed now as we only support migrations from one LTS to the next LTS. Resolves: #60594 Releases: master Change-Id: I40b1b4cbc9404d5f4cac7df27029986a2568f2c8 Reviewed-on: http://review.typo3.org/31841 Reviewed-by:
-
Felix Kopp authored
Bring default button style and base CSS definitions on Bootstrap buttons. Brings backward compatibility for all buttons. Resovles: #62392 Releases: master Change-Id: I2cd59c00a649e65c03a7843e8de359e84baaa169 Reviewed-on: http://review.typo3.org/33469 Reviewed-by:
-
