- Feb 28, 2015
-
-
Christian Kuhn authored
This patch improves the separation of FormEngine and its sub classes. Currently, all sub classes like single element and wizard classes get an instance of the parent object to call various methods and properties on them. This is very hard to refactor and the mesh of call trees must be simplified to ease further refactoring and improve maintainability of code. This patch follows a divide & conquer approach: * Methods only used by sub elements are moved to AbstractFormElement * Properties FormEngine "knows" that are needed by element classes are given down in a data array during element instatiation to have a clear definition of what element classes know. * Methods used by both FormEngine and sub classes that do not need an instance of FormEngine are moved to a static helper for now to reduce the amount of code in FormEngine and to mark certain areas as stateless. * Class instances are not created on a global level anymore but created only in the scope where they are used * Class instances injected by outer code are created internally for enabling the using code to be moved around. All in all, this patch is mostly a preparation of defining a fully separated structure with defined concerns for every sub class. Most methods are moved around "as is" without changing functionality. The only area that is refactored codewise is renderWizards(). There is still a nasty circular dependency between FormEngine, FlexFormElement and InlineElement. This is not resolved by the patch, but the surrounding code is now separated enough that this structure could be refactored to a tree. This may follow with other patches. This patch evolved on catharsis in branch formengine with 53 single patches. Details can be looked up there, all single patches are prefixed with [FormEngine]. https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f Releases: master Resolves: #65357 Resolves: #63848 Resolves: #63849 Resolves: #63851 Resolves: #63853 Resolves: #63855 Resolves: #63857 Resolves: #63867 Resolves: #63868 Resolves: #63869 Resolves: #63870 Resolves: #63871 Resolves: #63872 Resolves: #63873 Resolves: #63874 Resolves: #63875 Resolves: #63877 Resolves: #63879 Resolves: #63880 Resolves: #63884 Resolves: #63885 Resolves: #63886 Resolves: #63887 Resolves: #63888 Resolves: #63890 Resolves: #63892 Reviewed-on: http://review.typo3.org/37265 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
-
- Feb 27, 2015
-
-
Wouter Wolters authored
Resolves: #65372 Releases: master Change-Id: I19d67cb8de220f25f74667bc39a5ca25c62c9500 Reviewed-on: http://review.typo3.org/37309 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Wouter Wolters authored
Resolves: #65302 Releases: master Change-Id: I215fc48ba7a1ac72e5be5c7357a2dd1557413d1f Reviewed-on: http://review.typo3.org/37305 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
Wouter Wolters authored
Resolves: #65297 Releases: master Change-Id: I7822f7aa48fc47940300467ea15422d5910767cb Reviewed-on: http://review.typo3.org/37237 Reviewed-by:
-
- Feb 26, 2015
-
-
Michael Oehlhof authored
The local property languageService was only used in the indexAction. In getModulesData and getSubModuleData there was still $GLOBALS[‘LANG’] used, which is now changed to the local property languageService. Resolves: #65368 Releases: master Change-Id: Ibae1f34b7baa37d5693bdb8220f59c23c5bbac0c Reviewed-on: http://review.typo3.org/37297 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Allacher authored
In the emitPostProcessTreeDataSignal of the DatabaseTreeDataProvider the namespace for the SlotDispatcher to get the class name is wrong. TableConfiguration is used twice here. This patch removes the doubled namespace. Releases: master Resolves: #65360 Change-Id: Iff4f02ad63cc0f7ed6f0176a624aa293c5b1f4cc Reviewed-on: http://review.typo3.org/37252 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
-
Michael Oehlhof authored
Resolves: #65369 Releases: master Change-Id: Id488fb523c3b3dcc255f9c5d36af537abec267d0 Reviewed-on: http://review.typo3.org/37298 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65372 Releases: master Change-Id: I631590fd7ccb108aded2cd9b957331d0891e0bf8 Reviewed-on: http://review.typo3.org/37301 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #65371 Releases: master Change-Id: I6832775eda3c97229b764bdb258b5f3ffb813402 Reviewed-on: http://review.typo3.org/37300 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65299 Releases: master Change-Id: I3d3d9409e8994f9e61a487b02a132cc2db6c14df Reviewed-on: http://review.typo3.org/37290 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65301 Releases: master Change-Id: I1f479807f684952d183bee7dcfa1a26897c33c1d Reviewed-on: http://review.typo3.org/37289 Reviewed-by:
-
Felix Kopp authored
Unify button positions as last column in tables and obvious submit buttons underneath tables. + extension manager - switch state/action columns + scheduler - add button style to overview/info + func wizards sort - add submit button style Resolves: #64926 Releases: master Change-Id: If6a413d24c7af769284ac77d5764cced7b14f5bc Reviewed-on: http://review.typo3.org/36738 Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Helmut Hummel authored
The workaround added for IE8 in #22084 is not needed any more and removed without substitution. This avoids problems with multiple cookies which might be sent due to nested instances or due to moving an instance around in the folder hierarchy. Resolves: #65187 Releases: master, 6.2 Change-Id: I75c3ebcde62257cef91837bf1fc8272e2dd77eac Reviewed-on: http://review.typo3.org/37030 Reviewed-by:
-
Benjamin Mack authored
In order to have a proper "way to do things" for extension developers to look up registration process the following parts were streamlined: - Discouraged usage of the pseudo-global variable $_EXTKEY inside ext_localconf.php and ext_tables.php in favor of strings. For module registrations this part was left out for now as module registration will be streamlined separately. - Use PHP5.5-style ::class in all occurrences instead of escaped strings for class names. - Use $GLOBALS['TYPO3_CONF_VARS'] instead of $TYPO3_CONF_VARS. Releases: master Resolves: #65347 Change-Id: Iad03e42d38d65ae1483ef8190f755430ec617e45 Reviewed-on: http://review.typo3.org/37240 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65295 Releases: master Change-Id: I072b91e1085bf4def958dc2fdf51a45a01995492 Reviewed-on: http://review.typo3.org/37209 Reviewed-by:
Frederic Gaus <frederic.gaus@flagbit.de> Reviewed-by:
-
Christian Kuhn authored
Add PHP to monitor the situation and fix issues as soon as the environment stabilized. Change-Id: Ic08a6464c6be1fe43bc98a62d2bdca1acd6c814f Releases: master Reviewed-on: http://review.typo3.org/37248 Reviewed-by:
-
Wouter Wolters authored
The icon was moved with #61200 Resolves: #65298 Releases: master Change-Id: I0326e2d496905d5e4edb4e842cdd67fb86967290 Reviewed-on: http://review.typo3.org/37206 Reviewed-by:
-
- Feb 25, 2015
-
-
Benjamin Mack authored
Replace "typo/" with "typo3/". Releases: master Resolves: #65348 Related: #61459 Change-Id: I39d7f1516a41172dadf71a51f5743bdfa67f243f Reviewed-on: http://review.typo3.org/37241 Reviewed-by:
-
Benjamin Mack authored
The BE User initialization in the core uses the TYPO3_OS constant in various places. The initialization can be done in the constructor directly. Also, the property itself ($BE_USER->OS) is not in use directly by the core and it is encouraged to use the constant directly. The property is therefore marked for deprecation. Releases: master Resolves: #65343 Change-Id: I527f871bab419274c5a712a6a146d978be13d5cf Reviewed-on: http://review.typo3.org/37233 Reviewed-by:
-
Markus Klein authored
Change-Id: Ie911ce6da7fa60babc90104c27a45371c15492b4 Resolves: #64099 Releases: master Reviewed-on: http://review.typo3.org/36584 Reviewed-by:
Frederic Gaus <gaus@flagbit.de> Tested-by:
-
Andreas Fernandez authored
Adds a font size to the button text, so the button text in the "send stage" windows in the workspace dialogs used in the frontend become visible again. Also, a background color is added to the top buttons to fix the "cut". Resolves: #65102 Releases: master, 6.2 Change-Id: I928299e602829b322e3c6515367bcf1ac59b2479 Reviewed-on: http://review.typo3.org/37097 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Wouter Wolters authored
Improve the description of the manual registering of "switchableControllerActions" Resolves: #65300 Releases: master Change-Id: I8d376611d1db4c0c128fe8b3d2a4929d0a7c06c9 Reviewed-on: http://review.typo3.org/37207 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65294 Releases: master Change-Id: I56de58378c291d79127c713251b0fe99085bc02f Reviewed-on: http://review.typo3.org/37208 Reviewed-by:
-
Sascha Egerer authored
A faulty negation in the FileInfo class could end in a fatal error if `finfo` is not supported by the php version and ends up in not using `finfo` but `mime_content_type` if `finfo` is supported. Resolves: #65329 Releases: master Change-Id: I768d70501ee4a8f03317563cef2d95e59e791e7d Reviewed-on: http://review.typo3.org/37205 Reviewed-by:
-
Sascha Egerer authored
To prevent a duplicate '/' in a filepath the function LocalDriver::getAbsolutePath should be used instead of concatenating strings by hand. This fixes also an issue that file uploads are not possible on windows machines due to a incorrect filepath. Resolves: #65230 Releases: master, 6.2 Change-Id: Ibe6ff9c8c1d6579c8da24f14cfd6e528f57a8e4f Reviewed-on: http://review.typo3.org/37104 Reviewed-by:
-
- Feb 24, 2015
-
-
Wouter Wolters authored
Resolves: #65286 Releases: master Change-Id: I7c8576ebb76bb02582396e1345e253ba0e9a1623 Reviewed-on: http://review.typo3.org/37189 Reviewed-by:
-
Wouter Wolters authored
Resolves: #65284 Releases: master Change-Id: Icff258aac434e815a629e47290b41263674502f4 Reviewed-on: http://review.typo3.org/37187 Reviewed-by:
-
Andreas Fernandez authored
Check if CMD is "stop" to make "Add task" visible. Resolves: #65235 Releases: master, 6.2 Change-Id: Ia5b87f6105e14e224e8db0541d6fe36a021d8ba3 Reviewed-on: http://review.typo3.org/37113 Reviewed-by:
-
Oliver Hader authored
Releases: master Change-Id: I901675473bf00227e94c51edca5c2df065627a41 Reviewed-on: http://review.typo3.org/37170 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
TYPO3 Release Team authored
Change-Id: Ie8b44f5886414885ec5132821f3565185f99425c Reviewed-on: http://review.typo3.org/37169 Reviewed-by:
TYPO3 Release Team <typo3v4@typo3.org> Tested-by:
-
TYPO3 Release Team authored
Change-Id: Ia2e6ab0c8274d2c2bfc3cc61b3b72447ca9741d8 Reviewed-on: http://review.typo3.org/37168 Reviewed-by:
-
Markus Klein authored
This reverts commit 81ec05a3. The patch is reverted as it was merged in a merge-freeze by accident. Backport has not been merged yet. Change-Id: I805393f32e9ddf0c635d492a298ec0c3d2d50132 Releases: master Reviewed-on: http://review.typo3.org/37166 Reviewed-by:
-
Mathias Schreiber authored
The GeneralUtility::llXmlAutoFileName() method will now also correctly handle paths to files that are not placed within a known directory (ext, sysext, test etc.) if the call is made with $sameFile = TRUE. This allows placing language files in storages like fileadmin. Resolves: #35093 Resolves: #34728 Releases: master, 6.2 Change-Id: Ic5901c3fa98233978abf26db377666dade16f8e6 Reviewed-on: http://review.typo3.org/34285 Reviewed-by:
Gernot Ploiner <gp@webprofil.at> Tested-by:
-
Stanislas Rolland authored
When using the element browser wizard to import a selection of images into an images or text+images content element, the list of uid's of images to import is malformed and insertion fails. Releases: master Resolves: #65109 Change-Id: Ib32043507ef0dd6969c60d57738eaf16f2597192 Reviewed-on: http://review.typo3.org/36960 Reviewed-by:
Andy Grunwald <andygrunwald@gmail.com> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
- Feb 23, 2015
-
-
Markus Klein authored
This is a regression fix for #54091. It has been forgotten to add an isset() check for 'fixAttrib.set'. Releases: master Resolves: #65239 Change-Id: Ia39ef0760dab61bdb5bbfb71e525cc96e15f3077 Reviewed-on: http://review.typo3.org/37115 Reviewed-by:
-
- Feb 22, 2015
-
-
Andreas Fernandez authored
The clipboard is enabled by default now, which displays the copy / cut / paste actions. Resolves: #55950 Releases: master Change-Id: If2410be70209530284ac370f0f987f155caf2e69 Reviewed-on: http://review.typo3.org/37046 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Benjamin Kott <info@bk2k.info> Tested-by:
-
Benjamin Kott authored
The new content element button is hard to spot for new users and not self explaining / missleading in the first place. Unifying the "new record here" button with the corresponding title from the new record view makes it more clear what kinds of records will be available to place in a column and at the place the user has chosen. Resolves: #65206 Releases: master Change-Id: Icbe897f943d27771cdbb5e70505d1f47f6adfbdf Reviewed-on: http://review.typo3.org/37057 Reviewed-by:
-
- Feb 21, 2015
-
-
Nicole Cordes authored
This reverts commit 7dfd4607. Change-Id: I695b897597deb8d252cd9988e671175ebd8a1835 Reviewed-on: http://review.typo3.org/37082 Reviewed-by:
-
Nicole Cordes authored
If you add a page link to a field which is defined as softrefs, the ReferenceIndex creates an index to a FAL record if there exists a file record with the page id. As file links are always prefixed with 'file:' this patch adds a proper check before generating a file ref_index. Furthermore if you add a file or folder link, the field is referenced twice for the FAL record. So we have to suppress the softreference for those records. Releases: master, 6.2 Resolves: #60226 Change-Id: Ieb9179d393e23eda4fdb1bb47ba4693bd92e75d9 Reviewed-on: http://review.typo3.org/37016 Reviewed-by:
-
Benjamin Kott authored
Font icons were cut off on top when browser is zoomed or subpixel placement is not ideal. Also corrected the wrong placed CSS classes in the extension manager on extension import. Releases: master Resolves: #65212 Change-Id: If073b9a65550caaa816e68adde3c7758dd9586e3 Reviewed-on: http://review.typo3.org/37070 Reviewed-by:
-
