Change-Id: I74f33e689df164058f8e17b104c7f9650f99f604
Reviewed-on: http://review.typo3.org/5722
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

This fix opens the window in a sized window and changes the logic to
determine the correct function for closing the window.

Change-Id: Ie16d67284240a833e5bfae67d8b78eab808f9a79
Releases: 4.6
Resolves: #29788
Reviewed-on: http://review.typo3.org/5706
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Change-Id: I2518fcaa595529cf840b0d56805d11feb17468fe
Reviewed-on: http://review.typo3.org/5718
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

Example: Using the direct page edit feature (backend.php?edit=xxx)
the BE responds with "Module loader No module found. If this is a
temporary error, please reload the Backend!" error.

Since the AJAX request is not finished at the time this is called,
it has to be checked whether the store was completely loaded.

Change-Id: Ia7c39fc94e75ef003a7a839856ea78cbd0854a66
Releases: 4.6,4.5
Resolves: #28951
Reviewed-on: http://review.typo3.org/5681
Reviewed-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Tested-by: Jigal van Hemert

Deprecated option options.shortcut_onEditId_dontSetPageTree is wrongly
tested.

Change-Id: If88e869b8c92592ad6bb3369f1eda29c2a0809bf
Fixes: #30754
Releases: 4.6
Reviewed-on: http://review.typo3.org/5683
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Commit 0eb4686a wrongly introduced
a debug() statement instead of a call to the deprecationLog()
method.

Change-Id: Ie54e6b0f1d22035b17dad59ec8fea7b1b2f644f1
Resolves: #30759
Branches: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5693
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Changes included:
3b062e3 [TASK] Prepare merge for 4.6-RC1 (part 2)
27e93d6 Merge "[BUGFIX] Invalid target language in localization file"
ba0178b [BUGFIX] Invalid target language in localization file
36f1b21 [BUGFIX][SECURITY] SQL Injection in Scheduler Task of
Linkvalidator
9636b77 [TASK] Merge Changes from core since last sync
709531e [TASK] Prepare merge for 4.6-RC1
5607748 Merge "[BUGFIX] SQL error if a task is run on a disabled page"
e2bb756 [TASK] Update manual
79b4741 [BUGFIX] SQL error if a task is run on a disabled page
6856163 Merge "[BUGFIX] It is not possible to set page 0 to schedular
task"
28a38da Merge "[BUGFIX] SQL error if opening a disabled page with
module"
0fece3f [BUGFIX] It is not possible to set page 0 to schedular task
df464d4 [BUGFIX] Revert change in interface signature
4335331 [BUGFIX] SQL error if opening a disabled page with module
c12d8f5 [TASK] Fix CGL issues
74a9c14 [BUGFIX] Initialize $currentR in analyseTypoLinks
e5d6b19 [TASK] Bump version number

Change-Id: Ia3a9583112b601c21f58e9b782ecb5b03e331fe4
Resolves: #30756
Reviewed-on: http://review.typo3.org/5685
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

In the new EM in the extension configuration settings it is not possible
to switch between extension configuration categories in some browsers.
This is caused by a nested form tag which will be removed with this commit.

Change-Id: Ie4e4d5f33d319467626aa4923abe07d608af9bbb
Resolves: #30257
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5688
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Since the username label changed from "Utilisateur" to "Nom d'utilisateur"
in French, the alignment of labels and text fields is broken.

Change-Id: I35f28fd61f8c4a3e133949ae8eb865af0e0a1bc9
Fixes: #30688
Releases: 4.5,4.6
Reviewed-on: http://review.typo3.org/5648
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

This task just changes one line of css to remove the senseless space
between a panel and it's related tbar.

This is useful, because the space between toolbar and panel was bigger,
than the space to neighboor panels.

Change-Id: I631acb14d1ed598f2e5718b84b21d76277a37391
Resolves: #28793
Releases: 4.6
Reviewed-on: http://review.typo3.org/4170
Reviewed-by: Stefan Neufeind
Reviewed-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Resizing the backend browser window results in a JavaScript error.
The function that handles the re-positioning of the menus does not
work correctly. The observer requires a reference to a callback
function - currently the method was directly executed and the return
value used as function reference, which was undefined in this case.

Change-Id: Ifb2db858d7075f4fd714d737576189c0e1efc5a5
Resolves: #25787
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5634
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The 123 Installer now checks if openssl is configured properly
before enabling saltedpasswords and rsaauth.

Resolves: #28275
Releases: 4.6

Change-Id: I1d6c5ce6e3dfedfac85349baa01c88118bb348f8
Reviewed-on: http://review.typo3.org/5657
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Dmitry Dulepov
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Current implementation of md5.js only considers a very
limited range of characters.
The implementation from webtoolkit.info uses correct
unicode-representation.

Change-Id: I8f71673f60f22e39862ca2a447f496159b8079bb
Releases: 4.4, 4.5, 4.6
Resolves: #22328
Reviewed-on: http://review.typo3.org/5665
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Tested-by: Oliver Hader

There is a race-condition in the EM while updating the extension list.

If the update takes more than 30 seconds, Ext.Direct reaches its Ajax
timeout and sends the Ajax request (to update the list) again. As the EM
updates the extensions.xml.gz file at the beginning of the update
process, the second request immediately sees that the repository is
already up-to-date and respons this status to the client.

Thus, the user gets a "Repository is already up-to-date" message shown,
although it was not.

Change-Id: I2bc6b83f0951e16b895607025c2d3bad392b9759
Resolves: #30673
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5641
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Kay Strobach
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The TYPO3_CONF_VARS option to enable oncontextmenu is not
needed anymore IMHO, as this option is official part of
HTML5 (previously it wasn't allowed by IE for HTML4, and a
proprietary option for Firefox (back when we introduced it
in 4.1). The patch removes any occurence of this option and
enables oncontextmneu everywhere.

Change-Id: I487accb5717af79072c704fde34018827850269d
Resolves: #30613
Releases: 4.6
Reviewed-on: http://review.typo3.org/5603
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

There are multiple occurencies of the word "resource" spelled as "ressource".

Change-Id: Ib29360ec87d0070c9e7d8865dbf18b565c65784a
Resolves: #30704
Releases: 4.6
Reviewed-on: http://review.typo3.org/5662
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Just a small css fix, that enables the extjs like splitbars in chrome.
This fix adds small gray spaces into the toolbar, but let the splitbars
work as expected.

It also adds a background to the splitbars to reduce the optical
difference between chrome and other browsers.

Change-Id: Ib7be667d3b5dba0797bd1c5ecb1149a83f1e0bdc
Releases: 4.6
Resolves: #27660
Reviewed-on: http://review.typo3.org/5649
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

TYPO3 4.5 already uses the codemirror library 0.9.4. It has not yet been updated for 4.6.

Change-Id: I5ada44a795d47465025fb8e7c6de1ff61f5249d9
Resolves: #28854
Releases: 4.6
Reviewed-on: http://review.typo3.org/5670
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The copyright year in the HTML comment is hardcoded as 1998-2009. This
should be changed to using the constant.

Change-Id: I475f9a221acd4da4fe5376ee73d1b6bed2c3ccaa
Resolves: #30725
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5666
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The md5 checksums for all system extensions not integrated as submodule
should be updated.

Change-Id: I845cc4204ca3f6c334fcdb7750ba5a927a9c36f7
Resolves: #30723
Releases: 4.6
Reviewed-on: http://review.typo3.org/5664
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

tslib_cObj->typolink() generates cHash in every case, even if not
needed. Change the behavior to generate cHash only if necessary.

Change-Id: Id6a015e6bd89e9baeafd9532d4a21018adf91691
Resolves: #28352
Releases: 4.6
Reviewed-on: http://review.typo3.org/3456
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Tested-by: Popy
Reviewed-by: Xavier Perseguers
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Reviewed-by: Björn Pedersen
Tested-by: Xavier Perseguers

UC/titleLen in BE_USER is used to truncate data in the backend.
Increase the default value.

Change-Id: I64e2ecb1a8f4458101bc2bd395ef6c1be0ca667c
Resolves: #30670
Releases: 4.6
Reviewed-on: http://review.typo3.org/5637
Reviewed-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

System extension 'form' does not have a proper cover page (missing title
and basic information) and still contain lots of example placeholders.

Change-Id: I2ccecc6aa7904df0501a2c91d599258148458c33
Resolves: #30709
Releases: 4.6
Reviewed-on: http://review.typo3.org/5482
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The HTML multiple attribute is added for select boxes with size > 1 and
the Javascript to check this uses the multiple-property instead of the
getAttribute method which is poorly supported by various browsers.

Change-Id: Ib2ffeb2d0933a6c66e55586f1960ee7745e5623e
Fixes: #30681
Releases: 4.6
Reviewed-on: http://review.typo3.org/5646
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Method clearCacheMenu() allowed to create a drop-down selector to clear
caches and possibly add options such as "save and close documents".

Modules should respect the TYPO3 backend layout and use the top toolbar
instead. In addition, this method does not provide all clear cache commands
supported by the Core.

Change-Id: I2ecb014e6ceced56d827eac4f1b683c3f245cb4b
Resolves: #30700
Releases: 4.6
Reviewed-on: http://review.typo3.org/5660
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

This reverts the use of CardLayout for the Backend.
Following commits have been squashed:

- 9ec94db2
- 5ec3779c
- 873f1dfe
- a408234c
- 120d38d1

Change-Id: I2287b18598dbc5fe546c5ddc9aa9980d9b6a3b97
Resolves: #30645
Reviewed-on: http://review.typo3.org/5630
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The list of available extensions misses the install/uninstall icons in
Firefox 7 and Internet Explorer 9.

Change-Id: I1c5f51eb37441935ffafbd22109f56c336ba89e2
Resolves: #30369
Releases: 4.6,4.5
Reviewed-on: http://review.typo3.org/5640
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

In order to move workspace logic out of the TYPO3 core and into
versioning/workspaces extensions, a new hook is required first.
The hook will be placed after the backend authorization, and in
a followup issue the hook will be used for further cleanups of the
TSFE issue.

Change-Id: Ica08ce0c9d3802c6e9cd1b97d91f3d7a4efebd0f
Resolves: #30646
Releases: 4.6
Reviewed-on: http://review.typo3.org/5631
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: I860f6257e67c0fd6182d26d743a0d67127db224f
Resolves: #30669
Reviewed-on: http://review.typo3.org/5635
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Trying to download a file using the Edit Files page of the old EM
leads to a fatal error, because URL is not decoded properly.

Change-Id: I6980a0fbe8967bff0df0d8d7bc4c8f1abf53615e
Resolves: #27098
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5578
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stefan
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

tx_cal_tsservice uses queries with select <tablename>.* and
complex joins. This breaks due to the unconditionl adding of uid,pid
if the query is set.

Do not add uid,pid,... to field list if the field list already contains a
'*' or the repective field is in the list.

To keep the code easier to read, the sanitizing has been moved
to a seperate function.

The regexp matching is necessary to  detect fields like post_uid
(comments extension).

Change-Id: I50332c22e627ea452aaee233fdbbdf3dd426a1b6
Resolves: #29783,#30486
Releases: 4.6
Reviewed-on: http://review.typo3.org/4974
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Christof Rodejohann
Tested-by: Christof Rodejohann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

Extension manager produces a PHP warning on each invocation due to
incorrect parameters passed to t3lib_div::trimExplode().

Change-Id: I7bfd31677efb3cef07c0752486071e00d9ce889e
Resolves: #30598
Releases: 4.6
Reviewed-on: http://review.typo3.org/5581
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

For the purpose of modifying the database schema upon extension
installation and database compare in install tool I implemented hooks
to append sql create statements dynamically.

Hooks are registered via:

$TYPO3_CONF_VARS['SC_OPTIONS']['typo3/mod/tools/em/index.php']
['checkDBupdates'] for changes in the extension manager and has to
implement tx_em_Index_CheckDatabaseUpdatesHook interface

$TYPO3_CONF_VARS['SC_OPTIONS']['ext/install/mod/class.tx_install.php']
['checkTheDatabase'] for changes in the install tool and has to
implement tx_em_Index_CheckDatabaseUpdatesHook interface

Change-Id: I66ff195ae8f656961f5251d7722a16a554aca219
Resolves: #29594
Releases: 4.6
Reviewed-on: http://review.typo3.org/4870
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

All the standard renderers handle stdWrap themselves, so the general stdWrap
handling should be moved to the customMediaRenderer block to prevent duplicate
calls to stdWrap.

Change-Id: Ic0db017ad1d037636f1cb40994695686a2904c76
Fixes: #25277
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2620
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

ImageTTFBBox() randomly returns incorrect negative values. Repeat the operation
a number of time if this happens to try to find the correct values.

Change-Id: I6c1548e0f8762d6c2befdd47dbfb7810b01c9508
Fixes: #21054
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/3281
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

When installing an extension with a dependency to another extension,
which is not available on the server, EM retrieves it from TER. However,
by mistake it always retrieves the oldest version, not the newest.

Change-Id: I518cd5e4521d5ad1b578e342175f8b542ef42d02
Resolves: #29243
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5574
Reviewed-by: Josef Florian Glatz
Tested-by: Josef Florian Glatz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

stdWrap features GIFBUILDER transparentBackground and reduceColors
are broken

Change-Id: Icb74191aa6e53e8ca0737ead2638c3bda5d6a7fd
Resolves: #29445
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5590
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Problem: When saving a content element, the order of attributes of tags
is reversed. This clutters the workspace diffs with many changes. The
problem arises in WebKit and Opera.
Solution: Reverse the order of attributes.

Change-Id: I4686dc9a1a0a7a81b06ee6b6430371e86b593817
Resolves: #29855
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5535
Reviewed-by: Markus Klein
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Certain fields of type "select" which offer records from a
"foreign_table" will contain a huge amount of t3-icon-empty
icons just below the select box. If you have enough of them,
you even get a horizotanl scrollbar.

See some screenshots here:
http://forge.typo3.org/issues/13422

The issue is not a CSS issue, but a bug in the rendering
of such a field.

See it in action in tt_content field "sys_language". Just create
enough sys_language records so that you see the row of empty
icons being created. This wasn't this way before.

Change-Id: I664400ee6ee1d778e227b1858f79b9ed98482d0a
Resolves: #25398
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5569
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov

Change-Id: Ie4d202bc29094f3c234c1929c7fdd6c129777044
Related: #22881
Reviewed-on: http://review.typo3.org/5586
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader