- Nov 04, 2021
-
-
Jonas Eberle authored
This fixes cut modulemenu icons on Firefox when scrollbars are shown. It has been fixed before, but since then seemingly unrelated changes had the problem resurface. This time we set a min-width: for these links to prevent them from shrinking even if the #modulemenu around them decides to give some space to the scrollbar. Resolves: #95656 Resolves: #94146 Related: #94633 Releases: master Change-Id: I610f62f7f4730250c554c81edac91d5f9b37bb98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71795 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Mathias Brodala authored
Resolves: #95868 Releases: master, 10.4 Change-Id: Iffc8ed042f4990b132c28a0ff7b4d80ffca530ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72052 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Nikita Hovratov authored
Resolves: #95871 Related: #95859 Releases: master Change-Id: I0982c2289e00c7eaecfaa0dab89d184e09148f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72054 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Wouter Wolters authored
In the process, some tests calling tests (which is bad style) have been disentangled by calling the code explicit, rather then calling the test method. Resolves: #95198 Releases: master Change-Id: I07e88c3d082917f5cde9c950454583935e102192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71041 Tested-by:
-
Oliver Hader authored
The overlay handling (localization and workspaces) of relation values resolved in the RootlineUtility do only consider the live workspace. Values from other draft workspaces may work by accident, however the handling there is incomplete towards relations and the processing of the combined localization and version chain. Resolves: #63353 Releases: master Change-Id: Ie8423f43b046367fdf0c3cee0d36d6e0f1c0ee75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/34974 Tested-by:
-
Jochen Roth authored
Currently all "*Action" are set to public which isn't neccessary because the handleRequest() dispatches these actions. This has been fixed by setting all these methods to protected. Resolves: #95869 Releases: master Change-Id: Idb11d1e262d99ae139e390ee2cced57f206ba7d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72049 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Davide Alghi authored
When updating feature toggles, the corresponding method iterates over all feature toggles and checks if those state changed. If so, previously each changed toggle state was saved individually, leading to problems with file caches. This is now fixed by storing the toggles to be changed in an intermediate array which is then executed a single time, only modifying the LocalConfiguration file once. Additonally, the flash message is improved. Resolves: #95111 Resolves: #95112 Releases: master Change-Id: Ieea82d6af5837dd3bbd56abe182b5e7affd9eaa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70896 Tested-by:
-
Anja Leichsenring authored
FluidEmail view object is null after deserialisation causing an error when flushing the file spool queue. Ensure the view is initialised when generateTemplatedBody() is run. Resolves: #92394 Related: #91763 Releases: master, 10.4 Change-Id: I5c8025a9526af00aa520213a9c5c105d8d7d3ccf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65844 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Oliver Bartsch authored
Columns, not having a colPos defined, are considered as inaccessible. A event listener therefore enriches such columns with a corresponding information in the page module. Since the special "unused elements" column is obviously also missing the "colPos", the information was previously also shown for this column. This is now fixed by checking for the special "unused" column, before enriching the columns markup. Resolves: #95870 Releases: master Change-Id: I7af75e58181af24d772aa63a3fccec5c2d52c5e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72050 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Mathias Brodala authored
Resolves: #95868 Releases: master, 10.4 Change-Id: I443ba87dd97e1efacbaf441a1263dd47ec1e1aa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72047 Tested-by:
-
Nikita Hovratov authored
Because of normal selectSingle fields having the css property "width: auto", very long text forces those fields to span the whole width of the text. To fix this problem, the entire table layout has to fall. FormEngine fields have now a solid grid layout. This allows us more control over the layout. With this in place the fix is pretty straight forward: "overflow: hidden" for the wrapping div of the select field. In addition, some cleanup has been done in GroupElement: Empty aside divs are no longer rendered. Resolves: #94688 Releases: master Change-Id: I01a14dd2b2294d3260a90c1efecc402f742fabfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71798 Tested-by:
-
Nikita Hovratov authored
This removes the default values for: - minitems = 0 in general - size = 1 with renderType = selectSingle minitems = 0 can be safely removed, as it is always the default. size = 1 adds the html size attribute size="1". This is the default anyway and only used in FormEngine. Resolves: #94572 Releases: master Change-Id: Ifafb3a8b8a2924b1ed1df751b15c32b79ebaf494 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69906 Tested-by:
-
Jochen Roth authored
Currently some acceptance tests do not use a data provider as intended. These tests have been optimized to use the data providers correctly. Resolves: #95813 Releases: master Change-Id: Ib19ebc59079f1a4a533cd51ec82191858758fba1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72003 Tested-by:
-
Benni Mack authored
This change fixes a regression introduced with #92993 when removing personalized search statistics. A simple search with just "&" does not throw an SQL error anymore. Resolves: #95852 Related: #92993 Releases: master Change-Id: Iec46ac5830e77a16ff3981cb53be57a35a8f7ea5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72046 Tested-by:
-
Stefan Bürk authored
Sanitize filter 'FILTER_SANITIZE_STRING' has been deprecated since PHP 8.1 and will be removed in PHP 9. ext:extbase RequestBuilder has used this depcrecated filter to sanitize values, thus creating E_DEPRECATED warnings. This patch replaces this filter with alnum preg_replace(...) calls, except for $controllerName where backslash is allowed. Resolves: #95866 Releases: master Change-Id: I19b84281b55b1a247f31d39f1270a15b8e934576 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72042 Tested-by:
-
Jochen Roth authored
A long database name currently causes the modal to show scroll bars. This has been fixed by setting word-wrap for list items. Resolves: #95864 Releases: master Change-Id: If8f5fe51f29a6ee44f8d094e735e3876dcead52d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72041 Tested-by:
-
Stephan Großberndt authored
This patch adds an error if the site configuration file cannot be written or deleted. Exceptions thrown while failing to write the site configuration are now caught and shown as error messages instead of breaking the backend in DebugContext or silently ignoring the error in LiveContext. Resolves: #91490 Releases: master Change-Id: I27802eb1a3798d305635df0eeebda8720f7bea47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64582 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Benjamin Franzke authored
With #89555 cache clearing has been disabled if the user is currently in a workspace. This is fine in most cases, but if a record is published to live, cache clearing needs to be enabled. Resolves: #95600 Related: #89555 Releases: master, 10.4 Change-Id: Ic69baa3439912740abbfbb03d5ac6a076e46410a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71799 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Nov 03, 2021
-
-
Sybille Peters authored
Due to improvements for accessibility, the contrast between color and background color was increased for disabled buttons. This resulted in less visible difference between the active and the disabled buttons in the pagination controls. The disabled buttons are now replaced by placeholder buttons. This solves the above problem and also helps to visually declutter the pagination controls. Just removing the buttons entirely would have changed the placement of the buttons and resulted in them jumping back and forth when paging. Resolves: #95191 Releases: master Change-Id: I166da8fc191953d28a7272cb20070112aeb51588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71076 Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Marcin Sągol authored
The Install Tool Login page shows informational boxes like the one that by default the Install Tool password is the one specified during the installation or how to set new one. This 3 boxes used Panel component known from Bootstrap 3 to render them and style according to importance level (info, warning, danger). Since migration to Boostrap 5 this component is not available anymore (should be replaced by Card component) yet TYPO3 in various places is still using it and here on login page the color variants for this panels don't work anymore since they require additional outer class (.install-tool-modal - see Build/Sources/Sass/module/_install.scss). The callout component is now used to display the information. Resolves: #94575 Releases: master Change-Id: I6fbc3a6aeba6b23910fce1d11408790c22130a9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70595 Tested-by:
-
Helmut Hummel authored
When accessing static files via FAL API, the compatibility layer (storage 0) kicks in. This compatibility layer has multiple downsides. One of them are unreliable updates when the file changes. This should be avoided to be used especially by core code. Also remove the code that only was added to allow f:image usage with URLs soley to allow mixed usage of this VH not only for FAL assets but also URLs and static resources through FAL compat layer. Resolves: #91212 Releases: master Change-Id: I7e824207f99ff9b39ec90b105511b7b8711f7ffd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64327 Tested-by:
-
Stefan Bürk authored
ext:lowlevel QueryGenerator calls quote(...) with non string value as first parameter which ends in a E_DEPRECATED as underlaying quote(...) method from PDO expects an string value as first parameter. This patch casts the first parameter to string and add parameter type string as quote type, as the places expected string enquoting. Resolves: #95828 Releases: master Change-Id: If1a5e8004328f0a978b27a86ec7cdf30dc362072 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72010 Tested-by:
-
Stefan Bürk authored
htmlspecialchars(...) expects that first argument is a string, otherwise triggering E_DEPRECATED. This patch adds a string cast to ensure value is passed as string to htmlspecialchars(...) in FormViewHelper. Resolves: #95829 Releases: master Change-Id: I96ebe29d6fd118d4306e43693554fc76d2187b87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72011 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Jochen Roth authored
Added acceptance test for all missing cards in "Environment -> Image Processing". to see headline, buttons and expected AJAX loaded content. Resolves: #95863 Related: #95862 Releases: master Change-Id: Iea36fbe731dacbcf60cd3d4ce1f5f7b3b044d65b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72039 Tested-by:
-
Nikita Hovratov authored
To use CodeMirror's auto sizing feature, we need to set the style attribute of the wrapper element to "auto", instead of providing the "height" option. In a previous patch a related issue was fixed by setting the height to the remaining space of the frame. This led to another issue, which occurs, when there is already little space left. Both is fixed by using the auto sizing option correctly and even gives us the benefit of automatic resizing, when changing the editor's content. Resolves: #95801 Related: #86699 Releases: master Change-Id: I856aa85dfac348db1a49d9c73306159e145f9eeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71998 Tested-by:
-
Tim Karliczek authored
Instead of holding only the uid as a plain value the given databaseRow array of the symmetric_field can hold an array containing a lot of information about the related foreign record. This e.g. applies if type group is used instead of type select. Now isOnSymmetricSide is set to true in both cases. Resolves: #92963 Releases: master Change-Id: Ibc761831a757915f454f08d64e4c13908e1cbb7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66955 Tested-by:
-
Maik Beckmann authored
This change allows for the db connection parameters 'user', 'host' and 'port' to be empty, as it happens when using SQLite. Resolves: #95862 Releases: master Change-Id: I6e7e1e4a3693078d106d2ee49fa4544887690533 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72038 Tested-by:
-
linawolf authored
Resolves: #95836 Releases: master Change-Id: Id7667dcfc5b6e16662a1087c7d5591be32510c64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72019 Tested-by:
-
Jochen Roth authored
The page tree delete modal labels have been changed to align with all other delete modals. Resolves: #95817 Related: #94780 Related: #92670 Releases: master Change-Id: I44c2b432c185acbecc4d6ad0eebba70391b6a37f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72004 Tested-by:
-
Florian Rival authored
When using a form witch contains a fieldset element, you will have a PHP warning: Undefined array key "xs" in GridColumnClassAutoConfigurationViewHelper.php This was only a notice with PHP v7 but it's an error with PHP v8. This bugfix corrects the usage of undefined array keys. Resolves: #95859 Releases: master Change-Id: Ieffc3034d694dd7641f8d948d19839f8751cfca8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72033 Tested-by:
-
Benni Mack authored
This change re-adds the output on "DB Relations" of the "DB Check" module by having proper (PHP 8) related checks on the array, and a SELECT query with all fields (ant not just "uid"). Resolves: #95735 Releases: master Change-Id: I0a4e96faf73c9c23340275a1279fbce4470f0154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72035 Tested-by:
-
Alexander Stehlik authored
All restrictions are removed from the query builder that fetches the orphan records. A seperate query builder instance is used to execute the count query to check if there are any orphans for a table. The records are only fetched if there are any. Resolves: #95418 Releases: master, 10.4 Change-Id: Ife6ce9d7ee7b1541bf7340d654962f07d3873bec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71387 Tested-by:
-
Oliver Hader authored
Instead overriding class member variables externally, existing initialize() method has been extended to support options. This is a preparation to reduce the amount of inline JavaScript later. Resolves: #95845 Releases: master Change-Id: I7d76761e6b57a6e97163ca2ad721a2b1c8775e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72022 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
Ensures workspaces PreviewController uses dedicated method to declare client-side settings PageRenderer::addInlineSetting(). This is a preparation to reduce the amount of inline JavaScript later. Resolves: #95849 Releases: master Change-Id: Ic13c008e0f07daaad44cf5e537679615f40e137a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72025 Tested-by:
-
Oliver Hader authored
To avoid having nested require.js inline JavaScript, initialization of the form manager uses a dedicated helper module. This is a preparation to reduce the amount of inline JavaScript later. Resolves: #95846 Releases: master Change-Id: I7661db1580f4229dd86a2b75e19300a2bb40140d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72023 Tested-by:
-
linawolf authored
Fix links to system extension in composer.json documentation where it was still missing. Remove reference to docs_indexed_search from indexed search. It has not been updated since 2008. Remove apostrophe from the verb "lets". Resolves: #95816 Releases: master Change-Id: I02a325f73c05c41d8cdf1270606cf20509151c71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72014 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Jochen Roth authored
An acceptance test for recycler has been added to ensure the modules works as expected. This acceptance test covers the following scenarios: * Recover records flagged as deleted * Nuke records from database As a side effect, fallback values for DatabaseRecordList and RecordList have been added to make the tests work. Resolves: #94551 Releases: master Change-Id: Id04b843555c106be927c443377eeee5c44898145 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71988 Tested-by:
-
Oliver Hader authored
Changes read-access to modules from `ModuleLoader::$modules` to `ModuleLoader::getModules()`. Resolves: #95851 Releases: master Change-Id: I011f014f6d1c70051e269b696b00a6a7c5c77a6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72026 Reviewed-by:
-
Sybille Peters authored
Resolves: #88570 Releases: master, 10.4 Change-Id: Iaf39f5d2b3d8509f405162d25b1de73d71e27c5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71960 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
-
Robert Kärner authored
When mapping a 'pages' row to an icon, the 'module' field might be both an array or a string. Reloading the page tree passes 'module' as a string, editing a page record passes it as an array. Therefore, IconFactory must handle both cases. Resolves: #95856 Releases: master Change-Id: I78c000506650867d6409755f84ac6197dfeb5c15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72030 Tested-by:
Rudy Gnodde <rudy@famouswolf.com> Reviewed-by:
-
