- Apr 27, 2023
-
-
Oliver Bartsch authored
Resolves: #100770 Releases: main, 11.5 Change-Id: I549371e78de399195d6810858d337528f39ce0ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78882 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Andreas Fernandez authored
The list of ids generated by `getSearchableWebmounts()` may contain duplicated values being passed into an `IN()` criteria, causing additional load to the database server. The values are now de-duplicated by applying `array_unique()` onto the list before passing the list around. Resolves: #100750 Releases: main, 11.5 Change-Id: Ib49bf1a5903cca2fbaa12ea240050caa7908f69c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78873 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Eßl authored
In a list of backend users, using the avatar viewhelper, the instantiated Avatar class would always be the same instance. Each time, getImage() is called, the avatar providers would be initiated again, flooding the $avatarProviders variable with superfluous providers. - Which meant, when rendering a list of just 50 backend users, we suddenly have 1275 calls to the avatar provider class, instead of just the expected 50. Resolves: #100366 Releases: main Change-Id: I8b2eed49b47853c52a4350eb06e671081e90e373 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78339 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Anja Leichsenring authored
In preparation of composer based test setups, all fixture extensions require fully functional `composer.json` files. For starters, the minimal required `composer.json` is added. We will adjust as we go. Extensions without classes don't receive PSR-4 class loading definitions as those are not needed. As a convention, all fixture extensions have their extension name start with `test_`, and their composer name will use the vendor `typo3tests`. Classes will have the vendor `TYPO3Tests`. This way, fixture extensions are easy to identify, both by providing tests that use the extensions, as well as in development to not accidentally use such an extension or class. Resolves: #100737 Releases: main Change-Id: I312c2dd2f906d3299dae3a1d54a977cde3ce0b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78815 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Apr 26, 2023
-
-
Andreas Fernandez authored
`text-overflow: ellipsis` only works in Firefox if the parent element has an explicit width. Therefore, `button` and `a` elements are now set to a width of 100%. This also fixes an issue where images appear to be squeezed in Firefox. Resolves: #100743 Resolves: #100761 Releases: main Change-Id: I750f553b0fbdc0a05652074b785ec5028d3937bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78876 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Chris Müller authored
Resolves: #100753 Releases: main Change-Id: Ia3d98fad1be54ad3056b746c436556f33d2a7818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78842 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Benjamin Kott authored
The clearable javascript was never included or initialized. Wrappers handled by the clearable implementation have been dropped from the templates. Resolves: #100754 Releases: main Change-Id: I39f6f995821bfbda549e088b51d8d63865fb478c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78872 Reviewed-by:
-
Frank Naegler authored
Resolves: #100726 Releases: main Change-Id: I49384e7bbf3f199504ee7a978a816df1285474ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78805 Tested-by:
-
- Apr 25, 2023
-
-
Stefan Bürk authored
Used command(s): > composer u typo3/testing-framework > composer u typo3/cms-styleguide Resolves: #100751 Releases: main Change-Id: Ie5983bc76593e088190b1c81f0d33b23e98e4759 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77624 Reviewed-by:
-
Gilbertsoft authored
This patch avoids undefined key warning and properly casts the haystack argument of the `InArrayViewHelper` to an array. Resolves: #100748 Releases: main Change-Id: Ifc7d3597374eb98441aa29ac3af4e1dd8eb24409 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78840 Reviewed-by:
-
Andreas Fernandez authored
The docs for configuration message routing mention the non-existent array `$GLOBALS['TYPO3_CONF_VARS']['SYS']['queue']`. This is now fixed to be `$GLOBALS['TYPO3_CONF_VARS']['SYS']['messenger']` instead. Resolves: #100744 Related: #97700 Releases: main Change-Id: Iad8b40d9e0ba2695a60cee60379316bafed7adf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78838 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Stephan Großberndt authored
Releases: main Resolves: #100747 Change-Id: Ifd39f0813996674620fe1b89aef29ca87351e5b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78839 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Daniel Siepmann authored
Resolves: #100742 Releases: main, 11.5 Change-Id: Ibff1f2da48192a23d3fe6e5404c95f3b7e6c8ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78837 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #100741 Releases: main Change-Id: I0f65275282c85ce005eac85a081da7139606ceda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78836 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Oliver Hader authored
* TYPO3 v12.4.x LTS is supported * TYPO3 v11.5.x LTS is supported * previous sprint releases of TYPO3 v12 are not covered * anything else prior to TYPO3 v11.5.0 is not covered Resolves: #100740 Releases: main Change-Id: I577569cd9794cafb2efb74bb92ef2b5d21c0a846 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78835 Tested-by:
-
Benni Mack authored
Change-Id: If17fbd8d45edd9c7685217342ad330de84ae471d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78834 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
Change-Id: I158409abb3555504ae6fa1a619794a44ab307c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78833 Tested-by:
-
- Apr 24, 2023
-
-
Andreas Fernandez authored
There are currently two ways to configure link classes in ckeditor: * `config.stylesSet` * `buttons.link.properties.class.allowedClasses` The latter configuration is required for use in the Link Browser. If the configured classes are missing in `config.stylesSet`, CKEditor's behavior is undefined. In most cases, the class is dropped upon save. Since this is a common misconfiguration, `CKEditor5Migrator` now registers said Link Browser classes as styles in CKEditor. To achieve this, `CKEditor5Migrator` now receives the *full* RTE configuration, as Link Browser configuration happens outside CKEditor domain `editor.config`. Resolves: #100679 Releases: main Change-Id: Iabc2da29afc703508c24db76db130ea3d5f8eebc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78762 Reviewed-by:
-
Benni Mack authored
With #100720 the AbstractExceptionHandlers const IGNORED_EXCEPTION_CODES was set from private to public in order to allow to use it in subclasses. However, public is making this a full public API, which should be within the ExceptionHandler logic in general. For this reason, the constant is now changed from public to protected. Resolves: #100736 Relates: #100720 Releases: main, 11.5 Change-Id: I58427977c2217792ae854738f59527bdb2e8339e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78814 Reviewed-by:
-
Jasmina Ließmann authored
With #100663 the overall spacings were adjusted. With this patch we align the spacing between scheduler group panels with the spacing between record list items. Also, a margin above the 'Unused task groups' section has been reduced. Resolves: #100735 Related: #100663 Change-Id: I618350f1bfa79cf67f781766a2a647c05b619cfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78813 Tested-by:
-
Markus Klein authored
Body content generation may be triggered by calling some getter or indirectly when the mail is sent (via `ensureValidity`). This changes ensures that multiple tries to generate the body are only executed if the state of the view has actually changed. This enables extensions to manipulate the content of an e-mail via events without getting their changes overridden again when the mail is sent. Resolves: #99944 Releases: main, 11.5 Change-Id: I5eced5710feeb66e6f1e32f10f710d388bc43a62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845 Tested-by:
-
Jasmina Ließmann authored
Previously, the form fields in user settings form were displayed in their entirety, filling the screen. With this patch, the width of the input mask is now reduced to create a uniform appearance with forms of the form engine. Some individual spacing between the form fields has also been adjusted to match those of the form engine. The buttons for adding or removing an avatar image now each contain speaking labels that were previously only aria-labels. Additionally, the form fields markup in the user settings has been updated to fully match the FormEngine form field markup. With this we create the prerequisite that rollouts of global style adjustments for form fields also work on this form. Mid-term, this module should be using FormEngine for rendering anyway, so this is kind of a pre-patch. Resolves: #100605 Releases: main Change-Id: Ia83c9d42bcdb2faa12e1c1918d19e66a43f7ad66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78661 Reviewed-by:
-
Jasmina Ließmann authored
With #100042 the markup of the form fields in the add/edit form of a task has been updated. With this patch the markup was updated again to fully match the FormEngine's form field markup. With this we create the prerequisite that rollouts of global style adjustments for form fields also work on this form. Mid-term, this module should use FormEngine for rendering anyway, so this is kind of another pre-patch. Resolves: #100601 Related: #100042 Related: #100726 Releases: main Change-Id: I4ec2f7a1607bfb5005610cf2ab3cd5c2a2aac851 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78643 Tested-by:
-
Oliver Bartsch authored
With #98488, the typolink option "addQueryString" changed the behaviour to only add mapped query arguments by default. To add all - even "untrusted" - arguments to the generated URL, the new "untrusted" keyword has to be used. This now adds the possibility to set the new keyword in all related ViewHelpers. Therefore, the "addQueryString" property of the extbase UriBuilder is adjusted as well. Resolves: #100583 Related: #98488 Releases: main Change-Id: I3a4b62ec734b13e6f3cd721f4a6acefe9877b72b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78804 Tested-by:
-
Thomas Hohn authored
The variable $row['url_response']['errorParams'] should always contain a value. Either the actual error message array or an empty array to avoid a PHP 8 warning. The corresponding getErrorMessage methods now have a guard clause to check if the array is empty to avoid further propagated warnings. In TYPO3 v13 that signature of the getErrorMessage should be changed to be array. The array $errorParams is always initialized to an empty array instead of null. IN TYPO3 v13 the default value of $errorParams should be [] instead of null. Resolves: #99988 Releases: main, 11.5 Change-Id: I0f7e10f45e0f5ec7e80b79d705b38fda9a3f1410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77898 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Oliver Hader authored
Adds new boolean `useNonce` attribute to asset view helpers, e.g. `<f:asset.css useNonce="1">` or `<f:asset.script useNonce="1">`. This way the `AssetRenderer` is instructed to apply the global dynamic nonce value. Resolves: #100732 Releases: main Change-Id: Id19c78f5f75bd3497a5bd102ae2d35606a8bacd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78810 Tested-by:
-
Chris Müller authored
Resolves: #100731 Related: #100721 Releases: main Change-Id: Id8ffc819a9ec908fc8f11750821efa2a484e6d49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78811 Tested-by:
-
Christian Eßl authored
Avoid a lot of superfluous yaml reading and parsing by fetching the richtext configuration only once per request, saving some time in FormEngine, when many inline records with richtext editors are present or when doing mass editing. Resolves: #100222 Releases: main Change-Id: I9813f574fc2a6a3a27218ed5440570cde8a0a23f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78175 Tested-by:
-
Benni Mack authored
The following methods and properties have been deprecated: * Argument $alternativeLanguageKeys in LocalizationUtility::translate() * <f:translate> ViewHelper argument "alternativeLanguageKeys" * LanguageService->getLL() The method "LanguageService->includeLLFile()" is marked as internal. This is done in order to streamline future development in label-related areas. Resolves: #100721 Releases: main Change-Id: I1a0bc2eab61ec807cb43082dfef2361dbe6b185f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78799 Reviewed-by:
-
Oliver Hader authored
The CSP nonce value was not assigned in frontend rendering process. Besides that, the value would have been cached statically, which is not in line with the concept of a "number used once (nonce)". A new `INT_SCRIPT´ instruction is added, which permanently post processes cached data and replaces the cached nonce with the dynamic value of the corresponding actual request. Resolves: #100665 Releases: main Change-Id: I52107167541993112c9abe331bd00c86726fc5fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78660 Reviewed-by:
-
Oliver Hader authored
This is a collection of some smaller adjustments of CSP aspects: * move `ScopeRepository` to `ext:core` (it will be useful later) * add `ScopeRepository::findAllFrontendSites()` (site-specific) * mark `Site::$site` and `Site::frontendSite($site)` as `@internal` both aspects are probably not required and might be removed later * add case `MutationOriginType::site` (site-specific mutations) * remove duplicate `*.google.com` URI from `GoogleMapsHandler` Resolves: #100727 Releases: main Change-Id: I1665eafbb1b7859459748263213165bca16b82e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78807 Tested-by:
-
Andreas Fernandez authored
The language label `indexedsearch.config.disableFrontendIndexing` was accidentally removed in EXT:indexed_search with #98945, while `indexedsearch.config.useCrawlerForExternalFiles` was meant to be removed. This is now fixed. Resolves: #100728 Related: #98945 Releases: main Change-Id: I8057644ccf108fda62f3c022244392920df57f1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78808 Tested-by:
-
Oliver Bartsch authored
It's now possible again to provide a "short key", an extension name and also a default value for the f:translate ViewHelper in non-extbase context. Resolves: #98647 Related: #96473 Releases: main Change-Id: I1d58ea8dcec2e4943972c3d6ecc62cd30b8d355c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78789 Reviewed-by:
-
Christian Eßl authored
PageViewHelper no longer exclusively supports extbase context request objects. Adjust the exception message accordingly. Resolves: #100710 Related: #96473 Related: #98474 Releases: main Change-Id: Ib476e9d832ebb796d4a19c6ff17572580a57ae46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78790 Reviewed-by:
-
Christoph Lehmann authored
This makes AbstractExceptionHandler::IGNORED_EXCEPTION_CODES public accessible in order to re-use it in custom error handlers. Resolves: #100720 Releases: main, 11.5 Change-Id: Id9217d3bbf3b66982adceb485918e52bb5cddd56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78800 Reviewed-by:
-
Christian Eßl authored
The exception has been marked as internal and is not in use anymore. Resolves: #100724 Releases: main Change-Id: Icac969e7ff5de139f03d3c947ccbbfe47f1dd5e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78803 Tested-by:
-
Christoph Lehmann authored
Illegal requests should not fill log files. The Exception is thrown in \TYPO3\CMS\Core\Http\Request::validateMethod() Resolves: #100718 Releases: main, 11.5 Change-Id: I202fba9e76ac00ab11e02dc401633b383b0048b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78798 Reviewed-by:
-
Oliver Hader authored
The cases of \TYPO3\CMS\Backend\Security\SudoMode\Access\AccessLifetime are not correctly documented, e.g. `XS` became `veryShort` during the development for #94246. Resolves: #100722 Releases: main Change-Id: If6cef5a4840b0d0d0e94575b45a2d0cc3b30858e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78801 Reviewed-by:
-
Christian Eßl authored
Avoid too much I/O blocking when compiling URLs in `HashProxy` by doing concurrent asynchronous fetch requests with the GuzzleHttp client. In addition, results of previously resolved URLs are now stored in `assets` cache for one week. Resolves: #100708 Releases: main Change-Id: I362f81dccb0067f3691a1188878e6fea30af7100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78787 Tested-by:
-
Benjamin Kott authored
Resolves: #100717 Releases: main Change-Id: I0641cb3c82119441727853f5580c3b98db43d6ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78797 Tested-by:
-
