- Oct 07, 2023
-
-
Benjamin Franzke authored
Unbundle CKEditor5 in order to be able to load plugins like "font" only if actually configured, allowing TYPO3 core to ship *all* available ckeditor5 modules without having to weigh in the downsides for large modules that we do not want to ship for "every" installation. All @ckeditor scoped npm packages provided by CKEditor5 are bundled into an own small per-package bundle that is loaded (and linked to each other) via our importmap infrastructure. This allows specific modules to be loaded ondemand and has the additional advantage that plugin authors can use modules via packages exports as suggested by upstream documentation. This should lower the the barrier for writing custom plugins. The existing bundle @typo3/ckeditor5-bundle is still in place and acts as wrapper for the split bundles. It is deprecated and will be removed in TYPO3 v13.0. Also worth noting is that terser is now used to shrink the module size. Resolves: #102099 Releases: main, 12.4 Change-Id: I873167a7cb5c04cb7ef34e943830879f3f78eaaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81369 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
core-ci <typo3@b13.com>
-
- Oct 06, 2023
-
-
Chris Müller authored
Links from LTS versions to other manuals should reference the same version. Resolves: #102036 Releases: 12.4, 11.5 Change-Id: I67ead0fd46756f754e889e5836632ed035a2727a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81330 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Patrick Schriner authored
Add a aria-describedby attribute to link the password field with the requirements description. Resolves: #102100 Related: #97388 Releases: main, 12.4 Change-Id: Iec46dca547cf53764a47b18a54952aff8b33fdf5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81365 Tested-by:
-
Christian Kuhn authored
Upgrade wizard SysLogSerializationUpdate loads all to-update rows into an array to iterate and update one-by-one afterwards. This can hit PHP memory limits when many rows need to be handled. The patch fixes this by avoiding the load to array and iterating single result rows directly. Resolves: #102104 Releases: main, 12.4 Change-Id: I454f89a18bdfcf1400f05edf318e37c5ea213424 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81364 Tested-by:
-
Helmut Strasser authored
The `f:link.page` ViewHelper registers an attribute for `target`, which works in extbase context. Due to some changes, the ViewHelper has been enhanced to mitigate the need for bootstrapping extbase in non-extbase contexts. Therefore, `LinkFactory` (TypoLink) has been used to build proper links in a non-extbase frontend context with #98474. The same principal for the different context has been applied to the `f:link.action` ViewHelper with #101729. That introduced a different behaviour between extbase and non-extbase frontend context by simply overriding the target attribute, if TypoLink generates one. This change discards the build target from the `LinkFactory` to behave equaly in non-extbase frontend context compared to extbase context. Additionally, tests are added to cover these cases to the corresponding ViewHelper functional test cases. Note: If TypoScript default target configuration is needed, the corresponding `f:link.typoscript` ViewHelper needs to be used. Resolves: #101432 Related: #101729 Related: #98474 Releases: main, 12.4 Change-Id: Icea34983ea1f730f5ceada7d7d5ea0dbf9827204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81359 Tested-by: -
Benjamin Franzke authored
Allowed content in CKEditor5 is to be configured via the General HTML Support plugin option config.htmlSupport. CKEditor4 style configs are now parsed and migrated. Note that this config.htmlSupport only applies to elements that are "known" to CKEditor5. Tags like "svg" or custom elements like "<foo-bar>" are not configurable this way as `htmlSupport.(dis)allow` can only handle elements that are defined in the CKEditor5 schema. [1] Also reintroduce the default configuration that allows any class and any attribute that starts with data- to be specified/preserved on known tags. This was removed with #96874. [1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html#enabling-custom-elements Resolves: #99738 Releases: main, 12.4 Change-Id: Idaadfc09328efa4d1f21171a400dc45d29ed5904 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81338 Reviewed-by:
-
Benjamin Franzke authored
* Use insertText command as provided by @ckeditor/ckeditor5-typing to match the behaviour of the upstream specialcharacters plugin: * Place cursor after inserted text * Replace existing selection when applying the button/shortcut * Disable button in source-editing mode (also fix ckeditor5 integration to work in case source-editing mode is disabled, to be able to test/verify that case) * Add tooltip to the toolbar button * Add a shortcut hint to the toolbar button tooltip * Show consecutive softhyphens * Show selections on softhypens and non-breaking-spaces Resolves: #101728 Releases: main, 12.4 Change-Id: I8c38a04a3c24de353edef921cc193f3fad718b4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81337 Reviewed-by: -
Christian Kuhn authored
When @import or <INCLUDE_TYPOSCRIPT: lines do not resolve to any include, this probably indicates a broken import statement. To help integrators find and fix those, the Page TSconfig and TypoScript backend modules now list them as "Syntax scanner warnings". We're adding a functional test to verify the detection works. This will ensure it does not break when we refactor some details of the include tree structure later. Doing as described in #102102 and #102103 would simplify and streamline various details, but it's currently unclear if we should still do this in v12. Resolves: #102064 Related: #100218 Related: #97816 Related: #102102 Related: #102103 Releases: main, 12.4 Change-Id: I1bba0cead97ff81b38c97f18581275edee01ea63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81358 Tested-by:
-
Markus Klein authored
The TypoScript parser matches valid operators first before dealing with values. Therefore, the TS `foo =<something` is now considered a reference and not an assignment. Resolves: #102101 Releases: main, 12.4 Change-Id: I7014b92f7a9120d0e77d264e964adef9d062070c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81357 Reviewed-by:
-
Benjamin Franzke authored
editor.config.typo3link.additionalAttributes was used in TYPO3 v11 to enable certian attribute on link tags. Add a migrator that enables the same effect via the General HTML Support (GHS) CKEditor5 plugin configuration `config.htmlSupport`. Also remove the evaluation of the related but unused global config option ['EXTCONF']['rte_ckeditor']['plugins']['TYPO3Link']['additionalAttributes'] which was added in #78917 (initial CKEditor4 linkbrowser integration) but was never actually used (which was probably undiscovered due to its similar name). Resolves: #102052 Releases: main, 12.4 Change-Id: I2ca5b24890dd71dc5cba3aade22995a843e3dd33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81334 Reviewed-by:
-
Markus Klein authored
Since v12 relative paths with INCLUDE_TYPOSCRIPT and DIR work differently. Resolves: #102065 Releases: main, 12.4 Change-Id: I365925767739e15547d0aed81f5631ab12c7d83e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81356 Tested-by:
-
Simon Schaufelberger authored
DataHandler->copyRecord_raw can also return null. This should be reflected in the doc header as well. Resolves: #102098 Releases: main, 12.4, 11.5 Change-Id: Ic7a12233efd32b67f0bf25d6478a03f807a5623e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81354 Tested-by:
-
- Oct 05, 2023
-
-
Benjamin Kott authored
The typo3-navigationIframe is not in use anymore, it is a leftover that was not removed in #96125. Resolves: #102097 Releases: main, 12.4 Change-Id: Ibc1f6be84f755c4e6b5869176edb682cc3f30f35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81336 Tested-by:
-
Stefan Bürk authored
Since PHP 8.3.0RC3 [1] the `\IntlDateFormatter` throws a `\IntlException` exception with the message: datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR if an invalid locale is passed to the constructor. The value `C` is considered as a non-valid locale, albeit it may be set. This change introduces a fallback to `en-US` for the two methods of the `\TYPO3\CMS\Core\Localization\DateFormatter` wrapping class, if `C` is passed as locale. `en-US` has been chosen as fallback because the TYPO3 locale class `\TYPO3\CMS\Core\Localization\Locale` uses the same as fallback if `C` is provided and additional tests are added to cover the same behaviour. Note: Other illegal locales are not handled and will allow the exception to bubble up with PHP8.3+. [1] https://github.com/php/php-src/commit/a80db7b52aa134bdc8b9841 Resolves: #102095 Releases: main, 12.4 Change-Id: I26d1ab74bd9dd659363320e191874f8526845158 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81335 Tested-by: -
Stefan Froemken authored
While migrating CKEditor5 property buttons.link.properties.class.allowedClasses the CKEditor5Migrator will now respect multiple classes. Resolves: #100841 Releases: main, 12.4 Change-Id: I245e8b0c8b2d14ee7917471963f29a9d65480245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81333 Reviewed-by:
-
Josef Glatz authored
This patch improves the record history view of an element by showing the realName on top of the username if available. Resolves: #102091 Releases: main, 12.4 Change-Id: I14387e6113ea632615cddd537136660d310819a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81332 Tested-by:
-
- Oct 04, 2023
-
-
Garvin Hicking authored
The scheduler detail view offers a "delete" button to delete a task from that view. This button now properly triggers a POST request, which is required by the controller to actually handle the delete action. Resolves: #102078 Releases: main, 12.4 Change-Id: I8553994f0e0a8b0967e3d93c2c5ceba84b96cc22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81320 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Oct 03, 2023
-
-
Simon Schaufelberger authored
In order to test local composer packages, they need to be placed under the "packages" directory in "Build/composer". To autoload these packages automatically, the necessary setup is adjusted. Resolves: #102054 Releases: main, 12.4 Change-Id: I6c40a06142efaf13493a149efc636da9837c3598 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81315 Tested-by:
-
- Oct 02, 2023
-
-
Benjamin Franzke authored
Download CSS via fetch() and apply CSS scoping and URL rebasing on the client in order to avoid the need for a server side SASS wrapper that: * can not relocate relative paths * can not easily check if the resource is web accessible * had to use regex-replacements instead of straight forward replacements on a properly parsed syntax tree The composer dependency scssphp/scssphp could theoretically be removed, but is kept in the v12 backport in order to avoid breaking classic mode extensions that relied on the fact that this dependency is shipped with TYPO3 v12. Commands executed: cd Build npm install --save css-tree npm install --save-dev @types/css-tree npm run build Resolves: #101918 Resolves: #100768 Resolves: #101380 Releases: main, 12.4 Change-Id: I34dfd76c07584a482f9012de1c693f0e7f9a2cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81308 Tested-by:
-
Benjamin Franzke authored
Do not operate on the view model, but always read link attributes from the data model. Do this to avoid conflicts with the (pre)view representation of the contents which may not represent the plain data 1:1. Examples: * CKEditor5 renderes phone links in the editor preview as `href="#"`. That means `href` must not be parsed from the link (#101303). * Link classes may be alterated with stateful style classes and had therefore be filtered server side previously (#101959). This is workaround could now be removed. To make it clear that the result of getSelectedLinkElement() must not be used as data source, the (more) correct return type `ViewAttributeElement` is defined now (upstream does so too). Note that CKEditor5 uses commands somewhat like data-models, where the data is to be collected in the refresh() method. This is why we process all link-related registered attribute in there, (based on the CKEditor5 schema). Releases: main, 12.4 Resolves: #101303 Related: #101959 Change-Id: I04ee9a07c7444cd197f70d658e856d6824254020 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81285 Tested-by:
-
Oliver Bartsch authored
Resolves: #102063 Releases: main, 12.4, 11.5 Change-Id: I0ee1a4ec00ee972e9a2c8c3db442883125dacacd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81284 Tested-by:
-
Simon Schaufelberger authored
Resolves: #102073 Releases: main, 12.4 Change-Id: I18e0d9758f7d18c3d44086286b8bed8f722dd57d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81283 Tested-by:
-
- Sep 28, 2023
-
-
Nikita Hovratov authored
Resolves: #102060 Releases: main, 12.4 Change-Id: I22acca2ecdff371a88c3cf060ac5c6707735bf73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81282 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Franzke authored
Adapt to the user expection for a style selector to only show applicable styles. The list becomes overwhelming in case a lot of specific styles (like table formatting) are shown for unrelated elements. Resolves: #99673 Related: #101627 Releases: main, 12.4 Change-Id: I482935e91c863b601676b078fab0e9ba3acd62fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81281 Reviewed-by:
-
Stefan Bürk authored
Sending a redirect response with a empty `Location` is invalid per RFC. Browser vendor are dealing differntly with it. * Firefox executes a redirect to the current url, leading to an `endless` redirect chain - stopping it after some recursions with a coresponding notice in the network tab. * Chrome determines this and is doing nothing at all with it - leading to a white page. From the [1] RFC regarding invalid URI spec for `Location`: > Note: Some recipients attempt to recover from Location > fields that are not valid URI references. This > specification does not mandate or define such > processing, but does allow it for the sake of > robustness. A matching redirect record with a manually entered `/` as redirect target leads in TYPO3 v11 to this behaviour. This can be mitigated by selecting the corresponding site root. For TYPO3 v12 and upwards a change in the LinkHandling has been introduced which properly handles the `/` in the link generation and correctly returning a `/` as redirect url. That change has quite some impact and is not reasonable to be backported to TYPO3 v11 within #100958. This change adds an additionally guard to the `RedirectHandler` to handle empty redirect urls as endless loop, just logging it and not responding with an redirect. This helps in v11 and keeps a safety guard for the future in this place. [1] https://datatracker.ietf.org/doc/html/rfc7231#section-7.1.2 Resolves: #100791 Related: #100958 Releases: main, 12.4, 11.5 Change-Id: I2af2d5bf759a277ade45bd0f7740ffe0099003b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81279 Tested-by:
-
- Sep 27, 2023
-
-
Stefan Bürk authored
With #98375 hooks in the `Page Module` has been replaced by modern PSR-14 events to customize the `Page Module` rendering. The related PSR-14 events are: * TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent * TYPO3\CMS\Backend\View\Event\ModifyDatabaseQueryForContentEvent * TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent This change adds some basic example how to implement event listener for these events to the corresponding feature ReST changelog file. Resolves: #102046 Related: #98375 Releases: main, 12.4 Change-Id: Ie7bdd8f365accc0224c28365da2f54e908520bd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81278 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
When the form is in "Preview" mode and an integrator either saves or switches to the form settings, the stage itself is updated to be in "Edit" mode again, but the internal state remains in "Preview" mode, causing glitches in the UI. This patch now disables the preview state in the form model everytime the "stage area", containing the editing interface, is rendered. Resolves: #102031 Releases: main, 12.4, 11.5 Change-Id: I84b0817bb99201527dbd4b950e560631e7b1d94f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81276 Reviewed-by:
-
Stefan Bürk authored
Storages using the local storage driver with a non existing base folder are put offline automatically. However, the file list module displays a to generic error message not pointing to that fact. This change adds a concrete check for this case and displays a more specific error flash message in the file list module now. This can be tested by creating a additional local storage with a non-existing relative path, for example: `fileadmin/not-existing-folder/` Resolves: #85323 Releases: main, 12.4, 11.5 Change-Id: Ie3ad64a99c0871d258470ffc858639dee4de1108 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81277 Tested-by: -
Andreas Fernandez authored
This commit updates all Symfony components to version 6.3, as 6.2 ran out of support. Please see the upgrade document at [1]. Executed command: composer require \ symfony/config:^6.3 \ symfony/console:^6.3 \ symfony/dependency-injection:^6.3 \ symfony/doctrine-messenger:^6.3 \ symfony/expression-language:^6.3 \ symfony/filesystem:^6.3 \ symfony/finder:^6.3 \ symfony/http-foundation:^6.3 \ symfony/mailer:^6.3 \ symfony/messenger:^6.3 \ symfony/mime:^6.3 \ symfony/options-resolver:^6.3 \ symfony/property-access:^6.3 \ symfony/property-info:^6.3 \ symfony/rate-limiter:^6.3 \ symfony/routing:^6.3 \ symfony/uid:^6.3 \ symfony/yaml:^6.3 \ -W [1]: https://github.com/symfony/symfony/blob/6.3/UPGRADE-6.3.md Resolves: #102043 Releases: main, 12.4 Change-Id: Ia306d0ad34cc3fdb72a51259464491dc64fbdbc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81260 Tested-by: -
Andreas Fernandez authored
The context menu component now uses the `URLSearchParams` API to build a query string for AJAX requests, being a replacement for manual string composition. Resolves: #101963 Releases: main, 12.4 Change-Id: Ifa5f46df04dc9a66f80e3d414ac0aeaa7ecb1368 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81264 Tested-by:
-
Stefan Bürk authored
The doctrine team realeased `doctrine/dbal 3.7.0` recently and this change raises the dependency to that version. Extension authors activating `doctrine/dbal` deprecation will then get the newest `doctrine/dbal` deprecations included in that release. That helps in preparation for planned `doctrine/dbal 4.x` upgrade with TYPO3 v13 to avoid stumpling into breaking changes. Used command(s): > composer require --no-update \ -d typo3/sysext/core \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/install \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/redirects \ "doctrine/dbal":"^3.7.0" ; \ composer require \ "doctrine/dbal":"^3.7.0" Resolves: #102042 Releases: main, 12.4 Change-Id: I34ee939fc94078df2006ad338d1e7ff1cac14a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81259 Tested-by: -
Andreas Fernandez authored
Resolves: #102040 Related: #101790 Releases: main, 12.4 Change-Id: I7a6a21fd98d1a9506da864d983b1f40b03f4259e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81275 Tested-by:
-
- Sep 26, 2023
-
-
Sven Proffe authored
Releases: main, 12.4 Resolves: #102039 Related: #97449 Change-Id: I5f7d314e40e53d09505bad92b5ce49bcc3ea8f10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81274 Tested-by:
-
J. Peter M. Schuler authored
Feature #76085 introduced an admin panel option which shows red boxes with section and partials for easier debugging. However sometimes no partial name is shown in the output, because the retrieved name is not cleaned correctly. Resolves: #97509 Related: #76085 Releases: main, 12.4, 11.5 Change-Id: I087e3688fa8d5703c621e182f80b594492c11115 Signed-off-by:
J. Peter M. Schuler <j.peter.m.schuler@uni-due.de> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81272 Tested-by:
-
Benjamin Franzke authored
In case a link with an invalid CSS class is edited, the class value is not simply invalidated and shown as empty (which isn't true), but a virtual select option "[ INVALID VALUE (…) ]" is added (and selected) that documents the fact that the current value invalid, but will be preserved upon updates. (as in FormEngine) This allows the editor to choose between preserving, removing or changing to another css class value. With this change applied, we can not properly remove empty value. Note that empty values previously implicitly preserved existing values, which made it impossible to remove a link title or target. Resolves: #102012 Resolves: #102013 Releases: main, 12.4 Change-Id: Iefae377a9e18467e8eb9111ef3ef7a96c89b6ce1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81213 Tested-by:
-
Chris Müller authored
Outdated manuals which are not supported anymore are removed. The missing system extensions manuals are added. Some special cases: - t3install was renamed to t3upgrade (as the Installation Guide was also renamed to Upgrade Guide) - t3l10n and t3translate are duplicates, t3l10n was removed The current list of manuals is maintained in https://github.com/TYPO3-Documentation/TYPO3CMS-Example-ExtensionManual Resolves: #102035 Releases: main, 12.4 Change-Id: I344f8a17d1c5de9dbcdc5148bed5322518d72b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81252 Reviewed-by:
-
- Sep 25, 2023
-
-
Chris Müller authored
Resolves: #102019 Releases: main, 12.4 Change-Id: Ib65eaf32d3bff91b943d965684eb2f0fcf25a44d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81183 Tested-by:
-
Ramón Schlosser authored
Resolves: #102029 Releases: main, 12.4, 11.5 Change-Id: Idfa299ece1011727da09421ee148a820dc4e0326 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81232 Tested-by:
-
Benjamin Franzke authored
Releases: 12.4 Resolves: #102033 Related: #101960 Change-Id: If063940470545c43a12541225b3da1a77101f2e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81217 Reviewed-by:
-
Benjamin Franzke authored
Use @web/test-runner which is toolset by the modern-web.dev and open-wc.org initiatives. It is based on mocha and es-dev-server, which allows to run our JavaScript modules natively in the browser (without having to bundle them via rollup). Note that compiled test files have been removed from the source tree, since we configure es-dev-server to transpile them on demand, allowing error output from tests to be using original line numbers and unmangled identifiers. The tests are executed in chrome by default (locally and CI). They can be executed via: # Run once npm run test # Run tests whenever files change npm run watch:build npm run watch:test # Open browser with devtools and debug mode activated MODE=dev npm run watch:test -- --debug Configuration is prepared to run in multiple browsers via playwright. Example: # https://playwright.dev/docs/browsers#install-system-dependencies npx playwright install --with-deps B...
-
