- Sep 26, 2020
-
-
Alexander Schnitzler authored
Since all level 2 rules are active and only level 2 parameters are set to different values compared to their originally declared value, the whole file can be removed, the overall phpstan level can be raised to 2 and the parameters can be defined in the main phpstan file. Releases: master, 10.4 Resolves: #92424 Change-Id: I8404f5f2f4ff318bb3419ed307b1ffe7edcc6822 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65902 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Aug 13, 2020
-
-
Alexander Schnitzler authored
Updating phpstan to version 0.12.37 lets phpstan benefit from static reflection which does no longer come with the need to load analyzed classes and use the native reflection api of php. Instead, roave/better-reflection is used, which does a better job and reduces false positives. Since phpstan has been updated, the rules which have been copied over from the vendor package had to be updated as well. And since phpstan does find more errors now, a few rules had to be disabled again. Used commands: - composer require phpstan/phpstan:^0.12.37 --dev - composer require friendsoftypo3/phpstan-typo3:^0.4.0 --dev Releases: master Resolves: #91635 Change-Id: Ia6b68e7ed1428fbc40ae4d1b9eb3a13d212a3a5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64851 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 16, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90910 Change-Id: If03889ee330e96c5ca82b31ae0604fb1d1d0afc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64031 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Apr 08, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90913 Change-Id: If38a526547518e93b3002ffa01accebf4a12e5b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64032 Tested-by:
-
- Apr 07, 2020
-
-
Daniel Siepmann authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 several @var annotations have been adjusted to reflect the actual used type of properties. This however led to the issue that several properties of Extbase models had one type as annotation but used more than one specific type internally. Adding the additional type made phpstan happy but broke the property mapper of Extbase, which expects just one type to be annotated via @var. Therefore, the @var annotations in the affected models have been reverted to their original state and the reoccurring errors have been put onto phpstans list of ignored errors. Resolves: #90969 Releases: master Change-Id: I91944a631b9e1ff300ada25953577d852a998270 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Apr 02, 2020
-
-
Alexander Schnitzler authored
Several issues have been ignored because of checks on runtime constants which vary from context to context. Since we can only simulate one context, phpstan is unable to properly detect several paths. Releases: master Resolves: #90909 Change-Id: Ie3213112a299559687f27317821453137cd5322a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64030 Reviewed-by:
-
- Mar 27, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90802 Change-Id: I84da713c7b8c68ae67b6b9c33ad66dcbac8d72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63810 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
- Mar 23, 2020
-
-
Alexander Schnitzler authored
Used command: composer require friendsoftypo3/phpstan-typo3:"~0.2" --dev Releases: master Resolves: #90811 Change-Id: Ibd9ae856e8046edc67cb7610956ede92c474bf12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63846 Tested-by:
-
- Mar 20, 2020
-
-
Alexander Schnitzler authored
As there are a lot of rules that do not raise any errors with our code base, those rules up to level 8 are enabled with this patch resulting in more pre merge tests being executed as of now. Releases: master Resolves: #90795 Change-Id: I3628569c90e1e7bbf2ffde81abbef37065bd45e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63812 Tested-by:
-
Alexander Schnitzler authored
This patch simply pulls out the level 2 rules into a separate configuration file which is a copy of the original level 2 configuration file of phpstan with some rules, services and parameters disabled. Also, additional configuration files are put into the Build folder and phpstan.neon has been added to the .gitattributes file. Releases: master Resolves: #90789 Change-Id: Ia3b3c30cfa57227c0607904df38add31f36be0e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63802 Tested-by:
-
- Mar 08, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
-
- Mar 06, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90665 Change-Id: I55c08b826d6e4560cbfbcde99e795f55036b049c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63565 Reviewed-by:
-
- Mar 02, 2020
-
-
Alexander Schnitzler authored
phpstan reported superfluous usages of isset checks for variables that are defined and whose type is more specifically checked in the same condition. Some reported errors of phpstan have been ignored for now as they are considered false positives and which will be tackled once there is more type safety in the context of those reported errors to be able to properly replace the isset checks. Releases: master Resolves: #90576 Change-Id: I028a928bcbc18185f69f7bda4358aaf08cc016b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63481 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Feb 28, 2020
-
-
Alexander Schnitzler authored
This patch introduces a bootstrap file for phpstan to define missing constants phpstan would report otherwise. A dedicated config file phpstan.typo3.neon has been introduced because there are plans to release a seperate configuration package that not only the core uses but which is also useful for TYPO3 users that test their codebase with phpstan. Releases: master Resolves: #90575 Change-Id: I1c5bce558c882f9dd002e480d78405770bdf8cc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63480 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Feb 27, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90558 Change-Id: I9a02974eb3c4efc242d83f0610f7fc15764b30b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63042 Tested-by:
-
- Feb 23, 2020
-
-
Daniel Goerz authored
Resolves: #90500 Releases: master Change-Id: Ieaecff065dcc60c4e8e7c7a19d87fe5a8d18cd40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63384 Reviewed-by:
-
- Feb 21, 2020
-
-
Alexander Schnitzler authored
This patch ignores several errors found by phpstan which are not easy to solve as of now or which are not solvable at all. - Unsafe usage of new static Those errors can be solved in different ways. Making classes final, making constructors final or using new self. Which solution is used has to be decided by people who are familiar which the affected files. - Call to an undefined method in AbstractWidgetViewHelper and AbstractViewHelper Those issues aren't solvable as those methods exist if users choose fluid ^3. - Access to undefined constant TYPO3\CMS\Core\Type\Enumeration ::__default This issue can't be solved as the Enumeration class does a lot of magic stuff which isn't compatible with static code analysis. Releases: master Resolves: #90402 Change-Id: Ie4a1623d42cb37d30082275ca1a09a733301d06e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63276 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de>...>
-
- Feb 19, 2020
-
-
Alexander Schnitzler authored
Bleeding edge configuration may be useful to use but shouldn't be enabled by default. To make the inclusion convenient, the include has only be commented and not be removed at all. Releases: master Resolves: #90403 Change-Id: I9a8dfdef29947df890db92d331f1b4b27d13b736 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63277 Tested-by:
-
- Feb 15, 2020
-
-
Alexander Schnitzler authored
Upgrade phpstan/phpstan to at least 0.12.10 and enable bleeding edge configuration to be able to run the phpstan analysis with all available cpu cores. Releases: master Resolves: #90378 Change-Id: I4c76a8f44c570b126844d1bde96998cf9d3790fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63253 Tested-by:
-
- Jan 17, 2020
-
-
Alexander Schnitzler authored
This commit introduces a development requirement to phpstan/phpstan to enable static code analysis. A basic configuration file has been added as well to identify most basic errors in the TYPO3 code base. Releases: master Resolves: #90097 Change-Id: I87e11eca6296864fdd7ba8cd109a23b82c27f641 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62851 Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Felix P. <f.pachowsky@neusta.de> Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
