- Aug 06, 2024
-
-
Torben Hansen authored
With #102770 the `delete()` method for a FileReference object has been implemented. This was however performed using a hard delete of the file reference record in the database, which is not appropriate, since the delete functionality must take into account, if the table is configured for soft or hard deletes. This patch changes the implementation, so the file reference is either hard or soft deleted depending on the TCA configuration. If the delete operation was successful, the reference index for affected records is now updated. Additionally, functional tests are extended to ensure, that the file used in the file reference remains when the file reference is deleted and that the reference index is updated accordingly. Resolves: #102785 Related: #102770 Releases: main, 12.4 Change-Id: I43beb066c2259441aa2ed7e3fba0e242b7d8fbbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85516 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Georg Ringer authored
Add the CSP headers to the response created by the PageContentErrorHandler. Resolves: #104486 Releases: main, 12.4 Change-Id: Iffc783dc40989abacbab4766a03a865fdd37b5cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85515 Tested-by:
-
Stefan Bürk authored
Doctrine DBAL retrieves for MariaDB `ENUM()` and `SET()` field default values quotes with single quotes, which leads to an endless field change reporting recursion in the database analyzer. The default value is now trimmed to ensure a working field compare within the extending `TYPO3\CMS\Core\Database\Schema\Comparator` class. Note that TYPO3 v13 (main) may reveal the same issue but is shadowed due to the general `ENUM()` and `SET()` type field issue since Doctrine DBAL 4, reported in #104413. That needs a change on its own for main only. Resolves: #97498 Related: #104413 Releases: 12.4, 11.5 Change-Id: I51b79a7f63db43cca2724958b0355a496a49fd33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85511 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Henrik Ziegenhain authored
For nearly all form elements one can pass the fluidAdditionalAttributes property to the corresponding templates. So also allow Fieldset to use this property by default. Resolves: #102291 Releases: main, 12.4 Change-Id: I1c48db94626ba724409dc0d97deb3cde51553bf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85512 Tested-by:
-
- Aug 05, 2024
-
-
Georg Ringer authored
The information about the allowed content types (typically CType) has been added to the user information in the beuser module. Resolves: #98590 Releases: main, 12.4 Change-Id: Ifb1377424d064071a90e0f5238c037ec4b347e4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85459 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Aug 03, 2024
-
-
Corinne van der Zande authored
Previously, using the property cols="inline" doesn't have an effect for checkboxes with renderType checkboxToggle. This patch resolves this issue and introduces a test case in typo3/cms-styleguide. Resolves: #104487 Releases: main, 12.4 Change-Id: I2581bb462af80f2336b0cac76ce955e6b7411463 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85504 Tested-by:
-
Mathias Bolt Lesniak authored
SiteResolving will now correctly interpret a temporary ID of a new page (e.g., "NEW12345678ABCDEF") as an invalid ID and try to infer the site using `$result['effectivePid']`. This makes it possible to access site configuration properties within the TCA also on pages that have yet to be created. Resolves: #103573 Releases: main, 12.4, 11.5 Change-Id: I174e71e084e96b24ebe721ad0336a3dd1a8115d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85457 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- Aug 02, 2024
-
-
Bastien Lutz authored
When creating a page with access set to "Show at any login" and trying to view that page with the admin panel "simulate user group" preview, the page is not displayed. This is because the provided frontend user does not contain the special group -2. Resolves: #104484 Releases: main, 12.4 Change-Id: I4504cdcadbdd6df217f74d258cd7e182ea23796e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85456 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Bartsch authored
In large installations, it's common to add sites, having site root option set, bundled into folders or similar structurs. Therefore, the auto creation of site configurations now also works for pages added with the site root option set on all levels. Resolves: #104531 Releases: main, 12.4 Change-Id: I8c5989754c34fef4a303ff3db497178f3366bf6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85455 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Anja Leichsenring authored
Used command: composer require --dev phpstan/phpstan:"^1.11.8, !=1.11.9" Resolves: #104536 Releases: main, 12.4 Change-Id: I6e020c6b4a903ad2ad942614f03b96b48317313f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85494 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Aug 01, 2024
-
-
Marcel Küpper authored
Namespace declaration did not match Fluid namespaces. This patch fixes the namespaces for the EXT:felogin partials. Also an unnecessary usage of a namespace fluid pointing to the TYPO3Fluid package was moved to the namespace f. Resolves: #104511 Releases: main, 12.4 Change-Id: Idafc5595177b312440e6a7bda18634df73bfb5be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85453 Tested-by:
-
Georg Ringer authored
With the CKEditor5 unbundling in #102099, we can now ship free (GPL-2 licensed) CKEditor5 modules, that may be useful, for some installations, without the need to ship them for all installations in a big bundle. npm install --save \ @ckeditor/ckeditor5-highlight@41.4.2 \ @ckeditor/ckeditor5-language@41.4.2 \ @ckeditor/ckeditor5-mention@41.4.2 npm run build Releases: main, 12.4 Resolves: #101128 Related: #102099 Related: #99670 Change-Id: Ic7b88985c64c59c65ee8502e50d74c3206636893 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85452 Tested-by:
-
- Jul 31, 2024
-
-
Markus Sommer authored
Resolves: #104513 Releases: main, 12.4, 11.5 Change-Id: I73d4d5eac80e3bd637fa2fabd7b1d1948daf357c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85429 Tested-by:
-
Georg Ringer authored
An editor might not have access to the 1st storage defined (usually fileadmin). To avoid an exception, an additional check compares the default storage to the available ones. Resolves: #103897 Releases: main, 12.4 Change-Id: Ib2d4dc758a2ad95298479122bd7302bb008b3c20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85424 Reviewed-by:
-
Simon Praetorius authored
This patch-level release resolves an issue with arbitrary ViewHelper arguments introduced with Fluid Standalone 2.12. Now the arbitrary arguments behave in the same way as manually defined tag attributes. > composer u typo3fluid/fluid Resolves: #104490 Releases: main, 12.4 Change-Id: I8480f54d89fb37eb7e75d887a093a44675aba4ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85422 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
- Jul 30, 2024
-
-
Garvin Hicking authored
In case a `sys_log` entry is deleted via the `belog` backend module, an error was thrown. This only happened for log entries with `details_nr` 11 or 12 (PHP errors) AND where placeholder values in the column `details` were used. Then the backend log module would try to delete all rows only with the exactly matching, substituted log details, so that not too many records would be deleted (with different placeholders). The code for this tried to unserialize the log data, which led to the created delete-query utilizing an array as named parameter placeholder value, which then threw an error. The solution is to use the actual raw data for the query comparison, which is what this patch does. Then the exact contents of the fields `details` and `log_data` will be used to delete all matching rows. Resolves: #104494 Releases: main, 12.4 Change-Id: I393b918919340eb279c62136feec2f27eeac708f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85414 Tested-by:
-
- Jul 29, 2024
-
-
Thomas Hohn authored
In the RestoreRegisterContentObject::render method a call to array_pop is performed. The result is assigned to the variable $frontendController->register which has type array. However array_pop can return null, this patch add's a null coalesce operator to ensure that correct type. Resolves: #104495 Releases: main, 12.4, 11.5 Change-Id: I46efce10e4322ff3cd39b5a0eeafd1f768644e38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85358 Tested-by:
-
- Jul 26, 2024
-
-
Christian Kuhn authored
PHP 8.4 support requires new guzzle versions. v13 sets requirements to PHP 8.4 compatible guzzle libraries versions, so v13 can not ship with libraries lower than that. This drops guzzle/promises v1 support, which has been re-added to v12 for backwards compatible reasons, and v13 inherited this. It should be fair to drop guzzle/promises v1 in v13 now. v12 and v11 will only "composer u" to the versions below, but not require them, so non-composer releases will package compatible library versions, while composer instances have the option to update when needed. > composer u guzzlehttp/guzzle guzzlehttp/promises guzzlehttp/psr7 Resolves: #104488 Releases: main, 12.4, 11.5 Change-Id: I43a4e56f9fbb3bb00d77eb198161350e72a51da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85394 Tested-by:
-
Christian Kuhn authored
Brings PHP 8.4 fixes. "composer req" in v13, "composer u" in v12 and v11. > composer u typo3/html-sanitizer Resolves: #104483 Releases: main, 12.4, 11.5 Change-Id: I3c5dfb7eb1b76bc13ef0d784e87138360bfbdd61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85391 Tested-by:
-
- Jul 25, 2024
-
-
Stefan Bürk authored
With #93223 minor index handling within the Database Analyzer Stack was fixed. Via DBAL 4 changes in "main" (and not 12.4), some variable names in loops were changed. When backporting #93223 to 12.4, these changes were not carried over, which led to an inner loop re-using a variable name from the outer loop. Due to this, the index name generation could not properly recognize all renamed keys, and only the last renamed key was recognized in the Database Analyzer. This patch adjusts the inner and outer loop variable names to be unique and in line with what is in place in "main". Resolves: #104449 Related: #93223 Releases: 12.4 Change-Id: Id2aeefad661188c1fe458c773f571abdf9bfb0bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85379 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Sergio Catalá <cajondesartre@gmail.com> Reviewed-by:
-
Stefan Bürk authored
This change raises the core-testing-php84 image version to use PHP 8.4.0 alpha2. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/abd0b88dd70d0053359b08584d66df17540f177d Resolves: #104480 Releases: main, 12.4, 11.5 Change-Id: Ife69d5fdb82f4243547fab5998b4a1ba0123bafc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85356 Tested-by:
-
Christian Kuhn authored
Youngest patch levels add a finding. Fit it codewise and raise. > composer req --dev phpstan/phpstan:^1.11.8 Resolves: #104478 Releases: main, 12.4 Change-Id: I21830f4a36094dd6c279715a0571a2f2ad911afa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85383 Tested-by:
-
Garvin Hicking authored
In #102557 additional sprintf() placeholders were added, but were missing to be introduced to `DataStructureIdentifierListener`. This change propagates the needed identifier to the output, too. Resolves: #104433 Related: #102557 Releases: main, 12.4 Change-Id: Idb4f3f37f8fb347d77f3ca0038962a7280291930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85380 Tested-by:
-
Christian Kuhn authored
phpstan "bleeding edge config" enables a feature that reduces memory usage significantly. We don't switch to "bleeding edge" per se, but enable that single toggle for now. phpstan does not do this by default since it may be breaking for existing rules, which is not a problem in our case. > rm -rf .cache/phpstan/; Build/Scripts/runTests.sh -s phpstan Before locally: 10.99 GB After locally: 5.82 GB Before CI: 15.15 GB After CI: 9.49 GB Numbers vary depending mainly on available number of CPUs: My local machine has less CPUs than CI - we *may* tune phpstan a bit further in this area, later. Resolves: #104476 Related: #104475 Releases: main, 12.4, 11.5 Change-Id: I32ca9a36b752ad52e8ac5fd433c3f929f86843af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85377 Reviewed-by:
-
Benni Mack authored
Resolves: #104396 Releases: main, 12.4 Change-Id: I28404ae44961918f372dd3b3c8e8de4e138e09c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85355 Tested-by:
-
Markus Klein authored
* ext:form is FE an extbase plugin and operates with an extbase request created by extbase bootstrap (or by FluidTemplateContentObject, but that's a different story). * ConfirmationFinisher has option 'contentElementUid', which - when set - creates a ContentObjectRenderer to render specific content elements. * ContentObjectRenderer then often renders this content element using FluidTemplateContentObject. Various code within Fluid rendering then applies magic to create new requests, *if* an extbase request is given. This can lead to broken template resolving when rendering in FluidTemplateContentObject. This entire thing is quite messy. We're taking measures to resolve the underlying flaws in v13. To fix the situation in v12, the idea is like that: When ConfirmationFinisher calls ContentObjectRenderer and hands over its request, it should "free" that request from its own extbase context to not trigger pollution by code that does things if an extbase request is given. Note this was not an issue in v11 since only v12 started handing over the extbase request to ContentObjectRenderer, in v11 it was indirectly pulled from $GLOBALS['TYPO3_REQUEST'] within ContentObjectRenderer, which is the "original" request before it is turned into an extbase request by extbase plugin bootstrap. Resolves: #104462 Related: #100623 Related: #104472 Related: #104471 Related: #104473 Releases: main, 12.4 Change-Id: Id53bc9f159dc2575a8bedb63cd7e7a039864f92b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85376 Tested-by:
-
Christian Kuhn authored
phpstan can be very memory hungry. Option --verbose adds a line about 'peak memory' usage to the output. Add this to get a better feeling of the memory usage. Resolves: #104475 Releases: main, 12.4, 11.5 Change-Id: I3fdaf7ddee7e003e7a8e75a508dd69161c804c8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85353 Reviewed-by:
-
- Jul 24, 2024
-
-
Georg Ringer authored
Resolves: #99197 Releases: main, 12.4 Change-Id: I9ac78c5a7ef29f0390dbe7d5dd0004472382eea8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85352 Reviewed-by:
-
Georg Ringer authored
ProcessedFile::getSize() can call AbstractFile::getSize which can return null instead of integer which is required as return type. Add a type cast to avoid exceptions. Backport the changes done already in v13 with #101327. Resolves: #103777 Related: #101327 Releases: 12.4 Change-Id: Ie42cb69c045d5c586a7ce34cd4dee545ec6233b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84445 Reviewed-by:
-
Andreas Kienast authored
This commit updates the package `requirejs` to version 2.3.7 to fix a prototype pollution vulnerability [1]. [1] https://github.com/requirejs/requirejs/compare/2.3.6...2.3.7 Resolves: #104459 Releases: 12.4, 11.5 Change-Id: I73a62c7e4e715954db5802d0a46d5758c407ac7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85334 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Jul 23, 2024
-
-
Lina Wolf authored
So that they can be properly linked in api.typo3.org and IDEs. Releases: main, 12.4 Resolves: #104439 Change-Id: Id01abd68ec8f8238a70aa900a17fd33917ffd67e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85339 Tested-by:
-
- Jul 19, 2024
-
-
Sandra Erbel authored
Missing definition provided and wording corrected. Releases: main, 12.4 Resolves: #104429 Change-Id: I59bca54826557e7633ce837c73df6d38cda24742 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85308 Reviewed-by:
-
Stephan Großberndt authored
Disables spell checking in the changePassword form of EXT:felogin See issue #98492 for details. Resolves: #104437 Related: #98492 Related: #98504 Releases: main, 12.4 Change-Id: I4ec8056867ac55b00a542c1527f028c234a064c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85207 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org>
-
Stephan Großberndt authored
Resolves: #104438 Releases: main, 12.4 Change-Id: I4ef127561e45d72c03beb9db08a2a081aa59ddca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85307 Tested-by:
-
Stefan Bürk authored
Resolves: #104435 Releases: main, 12.4, 11.5 Change-Id: I5ff37f97f0d0a71420839c4d2b1bf8bde70afa7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85205 Tested-by:
-
Stefan Bürk authored
This change adds the predefined GitLab CI/CD variable `CI_JOB_ID` value to the suffix, used for containerized network and container names, with the goal to increase uniqueness in CI runs. Additionally, the value is now displayed in execution and the container cleanup notes at least the network name further information source to investage unusually container shutdowns. [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Resolves: #103928 Releases: main, 12.4, 11.5 Change-Id: I6cf8dddefd2b45ed6f5c8cca8aa5521319cc8c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85301 Reviewed-by:
-
Oliver Hader authored
Fixes an array key warning in $backendUser->groupData['webmounts']. Resolves: #104430 Releases: main, 12.4, 11.5 Change-Id: I077c59c67067f6221288ca4a73589dcc9c69bd07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85297 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Andreas Kienast authored
Historically, FormEngine UI mangles dates from one format to another and feeds the result back to the date picker, crossing fingers nothing goes wrong. This bites hard when it comes to non-standard date formats, basically everything but `d-m-Y`. To lay the groundwork on tackling the date format issue, FormEngine now always works with ISO8601 dates internally, allowing to get rid of some helper methods. Resolves: #104309 Releases: main, 12.4 Change-Id: Iafac126f8f02b6dba6f2623f1e7790c6c6fb9bb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85243 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Georg Ringer authored
Remove the usage of the RawViewHelper in the list view of distributions as also the single view doesn't allow any HTML. Resolves: #97930 Releases: main, 12.4 Change-Id: I6b4fceb7adcb6c7e396140a28d2a50a9dd136029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85203 Tested-by:
-
Garvin Hicking authored
The Changelog mistakenly referred to "PageRenderer::loadJavaScriptModules" (even though the example code itself was right). To avoid confusion of the method not being static, the notation is also changed from "::" to "->" to indicate a non-static class member method. Resolves: #104428 Releases: main, 12.4 Change-Id: I82827590ea2c852522b487986ff95159204b5b70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85290 Tested-by:
-
