- Aug 13, 2021
-
-
Wouter Wolters authored
diff-format option has been removed. udiff is the default now since v3. composer u friendsofphp/php-cs-fixer composer/xdebug-handler php-cs-fixer/diff composer req --dev friendsofphp/php-cs-fixer:^3.0 Resolves: #94856 Releases: master Change-Id: I33470fc49b4355130e73326c85323a1848fe3562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70516 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Wouter Wolters authored
The following core extensions are handled: * EXT:scheduler * EXT:seo * EXT:setup * EXT:t3editor * EXT:workspaces Resolves: #94850 Releases: master Change-Id: Ia3e7138a2c4babbcf4428a9a3e5d64de81262687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70503 Tested-by:
Marcin Sągol <marcin@soee.pl> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Wouter Wolters authored
Several unused variables are found that can be removed without problems. Resolves: #94793 Releases: master Change-Id: Ibf87fc95fbfe6da1b0dc7ba9e5939d7e738fa867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70410 Tested-by:
Stefan Busemann <stefan.busemann@in2code.de> Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Wouter Wolters authored
Test methods are not allowed to have a prefix "test". Use the annotation "@test" in phpDoc instead. Integration into pre-merge and nightly gitlab-ci suites. Note we now have multiple tests based on nikic/php-parser. Those should be rewritten to use one parser instance with multiple visitors to scan php code only once. The exception code checker should be rewritten to use the parser, too. This will be done with a dedicated patch. Resolves: #94859 Releases: master Change-Id: I43ba692eaf2a342a2e0ed3d8978386ea5719183f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70524 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
-
Jochen Roth authored
The "create new element" button in the form editor was cut off. This is fixed by calculating the height minus the doc-header height. Resolves: #94773 Releases: master Change-Id: I7dfc891138473592c76562c6802430a4311739a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70394 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Jochen Roth authored
On each keystroke the animation for validators was triggered. This is now fixed by removing the animation on an active form element. Resolves: #94775 Releases: master Change-Id: I78d454df081c035c5858f32bb0bd3a8b01679a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70395 Tested-by:
-
Oliver Hader authored
New `<f:sanitize.html build="default">` view-helper is introduced which directly invokes processing of `typo3/html-sanitize` package. An optional view-helper argument `build` allows using a defined preset, or a fully qualified class name of a builder instance as alternative, which has to implement `\TYPO3\HtmlSanitizer\Builder\BuilderInterface`. In contrast to `<f:format.html>`, this does NOT invoke `lib.parseFunc`, and does NOT rely on TypoScript configuration being loaded and parsed. Resolves: #94825 Releases: master, 11.3, 10.4, 9.5 Change-Id: Id0720120fea7d5d517a8c61d10bdbb6b03658adf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70457 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Andreas Fernandez authored
To be more consistent: * Rename "-s install" to "-s acceptanceInstall" * Rename "-s cglAll" to "-s cgl" * Rename "-s lint" to "-s lintPhp" Apart from that, the cgl checker also lints the files before checking cgl. The explicit pre-merge lint jobs are thus obsolete in pre-merge. We keep "lint everything" for nightlies to be sure. Resolves: #94769 Releases: master Change-Id: Ie7b409f3b2485a8792199e4ad2eaec8565daf253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70340 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Björn Jacob authored
Resolves: #94882 Releases: master Change-Id: I3f398731cb2bd313efae0f8f7f75032fb4220ca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70583 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
11nd11 authored
Streamline and optimize styling and markup of the form manager of form module. * Clean up markup and classes of form list * Optimize UX of the form list and use the new alternative action menu for better icon description * Use new common styles and elements for better overview and modern look Resolves: #94806 Releases: master Change-Id: I5e24be3e022480c1798745131be7d41f4a5eaf2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70450 Tested-by:
Paul H <paul+typo3@ecopixel.com> Tested-by:
-
Benni Mack authored
* Clickmenu needs to wait for full initialization before clicking on 'more'. * Always wait for page elements when loading new page. Resolves: #94875 Related: #94772 Releases: master Change-Id: I883a0370c34309ca555076b4088f173d77579f61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70549 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
-
Oliver Bartsch authored
The columns selector actions buttons did previously not respond when clicking on their icon. This is fixed by adding the event listener to the corresponding buttons instead of the outer container and by accessing the required data attribute from `event.currentTarget`. Resolves: #94881 Releases: master Change-Id: I7992a307bd5a397eff11b395c5a4b22bd9e05a40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70581 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Mathias Brodala authored
Resolves: #94871 Releases: master Change-Id: If8f4c823d1e21639a173f8ba2580e15c4daf9e20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70544 Tested-by:
-
Björn Jacob authored
The documentation describes how to exclude specific options from being overridden via the form plugin. Resolves: #80407 Releases: master, 10.4 Change-Id: Id90808b921afadc3d090078e6d2cc5eb157fcf43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70538 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Christian Kuhn authored
This one is disabled with sqlite already, mssql suffers from the same issue. Needs a dedicated fix somewhere in the tree classes, the issue is on our todo list with current ext:impexp works. Resolves: #94874 Related: #94772 Releases: master Change-Id: Ic4770ba5c6cb72c790816edafd732ca263ab8c1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70545 Tested-by:
-
Ralf Zimmermann authored
Cleanup the last "duplicate form" wizard code and make the buttons in the last "duplicate form" wizard step clickable. Resolves: #94860 Releases: master Change-Id: Ib6dac66cc3a3860fb380ee7028890acb08890f36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70527 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
-
Wouter Wolters authored
The FileSpoolTest is creating a directory "spool" on root level. Unit tests should never create directories on the root level of TYPO3 project. Instead use `Environment::getVarPath()` as path. Resolves: #94858 Releases: master,10.4 Change-Id: I04d1aa246d496b175361f22aa49ed2ac8fec3853 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70520 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Rudy Gnodde <rudy@famouswolf.com> Reviewed-by:
-
Jochen Roth authored
Fixed by adding a fallback to the affected array keys. Resolves: #94863 Releases: master Change-Id: I373910d106971c101493b0a427d09cf9904ab249 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70541 Tested-by:
-
Stefan Bürk authored
Remove resolved scriptName with leading slash from url in PageRouter matchRequest method. This prevent to change the url to a invalid url if PageTypeSuffix Decorator with .php is used and a page slugs ends in index. Resolves: #94537 Releases: master, 10.4, 9.5 Change-Id: I5057bb6888c228a4ca5b53d363ecf1bc7a6af1c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69854 Tested-by:
-
Andreas Häfner authored
In patch #94429 inclusion of LL file has been removed accidentally. To prevent multiple inclusion of LL-file in loop, incusion is done in DataStructureIdentifierHook::__construct now. Adds new constant for LLFile. Resolves: #90784 Related: #94429 Releases: master Change-Id: I4446ed6e05b8e506279e77fae4703a817831129d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70465 Tested-by:
-
Ralf Zimmermann authored
Form mixins were deprecated with #89742. The patch removes the code. Resolves: #94861 Releases: master Change-Id: Ic82729ae52d3f8c6ca7cd0ad8f6c97aceebc96d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70528 Tested-by:
-
Benni Mack authored
When having a content element on the clipboard (normal mode) the page module dynamically shows paste icons everywhere. This change centralizes the generation of the Paste icons into JavaScript, so the inline javascript usage of "top.*" functionality to park code somewhere has been removed, and the actual items are generated in JavaScript. In addition, as this code is only affecting the page module when a tt_content element is on the clipboard, the Paste.js JS module is only loaded when appropriate, thus reducing the actual loading time for "regular" visits on the Page Module. The icon in the paste button is now loaded via a native web component, and only necessary logic is used in the Paste JS module. The outer rendering for the Page Module has been simplified, moving this functionality all into PageLayoutController, reducing cross-dependencies between the PageLayout* classes. Resolves: #94840 Releases: master Change-Id: I380df9a56bfff74684616732166f25c68bbc6dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70488 Tested-by:
-
Guido Schmechel authored
Resolves: #94357 Releases: master, 10.4 Change-Id: I8c074372c3c42b8c5a74afff7b9fb386c2f136a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69953 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Roman Büchler authored
Resolves: #94851 Releases: master Change-Id: Ied2b2e1eb3ca05da12893a1ad23784e85bda74d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70506 Tested-by:
-
Georg Ringer authored
Skip a real check of the file system for SVG files in advance in the SvgFilesSanitization wizard to avoid timeouts in e.g. the reports module. Resolves: #94801 Releases: master, 11.3, 10.4, 9.5 Change-Id: I4ed52d357effec4a8e698d5b117f024150a01beb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70448 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Aug 12, 2021
-
-
Oliver Hader authored
Resolves: #94857 Releases: master, 11.3, 10.4, 9.5 Change-Id: I7654fb4cec38d38044441e885a21676dcacf9a8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70518 Tested-by:
-
Oliver Hader authored
A new `SanitizerInitiator` is added and forwarded to `typo3/html-sanitizer`. This allows getting a full stack-trace when HTML nodes have been sanitized/modified and to debug the actual cause (initiator) much better. To receive corresponding initiator stack-traces * logging for TYPO3.HtmlSanitizer namespace needs to be enabled * TypoScript `config.debug = 1` must be set, or as a fall-back `$GLOBALS['TYPO3_CONF_VARS']['FE']['debug'] = true;` must be set * HTML sanitizer must have found and modified invalid tags/attributes Resolves: #94837 Releases: master, 11.3, 10.4, 9.5 Change-Id: I0239785d347d2c4ad6153ccb26130556399949d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70490 Tested-by:
-
Björn Jacob authored
The Form Framework ships its own YAML loader and does not consistently use the YAML loader of the TYPO3 core. The patch documents the reasons and shows when which loader is used. Additionally, some inconsistencies are fixed with this patch. Resolves: #93579 Releases: master, 10.4 Change-Id: Ia1e091a4d54e714ca31ce44aed6c61cf994fe2d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70496 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Jochen Roth authored
Running PHP8 on "Indexing Statistics" page an undefined array key warning was thrown. This is fixed by adding a null coalescing operator. Resolves: #94845 Releases: master Change-Id: If0668f528b314dd158acf29b5b744e6e4d0dc24d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70495 Tested-by:
-
Oliver Bartsch authored
This introduces a new TCA option "showNewRecordLink" for TCA type "inline". It can be used to disable the "New record" link of inline elements, without any side effects for other links/buttons. As a consequence, the "levelLinksPosition" option does not longer support the value "none", as this behaviour (disabling all level links) should be achieved by setting the link specific options to FALSE. This means, the "levelLinksPosition" options should only be used to position the links, if shown at all. A TCA migration is in place. As another side effect, the previously - undocumented - misuse of ['enabledControls']['new'] is resolved. The mentioned option does now only affect the "+" button in each records' header. Resolves: #94765 Related: #94764 Related: #92397 Related: #82489 Releases: master Change-Id: I52bd633714d5527fec8afb37e250ef1782205ed9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70315 Tested-by:
-
Simon Gilli authored
The calls to the getUpdateSuggestions() method may result in the same change is added twice to the same hash. Using array_replace_recursive() ensures the same two suggestions are merged correctly and not as array of strings like done by the former implementation. This is important for sqlite which creates multiple statements for one 'job' sometimes. Resolves: #94709 Releases: master Change-Id: I1cec5977215559b17004d0f32b01fec039f09992 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70201 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Björn Jacob authored
In #90264 the datepicker JS was moved to an external file. A new YAML configuration has been introduced. Unfortunately, a nasty spelling error sliped in which has been fixed now. Resolves: #94846 Related: #90264 Releases: master Change-Id: I02fdd858b92afebb10295f241c9b8cdf5d10108b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70498 Tested-by:
-
Nikita Hovratov authored
During development the method name getParserByKey of the SoftReferenceParserFactoy class has been changed to getSoftReferenceParser. This renames the method in some missed places. Resolves: #94853 Releases: master Change-Id: I554e613509a32c0331de34b618ce30f29815f948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70504 Tested-by:
-
Alexander Nitsche authored
Sometimes acceptance tests fail due to a failed TYPO3 backend request, which is recorded in the TYPO3 log file. Save this log file along with the Acceptance Reports folder in the gitlab-ci job artifacts. Resolves: #94843 Releases: master, 10.4, 9.5 Change-Id: I0b260c197a6a71dc23e6f9da547fc20a55fc4ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70497 Tested-by:
-
Oliver Hader authored
https://github.com/TYPO3/html-sanitizer/releases/tag/v2.0.8 composer req typo3/html-sanitizer:^2.0.8 Resolves: #94849 Releases: master, 11.3, 10.4, 9.5 Change-Id: I367343abe5b18445ddc28023ef45c65bc6d0de23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70499 Tested-by:
-
Oliver Bartsch authored
Clipboard components still used and documented the deprecated shortMD5 method. This is now fixed. Resolves: #94844 Releases: master Change-Id: Idd30ee5af7496b8ded379b862e41c364b10e0d99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70494 Reviewed-by:
-
Roman Büchler authored
Resolves: #94838 Releases: master Change-Id: I6e5c5e5dfb58c42956629ddefa85cd5f21a55884 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70486 Tested-by:
-
Oliver Bartsch authored
In case no secondary options are available, the dropdown is not longer rendered in record- and filelist, since this led to display errors. Resolves: #94834 Releases: master Change-Id: I2aa6b60b09dbb3fa4cb3b2f79b3b44a19063c2cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70483 Tested-by:
-
Nikita Hovratov authored
The concept for registration and usage of soft reference parsers received a complete overhaul. Starting with the registration, it is now possible to register soft reference parsers by dependency injection in the extension's Services.(yaml|php) file. For this, the new tag name "softreference.parser" has been introduced. One has to provide the additional attribute "parserKey" to identify the parser. This replaces the old way of registering these parsers in the $GLOBALS array. If a parser is registered with the same key in both ways, the old way takes precedence for b/w compatibility. This comes with a completely new factory service class TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory. This classes' responsibilities are collecting all registered soft reference parsers and serving them to the consumer by calling the method "getSoftReferenceParser" with the desired parser key as the only argument. There is a compatibility layer for the old way of registration and for classes not implementing the new interface. Soft reference parsers now have to implement TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserInterface. The interface defines the implementation of the "parse" method. The first 4 and the last parameter stay the same as in the old method "findRef". The remaining two parameters "spKey" and "spParams" have to be set with the "setParserKey" method, if they are needed. The key can be retrieved by using the "getParserKey" method. The different parser implementations in the old class TYPO3\CMS\Core\Database\SoftReferenceIndex have been extracted and moved into dedicated classes in the TYPO3\CMS\Core\DataHandling\SoftReference namespace. Missing tests for parsers other than "typolink" and "typolink_tag" are added. The method makeTokenID of SoftReferenceIndex has been moved into TYPO3\CMS\Core\DataHandling\SoftReference\AbstractSoftReferenceParser. A parser can extend this abstract class, if this method is needed. The methods of BackendUtility "softRefParserObj" and "explodeSoftRefParserList" are now deprecated and the replacement TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory should be used instead. Resolves: #94687 Resolves: #94741 Releases: master Change-Id: I460bfdd4478194fa4b4111fc44871f7225c6c084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70177 Tested-by:
-
Björn Jacob authored
Some remarks regarding the overrideConfiguration parameter have been documented. Resolves: #89933 Releases: master, 10.4 Change-Id: Iabce22db2257fc85a415d1c7d74d2a9195586ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70479 Tested-by:
-
