Take the chance to also clean up the test class a bit.

Change-Id: Ib2835aa4dc4c170d327f56dfcde134cf5871867b
Resolves: #40956
Releases: 6.0
Reviewed-on: http://review.typo3.org/14618
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I09b90a58a74a219e6957488a7cca7a591c27ff70
Resolves: #40881
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14566
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I818d55a2f00b549fef8377f1c6766c293edd021c
Resolves: #40880
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14565
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: If6d3dfcb0fb095063750eaeb85bdb32aef0f417e
Resolves: #40282
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14144
Reviewed-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Instead of literal characters in single quoted strings it's better
to use doubled quoted strings for control characters to provide
better compatibility across platforms

Change-Id: Icb9722ad0e729c898d458c085f89d0fdf1f13896
Fixes: #40672
Releases: 6.0
Reviewed-on: http://review.typo3.org/14603
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: I69b9d1c81e1215980d4a40b0383de400b26886d7
Fixes: #40952
Release: 6.0
Reviewed-on: http://review.typo3.org/14615
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I8a30e8689c1c567770d0c03beaa12a0bf29e9b09
Resolves: #40878
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14563
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

In the Install Tool All Configuration part all field descriptions
are missing. This patch removes the additional newline characters
which caused the comments used to render the descriptions being
moved away from their fields.

Change-Id: I0c6db43b6940494405eb794a28a684d1894b046e
Fixes: #40939
Releases: 6.0
Reviewed-on: http://review.typo3.org/14607
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

* Skip the IPV6 Test that always fails on darwin/ OSX OS
* Remove the potentially skipped tests concerning t3lib_diff
  since this class is still in use

Change-Id: Iab26c428ff7cf8a8b447d536d820821ed000a8fd
Resolves: #40879
Releases: 6.0
Reviewed-on: http://review.typo3.org/14564
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: Ic4a640c880a59bf322101efb1ab7fb58bb8ace48
Fixes: #40876
Releases: 6.0
Reviewed-on: http://review.typo3.org/14560
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Cleans up ext:belog and activates the test suite:
* Fix some annotations
* Move a test that was put to a wrong location
* Minor CGL and readability changes
* Remove namespace compat layer of new 6.0 classes
* Change module registration and viewhelper to namespace

Change-Id: Ia31b5fcd52b76c40dbc6215c9820fa8c83a8ab86
Resolves: #40871
Related: 6.0
Reviewed-on: http://review.typo3.org/14557
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The namespace switch removed some linefeeds that 
were there to improve readability of the bootstrap.

Add these again and also remove the compatibility 
files as these files are new to 6.0 anyway.

Resolves: #40877
Releases: 6.0

Change-Id: I1ed4e7d8710f4feb97a0331b5526336075aa7932
Reviewed-on: http://review.typo3.org/14561
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Next try to add the scheduler tests to the test suites.

The patch applies several changes:

* For some weird reasons PHP does not recognize 'September' as valid
month keyword if the timezone is not Europe/Berlin. The test is removed
since only three letter abbreviations are allowed anyway.

* Make the cron command test system timezone agnostic.
CronCommandTest now explicitly sets the timezone to UTC (GMT) in setUp
and has a backup for tearDown. This is needed because the tests use hard
coded timestamps and the system under test is sensitive for timezones.
This was the main reason for the travis runs to fail in the first place.

* The dataProvider in CronCommandTest do not execute strtotime anymore.
The reason for that is, that the data provider data in phpunit is
executed before setUp and won't get the timezone setting then. The main
data provider is now splitted into two, separating the strtotime()
calculation off from the rest.

Change-Id: Ifb8de929b8e6edb31b24cbf02a9ddaa9dda9ab43
Resolves: #40515
Releases: 6.0
Reviewed-on: http://review.typo3.org/14549
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The wrong line icon is used in the wizard of
db_new.php

Change-Id: Ifba1d0270b547e11326ffb1c82a48e8c8838b401
Resolves: #40862
Releases: 6.0
Reviewed-on: http://review.typo3.org/14545
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The margin can be improved.

Change-Id: I5680551fdc7625037d222d627d49a51a49835f26
Resolves: #40858
Releases: 6.0
Reviewed-on: http://review.typo3.org/14536
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

An upgrade wizard is needed to add the default
repository of the EM. Otherwise the EM crashes

Change-Id: I3d254fae0bc1e937fd18b84b42df13d99a1b9ddc
Fixes: #40508
Releases: 6.0
Reviewed-on: http://review.typo3.org/14506
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The patch moves the last files in tests/ to a different location:
* FAL functional StorageTest is moved to ext:core as functional test
* A naming mistake of one of the other FAL tests is fixed
* class.removexssTest.php and class.t3lib_formmailTest.php are moved
to ext:core/Tests/Legacy

Change-Id: I7f627c29f3154d07d40a3e11db3730f763f7ff2f
Resolves: #40841
Releases: 6.0
Reviewed-on: http://review.typo3.org/14530
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This was decided at the latest release manager meeting:
To get rid of the top level tests/ directory, the UnitTests.xml
file is moved to the core extension to a new folder Build/. This
directory will later be used for other build specific things.

Change-Id: Id541f1e0bab3b1d2891f13697f48ea16e6c86d5e
Resolves: #40837
Releases: 6.0
Reviewed-on: http://review.typo3.org/14528
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

* Move BaseSetupTest to SystemEnvironmentBuilderTest and namespace it.
* Introduce an AccessibleProxy for the protected methods instead of eval.
* Merge config_defaultTest to SystemEnvironmentBuilderTest

Change-Id: Ie90857962087e235a7f4a8eb53df120624fd8780
Resolves: #40836
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14527
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I26b501e49d41656eb50996be4d56b4c18f1563ba
Fixes: #40364
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14178
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

There are still some fixture files within the root tests/ directory.
The patch moves them to Fixtures/ folders below the using tests
within the affected core and backend extensions.

Change-Id: Ied23b542a65becac02c9af576728da886552484d
Resolves: #40834
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14525
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of
strtime/gmstrftime.)

Change-Id: I7cc43a09f75d21ab8db84c0191fa0c1c5d67ddb0
Fixes: #38717
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12713
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

In the past it happened quite often that some test did not take care
of proper backing up globals or other environment settings. This
usually leads to failing tests if they are run afterwards. Those
side effects are often hard to track down and take quite some time
if searching for the one test that breaks the environment.

Therefor, a new "Integrity" test is added to the system that is
executed as the very last test in the list of test suites. It checks
that important things that were messed up in the past are still working.

Currently it checks that the registered singleton instances are still
there, that $GLOBALS['TYPO3_DB'] still has a valid resource link to
the database, and $GLOBALS['typo3CacheManager'] is still a valid
class instance.

If one of this test fails after any merge (especially combined with
travis), it is now obvious that this merge broke the environment, so
the evil test can be found much quicker and the evil merge can be
reverted directly.

Change-Id: I0dc733081ea9ad0c050a7dbcf4d95dd8f819f1bf
Resolves: #40832
Releases: 6.0
Reviewed-on: http://review.typo3.org/14524
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The FrontendEditingController calls TSFE->includeTCA right
before the index_ts.php calls TSFE->getCompressedTCA().

Because of the missing parameter within the
FrontendEditingController, getCompressedTCA wil not be
executed anymore. As an result the TSFE->TCAcachedExtras
are not available when FE-editing is active.

This prevents the a working language overlay, which only
looks to that array, which fields are configured to be
overlayed.

Change-Id: Ib130b11dd76c0b533b9a699a113f03e750ba2516
Fixes: #40733
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/14432
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

This patch replaces the language selection field in language module.

Change-Id: I52fd08df4bfd4687c65588cd3e479d08b48d68df
Resolves: #40430
Related: #39963
Releases: 6.0
Reviewed-on: http://review.typo3.org/14293
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch replaces the icon in extensionmanager and admin tools menu
(module icon) with a more attractive one.
The new icon is from the http://www.famfamfam.com/lab/icons/silk/ silk
icon set, so it is free, credits to famfamfam are already give in
TYPO3 core, and it fits to the rest of the core icons.

Change-Id: Ic379c457b91eb5ba87d56d646a3b76a0909cb021
Resolves: #40546
Related: #39963
Releases: 6.0
Reviewed-on: http://review.typo3.org/14300
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Labels improve the usuability, so add them

Change-Id: I7d06f26959eb46cab449a2870942df02917023b0
Resolves: #39874
Releases: 6.0
Reviewed-on: http://review.typo3.org/13831
Reviewed-by: Stefan Neufeind
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

One place has been missing while changing all the
class names

Change-Id: I73d5e3f006377ea46079ac9f17f30c817ada7d4a
Resolves: #40795
ReleaseS: 6.0
Reviewed-on: http://review.typo3.org/14508
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

After fixing lots of side effects and invalid environment changes
of existing unit tests and updating the introduction package database
and the travis test environment, it finally seems to be possible to
activate the extensionmanager tests for every travis build.
Let's see if this works out now ...

Change-Id: Ic8beb96121df3e8ef8b76b0ff4c2ef7d0daa8dab
Resolves: #40810
Releases: 6.0
Reviewed-on: http://review.typo3.org/14507
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ic37ed816e8ccce1c976c1e66155ebe77788738bc
Reviewed-on: http://review.typo3.org/14499
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

TYPO3\CMS\Core\Utility\GeneralUtility::setSingletonInstance() is a method
for unit tests to inject singleton mocks for classes that are
instantiated with makeInstance. purgeInstances() can be used to reset all
registered singletons, so makeInstance() creates new objects after that.
purgeInstances() can change the behaviour of tests that are executed
afterwards, because *all* registered singletons are reset. Currently the
helper methods for singletons around makeInstance() are not able to get
the list of registered singletons, and reset them to the previous list.

The patch introduces method getSingletonInstances() that returns a list
of all registered singletons (used in setUp()), and method
resetSingletonInstances() that resets registered singletons to a given
stored list (used in tearDown()). This way it is possible to fiddle in
tests with purgeInstances() without introducing side effects to other
tests.

All unit tests that used purgeInstances() are adapted to take care
of re constitution of changed objects this way.

Change-Id: I19dc869423a537226bb019e227d84b6f74fe9afc
Resolves: #40780
Releases: 6.0
Reviewed-on: http://review.typo3.org/14487
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The PHP parser caches NULL instead of an array when the Backend
language is not available for a given extension using PHP array
localization files (e.g., tscobj with German "de").

This leads to PHP warning when reading the labels as NULL cannot
be used in a foreach statement.

Change-Id: I1678674ecfba71e04c9c13aed44dd7f0aa574cbc
Fixes: #40643
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/14360
Reviewed-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: I61bfb67d9e633ddb25eebf2c82092c67c9ea8970
Releases: 6.0
Reviewed-on: http://review.typo3.org/14480
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch moves most unit tests of the tests/Unit/t3lib/*
directory to the core extension, following the new name scheme.

Change-Id: Ia03bc00ccb256c68684f7243fea77804081cb287
Resolves: #40770
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14475
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch moves most unit tests of the tests/Unit/t3lib/*
directory to the core extension, following the new name scheme.

Change-Id: Ia08a3c0251c577676e3920dc880bb54e1651e5c2
Resolves: #40620
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14339
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The patch fixes some rather obvious problems in EXT:extensionmanager
to stabilize the tests. Furthermore the extension dependency
calculation did not work due to missing TCA definition.

Change-Id: I8364f603c5d3c104554838e303f156114f047c16
Resolves: #40771
Releases: 6.0
Reviewed-on: http://review.typo3.org/14476
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

StringUtility::isLastPartOfString does not sanitize the input arguments
enough and throws warnings if calling strlen() for example with arrays.
The patch changes the (new 6.0) method to sanitize the arguments and now
throws Exceptions if they can not be interpreted as string.
The tests are adapted to test for the exception and adds a test with
an object to the data provider.

Change-Id: I497a1478a7804c4bbeddc2d1e340e29d73efa200
Resolves: #40767
Releases: 6.0
Reviewed-on: http://review.typo3.org/14467
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

checkFolderPermissionsRespectsFilesystemPermissions throws a warning
that the third argument from the data provider is missing with its first
data set. The third argument is not always needed and set to a sane
default now.

Change-Id: I25d6c21addcefc5bec6d8f3a8adc48bfc0f38481
Resolves: #40766
Releases: 6.0
Reviewed-on: http://review.typo3.org/14465
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

finfo() in FAL LocalDriver can not deal with vfs streams and throws
warnings. It is used to fetch the mime type of files.
The patch moves the finfo call to an own method and mocks the methods
in all tests that triggered the warnings.
Additionally, the statReturnsCorrectFileInfo() test is splitted into
four tests and renamed to getLowLevelFileInfoReturnsCorrectFile*. An
additional test is added to test for correct retrieval of mime type
with a prepared dummy file.

Change-Id: Ib3dcd0998dee3d2fa7e0e60eabcf783b712c5fdd
Resolves: #40765
Releases: 6.0
Reviewed-on: http://review.typo3.org/14460
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The cshmanual extension must be loaded by default to make the CSH
popups work.

Change-Id: Iad8d12bc2caac8b24cf14ac14a6c3b6afdab5924
Fixes: #40665
Releases: 6.0
Reviewed-on: http://review.typo3.org/14457
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert