- Nov 10, 2021
-
-
Nikita Hovratov authored
TCA shares same keys across different types, and so does "items" with type check, radio and select. The value is usually set for the array key "1". But type check is special in that regard: the value is stored as a bitset. This means, the value is completely unused and shall not be provided for checkboxes. 1. All occurrences of "items => ['1' => '']" removed. 2. When checkboxes only have 1 item and no configuration whatsoever, "items" can be omitted. These constructs are gone now: 'items' => [ [ 0 => '', 1 => '', ], ] Resolves: #95876 Releases: master Change-Id: I3deb96498e3afb8823cd6397e57e268c68774276 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056 Tested-by:core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Stefan Bürk authored
InputTextElement::render() calls htmlspecialchars() to output the itemValue. $itemValue can be null null instead of a string at this place and feeding null to htmlspecialchars() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95929 Releases: master Change-Id: I96eeb6fb0b19e5f751b68e835a59726c7a4657b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72106 Tested-by:
-
Stefan Bürk authored
DatabaseRecordList::renderListRow() calls linkUrlMail() with eventually null as second argument, thus invoking parse_url(null) which emits a E_DEPRECATED PHP 8.1 error. The patch sanitizes call in renderListRow(), adds type casts in linkUrlMail() and a @todo to change signature in v12. Resolves: #95937 Releases: master Change-Id: I78c0498cf5e2aa8de70576300a616ef1328d6f66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72134 Tested-by:
-
Oliver Hader authored
To decrease the amount of inline JavaScript that has been generated by some PHP process assignments and invocations are declared in a more strict way. This would allow to make use of strict content security policy denying invocation of unsafe-inline scripts. Resolves: #91786 Releases: master Change-Id: I89384d661ebd35a5fda10f9587a7f41db4f587aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64123 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Stefan Bürk authored
TemplateService::render() calls substr_count() on a array field retrieved from the database, which may be null instead of a string. Feeding null to substr_count() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95932 Releases: master Change-Id: I1429d0f49356922208acf9ccb2ab8b8bbd53043c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72109 Tested-by:
-
Stefan Bürk authored
TextElement::render() calls strlen() to determine length of form elemet item value. It may be that item value is null instead of a string at this place and feed null to strlen() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95930 Releases: master Change-Id: Ib7f073d59e4bbc39fb070d86bbfe3a5b69d3bef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72107 Tested-by:
-
Stefan Bürk authored
TextElement::render() calls htmlspecialchars() to output the item value. It may be that $itemValue is null instead of a string at this place and feed null to htmlspecialchars() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95931 Releases: master Change-Id: I0b2066e7161b2e12e3a4b39d3f9669938a04c9bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72108 Tested-by:
-
- Nov 09, 2021
-
-
Nikita Hovratov authored
Add core and workspace functional test for TCA option 'localizeReferencesAtParentLocalization' with type=group to nail current state. Resolves: #94570 Related: #41713 Releases: master Change-Id: If349614306118405a2721d11d074eb2c1d0ee13e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69904 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Florian Rival authored
When using a text content element with a table inside bodytext, you will have a PHP warning: Undefined array key "1." in typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php This was only a notice with PHP v7 but it's an error with PHP v8. This bugfix corrects the usage of undefined array keys. Resolves: #95858 Releases: master Change-Id: Ie70fb6bdd66eee895e0c290a9bcc662c9f734d2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72058 Tested-by:
-
Chris Müller authored
Resolves: #95924 Releases: master Change-Id: Id341014507623e1f1aa07721d81d0667b7cdef04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72101 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Marcel Schüßler authored
Cast 'tokenValue' to string as it can happen to be an integer. Releases: master Resolves: #95887 Change-Id: I2c053926a7ed24f6cc3634a8c139213de9b65f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72069 Tested-by:
-
Alexander Schnitzler authored
To ease the work with phpstan and IDE's, some types in persistence related classes of extbase are now either fixed or more specified. Releases: master, 10.4 Resolves: #95885 Change-Id: I2a784bd3ffaae651dd67dd939ef13e5efcb2ead6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72066 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
It's possible to query for deleted records in DB Check "Full search". Such records can then be restored only or additionally restored and directly edited. The icon for the latter action was broken, since a non existing icon identifier was used. This is now fixed, using the correct icon identifier. Resolves: #95923 Releases: master, 10.4 Change-Id: I7da25198efe731a9ccba9e673c8c55e42760b233 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72098 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
In case only one localization mode is available, e.g. because a localization mode was already defined for the translated page or only one mode is allowed by configuration, the selection step is superfluous and therefore now skipped. Resolves: #95909 Releases: master Change-Id: I4a842b0758c9c95744f31f8074a09a1c29f53af2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72079 Tested-by:
-
Alexander Schnitzler authored
The method signature of Query::locicalAnd() is very misleading because it only states there is one method argument $constraint1. Actually, the method does accept any number of arguments, evaluated via func_get_args(). It also accepts any number of arguments if $constraint1 is an array of constraints. This leads to multiple issues when working with phpstan and also when simply using an IDE which does not understand the internal magic. The goal is to state, that logicalAnd() needs at least two constraints but also accepts any number of further constraints. Since that requires a breaking change, the method signature can only be fixed partly for now. $constraint1 remains as is, a 2nd argument $constraint2 is introduced, null by default to make it optional and a variadic argument ...$furtherConstraints is also introduced. This approach keeps the bc promise but also lays the foundation for further changes in the next version. Releases: master, 10.4 Resolves: #95889 Change-Id: Ife1be32d99371b82a84b6f6d800a58d242c8ff0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72063 Tested-by:
-
Oliver Bartsch authored
In prior versions, creating a new page via the context menu inserted the new page "inside". This however changed to "after" in v8, leading to misbehavior, especially for non-admins, as they are usually not allowed to create pages on pid=0. This is now fixed by restoring the previous behavior of inserting pages "inside" instead of "after". Resolves: #81405 Releases: master, 10.4 Change-Id: I6a941c3e015189a471d0c136c81f1e5698426dbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72093 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Nikita Hovratov authored
The identifier from the linkHandler page TSconfig was formerly used as the reference table name "ref_table". This identifier is free to choose and shouldn't be interpreted as a name of a table. In order to resolve the correct table name, which is stated in the configuration, the page id of the reference record is now used. This allows the TypolinkSoftReferenceParser to read the according page TSconfig and to set the correct table name. Resolves: #95380 Releases: master Change-Id: I28817a7267a107df27828d99f7e0cf2eeaaf2de1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71340 Tested-by:
-
Nikita Hovratov authored
Resolves: #95917 Releases: master Change-Id: I0a02c5f9ac49b4523fe754d5a0a1e86b6a57eb34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72092 Tested-by:
-
Stefan Bürk authored
GeneralUtility::fixed_lgd_cs() may be called with null instead of a string as first argument, which is passed to mb_strlen(). Feeding null to mb_strlen() emits a E_DEPRECATED PHP 8.1 error. This patch sanitizes the call in BackendUtillity and further ensures that the first parameter $string is a string (until strict type hints can be added). Resolves: #95913 Releases: master Change-Id: Ie3bb44d4d47d4673d2274f10dca80f860d494c32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72085 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
-
Oliver Bartsch authored
The pagination feature in DB Check "Full search" did not work, since the defined offset was not added to the query. This is now fixed by checking for a comma separated string, which would therefore contain both an offset and the limit. In case both values are given, they are now properly added to the query. Resolves: #95922 Releases: master, 10.4 Change-Id: Id461b98a9818c3b55b34f93041a9c0950e68f634 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72095 Tested-by:
-
Stefan Bürk authored
DatabaseRecordList::renderListRow() used the return value of called BackendUtility::getProcessedValueExtra() to feed it into php internal htmlspecialchars. As result can be null instead of a string this emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95916 Releases: master Change-Id: If9fde8e6ab96ab8083d60e1a67fc37160859a7e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72087 Reviewed-by:
-
Christian Kuhn authored
Latest 3.141 again leads to trouble with timeout exceptions. 4.0 seems to behave better ... let's raise again to see if that improves the situation. Change-Id: If04b85cf544c1f95d0d65bc95657d5dbf852dacc Resolves: #95920 Related: #95883 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72094 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
Add PHP 8.1 attribute #[\ReturnTypeWillChange] with todo to set correct return type as breaking change in v12 to satisfy PHP 8.1 strict return on SPL classes. Resolves: #95912 Releases: master Change-Id: Id92292d7dacec8c99022a719fe4e407e848f2f81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72084 Tested-by:
-
Oliver Bartsch authored
Since #91085, sending a remote request in workspaces, e.g. sending records to another stage, is visualized by a progress bar. The configured selector for the progress bar however differs between the review module and the preview module and therefore led to a TypeError. This is now fixed by using the correct selector depending on the current module. Resolves: #95661 Related: #91085 Releases: master Change-Id: Ibeb84879e459ac8e94a0e248d77b2d974b94710c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72080 Tested-by:
-
Simon Gilli authored
When installing TYPO3 and Extensions into the vendor folder, no language files can be loaded anymore because of an implementation depending on hard coded Extension directories. A new method is implemented in the PackageManager to extract a package key from a path which solves the issue and makes the old implementation superfluous. The code is left there however to not interfere with custom implementations (despite these classes are marked internal). LLL references not using an EXT: path, but a file system path will "work" exactly like before. This should rather be deprecated later on. In fact the whole language file parsing deserves a complete overhaul, which should be tackled in subsequent changes for a new major TYPO3 version. Resolves: #95839 Releases: master Change-Id: I5ca698d445ae6c5125ee42787fd7274dc8d27a38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71938 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Stefan Bürk authored
Set void return type for @internal class ExtensionXmlParser to satisfy PHP 8.1 strict return on SPL classes. Resolves: #95911 Releases: master Change-Id: If112aed90f6e9d6b411d1d66086dab142b68748a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72083 Tested-by:
-
Stefan Bürk authored
Nl2brViewHelper::renderStatic() calls nl2br with the return of the called $renderChildrenClosure which may return null. Feeding null to nl2br() emits a E_DEPRECATED PHP 8.1 error. Sanatize the call. Resolves: #95915 Releases: master Change-Id: I2313811b42836ec21ba7efcee4c0a6ed9148fcab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72086 Tested-by:
-
- Nov 08, 2021
-
-
Chris Müller authored
In most module configurations icons with a distinct path are used. This is not necessary, as the module icons are already available from the TYPO3.Icons package and therefore the icon identifier can be used. For EXT:core this was already done. The previously referenced icons are not used anymore and will be removed by a separated patch for v12 once v11 is branched. Resolves: #95888 Releases: master Change-Id: Ic113fc9f40ce80059b65e1290afe70673ba06a33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72070 Tested-by:
-
Robert Vock authored
The TCA types "group" and "select" are both using the relation handler to resolve items from foreign tables. Previously, delete placeholders were still fetched in a workspace. This is now fixed by properly handling the delete placeholders before fetching the items. Resolves: #88144 Releases: master, 10.4 Change-Id: Ieca2acb16af10982d16af981d0e302b2ea29ae1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60468 Tested-by:
-
Torben Hansen authored
This patch removes inline JavaScript usage for the refresh button in ViewModuleController. Resolves: #95896 Releases: master Change-Id: I4a562dac5793a54254cf17636af2246339c59f75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72073 Tested-by:
-
Sybille Peters authored
PHPDoc block for method PageSlugCandidateProvider::getCandidatesForPath() had incorrect return type of string[]. This is changed to array<int,array<string,mixed>>. Resolves: #95901 Releases: master, 10.4 Change-Id: I9a7cd326acf3dd88bfb2833b50b135a9d84164eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72076 Tested-by:
-
Jochen Roth authored
Resolves: #95883 Releases: master Change-Id: I54cf7f2e0c8e968d8f29151b1621b54357681ab2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72062 Tested-by:
-
Georg Ringer authored
The forced scheme needs to be checked if not empty and not only if existing. The regression has been introduced with #90228. Related: #90228 Resolves: #95796 Releases: master, 10.4 Change-Id: Ia941142aacc688ddd02d3f7f45d3ce493821ce68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71997 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Aimeos <aimeos@aimeos.org> Reviewed-by:
-
Jochen Roth authored
Currently the acceptance test for the recycler module uses "see" to check if a text appears in the flashmessage which can cause timing issues. This has been fixed by using waitForText to actually wait until the message appears. Resolves: #95902 Related: #94551 Releases: master Change-Id: Ie63d2944c07ac1e3103fa02b2ef2c2cd275b6448 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72077 Tested-by:
-
Torben Hansen authored
Use ignoreVCSIgnored for the Symfony finder initialization in php-cs-fixer.php to automatically ignore all files from .gitignore. Resolves: #95894 Releases: master Change-Id: If8e3d61af016ed56e8aea4c5b2b8290cca8b6329 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72072 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Nov 05, 2021
-
-
Tom Warwick authored
This commit improves the overall readability of the ext:redirects documentation. Releases: master, 10.4 Resolves: #95884 Change-Id: Ia15d2f909dcdbb301152142c8fd32989a12687fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72064 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Francois Suter authored
Class \TYPO3\CMS\Core\Html\HtmlParser generates a lot of undefined key warnings when running with PHP 8. It needs to be cleaned up. Resolves: #95738 Releases: master Change-Id: Ic9cda1e3c3f3990ae07ca2bf91f210c2f2a9d7d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71941 Tested-by:
-
Helmut Hummel authored
Code for scanning extension folders and populating information from that, is removed to use already available API in extension manager. Therefore the ComposerDeficitDetector, which has only usages in EM anyway, is moved into the namespace of EM. With doing so some folders in typo3conf/ext might be missed, that do not contain valid extensions, but for these, providing composer.json suggetions might not be useful anyway. Releases: master Resolves: #95063 Related: #93931 Change-Id: I7652036a7c0a4ac9e9884393383945f58788d88e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70850 Tested-by:
-
Helmut Hummel authored
ScriptViewHelper and AssetViewHelper do not directly output any tag, but only pass the arguments to AssetCollector. Therefore the tag attribute values must not be HTML encoded. To achieve that, we use a subclass of TagBuilder before the tag is initialised, which does never encode attribute values. The tag view helper inheritance is kept because the tag builder nicely abstracts attribute handling, which otherwise would have to be duplicated. Also ensure that rendered children will not be encoded as this string is used as CSS or JavaScript, where HTML encoding won't help or rather break the code. Resolves: #92706 Related: #92284 Releases: master, 10.4 Change-Id: I823ad167ccbd52e9e0f3ad9bb3d54f554a985fef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66284 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
André Buchmann authored
Width and height of an image is stored in translatable metadata records. These properties are extracted by FAL API when a new image is uploaded. The TYPO3\CMS\Core\Resource\Index\Indexer::updateIndexEntry method uses the MetaDataAspect to save the new file dimensions. As the MetaDataAspect has no support for multi-language, it only updates the default language. A new PSR-14 event listener is added on AfterFileMetaDataUpdatedEvent to overcome the lack of translation support. It updates the width and height of all corresponding sys_file_metadata translations. Wrong dimensions leads to rendering issues in the frontend when the image is cropped as the crop area can't be calculated properly. Resolves: #87162 Releases: master, 10.4 Change-Id: Ic1d66a24f23f4312325b3f74e5959b2d2b3c1cf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72044 Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
-
