Change-Id: Ib07ed4f272fde10e7f275411699c6c4f2106a9d2
Resolves: #37979
Releases: 6.0
Reviewed-on: http://review.typo3.org/12009
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

During cleanup of the page module's CE rendering
a bit too much cleanup happened and the name
of the plugin is not shown anymore. Furthermore "No
plugin is selected" is now shown if nothing yet selected

Change-Id: I3b2210eca870f3c4f2ed059cf6f80f63dc6416d2
Resolves: #37944
Relases: 6.0
Reviewed-on: http://review.typo3.org/11975
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I2b7154823d5878bfd8893cf3c1279ac048df9e8c
Resolves: #37973
Releases: 6.0
Reviewed-on: http://review.typo3.org/12002
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I26bb40d7d55c03c0cbca16987c4c09995b29e67d
Resolves: #37983
Releases: 6.0
Reviewed-on: http://review.typo3.org/12013
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The field "Selected Pages" is never used in the content element
"Menu/Sitemap" with menu type "Sitemap". So it should not be
shown in the backend.

Change-Id: I9464ff29fc9fd9864a404cfb14f0545b3e186366
Fixes: #35944
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10425
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Clean up phpDoc comments for the following classes:

* typo3/class.file_list.inc
* typo3/class.filelistfoldertree.php
* typo3/class.show_rechis.inc

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Id71deb990e0e41babb955bf48ea5f12d54436a45
Resolves: #37937
Releases: 6.0
Reviewed-on: http://review.typo3.org/11971
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I458577566cf13bd9a6e026ccfdaba7610e309586
Resolves: #37930
Releases: 6.0
Reviewed-on: http://review.typo3.org/11968
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I1f6130e6af5480533a5f40e62a45ffc9530c8a95
Resolves: #37927
Releases: 6.0
Reviewed-on: http://review.typo3.org/11967
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* typo3/class.db_list.inc
* typo3/class.db_list_extra.inc

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I13914081107bf321dd7bb35b7943e7dd3c0fd5e1
Resolves: #37924
Releases: 6.0
Reviewed-on: http://review.typo3.org/11966
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I14825a8139ce5bf78ffcc96eea4204f507da5fb7
Resolves: #37923
Releases: 6.0
Reviewed-on: http://review.typo3.org/11965
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix CGL violations against FunctionCallArgumentSpacingNoSpaceAfterComma
in /typo3/sysext/setup.

Change-Id: I34e805a53d1e36394bc99526f1ea2567c2cf2bfa
Resolves: #37917
Releases: 6.0
Reviewed-on: http://review.typo3.org/11948
Reviewed-by: Roland Waldner
Reviewed-by: Obadja Hauser
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

From PHP 5.4, E_STRICT became part of E_ALL. This leads to lots of runtime
notice exceptions when using PHP 5.4. To avoid that, E_STRICT needs to be
excluded from error reporting.

Change-Id: I457585b03e2c7d6722c61636a04af47b4b5191f5
Fixes: #35154
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10524
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* typo3/backend.php
* typo3/browse_links.php
* typo3/browser.php
* typo3/class.browse_links.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I0756bd4b85edb575a06db00490ad0b5597c5b6c0
Resolves: #37918
Releases: 6.0
Reviewed-on: http://review.typo3.org/11945
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* typo3/alt_doc.php
* typo3/alt_doc_nodoc.php
* typo3/alt_file_navframe.php
* typo3/alt_shortcut.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ib6092201be4d5e18522e25393b02c2dfd8701f71
Resolves: #37913
Releases: 6.0
Reviewed-on: http://review.typo3.org/11938
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ie934ab73b9c24f2f383d15a2f5f91347382ea48b
Resolves: #37789
Releases: 6.0
Reviewed-on: http://review.typo3.org/11849
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I3f2af480d2ebbaeb1eea1b589a060b595c35f76a
Resolves: #37790
Releases: 6.0
Reviewed-on: http://review.typo3.org/11850
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

A few other CGL violations will also be reduced.

Change-Id: Ib7e4ee0d53718a734ba8537f85ff3f234caa78c7
Resolves: #37870
Releases: 6.0
Reviewed-on: http://review.typo3.org/11898
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* typo3/ajax.php
* typo3/alt_clickmenu.php
* typo3/alt_db_navframe.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I95b0dffa62a4a057a6a3c4e913e02498b21187cc
Resolves: #37909
Releases: 6.0
Reviewed-on: http://review.typo3.org/11933
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Clean up phpDoc comments for the following classes:

* typo3/classes/class.ajaxlogin.php
* typo3/classes/class.clearcachemenu.php
* typo3/classes/class.livesearch.php
* typo3/classes/class.modulemenu.php
* typo3/classes/class.shortcutmenu.php
* typo3/classes/class.typo3_tcefile.php
* typo3/classes/class.typo3ajax.php
* typo3/classes/class.typo3logo.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I6246d7dd21a10cfeb4b0fa63b89241a8e0b0b630
Resolves: #37869
Releases: 6.0
Reviewed-on: http://review.typo3.org/11897
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

There are CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/saltedpasswords/.

These will be reduced.

Change-Id: I7d05359029f9e5a93515c428e5f915292f37f7a7
Resolves: #37880
Releases: 6.0
Reviewed-on: http://review.typo3.org/11924
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

A few other CGL violations will also be reduced.

Change-Id: I8d410de51886dd7314d6ebb83644b5ef969f26ce
Resolves: #37871
Releases: 6.0
Reviewed-on: http://review.typo3.org/11914
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adds favicon to the backend view.
Also brings few CGL improvements.

Fixes: #37868
Releases: 6.0
Change-Id: I7b0e71e6b15f8105973ca738a29d95407827b895
Reviewed-on: http://review.typo3.org/11896
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I77826ac68c8d96191c708ff39e122981882addb6
Resolves: #37875
Releases: 6.0€
Reviewed-on: http://review.typo3.org/11918
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Clean up phpDoc comments for the following classes:

* typo3/interfaces/interface.backend_cacheActionsHook.php
* typo3/interfaces/interface.backend_toolbaritem.php
* typo3/interfaces/interface.cms_newcontentelementwizarditemshook.php
* typo3/interfaces/interface.filelist_editiconshook.php
* typo3/interfaces/interface.localrecordlist_actionsHook.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I5533bc4ff2c6b6e840360ab543da444518ad1802
Resolves: #37874
Releases: 6.0
Reviewed-on: http://review.typo3.org/11915
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Adds tests for _GP, _GPmerged, _GET, _POST and _GETset.

Change-Id: I27b8db55d76b560854700baf518c686254c951ae
Resolves: #37355
Releases: 6.0
Reviewed-on: http://review.typo3.org/11362
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There are violations against the CGL rule "DoubleQuoteUsageNotRequired" in
/typo3/ (not: /typo3/sysest/).

These will be reduced.

Change-Id: I5448388752de47d381c9a6be6b7df6bef4ebf0ba
Resolves: #37690
Releases: 6.0
Reviewed-on: http://review.typo3.org/11797
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There are some violations against the CGL rule
"DoubleQuoteUsage" in /t3lib/. These will be
reduced by this commit.

Change-Id: I8c133a0ab6cd0638ef79148cabad378b04c985fe
Resolves: #37495
Releases: 6.0
Reviewed-on: http://review.typo3.org/11633
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Roland Waldner
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There are CGL violations against
FunctionCallArgumentSpacingNoSpaceAfterComma in
typo3/sysext/cms/tslib/media/scripts/fe_adminLib.inc.

These will be reduced.

Change-Id: I977b2b328875d0317a351558de33d5c6568f60e3
Resolves: #37774
Releases: 6.0
Reviewed-on: http://review.typo3.org/11841
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Increase the readability of CLI messages when calling them on the
command line.
This improvement displays more human readable messages to a CLI
user when calling the cli_dispatcher with wrong or no arguments
leaving out technical details like "array" and the array keys.

The keys are also sorted alphabetically.

Change-Id: I62f41f333cf52e46836aeef105021eb571c09110
Fixes: #37713
Releases: 6.0
Reviewed-on: http://review.typo3.org/11809
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adds spaces to function definition where needed.

Change-Id: I3265a0fa9a82da91babfd8b87f0019e785f1574b
Fixes: #37709
Releases: 6.0
Reviewed-on: http://review.typo3.org/11807
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Roland Waldner
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There are CGL violations against
FunctionCallArgumentSpacingNoSpaceAfterComma in
typo3/sysext/cms/tslib/media/scripts/plaintextLib.inc

These will be reduced.

Change-Id: I2fc1b4e9b1ea436bb61f97567bd1bcb10eeb786f
Resolves: #37775
Releases: 6.0
Reviewed-on: http://review.typo3.org/11842
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Improves last outstanding function spacing issues of type
OpeningFunctionBraceKernighanRitchieSpaceBeforeBrace.

Change-Id: I393ca85d63779b5368ea6d8aaa8dbcf629ca0df6
Fixes: #37827
Reviewed-on: http://review.typo3.org/11877
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I1d7621f445690a4b1056ed6c227035514129415a
Resolves: #37540
Releases: 6.0
Reviewed-on: http://review.typo3.org/11882
Reviewed-by: Oliver Klee
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Change-Id: I1a0f8bcd436eefa59abdaa1e40a0cd9711a01b38
Resolves: #37776
Releases: 6.0
Reviewed-on: http://review.typo3.org/11843
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Replace local static member references with self::

Change-Id: I70624b19d67d96dedd05780c2162c4b68d7abc27
Resolves: #37721
Releases: 6.0
Reviewed-on: http://review.typo3.org/11816
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Currently suggest wizards don't work in IRRE records. This is because of
the missing javascript functions. IRRE elements are post loaded and
wirzards are not known on loading the parent form.

Change-Id: Id1c23d7e53c4e8499f13bb1776bf76c960995b04
Fixes: #27020
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10831
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

There are violations against the CGL rule
"FunctionCallArgumentSpacingTooMuchSpaceAfterComma".

These will be reduced.

Change-Id: I24cb9b59424ccd51538fb82fa55c1a54835650a6
Resolves: #37707
Releases: 6.0
Reviewed-on: http://review.typo3.org/11805
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

There is one violation against the CGL rule
"InlineCommentWrongStyle" left.

This will be fixed.

Change-Id: I7b2b659ad45db4dfdf802d415b3d9d10874d85fb
Resolves: #37708
Releases: 6.0
Reviewed-on: http://review.typo3.org/11806
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

There are violations against the CGL rule "InlineCommentWrongStyle".

These will be fixed.

Change-Id: I346022ff6aecf15a8a55b7dda09711a116f4e2b1
Resolves: #37687
Releases: 6.0
Reviewed-on: http://review.typo3.org/11796
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

There are violations against the CGL rule
"OpeningFunctionBraceKernighanRitchieSpaceBeforeBrace".

These will be reduced.

Change-Id: I69a0f6025e011dd54a106d71523a7a3547ea8b52
Resolves: #37693
Releases: 6.0
Reviewed-on: http://review.typo3.org/11798
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer