Change-Id: I5d631cf408758e89c69b129bb414d1ee14289bdd
Resolves: #51158
Releases: 6.2
Reviewed-on: https://review.typo3.org/23182
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

According to the HTML5 specs the header element should be used for
grouping elements. Currently the header element is used if there is any
content in lib.stdheader, for instance a single hx.

This patch fixes this by wrapping lib.stdheader with the header element
only when the date is added to the header. Otherwise it will use the
default div wrapping.

Change-Id: I3e1335e1b1d64962a8488b8177d72eb1126e89dd
Fixes: #47575
Releases: 6.2
Reviewed-on: https://review.typo3.org/20149
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Some tests in GeneralUtilityTest rely on a working internet
connection and fail if offline. Skip those tests if no needed.

Change-Id: Ia5e828cee6a834b971ad8d9c7da0598867a275f8
Resolves: #51496
Releases: 6.2
Reviewed-on: https://review.typo3.org/23445
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The problem came from a row of icons which was always rendered below
the select list with a hardcoded width of "250px", regardless if there
was content or not. Solution is not to render this icon row if there are
no icons, thus allowing the select list to be reduced in width.

Releases: 6.2, 6.1, 6.0
Resolves: #50707
Change-Id: I23520c1c547de1155091e38c69013a18fed9e559
Reviewed-on: https://review.typo3.org/23391
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If a file or directory below uploads/ is not readable by the
executing user, the integrity check system in db check module
menu may fatal. This is sanatized by the patch.

Resolves: #51460
Releases: 6.2, 6.1, 6.0
Change-Id: Ide3401c014aa7bec33585083f81f30c00100da09
Reviewed-on: https://review.typo3.org/23424
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When the feature introducing categories-based page menu was
introduced, a utility class was eventually forgotten. This
patch restores it.

Resolves #51524
Releases: 6.2

Change-Id: I447b22a80252eb8c7ede80daa11cfc7db5144479
Reviewed-on: https://review.typo3.org/23466
Reviewed-by: Francois Suter
Tested-by: Francois Suter

In ContentObjectRenderer->getQuery() the pid where clause is build
using getTreeList() to fetch recursive pids. But for the inclusion
of the uppermost pid, string concatenation is used.
The method getTreeList() offers the option to include the uppermost
pid into the returned result by passing it as a negative value. Method
getQuery() should use this opportunity instead of doing its own magic.

Additionally some cleanup is done for getTreeList, optimizing the
returned string, and unittests were added.

Resolves: #51067
Resolves: #51503
Releases: 6.2
Change-Id: Ie72103ca66d847cb0eb0f3ef5e33a1896d86de5b
Reviewed-on: https://review.typo3.org/23092
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #51480
Releases: 6.2
Change-Id: Ieaff9ddaf43e339979ecb5fff48678d28b9b0e61
Reviewed-on: https://review.typo3.org/23438
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

In table sys_category the TCA for field "t3ver_label" appears twice,
the first time with the expected definition, the second time with a
slightly different one, never seen in the Core. Since the second
definition overrides the first, it should be removed.

Resolves: #51513
Releases: 6.2
Change-Id: I4d7d642dadb884199b6f2a0aa3bcc1c93993c309
Reviewed-on: https://review.typo3.org/23452
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If you create an empty ext_autoload.php or an empty classAliasMap.php
file or fail to return an array, NULL is merged with the existing
array which results in NULL for the array $classRegistry or
$aliasToClassNameMapping
This patch casts the required Array(which is possibly NULL) to an
Array to prevent array_merge with NULL values.

Fixes: #51474
Releases: 6.2, 6.1, 6.0
Change-Id: I1887da3a942b17e441338a95cb7da49a17535907
Reviewed-on: https://review.typo3.org/23441
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christoph Dörfel
Tested-by: Christoph Dörfel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This method was supposed to be in the interface, but due to a syntax
error in the closing comment tag, it was not (and was not detected as a
PHP syntax error).

This finally adds this method and implements it also in the class
FileReference which hadn't had this method before but also implements
this interface.

Resolves: #51509
Releases: 6.2, 6.1, 6.0
Change-Id: I8ee1ecc155e9cfaeec7ac0ac7086f75df13f4c34
Reviewed-on: https://review.typo3.org/23453
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Some parts of the install tool can throw fatal PHP errors if
broken extensions are loaded. Currently the database analyzer and
the upgrade wizards are affected by this.

The patch implements a shutdown function that is called even if a
fatal error is thrown and redirects to a special action that renders
the "Check for broken extensions".

Resolves: #51499
Releases: 6.2
Change-Id: Ie64781e59732fb1ef05efd6bd9da1e136241b22e
Reviewed-on: https://review.typo3.org/23440
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

As preparation for the new distribution (introduction package ...)
handling extensions should be able to provide initial file imports.
These are then imported to fileadmin/<extensionname>
upon installing the extension.

The files have to be located in <extension>/Initialisation/Files/*.

The files are imported only once (even if you reinstall the extension),
execution state is saved via the core registry.

Resolves: #51466
Releases: 6.2
Change-Id: Icbf63227aa8bbb9fcfb0335bfa5ae92b549a94ba
Reviewed-on: https://review.typo3.org/23427
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Now that system categories are activated by default for pages,
provide a simple way of display categorized pages with a new
typee of menu for the menu/sitemap content element.

The rendering uses a new type of special HMENU called "categories",
which means that it is also possible to create categories-based
menus in pure TypoScript.

Resolves: #51161
Documentation: #51162
Releases: 6.2
Change-Id: I137158f39607ad65dff13a604210a647cb8dda6f
Reviewed-on: https://review.typo3.org/23184
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

As the report tool checks system environment with the use of the hook
witin that function, we can deprecate the function in the BackendUtility
and move the hook to the appropriate extension "aboutmodules".

Resolves: #51434
Releases: 6.2
Change-Id: If39a82680a8797782bcbf620d7a3e59193468a9c
Reviewed-on: https://review.typo3.org/23400
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The test for insecure passwords handles empty passwords as insecure and
recommends to use the saltedpasswords scheduler task to convert all
insecure passwords. But the scheduler task doesn't convert empty
passwords, so a never ending story exists. Therefore this patch exludes
empty passwords being handled as insecure.

Resolves: #36244
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6bdd5c8807a07841850c1e4c22afe57eec28b335
Reviewed-on: https://review.typo3.org/23421
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If you start a disabled saltedpasswords task it begins to look over all
users again. If it didn't process all users the current position is saved
but there is no message to the backend user that the processing is not
finished. Therefore the task should re-enable itself to be able to
process remaining users.

Resolves: #51465
Releases: 6.2
Change-Id: Ia0abf76af2ba91b68d05f0837dda950660f52c1c
Reviewed-on: https://review.typo3.org/23425
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The HTML template was used in the old install tool, is
unused now and can be removed.

Change-Id: I046c772acd2a9db166036216b3d8ed78ffe813e4
Resolves: #51469
Releases: 6.2
Reviewed-on: https://review.typo3.org/23428
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

As preparation for the new distribution (introduction package ...)
handling extensions should be able to provide initial t3d imports.
These are then imported on the root level upon installing the extension.

The t3d file has to be called data.t3d and located in
<extension>/Initialisation/data.t3d.

The data is imported only once (even if you reinstall the extension),
execution state is saved via the core registry.

Resolves: #51437
Releases: 6.2
Change-Id: Ibfe631d173b962781018c6c9e929f4f020e48aa5
Reviewed-on: https://review.typo3.org/23397
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

To allow signalSlots to modify the given arguments,
even if not an object (which could be modified by
reference anyway), the signalSlot should be able
to return the arguments.

This will make the signal slot handling diverge
from Flow and violates or at least bends the
signal slot pattern.

To make this clear, we should rename the
signal slot dispatcher in an upcoming change.

Resolves: #51138
Releases: 6.2
Change-Id: I36928adceed672580c76a68891dfb825e43a5a9e
Reviewed-on: https://review.typo3.org/23146
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Until now, the sys_file_reference records use the regular "null value"
checkbox to switch between the value from sys_file and a custom value
the user can supply. This is however confusing for users, as there is no
explanation what the checkbox really does and also the placeholder text
is not removed when checking the checkbox (but an empty string is stored
in the database and thus used for output afterwards).

This commit changes the appearance to have a checkbox on top and toggle
between a classical read-only field and a real input field.

Change-Id: I2370b17c2cdf475aa6742cbca7cd12b6c8558130
Resolves: #49685
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21931
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

To keep track of missing files we introduce a missing
flag is sys_files.
When indexer detects file is missing the flag is set
and reset when file is present again.

In backend a message is shown when a reference to a
missing file is used.

Resolves: #50827
Change-Id: Iaaf9455698507c5cd574f6928fa5a563a49ad121
Reviewed-on: https://review.typo3.org/22913
Reviewed-by: Steffen Ritter
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Tested-by: Steffen Ritter

The functional test framework needs create and drop
table database permissions.

Added a check that outputs an error message if the DB user
is not able to connect to the database or if the user
has not the required permissions to create a database.

Resolves: #51381
Releases: 6.2
Change-Id: I94c4eeb4356fdba06026ec727283807112c53926
Reviewed-on: https://review.typo3.org/23388
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove the note "Install tool has hardcoded md5 hashing,
enabling this setting will prevent use of a install-tool-created
BE user." for backend.BE.forceSalted

Resolves: #51355
Releases: 6.2
Change-Id: Ic6dd03d37f5c4fe1027dece048693c74ab4dc98e
Reviewed-on: https://review.typo3.org/23395
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

To enhanced the security this patch changes the Install Tool password
from md5 hash to a salted hashed password. Therefore the default
password in the FactoryConfiguration.php is changed. Old md5 hashes get
converted automatically during the boot process of the Install Tool. The
output of the calculated hash is reintroduced when an error occured.
The report modules were adjusted to be able to check salted hashed
passwords.

Resolves: #50613
Releases: 6.2
Change-Id: If02a43780c9c819ebd6da7cbf0acad305f805330
Reviewed-on: https://review.typo3.org/22739
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Some file/directory actions were logged as they were
successfully performed, even when they failed.

Resolves: #51328
Releases: 6.2, 6.1, 6.0

Change-Id: Iab03e668d3f7d0e8feec09851ea50a59ab4b71a0
Reviewed-on: https://review.typo3.org/23303
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

In the installation wizard (123 steps) the admin user is created with a
md5 hashed password. For security reason this should be changed to a
salted password. As this function is used in #31407 as well it was
refactored to the AbstractAction class.

Resolves: #50612
Releases: 6.2
Change-Id: Ide966eb1c1e05d2190f0d22446bc2b3e92643451
Reviewed-on: https://review.typo3.org/22738
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

With displaying the count of failed error checks in the navigation menu
(like the count of unread messages in an email inbox) a user will more
likely enter the "System environment" section of the install tool and
take care about the found errors and warnings.

Change-Id: I3d9b628b428da13992c3dc1e7e5ab6beaeda5ce1
Resolves: #51410
Releases: 6.2
Reviewed-on: https://review.typo3.org/23380
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Remove all calls on SaltedPasswordsUtility::isUsageEnabled('BE')
as backend is enabled by default. Besides remove all
ExtensionManagementUtility::isLoaded('saltedpasswords') as
extension is loaded by default.

Change-Id: Ie2332fc3c6c454888afc8c9956b9869309623584
Resolves: #51356
Releases: 6.2
Reviewed-on: https://review.typo3.org/23375
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #51190
Releases: 6.2, 6.1
Change-Id: I105e23b12659495b4058edbc8091eee4374d58b9
Reviewed-on: https://review.typo3.org/23278
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The call to substr_count was incorrect.

Change-Id: I9f452d22f03a99fbf0b862021b100dcf6d53d792
Resolves: #51409
Releases: 6.2
Reviewed-on: https://review.typo3.org/23374
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Feature wise equal to 4.3.1, but now with MIT license.

Resolves: #51406
Releases: 6.2

Change-Id: Ie0cd306b544c2f56853ca7e16ba6cdd5cdf84a6e
Reviewed-on: https://review.typo3.org/23370
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Nearly all buttons in the install tool currently show a green checkmark
icon. This is misleading, as in most cases nothing has been checked.
The button simply leads to the next step or executes the desired action.

With removing the icon, it will be more clearer that clicking a button
will just perform the intended action, without any check being
performed beforehand that this action will actually succeed.

Change-Id: If00d4ccde24a201f552ead6b9d8991c8e58b473f
Resolves: #51407
Releases: 6.2
Reviewed-on: https://review.typo3.org/23368
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In the extension manager make the extension titles link to the
configuration again. This will provide an additional clickable area and
it allows the integrators to continue using the known behavior.

Resolves: #50234
Releases: 6.2, 6.1, 6.0
Change-Id: I120e8fb47628fe118291cbdd57951a0238ebcd71
Reviewed-on: https://review.typo3.org/22663
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

To use saltedpasswords in the install tool it is necessary to move the
default salt methods registration from ext_localconf.php to the salt
factory. This patch adds an initialize function to set the default salt
methods.

Resolves: #51404
Releases: 6.2
Change-Id: Iaa4547255c8d6e3b0b0fd75c0aaadfa54109ba27
Reviewed-on: https://review.typo3.org/23369
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If the Install Tool is locked, the login-screen states whether the
cause to this is if the ENABLE_INSTALL_TOOL file doesn't exist (and
therefore it's locked) or if no password is set.

Currently, the Browser-Title states "No install tool password set"
even if it's set but the ENABLE_INSTALL_TOOL file doesn't exist.
This Patch sets the correct title in the browser-window:
"The Install Tool is locked".

Resolves: #51408
Release: 6.2
Change-Id: Ia9d25a884667404408a2ef6a375d95f7509d8d9d
Reviewed-on: https://review.typo3.org/23373
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The button icon viewhelper now supports an empty uri parameter. The
link on the next / last button of the backend paginate widget in case
you are on the very last page can be removed.

Change-Id: I238c77efa8a9d4ff4a1864f6df876a695dc690e5
Resolves: #51395
Releases: 6.2
Reviewed-on: https://review.typo3.org/23363
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This patch rewrites the configuration of ext:saltedpasswords into
a readable array which gets serialized afterwards. The check for
enabling salted passwords in the backend is obsolete and removed.
The values of the "checkConfiguration" user functions superfluous
and removed as well.

Resolves: #51354
Releases: 6.2
Change-Id: I539070d1642660ad0a5641d8971bdabc7cf92223
Reviewed-on: https://review.typo3.org/23366
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

"Check for broken extensions" in important actions of the install
tool checks for broken extenions over an Ajax-Request.

Currently, the user clicks the button to check for broken extensions
and doesn't get any feedback whether there is something going on or not.
This patch implements a loading-message with a Spinner that is displayed
as soon as the button to check for broken extensions is clicked.
Furthermore the button is hidden as long as the request is beign executed
and displayed again if there is anything more to check (e.g. broken
extensions are found).

Resolves: #51379
Release: 6.2
Change-Id: I13e5024a1e2666e54e782ff1bab9418ba8b180f6
Reviewed-on: https://review.typo3.org/23365
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Christoph Buchli
Tested-by: Christoph Buchli
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Purpose of the initialize() method in the AbstractAction class is the
initialization of a handle. It is not intended to be used for generally
initializing classes derived from AbstractAction.

By refactoring the method name, the method's purpose will be indicated
more clearer.

Change-Id: I1603090e4dfccb5b57da4fa9c3792ec73647c524
Resolves: #51396
Releases: 6.2
Reviewed-on: https://review.typo3.org/23364
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn