Add the dependency resolving when installing local
extensions with the extension manager.

Cleanup the download controller arguments on the go.

Fixes: #41273
Releases: 6.0

Change-Id: I10876f09bf4bed7b33d803a80a3d89fb583d4c7e
Reviewed-on: http://review.typo3.org/15873
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

\TYPO3\CMS\Form\Localization is a singleton class with constructor
parameters. This is an antipattern and broken by design. As an effect
it leads to warnings in unit tests and makes the class unusable
with multiple files.

The patch removes the implementation of the singletonInterface, but
sets the default localization file as default parameter to keep
backwards compatibility.

Change-Id: I3ed5c77c5c3a653c8d5e7259baa64a41c8c20859
Resolves: #42280
Releases: 6.0
Reviewed-on: http://review.typo3.org/15886
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Problem: The filename created by t3lib_div::tempnam may contain
backslashes.

Solution: Process the file name through t3lib_div::fixWindowsFilePath

Change-Id: I47f8fe39ffb29894d78ac28141b88ea7abf6fd2c
Releases: 4.5, 4.6, 4.7, 6.0
Resolves: #38699
Reviewed-on: http://review.typo3.org/12684
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Internet Explorer 8 raises an error on JavaScript objects with reserved
words as property names. In the new form wizard an object was created
with class as property name which is a reserved word. Surrounding with
quotes fixes the bug.

Change-Id: Id9ceef79e8503886cdaebbf14ddb4e92c4b7dcea
Fixes: #33504
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/8776
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The extension state is stored as text in the TER dump, but stored as
an integer in the database. The correct conversion must be done to
be able to show the states from extensions in TER.

Change-Id: I9fc05a61df1df71696c690874507f7bbc51e9aab
Fixes: #42260
Releases: 6.0
Reviewed-on: http://review.typo3.org/15877
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Through calculation of dependencies the dependency
utility swapped lowest and highest constraint.

Fix that and also make the dialogue work again
when installing an extension with dependencies.

Fixes: #42245
Releases: 6.0

Change-Id: I1701b966bbb0c9768992e5e8a9a6a88ae4917ce6
Reviewed-on: http://review.typo3.org/15862
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Resolves: #41941
Releases: 6.0
Change-Id: Ia500d4892532a7e5ec7a997f4b3b0c521d22a654
Reviewed-on: http://review.typo3.org/15858
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Resolves: #41940
Releases: 6.0
Change-Id: Ie45de7e048950cae42672439f72639813ce423ff
Reviewed-on: http://review.typo3.org/15857
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

All absolute identifiers within a storage have to begin with a "/". The
Storage does not respect this for the processing folder, leading to
wrong identifiers being generated for images inside this folder.

To account for this change, the sys_file_processedfile table should be
cleared. All identifiers will be regenerated then.

Change-Id: I19293ea766f54830264555f63094471f73a61b28
Resolves: #42180
Releases: 6.0
Reviewed-on: http://review.typo3.org/15836
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Just some CGL, DocComment and variable name
cleanup within the FileRepository

Change-Id: If5cf743f1a3e5ac1e2dc5c7f592df642cca9211a
Resolves: #42243
Releases: 6.0
Reviewed-on: http://review.typo3.org/15860
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The key for the default filters array in the default configuration of
TYPO3 is callbackFilterMethods. This is misleading, as one might see
this as a list of *all* available filters. Therefore, the key is renamed
to defaultFilterCallbacks.

The name change does not break any public API as the array key is only
used in one place: the ResourceStorage.

Resolves: #42239
Releases: 6.0
Change-Id: I48282f8e49ab786aaf8821badfb411a653e9a3fc
Reviewed-on: http://review.typo3.org/15856
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

There is an information about the ThreadStackSize on Windows systems in
the Install.txt

This information should be displayed in report status as well

Change-Id: I70512b15ec672aa16dee8223a48ea5d51f3a8964
Resolves: #42235
Releases: 6.0
Reviewed-on: http://review.typo3.org/15845
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Implement the creation of configured upload folder 
and "createDirs".

Releases: 6.0
Resolves: #42145

Change-Id: I4951d6daa6c3c8981f03b3d77a56e5f48913a5a5
Reviewed-on: http://review.typo3.org/15838
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

In some browsers the upload form did not go to the iframe for further
processing by JavaScript. Adding a name to the iframe solves the
problem.

Change-Id: If9f6afcf4a80ac178c6c473cc8542ddb4bf7317c
Fixes: #42156
Releases: 6.0
Reviewed-on: http://review.typo3.org/15840
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Change-Id: Ifbf4d901a496ce065c453073bc15cb7f3590fa61
Resolves: #42170
Releases: 6.0
Reviewed-on: http://review.typo3.org/15813
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The TCA for sys_file_reference table configures fields like
hidden, sys_language_uid and alike as "exclude => 1".

This causes the translation of tt_content elements with
images to fail for an regular editor if these fields are
not configured to be allowed explicitly.

These fields are always hidden in TCEforms, but always
required for IRRE and translation to work.
Therefore remove the exclude-field configuration.

Change-Id: I1783b7406b62c1142acb991308e3698cf5af68f1
Resolves: #42224
Releases: 6.0
Reviewed-on: http://review.typo3.org/15835
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

* Use controller arguments for actions
* Simplify contollers

Releases: 6.0
Resolves: #42163

Change-Id: I211d58e0dbbed083bb7a643a89da764bb4a186a3
Reviewed-on: http://review.typo3.org/15823
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

When showing extensions from TER unsafe extensions must not be shown
in the list or search results.

Change-Id: I229e3fc2b00a25c4e1cbcdc1ec2ac1596692630a
Fixes: #42153
Releases: 6.0
Reviewed-on: http://review.typo3.org/15824
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

* Use controller arguments for actions
* Add escaping in viewhelpers
* Remove compatibility files
* Fix some annotations
* Enable test after ConfigurationManager change
* Fix new property mapper configuration

Releases: 6.0
Resolves: #42163

Change-Id: Ida9010e2eb00013c3a3e855983b58bb7df38c30d
Reviewed-on: http://review.typo3.org/15803
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Cleans up the About Modules CSS file (mainly paddings) and terminology
to distinct between "TYPO3" (Association) and "TYPO3 CMS" product
within copyright notices.

Standardize CSS ids to use the extension key (aboutmodules).
Also adds links to the module descriptions to jump to module.
Brings one further logo image to comply with new brand definition.

Only applies to the extbase version of AboutModules.

Resolves: #41980
Releases: 6.0, 4.7
Change-Id: Iba088c5d644dfc048ea9c65e72711d501b51ae59
Reviewed-on: http://review.typo3.org/15610
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Better mocking in test class to ensure isUsageEnabled() returns TRUE
in all environments and especially in travis.

Change-Id: Icb68b1c863c13db0fb1e48390db130f43b9e0622
Related: #41828
Releases: 6.0
Reviewed-on: http://review.typo3.org/15815
Reviewed-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Test files for #41828 should be in Tests/ instead of tests/

Change-Id: I26188b0addae691a2d5c4c8289885303db556d82
Related: #41828
Releases: 6.0
Reviewed-on: http://review.typo3.org/15810
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Upload in EM assumes <extkey>_<version>.zip, so the download as zip
feature must use the same format.

Change-Id: Ide7eb7aac3c8f213b7db2bc9dad5e014e8faa666
Fixes: #42067
Release: 6.0
Reviewed-on: http://review.typo3.org/15801
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Problem: When linking from a piece of content in the RTE to a disabled
page in the tree, the link isn't shown in the final frontend rendering.
However, the small arrow icon that you can have in front of the link to
denote its type, does get shown.
Solution: Remove the icon if no link is generated

Change-Id: If2f5af7ef81578571ed0a1255a53d9373f14bfed
Resolves: #36087
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15802
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

The compatibility class loader currently fails
to match method declarations that go over multiple
lines.

Add the /s modifier to the pattern and adjust the testcases.

Releases: 6.0
Resolves: #42134

Change-Id: I2671944a80608b9ac585f6b5c586ceb571b82ecb
Reviewed-on: http://review.typo3.org/15800
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Problem: The spell checker must analyze the dictionary file and may
have to update the charset of the personal dictionary. In doing so,
it is looking for the wrong file when the dictionary in use is a
regional/variety dictionary.

Change-Id: Ia2b57c0ead7c90a6d40e9db4d396e6c7ded72e5c
Resolves: #29685
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15790
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

To have the possibility to remove dependencies from code that
calls the configuration manager, it has to be made non static.

Together with this change, all further configuration file logic
is moved to that class, to not expose internals in other
places. For that some methods needed to be made public, but
have been marked private, thus are not public API.

Further cleanup and simplification, especially not calling
makeInstance several times, will go in a separate change.

Resolves: #41052
Releases: 6.0

Change-Id: I8ddfa4a957d0b4955ed422a1deeebaf84340c2c1
Reviewed-on: http://review.typo3.org/15267
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

EXT:cli was removed and merged with core but the extension key is still in
the list of REQUIRED_EXTENSIONS.

Change-Id: I272338b2676f8d84d586586c36c151c9339ed1a7
Resolves: #42138
Related: #40949
Releases: 6.0
Reviewed-on: http://review.typo3.org/15788
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Do additional code style cleanups on the go.

Change-Id: I6d8732b7b4c979a96b4847a85e3aea52db01fbd3
Fixes: #38406
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12898
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Adding users to Compare list does not work.

Change-Id: I079f0c8cf47213854c1ef358631b6a7c9ecc9260
Resolves: #41233
Releases: 6.0
Reviewed-on: http://review.typo3.org/15377
Reviewed-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Extension manager shows possible locations to install an Extension.
The options set in the Install Tool must be shown.

Change-Id: I6d51c1a71eb4ff83077cf3962fadbcefb5049637
Fixes: #42103
Releases: 6.0
Reviewed-on: http://review.typo3.org/15778
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Replace text in Javascript by language labels. Fix jQuery behaviour
for update, upload and other icons. Replace some text links by icons.
After answering No to update confirmation the mask in the background
is removed.

Change-Id: Id934e4c270897d5810ff68e1f076a91d7ba182fb
Fixes: #42033
Releases: 6.0
Reviewed-on: http://review.typo3.org/15759
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Adjust occurence in t3lib which is just
there for compatibility (deprecated).

Change-Id: Ieca152e5a4f21fac4e5473747a205eead278f88e
Resolves: #42102
Releases: 6.0
Reviewed-on: http://review.typo3.org/15769
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

As not all usage of class names trigger the autoloader,
usage of old class names in type hints for example doesn't.

If an object with a namespaced class name is given to
a method with an old class name, PHP dies with a fatal error.

To ensure full compatibility we need to set the
class alias also when a namespaced class is required
in the autoloader.

Resolves: #42058
Releases: 6.0

Change-Id: Ia4babeeae07fb778732c5846c5cf8c70115037f0
Reviewed-on: http://review.typo3.org/15748
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Adds a standardized headline to the ExtensionManager backend
end module.

Also streamlines the outer spacing to comply with the other
core backend modules and #typo3-inner-docbody.

Change-Id: Ie5a8decf30f4fd19a2a692ee1f7e8d1c34d3ddf5
Resolves: #39921
Releases: 6.0
Reviewed-on: http://review.typo3.org/15661
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Due to the fact that the pages table has it's own translation
table, pages_language_overlay, localization of IRRE records is
not possible there.
The fix is to use the TCA setting transOrigPointerTable
(= pages_language_overlay) instead of the original parent table
(= pages).

Change-Id: I088fe01033f9cf9c35a0e979215bb378be4a3dba
Fixes: #41924
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15523
Reviewed-by: Steffen Ritter
Reviewed-by: Georg Ringer
Tested-by: Steffen Ritter
Reviewed-by: Andreas Wolf
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Follow up to which uses the vector graphics as base
instead of manually modified and cropped ones.

Change-Id: I73922312fa0512c635ce60b1b70662c25d3028ed
Fixes: #41704
Releases: 4.5,4.6,4.7,6.0
Reviewed-on: http://review.typo3.org/15443
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The compatibility class loader rewrites typehints of classes
but fails to find abstract class declarations which end with
an ; and not with a {

Adjust the regular expression to reflect that need.

Resolves: #42057
Releases: 6.0

Change-Id: I793bdaaf5c119c6dc525c9a2812a909404aa400e
Reviewed-on: http://review.typo3.org/15744
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: I24d4648716825debef6f0ed275b1f0226cff47c6
Reviewed-on: http://review.typo3.org/15729
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

The ll-XML parser internally falls-back to English when looking for a
non-existing language translation. This prevents the localization
fallback mechanism to detect that the translation did not exist or was
only partially available and thus take the language dependency into
account to return a proper label.

Change-Id: I4095d20ec8fc08105dfff108c7e3865f468ddb91
Fixes: #41996
Releases: 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/15634
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers