- Sep 28, 2021
-
-
Helmut Hummel authored
Since TYPO3 core packages (extensions) are independently published and might be installed in arbitrary file locations in the near future, referencing assets in package A from a CSS file package B will likely not work. Therefore all assets that are referenced from a CSS file are now moved to the package that contains this CSS file. Also references of assets in CSS that already were located in the same package are cleaned up to not assume a hard coded path name (breaking out of Resources/Public directory). Resolves: #95372 Releases: master Change-Id: I6d7d7557d8ea7b293c81b50bc4172019a088f7b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71332 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Substitutes deprecated invocation of `TBE_EDITOR.fieldChanged`. Relevant processing has been duplicated from `TBE_EDITOR` to corresponding `FormEngine` event handler. Throwing a new `change` event from a `change` event handler is counterproductive and would lead to an endless loop. Resolves: #95352 Releases: master Change-Id: I61daee4457ec5d2bb36d1bcc773178c25e00cb8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71229 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
This change adds XL and XXL breakpoints to the EXT:form FormElement definitions. Resolves: #95363 Releases: master Change-Id: I881539a183f8d803278d5c8a83e560a75b17fb06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71314 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Nikita Hovratov authored
Resolves: #95373 Releases: master Change-Id: I961233104e0f3747aaa67f4e018852824181ee7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71333 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change adds the "groupName" property to group records within the "New Record" wizard into logical groups, where TYPO3 Core defines "system", "frontendaccess", "backendaccess" and "content". Existing extensions with "groupName" continue to work by shipping their own groups. Resolves: #95366 Releases: master Change-Id: I5c218823fa16917fc1d0cb8099899ee26a298cd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71316 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Sep 27, 2021
-
-
Benni Mack authored
The replacement "PathUtility::isAbsolutePath()" works the same way and has been around for a long time. For this reason "GeneralUtility::isAbsPath()" is deprecated. Resolves: #95367 Releases: master Change-Id: Ia2b1bf71773d2f0d4c7ed0ab58a937652ddade74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71177 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Nikita Hovratov authored
Declaring non-existing soft reference parser keys in TCA is ignored again and won't throw an exception anymore. For informational purposes this will be logged instead. Resolves: #95012 Releases: master Change-Id: Ifbc7927365f7c6a402e6ad99417f82cda0aa51d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70795 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Larry Garfield authored
SQLite returns the correct type information now, so this workaround is not necessary. As long as we are not on php 8.1 as min requirement, use a version check to disable the workaround for sqlite and php >8.1. After 8.1 as minimum requirement the workaround method should be removed at all. Resolves: #95153 Releases: master Change-Id: I8545d9eb847eacd13a4514034fab37cdb9a5d192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71238 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Kott authored
Resolves: #95353 Releases: master Change-Id: Ibce6c125438a6dcd73295069d6cea45dd3d4ebae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71234 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Stefan Bürk authored
phpunit has released new versions for 8.5.x and 9.5.x, which do not longer automaticly throw exception for user depcrecations. As there are tests expecting this exception, the min version must be increased and the explicity configuration option set. Otherwise nightly composerMax unit tests will fail. Furthermore there was a patch merged which needs to have 'phpspec/prophecy' on ^1.14.0 as minimum requirement. Otherwise nightly composerMin php7.4 tests will fail. This patch increase the min version for the two dev dependencies and apply the needed phpunit configuration option to throw user deprectation excetions again. Used composer commands: composer req --dev --with-dependencies phpunit/phpunit:^9.5.10 composer req --dev phpspec/prophecy:^1.14.0 Tests: Build/Scripts/runTests.sh -s composerInstallMin -p 7.4 ; \ Build/Scripts/runTests.sh -s unit -p 7.4 Build/Scripts/runTests.sh -s composerInstallMax -p 7.4 ; \ Build/Scripts/runTests.sh -s unit -p 7.4 Build/Scripts/runTests.sh -s composerInstallMax -p 7.4 ; \ Build/Scripts/runTests.sh -s unit -p 8.0 Resolves: #95360 Related: #95210 Releases: master, 10.4 Change-Id: Ia009fe20a0b53b3d1bdef097b00c1993d3b8c596 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71292 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Sep 26, 2021
-
-
Benjamin Franzke authored
ExtensionManagementUtility() usage in Services.php has never been an intended usage, but was technically possible in TYPO3 v10 as a side effect of runtime activated packages, and therefore got documented in example code. Container builds should generally be stateless and should only take explicit service configuration and ContainerBuilder compile time state into account. Therefore conditional service registration should only use compile time container state, which can be achieved with: ContainerBuilder->hasDefinition(ClassNameOfOptionalDependency::class) Resolves: #95359 Related: #95358 Releases: master, 10.4 Change-Id: I36073e9600a636d4b65f246e27109883e2dc80a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71272 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
- Sep 25, 2021
-
-
Benjamin Franzke authored
This reverts commit 11c7e844. The BUGFIX accounted for ExtensionManagementUtility usage in Services.php which has never been officially supported, but has been a documentation bug and actually worked only by accident and only in TYPO3 core, not with tools like typo3-console. Therefore extensions that use this could always cause breakage in some situations. The alternative to use optional service dependencies via ContainerBuilder::hasDefinition() is available since v10 and the documentation is adapted accordingly in #95359. Therefore the BUGFIX is reverted. Resolves: #95358 Related: #95359 Reverts: #95327 Releases: master Change-Id: I387fa2905b554ca12bf60d6bff452c9964c36a69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71252 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Stefan Bürk authored
There has been a overlapping in merging two patches, first one adding rules for php stan to enforce trailing commas for an multiline array ( #94553 ) and the second one with a multiline array without trailing comma ( #89327 ). To make cgl happy again add this comma. Resolves: #95357 Related: #89327 Related: #94553 Releases: master Change-Id: Ic03916b9d4ae7151c2e13f22920c331443857f80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71239 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- Sep 24, 2021
-
-
Benni Mack authored
The HMENU / TMENU options for opening up links of a menu in a custom JavaScript popup are deprecated. Respective settings: page.123 = HMENU page.123.1 = TMENU page.123.1.JSWindow = 1 page.123.1.JSWindow.params = width=200,height=300,status=0,menubar=0 alternatively this syntax was possible as well: page.123.1 = TMENU page.123.1.target = 200x300 both variants and properties related to JavaScript are now deprecated. Resolves: #95351 Releases: master Change-Id: Iea28a8c8ecd907382cba327cb6c631e8beadfd4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71233 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The option to use the `@import` syntax for including external CSS files through TypoScript has been deprecated. This was possible through: page = PAGE page.includeCSSLibs.file1 = fileadmin/benni.css page.includeCSSLibs.file1.import = 1 Through the "import = 1" option the output was <style> @import url('fileadmin/benni.css'); </style> instead of using the <link> tag. Using the link tag, which is the de-facto syntax these days, allows to load a file directly when interpreting the HTML of the browser, instead of first interpreting the HTML, then the CSS and have a blocking call to an external URL to continue interpreting the CSS. Resolves: #95349 Releases: master Change-Id: I05071d800fb938af00695005081bfbfaeb4ecee5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71231 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Kott authored
Resolves: #95348 Releases: master Change-Id: I66214bec9ade995f43a16698629b89f0be5cc1c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71230 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org>
-
Benjamin Kott authored
Executed commands: cd Build yarn add "@typo3/icons@^2.4.1" grunt build Resolves: #95210 Releases: master Change-Id: Ia4bc675cd8dafa9ce76c837e329ea76cea90588c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71228 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Georg Ringer authored
GeneralUtility::validEmail is called for all legacy link formats like page ids. To avoid triggering Egulias\EmailValidator an early check for the `@` sign has been added. Resolves: #95042 Releases: master, 10.4 Change-Id: I7720a7e771d0f31f53a72e7a1a9377a9256f6014 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70855 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Wouter Wolters authored
In some cases it can improve performance too. Resolves: #95210 Releases: master Change-Id: I4915bb1391ec99ff891248545080640965c8f62a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70204 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benjamin Franzke authored
Ensure `grunt build` generates a timestamp in Build/.cache/grunt-newer/terser/typescript/timestamp by using `newer:terser:typescript` instead of `terser:typescript`. This is for `grunt newer:terser:typescript` (as executed by `grunt scripts`) to able to pick this timestamp in subsequent builds to avoid re-tersing files that have already been tersed in a previous full-run (grunt build). Background: With the changes in #95016, `grunt terser:typescript` became a static task that executed terser for all typescript files in Build/JavaScript/. Prior to that change the list of files to be tersed was dynamically configured only for changed files in `grunt copy:ts_files`. Now, that means `grunt newer:copy:ts_files terser:typescript` was equal to `grunt newer:copy:ts_files newer:terser:typescript`. That changed with #95015 because `grunt build` creates a cache for incremental builds of tsc but not for newer:terser. Note: Using newer: during `grunt build` has no impact on which files are processed as `grunt build` cleans all cache files upfront and therefore `newer:terser:typescript` will terse all files in that context and only creates the timestamp additionally. Releases: master Resolves: #95341 Related: #95016 Change-Id: I90b74198f8982012935d86db94f8e1e71fedc548 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71226 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Guido Schmechel authored
When renaming pages, the pages in the automatic redirect are now saved with the TYPO3 protocol. Resolves: #89327 Releases: master, 10.4 Change-Id: I0207b4c4b81381f85b7522a130d17cbd20fe8b58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68202 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
A few methods within the *UserAuthentication have arguments deprecated. * AbstractUserAuthentication->writeUC() - first argument deprecated * AbstractUserAuthentication->unpack_uc() - first argument deprecated * BackendUserAuthentication->isInWebMount() - third argument deprecated * BackendUserAuthentication->backendCheckLogin() - first argument deprecated Resolves: #95320 Releases: master Change-Id: Idc62a78d9238a7837770531ad94dcf40988c9d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71182 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The hook "$GLOBALS['TBE_MODULES_EXT']['xMOD_db_new_content_el']['addElClasses']" is now marked as deprecated, as the $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms']['db_new_content_el']['wizardItemsHook'] which has been in place for a long time should be used instead. Resolves: #95343 Releases: master Change-Id: I248671e4b897c087df81ff8b81b4239c525a510f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71218 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
This change moves code from PagePositionMap into the subclass ContentMovingPagePositionMap. This code is only used (showing colPos) when a content is placed / moved, and thus does not need to reside in the main class. Resolves: #95342 Releases: master Change-Id: I8ea0cedd01f585064576e2fbdd0fe80b40b2bb46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71227 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
In order to allow conditional service registration based on ExtensionManagementUtility::isLoaded() checks in Services.php, the PackageManager is pushed to ExtensionManagementUtility before container creation. This has been the case prior to #91500 in order to support runtime activated packages, but got removed as isLoaded() checks in Services.php have never been an intended usecase. They have been documented in example code nonetheless and therefore usage is now fixed: https://docs.typo3.org/c/typo3/cms-dashboard/master/en-us/Configuration/WidgetRegistration.html#services-php-file Documentation should be adapted to recommend conditional services checks (ContainerBuilder::hasDefinition) instead. Once that is done, isLoaded() in Services.php can be marked as deprecated in future patches. Resolves: #95327 Related: #91500 Releases: master Signed-off-by:
Benjamin Franzke <bfr@qbus.de> Change-Id: Ifec470bd6364727ec0d9a5937106e6c94c0e18c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71214 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Jonas Eberle authored
With #94209 the ViewHelper be:moduleLayout was deprecated. That ViewHelper injected the used FlashMessageQueue into the created ModuleTemplate which took care of rendering messages. This is now just replaced by a very explicit <f:flashMessages /> in the templates. Resolves: #95334 Releases: master Change-Id: Ia45effdb7abfcbf491b98a28d91d332400ca28d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71222 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Hader authored
Previously, `fieldChangeFunc` items have been declared as string and were forwarded as plain inline JavaScript to the client application using HTML attrs `onchange` and `onclick`. This change introduces semantic objects for those `fieldChangeFunc` items that either can be used as structured configuration (JSON) or still "serialized" to inline JavaScript for legacy applications. New `OnFieldChangeInterface` provides a hybrid component that is backward compatible and still supports inline JavaScript as fallback. Using scalar (string) instructions for `fieldChangeFunc` will trigger PHP deprecation errors. Resolves: #91787 Releases: master Change-Id: I691ea8d12accfcf1568c34e178ce2087fd6ef609 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71072 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Bartsch authored
Resolves: #95335 Releases: master Change-Id: I5969032e5e8ec6b25cca87f098209bb458ab8e34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71220 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benni Mack authored
Using Node 16 (will become LTS in Oct 2021) is only possible by updating node-sass 6. See https://github.com/sass/node-sass/issues/3077 and https://github.com/sass/node-sass/releases/tag/v6.0.0 Used command: * yarn add "node-sass@^6.0" --dev Resolves: #95340 Releases: master Change-Id: I686fab7247b17ad777d13381d4b76927554a5a13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71224 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
In #95331 the legacy usage of the wizard as a full document has been removed. This patch removes some further leftovers. - Unused definition of docheader buttons is removed - Protected property $moduleTemplate is removed due to single usage - Protected property $menuItemView is removed due to single usage - Guard clause is added to prepareContent() Resolves: #95339 Related: #95331 Releases: master Change-Id: If022edf286ed8c0398a7434c1c87751dd4726b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71225 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 23, 2021
-
-
Benni Mack authored
Before TYPO3 v7 introduced modals, TYPO3's New Content Element Wizard could be opened within the list frame as a full document. The corresponding controller code has now been removed, along with some legacy functionality and inline JavaScript related to PagePositionMaps, which are used within the NewContentElementController, along with some legacy GeneralUtility::_GP() calls. In addition, the ContentCreationPagePositionMap does not inherit from PagePositionMap anymore, as it only had a minor overlap of functionality. Resolves: #95331 Releases: master Change-Id: If87e4743c05aaab0550cc6939310ebed9d095813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71219 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
This change cleans up the NewRecordController which hasn't been touched since ages. It cleans up the render-related functionality into a Fluid Template. Within Fluid, Bootstrap 5 styling is now applied properly. Resolves: #95332 Releases: master Change-Id: Ic6a2e8967cfe8ee7ee0876300244e8bce9ca5c57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71216 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Oliver Bartsch authored
The file listing in the link browser is using bootstraps' "List group" component. In case a list group item is active, it receives "z-index: 2", to slightly overlay the neighbor items. To avoid conflicts with element browser components, which also use "z-index: 2", this patch increases the z-index of those components to "3". Resolves: #95323 Releases: master Change-Id: Ibd18992797cc8500518f589d4bebed9640b318f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71217 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
Due to some setups within e.g. shortcut elements did not have a proper information anymore when used in language mode and mixed setups. Resolves: #95324 Related: #95302 Releases: master Change-Id: Ic2022ab113c2ec0f75fb05d5c1a34be39387ec87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71212 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Rachel Foucard <rfoucard@w-seils.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Peter Kraume authored
Resolves: #95329 Releases: master Change-Id: I680b667971b09ce71f304f1a8180dfd1ab80d519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71215 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Wouter Wolters authored
Replace static:: with self:: in final classes. Resolves: #95319 Releases: master Change-Id: If375daf637c31f94c86f24d9189e85f8bae32581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71190 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
There was a time when new code for TYPO3 Core was introduced by using "MyClass::getInstance()" to act as a factory for this class, which _would_ be OK if these classes are actually prototypes and not services (or singleton services), as GeneralUtility::makeInstance() or DI via Services.yaml works as well. This change deprecates all getInstance methods around such code with GeneralUtility::makeInstance() calls. At a later point, proper DI can be introduced in these cases. * TYPO3\CMS\Core\Resource\Index\ExtractorRegistry::getInstance() * TYPO3\CMS\Core\Resource\Index\FileIndexRepository::getInstance() * TYPO3\CMS\Core\Resource\Index\MetaDataRepository::getInstance() * TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\OnlineMediaHelperRegistry::getInstance() * TYPO3\CMS\Core\Resource\Rendering\RendererRegistry::getInstance() * TYPO3\CMS\Core\Resource\TextExtraction\TextExtractorRegistry::getInstance() * TYPO3\CMS\Form\Service\TranslationService::getInstance() * TYPO3\CMS\T3editor\Registry\AddonRegistry::getInstance() * TYPO3\CMS\T3editor\Registry\ModeRegistry::getInstance() Resolves: #95326 Releases: master Change-Id: Ie3160c67792e115cf5488dc800bd717c0b913ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71178 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/browse_links.php']['browserRendering'] is deprecated in favor of the ElementBrowser API implemented in TYPO3 v7.6 via https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.6/Feature-66369-AddedLinkBrowserAPIs.html Also, calling "wizard_element_browser" with mode=wizard or "mode=rte" is deprecated, instead extensions should link to "wizard_link", which also exists since TYPO3 v8. Resolves: #95322 Releases: master Change-Id: I4ad30fa0b0c0684767e1060d99cebc11b7db9710 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71180 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Revert a style change, added in #95325, which led to disabled checkboxes are being shown, while only their label should be visible. Those checkbox classes hide the actual checkbox, while the label acts as one. This allows extended styling, e.g. "icon checkboxes" or "toggle checkboxes". Instead add the disabled style to the correct checkbox component, which is acutally using the checkbox element and no label. Resolves: #95325 Releases: master Change-Id: I0842c184e629a3c4327c18db92affde58c32924d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71213 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-