Skip to content
Snippets Groups Projects
  1. Dec 13, 2022
  2. Dec 07, 2022
    • Oliver Hader's avatar
      [TASK] Introduce string fragment extraction · f1e1e0bb
      Oliver Hader authored
      When working with variable interpolation and similar scenarios, in
      most cases variables, constants, expressions, ... are embedded in
      a solid string and can only be identified and extracted by the
      corresponding "reader" or "parser".
      
      This string fragment splitter aims to introduce a simpler way for
      extracting and working with these embedded fragments.
      
      Example:
          $pattern = new StringFragmentPattern(
            StringFragmentSplitter::TYPE_EXPRESSION,
            '%[^%]+%'
          );
          $splitter = new StringFragmentSplitter($pattern);
          $collection = $splitter->split(
            'Hello %variable% World!'
            FLAG_UNMATCHED_AS_NULL
          );
      
          // results in having
          // + StringFragment(type: 'raw', value: 'Hello ')
          // + StringFragment(type: 'expression', value: '%variable%')
          // + StringFragment(type: 'raw', value: ' World!')
      
      Resolves: #97553
      Releases: main, 11.5, 10.4
      Change-Id: Ie2b02a247ca884fa44ab7b3ba21214c8ee9bc457
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76947
      
      
      Reviewed-by: default avatarOliver Hader <oliver.hader@typo3.org>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarOliver Hader <oliver.hader@typo3.org>
      f1e1e0bb
  3. Dec 06, 2022
  4. Dec 05, 2022
  5. Dec 03, 2022
  6. Dec 01, 2022
  7. Nov 12, 2022
  8. Nov 02, 2022
  9. Oct 19, 2022
  10. Oct 14, 2022
  11. Sep 16, 2022
  12. Sep 13, 2022
  13. Sep 07, 2022
  14. Sep 05, 2022
  15. Aug 16, 2022
  16. Aug 12, 2022
  17. Aug 11, 2022
  18. Aug 07, 2022
  19. Aug 05, 2022
  20. Aug 01, 2022
  21. Jul 30, 2022
    • Nikita Hovratov's avatar
      [BUGFIX] Prevent duplicate page tree items when entry points intersect · 780ee8b3
      Nikita Hovratov authored
      In a scenario, where a backend user has two entry
      points, in which the second one intersects the first
      one (is a direct sub-page), pages were shown
      multiple times.
      
      The reason behind this was, that inside
      PageTreeRepository->groupAndSortPages() every page
      was added regardless if it was already added in a
      previous run. This is the case, when the same pages
      are found in different depth levels.
      
      E.g.
      
      1 - Home (DB mount 1)
        2 - Page 1
        2 - Page 2 (DB mount 2)
          3 - Subpage 1 // will be added for level 2 and 3
          3 - Subpage 2
      
      To prevent this, a guard clause was added, which
      checks whether the page was already added by
      comparing the uid value.
      
      Resolves: #96512
      Resolves: #97774
      Related: #96367
      Releases: main, 11.5, 10.4
      Change-Id: I65439011b894f05faef9cb507d905b3d7d3b709f
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75224
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      780ee8b3
    • Stefan Bürk's avatar
      [BUGFIX] Ensure deterministic sorting in `PageTreeRepository` · 80ecc2c7
      Stefan Bürk authored
      Using database queries without deterministic sorting
      definition may lead to unreliabe resultsets in some
      dbms type and version, which also may change over time.
      Thus it's good practice to have proper defined sorting
      for queries, at least if result relies on a constant
      and reliable result sorting.
      
      With #96512 and #97774 additional tests has been added,
      which showed the unreliable of these database queries,
      blocking the bugfix backport to TYPO3 v10.4.
      
      This patch adds sorting definition to two db queries in
      `\TYPO3\CMS\Backend\Tree\Repository\PageTreeRepository`
      to ensure consistent results in a deterministic manner
      and make it possible to provide the related bugfix for
      TYPO3 v10.4.
      
      Resolves: #98056
      Related: #96512
      Related: #97774
      Releases: main, 11.5, 10.4
      Change-Id: I8a1bf3b93bcfcaec4c3de3ea6321db62847d0c21
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75336
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      80ecc2c7
  22. Jul 29, 2022