- Apr 23, 2024
-
-
Andreas Nedbal authored
In the current frontend tooling, we invoke Rollup twice: * via grunt-rollup to build library modules * via the command line to build everything related to CKEditor This commit gets rid of the first way and moves the library compilation to a JS-backed configuration as well, so we can get rid of a grunt package and also unify the tooling a bit. We also make use of @rollup/plugin-terser instead of the deprecated rollup-plugin-terser module that was used in ckeditor build before. To match the new behaviour, the "exec:ckeditor" task also was renamed to "exec:rollup". Executed commands: npm remove grunt-rollup npm remove rollup-plugin-terser npm install @rollup/plugin-terser --save-dev npm run build Resolves: #103686 Releases: main, 12.4 Change-Id: I8057dcceae2d039c637c6db68cf51b3ef1f12406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84005 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Ayke Halder authored
There is a checkbox in page module to show hidden content elements. If this checkbox is not selected the hidden content elements must be hidden. Additionally hidden elements must not be accessible/focusable by keyboard. Resolves: #103626 Releases: main, 12.4 Change-Id: Id8f4b98938ae27e3bd3d3e7903c3f50588d554b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83974 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com>
-
Andreas Kienast authored
Executed commands: npm install --save chart.js@^4.4.2 npm run build Resolves: #103652 Releases: main, 12.4 Change-Id: Iddbfb5be5f998c7b9d693dac94fee88a1f242edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83996 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.7.0 \ @typescript-eslint/parser@^7.7.0 \ @typescript-eslint/typescript-estree@^7.7.0 \ eslint-plugin-wc@^2.1.0 \ sass@^1.75.0 \ sharp@^0.33.3 \ terser@^5.30.3 \ typescript@^5.4.5 npm run build Resolves: #103653 Releases: main, 12.4 Change-Id: I96bb9e96d12182adc33b5fafb52d53a4fecf6806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83997 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
-
Andreas Kienast authored
The "No results found" alert is rendered in a flex-row container, which caused a rendering bug where the alert box was stretched to a height of 100%, but its width is limited to its content. Use flex children modifiers to ensure correct positioning. Resolves: #103662 Releases: main, 12.4 Change-Id: I5b17950ca381fda841cd3a901d9f5e1a70e5562d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83972 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
-
- Apr 22, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ lit@^3.1.3 \ lit-element@^4.0.5 \ lit-html@^3.1.3 npm run build Resolves: #103654 Releases: main, 12.4 Change-Id: Id250be2076f29d095cffed34bffe3f882feb223d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83952 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- Apr 18, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save-dev flag-icons@^7.2.1 npm run build Resolves: #103656 Releases: main, 12.4 Change-Id: Ibebf001a8867104d616777adf47b7c0edaccbf9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83893 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Apr 16, 2024
-
-
Willi Wehmeier authored
Add proper focus styles to the nav links in the Link Browser modal window. Resolves: #103631 Releases: main, 12.4 Change-Id: I0abb597124e335c3955c73438ac3cd2f0dad93bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83854 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Apr 12, 2024
-
-
Andreas Kienast authored
This commit replaces the abandoned package `@ronilaukkarinen/stylefmt` with the already installed `stylelint` tool. Please note that this is an intermediate step to give the build toolchain some love it deserves. Executed commands: npm remove @ronilaukkarinen/stylefmt npm install --save-dev \ autoprefixer@^10.4.19 \ postcss-scss@^4.0.9 \ stylelint@^14.16.1 \ stylelint-scss@^5.3.1 Resolves: #103612 Releases: main, 12.4 Change-Id: I1f283d50a1a6504c4c000e674c75a40923f6c7e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83755 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Apr 11, 2024
-
-
Andreas Kienast authored
This commit updates ckeditor to 41.3. See changelog at [1]. Executed commands: npm install --save \ @ckeditor/ckeditor5-alignment@^41.3.0 \ @ckeditor/ckeditor5-autoformat@^41.3.0 \ @ckeditor/ckeditor5-basic-styles@^41.3.0 \ @ckeditor/ckeditor5-block-quote@^41.3.0 \ @ckeditor/ckeditor5-clipboard@^41.3.0 \ @ckeditor/ckeditor5-code-block@^41.3.0 \ @ckeditor/ckeditor5-core@^41.3.0 \ @ckeditor/ckeditor5-editor-classic@^41.3.0 \ @ckeditor/ckeditor5-engine@^41.3.0 \ @ckeditor/ckeditor5-essentials@^41.3.0 \ @ckeditor/ckeditor5-find-and-replace@^41.3.0 \ @ckeditor/ckeditor5-font@^41.3.0 \ @ckeditor/ckeditor5-heading@^41.3.0 \ @ckeditor/ckeditor5-horizontal-line@^41.3.0 \ @ckeditor/ckeditor5-html-support@^41.3.0 \ @ckeditor/ckeditor5-indent@^41.3.0 \ @ckeditor/ckeditor5-link@^41.3.0 \ @ckeditor/ckeditor5-list@^41.3.0 \ @ckeditor/ckeditor5-paragraph@^41.3.0 \ @ckeditor/ckeditor5-paste-from-office@^41.3.0 \ @ckeditor/ckeditor5-remove-format@^41.3.0 \ @ckeditor/ckeditor5-show-blocks@^41.3.0 \ @ckeditor/ckeditor5-source-editing@^41.3.0 \ @ckeditor/ckeditor5-special-characters@^41.3.0 \ @ckeditor/ckeditor5-style@^41.3.0 \ @ckeditor/ckeditor5-table@^41.3.0 \ @ckeditor/ckeditor5-theme-lark@^41.3.0 \ @ckeditor/ckeditor5-ui@^41.3.0 \ @ckeditor/ckeditor5-undo@^41.3.0 \ @ckeditor/ckeditor5-utils@^41.3.0 \ @ckeditor/ckeditor5-word-count@^41.3.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.0 Resolves: #103589 Releases: main, 12.4 Change-Id: Id24aac98727af0d0b9284e68dd8c4a4e138a6c15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83737 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Apr 09, 2024
-
-
Benni Mack authored
Change-Id: I0e897680df27e5380344f4436a7db7a6085d0688 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83717 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Change-Id: Ibd990830d7ad9d43707be802c6a24a1388589d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83716 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Apr 08, 2024
-
-
Stefan Bürk authored
`Build/Scripts/runTests.sh` is the monorepo main dispatcher of script and tools to ensure same working state across developer host system and installation by using well defined containers. This mitigates issues with missing dependencies or wrong version of tools on develper machines. Until now local installation of `node` and `npm` in the matching version was mandatory to work with the node ecosystem like manage dependencies, executing node based tools or the build chain for CSS and TypeScript/JavaScript. This change adds now a `npm` dispatcher to `runTests.sh` similar to the `composer` command dispatcher introduced with #103045 to allow executing npm commands and defined scripts in `package.json` in a well-defined environment and removes the hard-requirement of installing it locally for new contributors. Added `runTests.sh` suite: * ./Build/Scripts/runTests.sh -s npm -- <npm-command-arguments> which allows now to using npm commands ...
-
- Apr 07, 2024
-
-
Andreas Kienast authored
When t3editor got streamlined in the past, configuration for flex was defined that conflicts with CodeMirror's internal style definition, leading to UI glitches like "cut out" content, see screenshot attached to the ticket.. This commit removes the conflicting CSS. Resolves: #101442 Releases: main, 12.4 Change-Id: Ie5b9f8d498cdaef0b3455e05e247cb5fd64b0617 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83685 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
-
Markus Klein authored
As documented by PHP, `\DateTime` or `\DateTimeImmutable` objects created with a timestamp only ('@12345678') as the first constructor argument will use UTC as TimeZone. Creating an object instance without any constructor arguments will use the `date_default_timezone_get()` timezone for the object - and setting the timestamp using `setTimestamp()` will not change the object's timezone. That means, that formatting the value will be done using the object Timezone and **NOT** the default PHP Timezone (`date_default_timezone_get()`). Consequently, this may lead to wrong interpretation of the displayed formatted value in the context of another timezone - if no timezone information (+0000/-0100) is included. This change streamlines this for a couple of places were it is expected to format date, datetime or time values for the current context timezone by ensuring objects get the current timezone set instead of `UTC`. Note: Changing the date defau...
-
- Apr 05, 2024
-
-
Stefan Bürk authored
New core-testing-* images has been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below. * core-testing-nodejs18 => 1.4 * core-testing-nodejs18-chrome => 1.4 [1] https://nodejs.org/en/blog/vulnerability/april-2024-security-releases/ [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/712e35c72cd7788d1d6311714b5a0dfe46e743a7 Resolves: #103518 Releases: main, 12.4 Change-Id: Ibaafbd465a21d631f6726064255241aa4b42e726 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83652 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Apr 04, 2024
-
-
Andreas Kienast authored
In the image editor, the "Cropped area" was configured with a `ceil`ed width and height. Since all other dimensions are `floor`ed, this might cause an overlap. Due to the configured cropping mode, defining that the cropping area must never exceed the image dimensions, the cropper library places the cropper to a position that's mathematically correct but not desired. To solve this issue, the `width` and `height` properties fed to the cropper are now `floor`ed as well, basically aligning with the rest of the coordinates. Resolves: #101520 Releases: main, 12.4, 11.5 Change-Id: I981bd185eaf0db60662a5a6b7b423d84112c2150 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83659 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Oliver Bartsch authored
To regenerate a slug, the fields defined in the TCA "generatorOptions" configuration have to be present in the form. There are cases where those fields are added as hidden fields (e.g. using the "overrideValues" feature). Those fields are now also properly respected for the regeneration. Resolves: #103500 Releases: main, 12.4 Change-Id: I0ca7de4b7d7d09e62ece511aeb16615af3d3a1fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83657 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Mar 25, 2024
-
-
Oliver Bartsch authored
At various places, it's possible to edit the metadata of a file in the default language. However, users might not have access to the default language. To prevent moving to FormEngine and facing access permission errors, those places now use proper language access checks and do not display corresponding action if the user does not have access. Resolves: #103432 Releases: main, 12.4 Change-Id: I22c3755a17888cfc623ce05b25fd655b323cc553 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83583 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com>
-
- Mar 22, 2024
-
-
Stefan Bürk authored
New core-testing-* images have been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below. * core-testing-php81 => 2.12 * core-testing-php82 => 1.12 * core-testing-php83 => 1.13 [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/ebdaefdb54a4fe970abf0cb1d32567bbd6339de5 [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/21f88537fab0a6c5be866c602f206acdb289a20a Resolves: #103469 Releases: main, 12.4, 11.5 Change-Id: I35ffd10e7979d4fd59aab5a7fa5d52330e71e0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83537 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- Mar 21, 2024
-
-
Andreas Kienast authored
This commit checks whether `eval` and `is_in` are not empty before they are used as "input params" for the JavaScript part of the FormEngine. Also, a plausibility check is added to ensure `eval=is_in` and a non-falsy `is_in` configuration are given. Resolves: #103184 Releases: main, 12.4 Change-Id: I23da4483f1b35b0720ce59d07847fe01ead9a461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83561 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Mar 20, 2024
-
-
Jasmina Ließmann authored
Resolves: #103429 Releases: main, 12.4 Change-Id: Id8ab8e745a316f8af0abcfe495b7174f0afe1b96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83535 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
- Mar 19, 2024
-
-
Benjamin Franzke authored
* Always clean-up containers when Control-C is pressed * Enforce removing networks even if some containers have not been fully stopped (does not work with older docker versions, therefore only enabled for podman) * Bail out if `waitFor` failed instead of resuming with subsequent commands * Avoid waiting unnecessarily for VNC-web port 7900 in headless mode * Do not derive `--pull=never` from the `$CI` environment variable, as `$CI` is set both in gitlab [1] and github [2] actions. runTests.sh might be used in github actions, therefore this flag is moved into our gitlab-ci specific configuration. * Fix typos [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html [2] https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables Resolves: #103420 Releases: main, 12.4, 11.5 Change-Id: Ie8fcdc5ebc5ba651242bb54faffdfd8de0dc6026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83518 Tested...
-
Benni Mack authored
Change-Id: I03729854c268a32ba072d891d4701d42ba5d365d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83517 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Change-Id: I981c2fe620a96ce344730b184ce60e7aa17a6aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83516 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
This commit updates ckeditor5 to v41.2.1. It fixed a recent regression where importing documents from Word with suggestions caused CKEditor 5 to crash. See changelog at https://github.com/ckeditor/ckeditor5/releases/tag/v41.2.1. Executed commands: npm install --save \ @ckeditor/ckeditor5-alignment@^41.2.1 \ @ckeditor/ckeditor5-autoformat@^41.2.1 \ @ckeditor/ckeditor5-basic-styles@^41.2.1 \ @ckeditor/ckeditor5-block-quote@^41.2.1 \ @ckeditor/ckeditor5-clipboard@^41.2.1 \ @ckeditor/ckeditor5-code-block@^41.2.1 \ @ckeditor/ckeditor5-core@^41.2.1 \ @ckeditor/ckeditor5-editor-classic@^41.2.1 \ @ckeditor/ckeditor5-engine@^41.2.1 \ @ckeditor/ckeditor5-essentials@^41.2.1 \ @ckeditor/ckeditor5-find-and-replace@^41.2.1 \ @ckeditor/ckeditor5-font@^41.2.1 \ @ckeditor/ckeditor5-heading@^41.2.1 \ @ckeditor/ckeditor5-horizontal-line@^41.2.1 \ @ckeditor/ckeditor...
-
Benjamin Franzke authored
All applicable acceptance tests are now also executed in composer mode. Tests that check classic-mode specific functions are excluded and are therefore now tagged as classic-mode test. The composer mode instance is generated with our CLI setup tools, allowing to mimic the realworld case where a instance is creating via our setup tools instead of from fixtures (which we still use for classic mode tests, but try to reducde/avoid for composer mode tests). The existing existing classic-mode test acceptance test execution will keep running as-is. The v12 backport additionally imports pieces from #102440 as t3editor extension is enabled in this composer-mode, while v12 classic mode is tested (for historic reasons) without t3editor extension enabled. Commands executed: > composer require --dev "typo3/cms-styleguide":"^12.0.5" Resolves: #103297 Releases: main, 12.4, 11.5 Change-Id: I64973f110931b51ed2ef7ef8f8cc3411834fcf37 Reviewed-on: https://review....
-
- Mar 16, 2024
-
-
Oliver Bartsch authored
Resolves: #103391 Releases: main, 12.4 Change-Id: I48d55c7b66669f9836886f257aefba2171b6910e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83474 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Mar 15, 2024
-
-
Willi Wehmeier authored
This change makes the toggle button accessible via keyboard and sets the focus manually, so that the pagetree can be toggled via pressing space or enter on the keyboard. Resolves: #102426 Releases: main, 12.4 Change-Id: I6916cf1f19de288e961ecb0dab85c76241097d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83473 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Mar 14, 2024
-
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/prefer-string-starts-ends-with` [1] into account, enforcing the usage of `startsWith()` and `endWith()` over index checking in strings. [1] https://typescript-eslint.io/rules/prefer-string-starts-ends-with Resolves: #103374 Releases: main, 12.4 Change-Id: I88640f71cbe960db2a2e2b162410ff5a79e7c55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83448 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Mar 13, 2024
-
-
Ayke Halder authored
In the backend CEs are elevated by a surrounding box-shadow. This box-shadow was clipped off on top, left and right side. Resolves: #103381 Releases: main, 12.4 Change-Id: I3052ff7ced18e509aefb2f05c6b1bde8725572b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83429 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
This prevents the element browser from closing as soon as one file or folder was added. This restores previous behaviour, allowing the user to add multiple references without having to open the browser again and again. Resolves: #103369 Releases: main, 12.4 Change-Id: Id57ebe3ed115c0929beb06fd7dd136fe0f08e415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83458 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
With #103197, a loading indicator was added to the context menus, which rendered a stub context-menu. The position of the context-menu needs to be recalculated once the data has been loaded (the context-menu becomes taller) in order to avoid rendering outside the visible window area. Releases: main, 12.4 Resolves: #103382 Related: #103197 Related: #103294 Change-Id: I75e3659c619d4b98c773faa4dab9bbf184471065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83454 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/restrict-plus-operands` [1] into account, prohibiting merging of type-incompatible operands. [1] https://typescript-eslint.io/rules/restrict-plus-operands Resolves: #103378 Releases: main, 12.4 Change-Id: I267272e4f384cbcabc245cd85ea493886134b026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83447 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Mar 12, 2024
-
-
Andreas Kienast authored
The `@typescript-eslint` packages are updated for TypeScript 5.4 support. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.2.0 \ @typescript-eslint/parser@^7.2.0 \ @typescript-eslint/typescript-estree@^7.2.0 npm run build Resolves: #103370 Related: #103354 Releases: main, 12.4 Change-Id: I2c173437e1119dccb148e9eaa426cfdcdc94f682 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83426 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
With #103197, a loading indicator was added to the context menus. However, due to the nature how the context menu component registers itself, we run into conflicting event handling. We have to silent any subsequent handlers on the same event, therefore the event propagation is immediately stopped. This aligns the event propagation behavior with the modernized tree in TYPO3 v13. Resolves: #103379 Related: #103197 Releases: 12.4 Change-Id: I87ae7ac815d3271788a164258ab2208fe5e57e6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83441 Tested-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/no-array-delete` [1] into account, prohibiting element removal from an array via `delete`. The problem with `delete` is that the element to be removed is in fact replaced with an `empty` slot, effectible keeping the array's size. Using `splice()` [2] is the preferred way to remove elements from an array. [1] https://typescript-eslint.io/rules/no-array-delete/ [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice Resolves: #103375 Releases: main, 12.4 Change-Id: Ic742a43d44cbd8c5cc323f629cc82ad606a9858f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83443 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Ayke Halder authored
The commit messages line-length is documented as 72 characters. The commit-msg hook checks for 72 characters now. Before the hook checked for 74 characters. Resolves: #103363 Releases: main, 12.4, 11.5 Change-Id: I15138831a73e84f275e85a5cd88f0b33319f9c1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83424 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Mar 11, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.1.1 \ @typescript-eslint/parser@^7.1.1 \ @typescript-eslint/typescript-estree@7.1.1 \ eslint@^8.57.0 \ typescript@^5.4.2 npm run build Resolves: #103354 Releases: main, 12.4 Change-Id: I1c3d53002012153541cd34f9ceae546536b4aacc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83421 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Mar 07, 2024
-
-
Andreas Kienast authored
The module `@typo3/backend/tree/page-browser` used to modify a string representing an URL by appending arguments to a query string. The code is now modified to use a proper `URL` object, which is considered more safe for such tasks. Resolves: #103313 Releases: main, 12.4 Change-Id: I39c2c99a348aa338efc7724e96c732e65693343e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83312 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-