When maxCharacters is equal or less then the length of the first word,
the whole string was returned when 'crop to word' is enabled instead of
the only the cropped part.

Change-Id: I0a7ec720b12a7999245b183f36daff5cdd7a8ace
Resolves: #25368
Reviewed-on: http://review.typo3.org/1274
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The module DB Check > Record statistics counts the deleted pages
instead of the lost pages and displays that number. As the links
for adopting orphaned records should correlate to the count of
lost records, we should display the correct number.

Change-Id: Ie793aa337b56503f6f37ffd9cc6fbb8d052c1540
Resolves: #25863
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1531
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Icons status overlays are defined in t3lib_iconWorks::
mapRecordOverlayToSpriteIconName(). However it is necessary
for "external" process (e.g. versioning) to override the
icon status. Currently a deleted record in a workspace will
not appear properly overlaid because only deleted = 1 is
checked and not also t3ver_state = 2. This hook makes it
possible for the version sysext to hook into the process and
set the right status.

Change-Id: I349012e402ab349ad810c57e46b0a7d5f8a46b03
Resolves: #25765
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1459
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Hader

Booleans should be written in uppercase.

Change-Id: I5c6e07ceb53deb128f82dc67948925f5cb99dd91
Resolves: #26347
Releases: 4.6
Reviewed-on: http://review.typo3.org/1792
Reviewed-by: Peter Beernink
Tested-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Abandon the extra security feature of having one time tokens and create tokens
which are valid during a whole login session. Additionally create only one random token,
store it in the session and create the real URL and form tokens by hashing the scope strings
with the secret session token.

To enable re-login, store the session token in the registry and retrieve it in case a
re-login happens.

Thanks to Marion Eher (Bluechip.at) for sponsoring
this fix with 75 beers during the bug auction at T3BOARD11.

Resolves: #25359
Change-Id: If37990fbc1ae3701777e8218cc1bc8760a4d6a55
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1364
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The TCA tree feature did not work when setting maxitems=1 in the TCA.

This bug has been fixed in master in 290529a7 and in
TYPO3_4-5 branch 3019ca92 but the solution is different.

Use the same solution as is TYPO3_4-5 because it is cleaner:

* Check for empty() value instead of comparing with 0 in 
  t3lib/tceforms/class.t3lib_tceforms_tree.php
* Do not recalculate the number of checked items only if a new
  item is checked and the maximum item count is reached instead of always
  recalculating the item count in 
  t3lib/js/extjs/tree/tree.js

Resolves: #25347
Releases: 4.6

Change-Id: I1b55960f9c26f57aa05d6a95a9980798c06e8316
Reviewed-on: http://review.typo3.org/1804
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Remove the last occurrences of IE6 specific code.
Resolves: #26274

Change-Id: I82e86c5b8ecc14d6592871a2f86d6c50d69eed48
Reviewed-on: http://review.typo3.org/1723
Reviewed-by: Peter Beernink
Tested-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The logging functions in saltedpasswords are not able to log failed
backend userlogins to TYPO3s syslog, because the inherited
writelog-function gets overridden by a local function. As a result, no
notification e-mail is sent to [warning_email_addr] when a backend user
has multiple failed login attempts. A remote 'attacker' could try to
login to a TYPO3 installations backend numerous of times without being
noticed (no log entry and no warning-email if configured).

Rename the local writelog-function to writeLogMessage and add the
original writelog-functionality, so that failed backend logins are
written to TYPO3s syslog again and all logging/notifications work as
expected.

Change-Id: Ic05b05873e3fd20df675db908ba76b7dd0e5548f
Resolves: #23917
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1795
Reviewed-by: Torben Hansen
Tested-by: Torben Hansen
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The special value "null" should written in uppercase "NULL".

Change-Id: I84deb049c823ee6b51792df7afd08b18bbff5cac
Resolves: #26345
Releases: 4.6
Reviewed-on: http://review.typo3.org/1791
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In class tslib_content_offsettable there is one occurence of "tsdWrap",
which should read "stdWrap".

Change-Id: Ia658149602d5bbf1e3453ad8ed9eacbec247c1c5
Resolves: #26500
Reviewed-on: http://review.typo3.org/1800
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Booleans should be written in uppercase.

Change-Id: Ib29abc6e1e658e3a1b65cd1873a3a3edac7dba57
Resolves: #26346
Releases: 4.6
Reviewed-on: http://review.typo3.org/1790
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The test fixPermissionsSetsPermissionsWithRelativeFileReference
(t3lib_divTest) used a (wrong) relative path to a test file in the chmod
call. Thus the test failed.

Prepend PATH_site have the correct absolute path.

Change-Id: Ifab5649272952a626381e8562ca018d087efc789
Resolves: #26423
Reviewed-on: http://review.typo3.org/1780
Reviewed-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The unit test cropIsMultibyteSafe (class tslib_contentTest) fails, if
error reporting includes E_WARNING. In this case mb_strlen() throws an
error, as it is called with an empty string as second parameter
$charset. Initializing $GLOBALS['TSFE']->renderCharset in the setUp
method solves this.

Change-Id: If04278e3cbd01ad2f4b6b02c1b3df7cf89b251f0
Resolves: #26491
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1785
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

When EXT:felogin is not installed, a FE login content element is available, that is
out of date and should not be used anymore.
As we ship felogin since 4.2 and install it by default, the default login form is
useless and confusing.

Thanks to naw.info for sponsoring 135 beers at the bug auction for this fix.

Change-Id: I765b3d391b06dac34550f46f19992c9cf9d1c5c7
Resolves: #22408
Reviewed-on: http://review.typo3.org/1369
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Additionally throw exceptions instead of a return string if directory could
not be created.

Change-Id: I90da96e1b62d28997573d821c62b7b24b3ef2ba3
Resolves: #26240
Depends: #26230
Releases: 4.6
Reviewed-on: http://review.typo3.org/1716
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The message has TYPO3_CONF_VARS['SYS']['requiredExt'] instead of
TYPO3_CONF_VARS['EXT']['requiredExt'] as in config_default.php.

Change-Id: I46a3559b4b4da028b55b8cc8cda63aaa81fb91ea
Resolves: #26354
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1765
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "$includeEmtpyValues" into "$includeEmptyValues"

Change-Id: I8527373b7b5934025f8ef44bde8ef76ee9036a07
Resolves: #26351
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/1763
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "else if" into "elseif"
This is a follow-up because I forgot one "else if".

Change-Id: I51eeab3ced57a7f9ffc84ad05ee952e529ed533b
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1731
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "else if" into "elseif"

Change-Id: I7db545131851b2bb99dfe25c80fef6b26f5504dd
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1725
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The methods addReplyTo and addCc accept strings as parameters, but we
need the setReplyTo and setCc which accept arrays. This will make the
reply-to and recipient-copy options work in formMail.

Change-Id: Ia3826d51f53ffe497f4c3b25957f0332fb89e81e
Resolves: #25301
Releases: 4.6
Reviewed-on: http://review.typo3.org/1442
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adds a helper functions for easier handling of arrays.
New class t3lib_utility_Array adds a method to reduce an
array by a search value.
New method in t3lib_extMgm adds a method to add new items
to a TCA select list at a spcified position.

Change-Id: I589294525a7eacc7af6e54c5b78f5ee411574f12
Resolves: #26069
Relates: #22408
Reviewed-on: http://review.typo3.org/1647
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

A few files are containing inconsistent linebreaks.
Since all of these files are taken from external projects,
someone needs to make sure that they get fixed during future
imports.

Change-Id: I49e482add2f991356a4ad335f13c9c60719e9e44
Resolves: #26126
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1661
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ib8dd5576d4400cb4da38c86384ce6dd31f734508
Resolves: #25709
Reviewed-on: http://review.typo3.org/1408
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Add new unit tests for mkdir_deep() to document current behavior.
Clean up variable names in mkdir_deep (no functional change).

Change-Id: Ied48fbb5c23d7e9152464b4f71ace60be04f6074
Resolves: #26230
Depends: #26228
Releases: 4.6
Reviewed-on: http://review.typo3.org/1714
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove code from t3lib_div::fixPermissions and t3lib_div::mkdir that remove
a trailing slash from a given directory. This was a workaraund for PHP functions
like mkdir, they fail with trailing slashes if safe_mode is on.
Additionally the according unit tests are cleaned up and completed.

Change-Id: I44b330a3542bfd172736b103feec895b46494346
Resolves: #26228
Related: #25332
Releases: 4.6
Reviewed-on: http://review.typo3.org/1713
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

It is neccessary to hold more than 120 characters in redirectTo field,
thus changes in ext_table.sql and tbl_cms.php are neccessary. This fix
changes the max-value to 255 chars.

Resolves #25780
Releases 4.6

Change-Id: I228f636b529ca75c9b1820a8cff622970b00cd42
Reviewed-on: http://review.typo3.org/1472
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefano Kowalke
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

According to CGL the files which contain a class must have a prefix "class." in filename.

Change-Id: I1b636b6b64e7202d4c6fc4a6741478817295ce99
Resolves: #26231
Related: #25868
Releases: 4.6
Reviewed-on: http://review.typo3.org/1715
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The file SVNreadme.txt in the root of the repository contains
information, which should help people coming from older versions bevore
4.0 and using an SVN checkout.

Not only the name is outdated, most of the information is also wrong.
So remove this file.

Change-Id: If08c6b835278d2bb2b83f100f9f68a60406d1cae
Reviewed-on: http://review.typo3.org/1706
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

TYPO3_DB must be added to $backupGlobalsBlacklist.

Change-Id: I1a4642d563f67582f5a300859a2ecc2ae2e96390
Resolves: #26174
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1700
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This is a CGL cleanup.

Change-Id: I761fe8983c35e2dbe002728c54d547e590004d26
Resolves: #26173
Releases: 4.6
Reviewed-on: http://review.typo3.org/1698
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I8fd91f031634e43a34ab1d3b75869452a8dd4d6a
Resolves: #25090
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1696
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This is a CGL cleanup.

Change-Id: I30ef7ff173b91a14f8562c094ed071917a4918cb
Resolves: #26171
Releases: 4.6
Reviewed-on: http://review.typo3.org/1693
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This is a CGL cleanup to get rid of all trailing newlines at EOF.

Change-Id: I905d04317303f000a5e71eaf61973bf7cadea119
Resolves: #26162
Releases: 4.6
Reviewed-on: http://review.typo3.org/1684
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ic068f31188e09e9d55cc7ada246e5d192a70fbc7
Resolves: #26164
Releases: 4.6
Reviewed-on: http://review.typo3.org/1685
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The HTML template for EXT:felogin should be configurable.

Therefore, add a new constant to css_styled_content named
styles.content.loginform.templateFile

As default it holds the previously hardcodede value from
EXT:felogin/ext_typoscript_setup.txt (EXT:felogin/template.html)

Change-Id: I98a55c3d2ed9f782450436194f95275e0ee307c7
Resolves: #26103
Reviewed-on: http://review.typo3.org/1658
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

the register['count_menuItems'] is set, before a possible userfunc filters the menu items -> wrong register value.

Solution: change call sequence

Change-Id: I0425d04602110a5f6707022cb88077cc75e81f02
Resolves: #25405
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1471
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Frederic Gaus
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Change-Id: I0a61737755afbda6e2ab6c02ba59c078a77cc020
Resolves: #25979
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1649
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

According to the CGL the files which contains a class must have a prefix "class." in filename.

Change-Id: I5ac0214236dc248a7d2b37d5981278fd65bc6c91
Resolves: #25868
Releases: 4.6
Reviewed-on: http://review.typo3.org/1646
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When editing TypoScript in the template module and using the "Include
TypoScript file content" option with more than 9 files, then the 10th
and all later files gets screwed up.

Thanks to André Spindler for reporting and providing a patch.
Thanks to Kilian Hann (futureconnection AG Zürich) for sponsoring
100 beers during the bug auction.

Change-Id: I2b1363506e5b01a9fb8fa47b792d3351d302eaa9
Resolves: #25374
Reviewed-on: http://review.typo3.org/1362
Reviewed-by: Michael Stucki
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Iae45d949855ceec1e9dc9bf6e27d4885749375d5
Resolves: #25332
Reviewed-on: http://review.typo3.org/1447
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog