- Jun 04, 2018
-
-
Benni Mack authored
The scheduler object cleans up execution arrays on instantiation. Due to the PSR-3 refactoring, the logger is instantiated after the constructor is called - resulting in a fatal error ("Call to member function info() on null") when cleaning up the execution array. The patch manually instantiates a logger if there isn't one already. Resolves: #85148 Releases: master Change-Id: I5ff3a06a2b9d7e511d5d243df545359a48bf84b1 Reviewed-on: https://review.typo3.org/57118 Tested-by:TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- May 16, 2018
-
-
Mathias Brodala authored
If the class of a registered task is missing, e.g. because the related extension has been removed, the task itself will be unserialized into an __PHP_Incomplete_Class object. Checking the task execution is an invalid access in this case and must be avoided for such tasks to be deleted. Resolves: #84973 Releases: master, 8.7 Change-Id: Iaec8a5e346a0d6257a942cbead50b214036ed700 Reviewed-on: https://review.typo3.org/56959 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 12, 2018
-
-
Benni Mack authored
The custom logging of the scheduler pollutes the sys_log table by default in all installations. Switching to proper logging API allows to log to more custom processors. Resolves: #83866 Releases: master Change-Id: I2bd0a13cf55f70f8accc6a799099f713c648aac2 Reviewed-on: https://review.typo3.org/55670 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Frank Naegler authored
Resolves: #66587 Releases: master, 8.7 Change-Id: I444c818e9f81d3595ca68513800c85d9f993f9b4 Reviewed-on: https://review.typo3.org/55685 Reviewed-by:
-
- Dec 08, 2017
-
-
Markus Hoelzle authored
With #82254 LocalConfiguration serialized array EXT/extConf has been changed to a not serialized array in EXTENSIONS. This patch follows up on this task an finishes various tasks: * An install tool silent upgrader upmerges given EXT/extConf settings to EXTENSIONS array. The resulting EXTENSIONS array does not contain dots for sub paths in its array key anymore and is accessible with a new ExtensionConfiguration->get() API to fetch values and whole extension config. * A new API is introduced to get() and set() extension specific configuration, is documented and used throughout the core to not unserialize old EXT/extConf anymore. Setting values updates legacy EXT/extConf to new values including compatible 'dot' ending on nested array configurations. * If extensions come with new configuration items in ext_conf_template.txt a silent upgrader of the install tool synchronizes these to the EXTENSIONS and old extConf array. Extensio...
-
- Nov 03, 2017
-
-
Pascal Rinker authored
Add a deleted flag to database table "tx_scheduler_task". Any task execution will also consider this field. Resolves: #79777 Releases: master Change-Id: I9f96ae9b255042ebf4ba3c812726cbf5ba4fa41c Reviewed-on: https://review.typo3.org/51656 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Markus Sommer <markus.sommer@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Oct 20, 2017
-
-
Christian Kuhn authored
The feature to execute scheduler tasks via the "at daemon" on unix found extremely little use in the wild and is dropped from the core. The implementation is rather clumsy, too, so we take the opportunity to just drop this feature. Change-Id: Ia3786953c41580ef6ea3b3c3ee21c1a82cab3dcd Resolves: #82832 Releases: master Reviewed-on: https://review.typo3.org/54455 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Aug 23, 2017
-
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- May 18, 2017
-
-
Georg Ringer authored
The public method Scheduler::log accepts an optional $code as 3rd parameter. Add this information to the parameter $details of BackendUserAuthentication::writelog as otherwise it will be casted to an integer and its information will be lost. Resolves: #80592 Releases: master, 8.7 Change-Id: Iab5f1d285976e9e88795ebbe75faff9f689b1a8c Reviewed-on: https://review.typo3.org/52553 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Apr 18, 2017
-
-
Benni Mack authored
There are still some places left where legacy functionality is used or documented related to cli_dispatch.phpsh instead of the generic typo3/sysext/core/bin/typo3 binary. Resolves: #80868 Releases: master, 8.7 Change-Id: Iad3392403a0e1b16ed42422f840de647f0b9ce0d Reviewed-on: https://review.typo3.org/52469 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Jan 27, 2017
-
-
Michael Oehlhof authored
Added a feature to the scheduler to mark tasks to be run by next cron job. Resolves: #45537 Releases: master Change-Id: I72d0e693821630a0be655159b53c168b1973d886 Reviewed-on: https://review.typo3.org/45807 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- Dec 23, 2016
-
-
Morton Jonuschat authored
Set PDO attributes to ensure that BLOB fields are returned as strings to PHP, the way MySQL does. Update INSERT/UPDATE statements that deal with BLOB field to declare the proper parameter type so that the driver can do the required encoding/escaping when sending the data to the DBMS. Releases: master Resolves: #78884 Change-Id: I1618da9130549bd95ce0410420ecdee40cc3632d Reviewed-on: https://review.typo3.org/50883 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- Oct 26, 2016
-
-
Manuel Selbach authored
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Sep 03, 2016
-
-
Morton Jonuschat authored
Databases that use sequences for auto increment columns need to have information about the table name to select the correct sequence to return information from. Change-Id: I5a4ff882d2237c86030b41a921843afdb95b9789 Resolves: #77833 Releases: master Reviewed-on: https://review.typo3.org/49843 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jun 06, 2016
-
-
Wouter Wolters authored
Resolves: #75773 Releases: master Change-Id: I857364ef92f92e1af1ff902be5af445a775b8dbb Reviewed-on: https://review.typo3.org/47784 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- May 27, 2016
-
-
Christian Kuhn authored
To mitigate potential "unsecure unserialize()" issues, the new PHP7 feature to allow only specific classes or to totally deny object creation is rolled out throughout the core in v8. Since a lot of places use unserialize() and some are critical or hard to understand, this is done with a series of patches for single areas. This patch denies object creation at all places where $GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['anExtension'] is unserialized() - the extension manager and ext_conf_template.txt handling never handles objects at this place, so it should be safe to deny objects at all places. Change-Id: Ie96e6fb6837418fd765f883b216b7a9c5af5795d Resolves: #76320 Releases: master Reviewed-on: https://review.typo3.org/48314 Reviewed-by:
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- Aug 16, 2015
-
-
Stefan Neufeind authored
During a long-running task the connection to the database may be disconnected, if mysql `wait_timeout` is exceeded. This patch makes sure the connection is reestablished if there has been a connection before. Resolves: #69001 Releases: master, 6.2 Change-Id: I7575ae386ec190d60ddceee146133125083dee41 Reviewed-on: http://review.typo3.org/42546 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Josef Glatz <jousch@gmail.com> Tested-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Reviewed-by:
-
- Jul 15, 2015
-
-
Markus Klein authored
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
-
- Jul 07, 2015
-
-
Andreas Fernandez authored
Replace occurences of count() with matching empty() pendants. Affected extensions: - scheduler - sv - version - workspaces Resolves: #67955 Releases: master Change-Id: I1fd152ed9b581e0f2645837776fd7fab1ccbf73e Reviewed-on: http://review.typo3.org/40959 Reviewed-by:
-
- Jun 15, 2015
-
-
Mathias Schreiber authored
If the query for fetchTask fails for whatever reason, scheduler will now gracefully throw an exception instead of assuming it had gotten a valid resource pointer Resolves: #67463 Related: #39085 Releases: master, 6.2 Change-Id: I26819df3fd173b36de6121100a6398ed4b701319 Reviewed-on: http://review.typo3.org/40256 Reviewed-by:
Lienhart Woitok <lienhart.woitok@netlogix.de> Tested-by:
-
- Mar 02, 2015
-
-
Philipp Bergsmann authored
Scheduler task to remove deleted records from content table(s) which are older than x days. If a deleted record also contains an upload field, then the file is also deleted. Releases: master Resolves: #32651 Change-Id: I58577c05a1a3b228579c05578cc8fdf2e3b393fa Reviewed-on: http://review.typo3.org/9013 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
-
- Jan 26, 2015
-
-
Mathias Schreiber authored
If the query for fetchTask fails for whatever reason, scheduler will now gracefully throw an exception instead of assuming it had gotten a valid resource pointer Resolves: #39085 Releases: master, 6.2 Change-Id: If4d5e0866bf6e5e17fcafbf4287e330366d995fa Reviewed-on: http://review.typo3.org/36208 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
Julian Hofmann <info@julian-hofmann.net> Reviewed-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Reviewed-by:
-
- Jan 19, 2015
-
-
Stefan Neufeind authored
Instead of doing a (locale-aware) escaping in various places use a central utility-function. Change-Id: If0486b340543c33fc0794d754af81a4a666988c3 Resolves: #39928 Releases: master Reviewed-on: http://review.typo3.org/35959 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
-
- Dec 13, 2014
-
-
Roland Waldner authored
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- Dec 12, 2014
-
-
Stefan Neufeind authored
Change-Id: Iedee934b91eb22f9263de60e0f26c34af61222ec Resolves: #63619 Releases: master Reviewed-on: http://review.typo3.org/35130 Reviewed-by:
-
- Nov 13, 2014
-
-
Xavier Perseguers authored
Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance() should use the ::class construct instead of a string argument. Releases: master Resolves: #61788 Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce Reviewed-on: http://review.typo3.org/32913 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- Oct 28, 2014
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- Oct 25, 2014
-
-
Wouter Wolters authored
Resolves: #62467 Releases: master Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f Reviewed-on: http://review.typo3.org/33522 Reviewed-by:
-
Wouter Wolters authored
Resolves: #62468 Releases: master Change-Id: I2790ca5817e16cfe0dc1c43151d2587ca796294a Reviewed-on: http://review.typo3.org/33523 Reviewed-by:
-
- Oct 11, 2014
-
-
Georg Ringer authored
The "@todo Define visibility" is not very helpful because: * Nobody knows what breaks if changing the visibility * The code is flooded with todos which makes it hard to work with in an IDE During ACME it was decided to remove the @todo again. Resolves: #61957 Releases: master Change-Id: I0caa9756bba326dc132b6a2dabe79218c53a32c8 Reviewed-on: http://review.typo3.org/33044 Reviewed-by:
-
- Sep 08, 2014
-
-
Wouter Wolters authored
* Move images to Resources/Public/Images/ * Move language files to Resources/Private/Language/ * Migrate ExtJs to jQuery * Move module template to Resources/Private/Template/ * Add strict comparison were possible Resolves: #60630 Releases: 6.3 Change-Id: I7bae64263268562b158dccf9b9c8fa6d6726fe52 Reviewed-on: http://review.typo3.org/31875 Reviewed-by:
-
- Jun 22, 2014
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59785 for further details. Resolves: #59785 Releases: 6.3, 6.2 Change-Id: If6a4795e7f2841474241d236d8ed33baceee0d2e Reviewed-on: https://review.typo3.org/31030 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 26, 2014
-
-
Andreas Fernandez authored
With activated DBAL, dispatching the scheduler from cli currently fails. The SqlParser can't handle brackets in an ON-clause, so remove them in the query. Resolves: #57246 Releases: 6.2 Change-Id: I2efa92392d22c854dae925da9a2396ef08bae198 Reviewed-on: https://review.typo3.org/28805 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
- Feb 09, 2014
-
-
Przemysław Krukowski authored
Exception codes are unique now. Resolves: #52294 Releases: 6.2 Change-Id: I4ad49b1ff0342ea36147b6ba0b01d270d9d9f3c5 Reviewed-on: https://review.typo3.org/27462 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Feb 01, 2014
-
-
Jo Hasenau authored
This patch replaces most of around 1600 occurrences of intval() and every (integer) in the whole core. Additionally it changes GeneralUtility::intExplode to use references and typecasting as well. Some occurrences of strstr() together with intval() have been replaced with strpos() as well. And some superfluous intval calls have been removed or reduced to a single one i.e. for protected variables or before loops. Patch updated after Core CGL decision from 30.01.2014 Resolves: #54265 Releases: 6.2 Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8 Reviewed-on: https://review.typo3.org/26740 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Oct 15, 2013
-
-
Stefan Neufeind authored
Allows defining of task-groups and groups tasks in scheduler-list by those groups. Tasks inside a hidden group are neither automatically executed nor displayed in the scheduler module. Task-groups feature a description field that can hold additional information and is displayed below the group name in the scheduler list. Change-Id: I445cf9296ab03e9e0e9e3a35ba5a6aa66ad23f13 Resolves: #52695 Releases: 6.2 Reviewed-on: https://review.typo3.org/24608 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Georg Ringer Tested-by: Markus Klein Reviewed-by: Markus Klein
-
- Oct 13, 2013
-
-
Xavier Perseguers authored
Function date() expects a timestamp as second parameter, not an object. Fixes: #52759 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I6821bafa51372c50d8903c63d62ea44933bc12b3 Reviewed-on: https://review.typo3.org/24707 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
