- Aug 15, 2024
-
-
Oliver Hader authored
Change-Id: If480bcdddc3825d7e26196c151d6b2613cdd4602 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85650 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Kienast authored
The package `devbridge-autocomplete` was removed in TYPO3 v12 (#98455), but it is still referenced in "External Libraries" in the "About" module. The reference is now removed. Resolves: #104632 Related: #98455 Releases: main, 12.4 Change-Id: I8032933f59f1fcf0acccc6baf30ac0515b441faa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85648 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Hader authored
Aims to combine disabling site-specific CSP with report-only mode later. This reverts commit 56f64089. Reverts: #104549 Resolves: #104633 Releases: main, 12.4 Change-Id: I651f60d7b5cc24133801412c8f09b1efba98d3f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85647 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Oliver Hader authored
The previous patch introduced ambiguities for allowed attributes for multiple HTML elements that were reliable and hard-coded in previous versions. This reverts commit 71c9e190. Resolves: #104622 Reverts: #104520 Releases: main, 12.4 Change-Id: Ib63cc4733944ad98830ee269baf13f1b15076ef5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85643 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Aug 14, 2024
-
-
Stefan Bürk authored
Brings an internal change for better doctrine/dbal handling > composer require --dev \ typo3/testing-framework:^8.2.1 Resolves: #104624 Releases: 12.4 Change-Id: I33533e73398874fe597da97128fdb6dd6300086b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85636 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Mathias Brodala authored
This is a mitigation of an issue introduced with #102291, where f:for now tends to iterate an empty string and crashes. Resolves: #104612 Related: #102291 Releases: main, 12.4 Change-Id: Id462532e732e421eac04c09b267b0f80ca522ea6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85631 Tested-by:
-
Garvin Hicking authored
The change in #97498 introduced a specific handling for ENUM/SET definitions in MariaDB systems. The check may be performed with a NULL value instead of a string, which can result in a PHP type mismatch error. Due to other refactoring, the issue does not exist in main (v13), but only affects v12 and v11. Resolves: #104621 Related: #97498 Releases: 12.4, 11.5 Change-Id: Ia28aae519b1aebcabe9a5f5c620124dfd22edc6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85628 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Nikita Hovratov authored
Since #102825 the table is available in the GridItem object. This can now be used to replace the string "tt_content" with "{item.table}" where possible. This way other record types can be rendered as grids and will automatically function the same as content elements. Resolves: #104593 Related: #102825 Releases: main, 12.4 Change-Id: I00b36327e9417532afdad8089ec28c802f0b448b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85629 Reviewed-by: -
Andreas Kienast authored
When a user wants to move a content element via the Record List, the UI now respects the selected mode ("move" or "copy") by rendering a proper language label in the tooltip on the action button. Resolves: #104619 Releases: main, 12.4 Change-Id: Ib9334d86d4f268fc20f54111c90a21ed0f1194ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85627 Tested-by: -
Oliver Hader authored
This change allows to disable CSP headers for a particular site configured in `sites/<my-site>/csp.yaml` by using the assignment `enable: false`. Resolves: #104549 Releases: main, 12.4 Change-Id: I9e17b5658610e5d47915a5e45ca6a33a870e8d76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85622 Tested-by:
-
- Aug 13, 2024
-
-
Thomas Hohn authored
The method BackendUserAuthentication::returnWebmounts() returns an array of strings. This triggers a type error when calling DatabaseIntegrityController::getTreeList() since this method now requires the mountpoint as an integer. In order to keep backwards compatibility a new method BackendUserAuthentication::getWebmounts() has been introduced, which returns an array of integers. Existing calls to returnWebmounts() have been replaced by calls to getWebmounts() and fixes by applying array_map(intval(...) on the result is now superfluous. A follow up issue has been created #104607 to deprecate method returnWebmounts() and to investigate if succesive calls to array_unique can be done in getWebmounts() and removed. Resolves: #104591 Related: #104607 Releases: main, 12.4 Change-Id: I78b2ac3ca891b4144c3b68fd44afb645b875fa6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85614 Tested-by:
-
Andreas Kienast authored
The JavaScript linter `eslint` is upgraded from v8 to v9. This also requires an upgrade of all `@typescript-eslint` packages. With these, some breaking changes were introduced: * `@typescript-eslint/indent` rule is migrated to `@stylistic` The formating rule `@typescript-eslint/indent` has been extracted to a new package, as `@typescript-eslint` does not want to provide rules for code asthetics anymore [1]. * `@typescript-eslint/no-unused-expressions` is enabled by default eslint detects and reports unused expressions, which is a great thing. Some of our code misused this for shortcut if/else clauses. However, chai.js (the deep down framework used for JavaScript tests) uses this syntax for assertions, therefore the lint rules have been disabled for test files. * `grunt-eslint` requires the newer "flat config" for eslint. The existing configuration has been migrated invoking the command `npx @eslint/migrate-config .eslintrc.js`. Executed commands: npm install --save-dev \ @stylistic/eslint-plugin \ @typescript-eslint/eslint-plugin@^8.0.1 \ @typescript-eslint/parser@^8.0.1 \ @typescript-eslint/typescript-estree@^8.0.1 \ eslint@^9.9.0 \ eslint-plugin-lit@^1.14.0 \ grunt-eslint@^25.0.0 npm run build [1] https://eslint.style/guide/why Resolves: #104601 Releases: main, 12.4 Change-Id: Ic492d0d1dca31b1878c0de97191edf6c33015a2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85613 Reviewed-by: -
Andreas Kienast authored
The package `psy/psysh` can be upgraded to version 0.12.4, solving deprecations regarding nullable types in PHP 8.4 environments [1]. Executed command: composer update psy/psysh [1] https://github.com/bobthecow/psysh/commit/2b731c82c0e5b9b36450ce1d4a17f3010c343d91 Resolves: #104610 Releases: main, 12.4 Change-Id: I20a54c5761162f07c4019325a3d02ba09238a8af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85612 Tested-by: -
Andreas Kienast authored
The package `symfony/polyfill-php83` can be upgraded to version 1.30.0, solving deprecations regarding nullable types in PHP 8.4 environments [1]. Executed command: composer update symfony/polyfill-php83 [1] https://github.com/symfony/polyfill-php83/compare/v1.29.0...v1.30.0 Resolves: #104609 Releases: main, 12.4 Change-Id: I0c82a74cde2920d382cbdd8348978786c815c6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85611 Reviewed-by: -
Oliver Hader authored
Change-Id: Ic91384a576e3b3986fffaae5d749a8e68116a87a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85607 Reviewed-by:
-
Oliver Hader authored
Change-Id: I75549bf18ee2714a478d832a72b8a79d01fc9f61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85606 Tested-by:
-
- Aug 12, 2024
-
-
Christian Kuhn authored
sebastian/comparator:5.0.2 got a minor bugfix release changing a detail of assertEqualsCanonicalizing(). Two tests fail when this transitive dependency is raised. We slightly refactor the tests to deal with this. > composer u sebastian/comparator Resolves: #104605 Releases: main, 12.4 Change-Id: I1c7b88d438a9f0a2b596e13e960eed78f484d8bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85601 Tested-by:
-
Andreas Kienast authored
Exeucted commands: npm install --save-dev \ filesize@^10.1.4 \ flag-icons@^7.2.3 \ sharp@^0.33.4 npm run build Resolves: #104595 Releases: main, 12.4 Change-Id: Idad1107f63ec150851574d124125d5ada42d03b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85598 Tested-by: -
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.18.0 \ @codemirror/commands@^6.6.0 \ @codemirror/lang-html@^6.4.9 \ @codemirror/lang-javascript@^6.2.2 \ @codemirror/lang-sql@^6.7.0 \ @codemirror/lang-xml@^6.1.0 \ @codemirror/language@^6.10.2 \ @codemirror/lint@^6.8.1 \ @codemirror/search@^6.5.6 \ @codemirror/state@^6.4.1 \ @codemirror/view@^6.32.0 \ @lezer/lr@^1.4.2 npm run build Resolves: #104594 Releases: main, 12.4 Change-Id: Ie8133aa2093513052051a63af52b3cc92424d08a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85599 Tested-by:
-
- Aug 10, 2024
-
-
Christian Kuhn authored
idn_to_ascii() must not be called with empty string in PHP 8.4. Resolves: #104587 Related: #104513 Releases: main, 12.4, 11.5 Change-Id: I649d157cca3dadbe237e20eb440b071a1885db71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85581 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Wait for the drop down to be ready before clicking around on it. Resolves: #104585 Releases: main, 12.4, 11.5 Change-Id: I9fa86d99b02c74bcc0f9efebce8fc4c2f8e54af5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85578 Tested-by:
-
- Aug 09, 2024
-
-
Markus Klein authored
Use the class name as it should be. This only happens if you use aliasing (or similar) functionality in Services.yaml Resolves: #104563 Releases: main, 12.4 Change-Id: I471c6aa7cef09f80c39800f60e37769a1609fba3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85466 Tested-by:
-
Christian Kuhn authored
Wait for the modal body iframe being there before switching to it. This is mainly an issue in v11 where the modal takes more time server side and webdriver is 'too quick' switching to it. We still sanitize all branches. Resolves: #104577 Releases: main, 12.4, 11.5 Change-Id: Ida09f1945daae3d0fb396f1e495e91ed5042454a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85566 Tested-by:
-
- Aug 08, 2024
-
-
Christian Kuhn authored
Youngest patch levels improve detection and obsolete a baseline entry. > composer req --dev phpstan/phpstan:^1.11.10 Resolves: #104575 Releases: main, 12.4 Change-Id: I8ee69c3be26da678a9ba4e0e972769e958b95b43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85564 Tested-by:
-
Willi Wehmeier authored
Avoid fetching and redrawing the record overview table when the search term input field gets focussed. This prevents breaking the ui state and unwanted deselecting of rows. Resolves: #103802 Releases: main, 12.4 Change-Id: I3ff0f478e1a91a1a785f7093b26d1bf610dac921 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85559 Tested-by:
-
- Aug 07, 2024
-
-
Georg Ringer authored
Moves require statements into a custom method to avoid clashes with local variables. Resolves: #104509 Releases: main, 12.4 Change-Id: I632be874a18787cd75b0a6ff326f57a185a116be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85465 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Garvin Hicking authored
If an invalid record in `sys_be_shortcuts` is stored like this: ``` INSERT INTO sys_be_shortcuts (userid,route,arguments) VALUES (1,'record_edit','[]'); ``` then the backend cannot be accessed anymore due to PHP errors due to unguarded array key access of the "arguments" contents. This patch guards the array key access to prevent such a situation, so an invalid shortcut can be deleted from the menu. Database records like this might happen for migrated older installations. Resolves: #104496 Releases: main, 12.4, 11.5 Change-Id: I350e620eb403e53d1828cf5dedaab633ba00db55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85463 Reviewed-by: -
Bastian Stargazer authored
This commit fixes the former hard-coded "allowAttribs" for <span> tags by replacing them with the defined "allowAttributes" values of the YAML/TSconfig processing configuration. In addition, some other fixed lists are moved into class properties. Note that to alter the "span" configuration for example to restrict allowed attributes (or to allow an empty span tag) you can still use the following YAML/TSconfig: YAML: ``` processing: HTMLparser_db: tags: span: rmTagIfNoAttrib: 0 allowedAttribs: 'class,data' ``` TSconfig: ``` RTE.default.proc.HTMLparser_db.tags.span { rmTagIfNoAttrib = 0 allowedAttribs = class,data } ``` Resolves: #104520 Releases: main, 12.4 Change-Id: I170ef6ee0e38e013307ac72c00a13447795e3b8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85462 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 06, 2024
-
-
Christian Rath-Ulrich authored
The heading structure in the "Dashboard" backend module has been updated and a hidden h1 has been added. Additionally, role attributes have been added to various elements. Resolves: #104070 Releases: main, 12.4 Change-Id: I852ae244ecc399129e99be43f3e9cd58012c9dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85461 Tested-by:
-
Benni Mack authored
Resolves: #103756 Releases: main, 12.4 Change-Id: Ia2ae18406dda05c232546910d73d108a42af7bf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85540 Tested-by:
-
Christian Kuhn authored
Resolves: #104557 Releases: main, 12.4, 11.5 Change-Id: I1bea6d74fc444007c8787e0a642c86b35a7ccb90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85537 Tested-by:
-
Georg Ringer authored
The Site Configuration module currently allows to pick a language locale from a list of available locales of the system (via the "locale -a" command). This patch moves this functionality into a reusable method, which is now also utilized from within the Install Tool when configuring the `TYPO3_CONF_VARS[SYS][locale]` option. The description of this "locale" option now holds all possible locale variants. If the "locale -a" execution fails, the output will show an empty list. Resolves: #61189 Releases: main, 12.4 Change-Id: Icf048be100e8e658fb14bb983d7bab5101bd1587 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85533 Tested-by:
-
Christian Rath-Ulrich authored
To improve accessibility in ClearCacheToolbar dropdown menu, the descriptive text of each entry is hidden for screen readers and re-inserted after the link. Resolves: #104086 Releases: main, 12.4 Change-Id: I30f862cb420cb01f837014872174967c1041df2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85531 Tested-by:
-
Christian Kuhn authored
composer/composer as dev dependency got a security release relevant for monorepo. We should raise to it. > composer u composer/class-map-generator > composer req --dev composer/composer:^2.7.7 Resolves: #104556 Releases: main, 12.4 Change-Id: Ib9b81a942456f1ac78445f27b4b0b198ff204e2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85532 Tested-by:
-
Andreas Kienast authored
Executed command: npm audit fix Resolves: #104551 Releases: main, 12.4 Change-Id: I44ead5b72e8cba08da196210e4a5eb7d05a1aed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85514 Tested-by: -
Andreas Kienast authored
The previous implementation of notification tests relied on real browser timeouts, artifically slowing down their execution (roughly 11 seconds). Sinon (the stub library we use) provides API to mock several timing functions (e.g. `setTimeout()`) which can be incorporated for most cases. There's one caveat tho: notifications are visually hidden with an animation that executes for 400 ms and get removed from DOM after that. Sinon cannot mock timings for CSS-driven animations. To workaround this, a new event is introduced that is usually triggered after animation has ended. This reduces the runtime of the affected test from ~11 seconds to ~1.2 seconds. Resolves: #104553 Releases: main, 12.4 Change-Id: Iffd662e0ce9a87332a65ca50fb5ecb17623c764f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85529 Tested-by:
-
Christian Rath-Ulrich authored
The login screen can now be scrolled and is therefore usable even at larger zoom values. In addition, the currently-focused link elements are now highlighted. Resolves: #104405 Related: #92945 Releases: main, 12.4 Change-Id: If75b051a247bdd1b41031bf6956b90dc5cfb97d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85528 Reviewed-by:
-
Andreas Nedbal authored
Since the file upload button shows the dialog directly it is not necessary to also show the dropzone behind it. This also solves the problem of the dropzone staying visible when a user decides to not upload any file and cancelling the file dialog. Resolves: #101197 Releases: main, 12.4 Change-Id: I33b8c73582c19c94927187e26bf4513d1a1d6e07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85527 Tested-by:
-
Hannes Lau authored
Fix a bug where backend users without permissions to edit the default language would see an error message once they open the translation of a content element that contains an IRRE field with untranslated elements. Allow the language bound editor to open the translation of the content element and localize untranslated IRRE children. Resolves: #102625 Releases: main, 12.4 Change-Id: Icdbf5cb6a3f994b840c8e26bc4eb5886574823fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85526 Tested-by:
-
Oliver Hader authored
Resolves: #104554 Releases: main, 12.4 Change-Id: I4b4c8459526024ad0535d35ec8d43f7ead6e1e1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85524 Tested-by:
-
